From patchwork Mon Jul 17 21:00:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 704117 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 216A4EB64DC for ; Mon, 17 Jul 2023 21:01:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbjGQVBD (ORCPT ); Mon, 17 Jul 2023 17:01:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjGQVBC (ORCPT ); Mon, 17 Jul 2023 17:01:02 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A82A10C4 for ; Mon, 17 Jul 2023 14:01:01 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-991ef0b464cso1298439666b.0 for ; Mon, 17 Jul 2023 14:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689627659; x=1692219659; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AnjHreWF4HQ2gd8gLooLMHw770F6qkj0Sftpoev0l60=; b=Mx6aiakuHMHpp5y7Z2lsRn4qs1q6mwMOt2DvKCjAAGpWr9X3y0w6NcMDsyggz6xYvs E/fhWtYojdu+GexF9HBY7o+YfMNvSQp68xkAezwLpsVueQD/lvqNipteQhz2+fKn6lMy qm3jtb9aJf3OknVRW4gLVQjOrvPsKK12kgsZeNtmzqzutmpcoJdI59HFIhLPGLuYNyOa VUbprYJsRuZJyzBrQyFq/Hd4dV31bI+hBf9+AHuCpZ5l2z/KfXOCfCsW5uRvbx68zIgu 2WjQHPGLBOeROn0ir89hqD2qFO16yPmxBsz4J4DTWA08nXN0ogp7csvvyPMOiqGFdB0H Z6AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689627659; x=1692219659; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AnjHreWF4HQ2gd8gLooLMHw770F6qkj0Sftpoev0l60=; b=jtCe2UYKE0Bi6wQgfMTD1l/PckkdP1wJMvL5hTrpdPpQCpFYm3MHMNhQqlqaVqgm+p /LCVcxr47F15DUdxNP/EbC9RMxic7lWt8zGkheEQO7w3ogmThO0v+NNS1L7aFmzWQl05 GvZzQ3kyEXn98YlW51PF7F9+VtW2p8AtUQoMX8nvqDZF0cAxxkjcoq/Mxws/Bzo9jCYF MsirPElscAWE9t0mkxO20T0y+VKy1RQWyWDoNHMXrk1DY/q9uZI33QxzkMunEuJjEMsU u4VFvRtDxOGue4wJX5bqIzqpONpaoZiVDa+hWa1J1kuftFY7ZKUg2M8Y7RLG6sxtueDG SaIQ== X-Gm-Message-State: ABy/qLZtzEDxre1QP2xBovE6oXkpJsE8Nm7agBgIoGOoBfkfMEfQ13YJ yxUwoIug0zRZe52aLNLtw/bFF0NgAvvy/FYVcQGBlw== X-Google-Smtp-Source: APBJJlGMQK28GVmhsl4/oDUPAmhjGFlLEYUSj3Ugct7yLJzUxWoxWzUOQDQNN5cYhh8FnsOtviRl5g== X-Received: by 2002:a17:906:9746:b0:98e:3dac:6260 with SMTP id o6-20020a170906974600b0098e3dac6260mr12219537ejy.13.1689627659360; Mon, 17 Jul 2023 14:00:59 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id rs14-20020a170907036e00b00987e2f84768sm178392ejb.0.2023.07.17.14.00.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 14:00:58 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] arm64: dts: qcom: sc8180x-primus: remove superfluous "input-enable" Date: Mon, 17 Jul 2023 23:00:54 +0200 Message-Id: <20230717210055.21979-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Pin configuration property "input-enable" was used with the intention to disable the output, but this is done by default by Linux drivers. Since commit c4a48b0df8bf ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not input-enable") the property is not accepted anymore: sc8180x-primus.dtb: pinctrl@3100000: hall-int-active-state: 'oneOf' conditional failed, one must be fixed: 'bias-disable', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- That's my favorite commit. --- arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts index 9b8695b92c48..aaac2da69286 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts +++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts @@ -580,7 +580,6 @@ hall_int_active_state: hall-int-active-state { pins = "gpio121"; function = "gpio"; - input-enable; bias-disable; }; @@ -590,7 +589,6 @@ int-n-pins { function = "gpio"; bias-pull-up; - intput-enable; }; kp-disable-pins { @@ -639,7 +637,6 @@ tp-int-pins { function = "gpio"; bias-disable; - input-enable; }; tp-close-n-pins { @@ -647,7 +644,6 @@ tp-close-n-pins { function = "gpio"; bias-disable; - input-enable; }; }; @@ -656,7 +652,6 @@ int-n-pins { pins = "gpio122"; function = "gpio"; - input-enable; bias-disable; }; From patchwork Mon Jul 17 21:00:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 703757 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A1CC0015E for ; Mon, 17 Jul 2023 21:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbjGQVBG (ORCPT ); Mon, 17 Jul 2023 17:01:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbjGQVBE (ORCPT ); Mon, 17 Jul 2023 17:01:04 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E129A10C8 for ; Mon, 17 Jul 2023 14:01:02 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-992af8b3b1bso689871666b.1 for ; Mon, 17 Jul 2023 14:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689627661; x=1692219661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C+DQimrAqq5HrJuayvWKjqIpTBMUfwE2q6SblHTJ6nQ=; b=hig07dFEoE/VRC8eVzIyt4N5BQ9j5Vtqo5SweTa2x9QdauVRXa4mi8yoIN2Bx2yxCu 9AKfg4DYMNEf7G2JaS0odJ8yRAU/R7oBxnyZWRv8whWQqK0AbUEK5PExmTYLThLKpeoP MplkJBZ3B5is2ylNwhWPCm5ht2HFIw7Dg7miR+caxMYEFAP0irRaebN909McVjdtcX5J VNKH70w8emiDWt4PnnF8wDciOxoK6zwbj0UlvI6vV9DbC0tXLUloKGmFgnDgqfdVBdBe xEg9iSXWJjFHCVzonONSTe5T0yxTiO0b8pbtD4XUtPsyokevk1BS8m+JdEmjHNXtOEyV F9Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689627661; x=1692219661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C+DQimrAqq5HrJuayvWKjqIpTBMUfwE2q6SblHTJ6nQ=; b=B6gwEC04c5N7T1O97+RQVSPP9E78EbpuYSumKSf8Wyi4WYH1Fv+Qs0mTvcPl3fNDuD R9HX4U5h7R6cXjJ7ESXDKCIj1KAYirRMg0ZM3fQHAq2yHNG9vx9FZzgGz4R8UdyItHSO i6Jo79hqd0zXN8S1YD9Oo/+vznNm7hFVsuzMFizgAXqV2D2OWZJdW80qeo7M4hG4A0p0 QCTkWdl9MNUV9dND9LLPebFVubwQNxCONKaSPfY6/4j0HejxGgHg7xrxKF9t7LU5nLyl r6pD7QvsoNAIGKkHEJIsxnGG4h7s8DzOlVIvW5oYOBvsWgjRIUhh8qH3Q/w/jav8nkyX MOMg== X-Gm-Message-State: ABy/qLYIKH+8cbAlPo5Fe/PFmEtE86uRap6tFDkEEua7ltnq/CbsqoHP 9OApI9+PkPQOxg5TqJMlxbg3JQ== X-Google-Smtp-Source: APBJJlF/sm1slZ8Xso6i6fpxS7espnblLLE+1R3arjQ+z12DdP8u0owRxflvA2N9wGQaJHupNJW7lQ== X-Received: by 2002:a17:906:253:b0:993:eb4b:ed51 with SMTP id 19-20020a170906025300b00993eb4bed51mr499998ejl.27.1689627661213; Mon, 17 Jul 2023 14:01:01 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id rs14-20020a170907036e00b00987e2f84768sm178392ejb.0.2023.07.17.14.00.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 14:01:00 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] arm64: dts: qcom: sm8250-pdx203: add required pin function Date: Mon, 17 Jul 2023 23:00:55 +0200 Message-Id: <20230717210055.21979-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230717210055.21979-1-krzysztof.kozlowski@linaro.org> References: <20230717210055.21979-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org DT bindings expect function in each pin state in the pin configuration: sm8250-sony-xperia-edo-pdx203.dtb: pinctrl@f100000: cam-pwr-b-state: 'oneOf' conditional failed, one must be fixed: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dts b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dts index f4c4575eb03b..b70bf9261ba9 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dts +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dts @@ -366,6 +366,7 @@ &tlmm { cam_pwr_b_cs: cam-pwr-b-state { pins = "gpio69"; + function = "gpio"; drive-strength = <2>; bias-disable; output-low; @@ -373,6 +374,7 @@ cam_pwr_b_cs: cam-pwr-b-state { cam_pwr_a_cs: cam-pwr-a-state { pins = "gpio71"; + function = "gpio"; drive-strength = <2>; bias-disable; output-low;