From patchwork Fri Jun 28 03:44:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 168001 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3161554ilk; Thu, 27 Jun 2019 20:44:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqkggJUAzeLdq5eWjhS37TZvVCxD+PMe2azHKg4vnk8OIIWSN7fpH04ALW5pqKePnZtvA0 X-Received: by 2002:adf:f84a:: with SMTP id d10mr5633653wrq.319.1561693472793; Thu, 27 Jun 2019 20:44:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561693472; cv=none; d=google.com; s=arc-20160816; b=EdoIOyzNEqaz9jqZ4KNOdQnf6IkO02A9aT/SZL4+9S0MvTTwAto1kHFOGmIfHznU/M qT/UT9SJAd+P+pHpYoSD2qGt/IRc8aeJNGDNQU333YuFXtAOPr0akAw9hiK67MC9eECZ egGnkEb9v9FsSG8nT/7/GyZ9VbNanLg43NP09yqaYZVZfhmGzohjxJPrtOGo3sIpctsd t0K6p0g6HBvC+iqqNEu+Djxm9s6U6vdoBB3rZjtw4S2P+XLfGxC1ZcuA4rAcL9q6hQ6n lT8/33BlyxLA2RZdv/WdphywZcTqSW2VyhtWjxi0JOqF6UKxDGyEphaIgbfaJ32uNDDe cenw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:cc:to :from; bh=wq9aW4jcP5IvJP4csxHjgU4IXNA5EQXt3sQk9tsxDjE=; b=Y2Xx9n2dvmFSWxYwb8zfInX0bzpeDW7cLG27T7pItyy94SY/W943qY+gtji1/R4DQA TPyqnGhK9Jc/GePQF+e1LQI7ibT2jPy2Q1+BjQb8K8BuDUbgGASa46kMr9J+m/26FyJs KYdkHODljxjTfMpqjimTLlbdPKubRiNG/5/o9AGjaHwb2QaWH3o2auOAsIUCfMBqb1m3 nr57xrldfrlMzKj1EcbTgR1Q2AYXybVNrEwjtfVF9RuO0M31CnzNXMkNz7uJgNz9JXtB yiXIgbWB1FFhJ7Qd6zcLnHYrFOVx03HBqWtnnA0XBlRVpEO102iilIFaUZttp0b+GLOn QHMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id n5si722492wrq.93.2019.06.27.20.44.32; Thu, 27 Jun 2019 20:44:32 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CBB634F0; Fri, 28 Jun 2019 05:44:31 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 59F28F04; Fri, 28 Jun 2019 05:44:29 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 86008C0A; Thu, 27 Jun 2019 20:44:28 -0700 (PDT) Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com [10.118.12.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7DB113F706; Thu, 27 Jun 2019 20:44:28 -0700 (PDT) From: Honnappa Nagarahalli To: honnappa.nagarahalli@arm.com Cc: dev@dpdk.org, david.marchand@redhat.com, ruifeng.wang@arm.com, nd@arm.com, stable@dpdk.org Date: Thu, 27 Jun 2019 22:44:05 -0500 Message-Id: <20190628034406.5399-1-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 1/2] test/rcu: increase the size of num cores variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" num_cores is of type uint8_t. This results in the following compilation error. test_rcu_qsbr_perf.c:649:16: error: comparison is always false due to limited range of data type [-Werror=type-limits] if (num_cores >= RTE_MAX_LCORE) { ^~ RTE_MAX_LCORE is set to 256 for armv8 config. Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count") Cc: stable@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- app/test/test_rcu_qsbr.c | 4 ++-- app/test/test_rcu_qsbr_perf.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.17.1 diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index 943a1e370..0c6267ee9 100644 --- a/app/test/test_rcu_qsbr.c +++ b/app/test/test_rcu_qsbr.c @@ -27,7 +27,7 @@ #define TEST_RCU_QSBR_CNT_INIT 1 uint16_t enabled_core_ids[RTE_MAX_LCORE]; -uint8_t num_cores; +uint16_t num_cores; static uint32_t *keys; #define TOTAL_ENTRY (1024 * 8) @@ -891,7 +891,7 @@ static int test_rcu_qsbr_mw_mv_mqs(void) { int i, j; - uint8_t test_cores; + uint16_t test_cores; writer_done = 0; test_cores = num_cores / 4; diff --git a/app/test/test_rcu_qsbr_perf.c b/app/test/test_rcu_qsbr_perf.c index 363365f46..b1a910423 100644 --- a/app/test/test_rcu_qsbr_perf.c +++ b/app/test/test_rcu_qsbr_perf.c @@ -17,7 +17,7 @@ /* Check condition and return an error if true. */ static uint16_t enabled_core_ids[RTE_MAX_LCORE]; -static uint8_t num_cores; +static uint16_t num_cores; static uint32_t *keys; #define TOTAL_ENTRY (1024 * 8) From patchwork Fri Jun 28 03:44:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 168002 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3161608ilk; Thu, 27 Jun 2019 20:44:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqx32rENmjossli+0lazs4wn8wjNCfggBgHK0Mmm3lLyVreIG18RPkm6A1XUSOpA+kvi3ib9 X-Received: by 2002:a1c:f512:: with SMTP id t18mr5256314wmh.47.1561693479919; Thu, 27 Jun 2019 20:44:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561693479; cv=none; d=google.com; s=arc-20160816; b=Mx6E48uUgm3/NvQVwH0sDpudAwiRorVJqFrOqt0VIVTXH3Q41lxfXdkBggcb82cwBq VbMUptwcYLfGy2itbZySMtZhW8xfzaDVU9NXwFcL/AA75SZaf30ESfwNubqOFFqSkwNj atWcZw0Ke7f2K8oAY8EYdvAehzfSENzBgSmpKt6522viFYz1j6zegayRj+r0JspWE/3t w9JLFXxaG+pNAgD3SV1ggirUvJN5FoKFADYp7WmLCT1rneFkHN9yiSBWVqgQnZUXvyuU 4AO5keChpTrmfcVIbog8Dl20Ehvqmmkb5iMK6P5TUGE+XoblJ4jomMgf/QE1T85LAtVQ Xl7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=0irzGWKuwwmndqiqIPmygyGwNaVKOMmt2RGdXDYA97U=; b=nA9Gl6NmndF8r2sJWaD2cQaCek5aOMgSVQueydKEqkSGBHZKblWkKfuPGCP1ck0uPD NUpdeO6I34IUGxDatt75tGujGMvhCObjbkJkPX2ghVvamXXd03ItYHDTWNN7WNb8xgov dsy6tlD5o+6BFxTJLnKIGIrh+A2yX3E03cSeFOnV0mAtjh4k9aiEPvVVq689rPb3QrqD 5wIELrh7rFJGXo8JO60RBfcsYT2A4R6q35tqxH6eYQl7SK+fHo7u+nYyVLjdIY75Ov8K hDgLEnGdk7qh9vR1Zc/WTF72mG5B0gqbyCncMx1jFweew4M6R1Z2NImIZzDU4IIQ17e5 BOpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id s1si749180wrf.399.2019.06.27.20.44.39; Thu, 27 Jun 2019 20:44:39 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E58DC5B34; Fri, 28 Jun 2019 05:44:34 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 04CF94C99; Fri, 28 Jun 2019 05:44:31 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 480332B; Thu, 27 Jun 2019 20:44:31 -0700 (PDT) Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com [10.118.12.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 372563F706; Thu, 27 Jun 2019 20:44:31 -0700 (PDT) From: Honnappa Nagarahalli To: honnappa.nagarahalli@arm.com Cc: dev@dpdk.org, david.marchand@redhat.com, ruifeng.wang@arm.com, nd@arm.com, stable@dpdk.org Date: Thu, 27 Jun 2019 22:44:06 -0500 Message-Id: <20190628034406.5399-2-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190628034406.5399-1-honnappa.nagarahalli@arm.com> References: <20190628034406.5399-1-honnappa.nagarahalli@arm.com> Subject: [dpdk-dev] [PATCH 2/2] test/rcu: address test case failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Test case for rte_rcu_qsbr_get_memsize is written specifically for 128 threads. Do not use RTE_MAX_LCORE as it changes for different configurations. Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count") Cc: stable@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- app/test/test_rcu_qsbr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 Reviewed-by: David Marchand Reviewed-by: David Marchand > diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index 0c6267ee9..5d92fbee8 100644 --- a/app/test/test_rcu_qsbr.c +++ b/app/test/test_rcu_qsbr.c @@ -89,13 +89,13 @@ test_rcu_qsbr_get_memsize(void) sz = rte_rcu_qsbr_get_memsize(0); TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 1), "Get Memsize for 0 threads"); - sz = rte_rcu_qsbr_get_memsize(RTE_MAX_LCORE); + sz = rte_rcu_qsbr_get_memsize(128); /* For 128 threads, * for machines with cache line size of 64B - 8384 * for machines with cache line size of 128 - 16768 */ TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 8384 && sz != 16768), - "Get Memsize"); + "Get Memsize for 128 threads"); return 0; }