From patchwork Sat Jun 22 19:38:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 167512 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp2258766ilk; Sat, 22 Jun 2019 12:38:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqwu7ct645m9wOYVq7fLF52+Wk+7Q7Ye3R8xil0BBo4Tb/LvKM5qNCRCXYqDLnx6h/ZdszFG X-Received: by 2002:a17:902:b609:: with SMTP id b9mr59368711pls.8.1561232337298; Sat, 22 Jun 2019 12:38:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561232337; cv=none; d=google.com; s=arc-20160816; b=gQzHBkyV4L2DPXuPXN4tAsTG643zMRH+N5SrDZUVta+Q/YItmqrT6gyqZDEZQmlCqH cpdgSKH+H6xK6u6HIrdPfgBqcUlKFPc5XO4L7+RuOgLH6tcio3JHKqhMFxeT4b/BD784 5O8jZT9cw7DAS6rPeKCfaJrBOaC1ztWiaMA1F+0fxLmFUjj1H2p1mKWtnxoTkKO5n6T5 t+K+Sr5T+pkSPC5mSGHsI1jWyJ5pLqwPfK0v7oseKnmp8zufjqwTTjzsoSOQdpZov6mU vwnQsR06v4vypCNx5phylPc9THkQXnP9AMxmbHfOhqZ0X25Gj0KuPI8xyo12gj9irCLc vY5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JZi5qI5fs3eqak0rmlJ8FUpmcCJ8LSmdIGuMVhAVLqc=; b=MsufAojUFdhx0/RJ0P7a3s1xWtN2OXbuXHkYNkFSiixIPFV3AuBnC4+h8HqfQ6OOQw JjX2UyioqZZL2F9i5xXXMA+8nLehGR1VsyhdM4t2SVlO+Um6N5mJ8EqOexIu/0WCMUCq Pz4SiVq/q3Ivhz3RgwMmY2pA+8R/irhTdPjrfpg3fV7yyNX+kpE5U5d3VtvN2PwK/oeD V4tpkg1vXfR5RFsMnHvMuSUP65g3SXLWKeWB9QK/YCfH3HoL9XQKGX/hnBMSeMjUPuOP PEDb0ztIn+hQJGhhDhze3T9ze8AtF1XtiuTQgpJfRdKe+WvMYawIeqwHbJrY78+eZIFV M1dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZZ8MnRj8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bx21si6025621pjb.21.2019.06.22.12.38.56; Sat, 22 Jun 2019 12:38:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZZ8MnRj8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726442AbfFVTiz (ORCPT + 30 others); Sat, 22 Jun 2019 15:38:55 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38239 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbfFVTiw (ORCPT ); Sat, 22 Jun 2019 15:38:52 -0400 Received: by mail-wr1-f65.google.com with SMTP id d18so9732064wrs.5 for ; Sat, 22 Jun 2019 12:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JZi5qI5fs3eqak0rmlJ8FUpmcCJ8LSmdIGuMVhAVLqc=; b=ZZ8MnRj80C5Q8PPZEVB/DMWrWxScaqai5TQs8N4UM/ee4a0VRO85OJ8qch/iHEneIO OGykyug4pKFid/ukR8HKjNV28Q8eePS6f/x5WZ87KJto3UqxHxD2WRhLZA6c8cWQiRsq zTLhFLMb7xBRSaQVFboiwGqa8WLB8MLY5XqdTe10uQlEoh/pvSVIvwT2Mdb/zhmvcjpB 5Aencgy+KkYeJALqPtP6lUM07CqDW0PrB7Q95VKTC2FLmjn3gavu76HAoMbGIaddD0B0 I5SszlFfpcly97CD9pQXH12ZclYXvVmN7ALS4v+v3UrJZU8HodJ5cnJWKrnVlJfhKk4N lXvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JZi5qI5fs3eqak0rmlJ8FUpmcCJ8LSmdIGuMVhAVLqc=; b=baZh28CdeZ3BRGxW4HlPMROUS59VwFCEuX0mFY3KZr1As+RGTJyBFVxTp2lCtQKIDa h0e6MjG3gWEAPkLITxI9qmTGTXK5Q2fHazC5ZvgLS2DvQPFd0YdZ/CouCvZkfdLtzhYf +vpvUF45cYZ4sCuoal+WQnQ0amQGWXYbLsQ+jLnyY9Nw8GlrO0N/jkQBvaAilrbqQ9So edxgCP1MTI6m42jz3EPfc73lUz+ff7ipox/v44vYwhMS4G6VcRr6VbADPaD/0LKNOQWf vGX38G3iUaMXlS7lDZUhxmDrw5nVX7InsBStY53+VqCQItOFCMbgjz2idIrDN/piy+J/ ZmJg== X-Gm-Message-State: APjAAAVQosyKOiHiGur3sl+cmhIa/Ir+1J64whlNTy0mlxn5PIEJwKd1 HRGEnYeszIXOKA/PuHFwhC+QXw== X-Received: by 2002:a05:6000:110:: with SMTP id o16mr23049894wrx.200.1561232330085; Sat, 22 Jun 2019 12:38:50 -0700 (PDT) Received: from localhost.localdomain (88-147-39-13.dyn.eolo.it. [88.147.39.13]) by smtp.gmail.com with ESMTPSA id h90sm7506441wrh.15.2019.06.22.12.38.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Jun 2019 12:38:49 -0700 (PDT) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, Paolo Valente Subject: [PATCH BUGFIX 1/1] block, bfq: fix operator in BFQQ_TOTALLY_SEEKY Date: Sat, 22 Jun 2019 21:38:03 +0200 Message-Id: <20190622193803.33044-2-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190622193803.33044-1-paolo.valente@linaro.org> References: <20190622193803.33044-1-paolo.valente@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org By mistake, there is a '&' instead of a '==' in the definition of the macro BFQQ_TOTALLY_SEEKY. This commit replaces the wrong operator with the correct one. Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index f8d430f88d25..f9269ae6da9c 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -240,7 +240,7 @@ static struct kmem_cache *bfq_pool; * containing only random (seeky) I/O are prevented from being tagged * as soft real-time. */ -#define BFQQ_TOTALLY_SEEKY(bfqq) (bfqq->seek_history & -1) +#define BFQQ_TOTALLY_SEEKY(bfqq) (bfqq->seek_history == -1) /* Min number of samples required to perform peak-rate update */ #define BFQ_RATE_MIN_SAMPLES 32