From patchwork Fri Jun 23 15:22:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 695487 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96792EB64DD for ; Fri, 23 Jun 2023 15:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231994AbjFWPWp (ORCPT ); Fri, 23 Jun 2023 11:22:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232098AbjFWPWl (ORCPT ); Fri, 23 Jun 2023 11:22:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A71071AC; Fri, 23 Jun 2023 08:22:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A1CB61A94; Fri, 23 Jun 2023 15:22:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C16AFC433C8; Fri, 23 Jun 2023 15:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687533758; bh=sRj5H73scWO/9TBS+e2MwEJ4mooOFaJ0HbXk3SIJWAM=; h=From:To:Cc:Subject:Date:From; b=g5i0UUMm4sK9b+44ZtTnyAGB15oqq45T8zvGFnZlw7UWNvTOHaMpxcHU3sk2ieLBj N2j1PBm5Ewl+dSuQsuug7lBu1PAu09qzehGzGN9XQZdsYB1XiIWIYvSffIyxB+UGMe vMb1yWtjb2v+vhns3FARfi/Ppr3o98Oub/GBGkcruBfunUYXqrrr94yEC4eMLKygc2 5cO6fHOSYd9UFuCNlkhf0XtU7ShyaDDKOmp7nn1L/C1oXmA2LEd9ZvtJCAHmfCCu7A 1R+SuuslDJeeWi/XWllcgULrdPzkWnjyN0XUDjjYpRDxAO59Yac3x16Vqh1FMmUp7B yMqjfclwyFQow== From: Arnd Bergmann To: Pavel Machek , Lee Jones , Andy Shevchenko , Henning Schild Cc: Arnd Bergmann , Hans de Goede , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] leds: simatic-ipc-leds-gpio: restore LEDS_CLASS dependency Date: Fri, 23 Jun 2023 17:22:29 +0200 Message-Id: <20230623152233.2246285-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org From: Arnd Bergmann A recent rework accidentally lost the dependency on LEDS_CLASS, which leads to a link error when LED support is disbled: x86_64-linux-ld: drivers/leds/simple/simatic-ipc-leds.o: in function `simatic_ipc_leds_probe': simatic-ipc-leds.c:(.text+0x10c): undefined reference to `devm_led_classdev_register_ext' Add back the dependency that was there originally. Fixes: a6c80bec3c935 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver") Signed-off-by: Arnd Bergmann --- drivers/leds/simple/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/simple/Kconfig b/drivers/leds/simple/Kconfig index 44fa0f93cb3b3..02443e745ff3b 100644 --- a/drivers/leds/simple/Kconfig +++ b/drivers/leds/simple/Kconfig @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config LEDS_SIEMENS_SIMATIC_IPC tristate "LED driver for Siemens Simatic IPCs" + depends on LEDS_CLASS depends on SIEMENS_SIMATIC_IPC help This option enables support for the LEDs of several Industrial PCs