From patchwork Thu Jun 22 08:17:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Bara X-Patchwork-Id: 695205 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE4CEB64DB for ; Thu, 22 Jun 2023 08:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229832AbjFVIRf (ORCPT ); Thu, 22 Jun 2023 04:17:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbjFVIRd (ORCPT ); Thu, 22 Jun 2023 04:17:33 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91A491BCB; Thu, 22 Jun 2023 01:17:32 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9887ebe16d0so612081466b.2; Thu, 22 Jun 2023 01:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687421851; x=1690013851; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IhEqYOleu4e1Mnd0sN9Md8hZQNtCOZtfgYgaY4CTKSY=; b=bETU7hckyF82y/dgVR41ALqMliicvHL9VmOMHlKOezpZri7+Wwqe2Jbx+CCSLlawhS o9cH11n/d/QeET3nLp1M95DRwbnsew/wMDBJSz1mga7mQAydIopZdfXudEN2LyKXkSAF z55nHuyYuankeimGqxo9v+wcfz6v4l0r6kX3msGVwpEXfOqdYFt0yToSCDNI+G3lkBCK Qt6WpvOZ78MRnW23k8qxyzqFca1zmz53osX4oE9I2FYazrtOYvDjPo998cS5Sku2SSl/ 3Xzl18/LowUoga84FoNQ23vbf1Hz8JzaaBA0/hi404ZNnH5EaoiPDzNyhF3+oVjwiW86 I+3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687421851; x=1690013851; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IhEqYOleu4e1Mnd0sN9Md8hZQNtCOZtfgYgaY4CTKSY=; b=TiSe9Jm3JzaP2xArGonJAdBa0fxUOkl2jPDxSY7R1rs+0tNzwST5eeFavXMa83D7Km JeoU0MR+xwC+AZFoh/OEbOT3wGPwjYOLPme1+7Omp6qHLE7dvGFCc+9frbr8PUw6JyXW ZGBmIGQu1723TOk4EshEBkCbTbnlsKyGKCVXk0UJ/jPm5p0UceYzDJPwXxk4QBYr7peT Q+Jdr/G8fKeFLaZDWMZcVEaeZeXEm0+hg4QmP1AJzgoCxZb+aCVL1KNYPJ8r9mwO6cuZ 999BFsBx8CLbaFqDlX80tPPL4THqTQ9vfycMMbYShRKKHDL0W9/n6X4dajM1iIp9ht4v 94EQ== X-Gm-Message-State: AC+VfDyl9iGh0/BH5WMVlZeRdwxY8aZp70iqlgFDXD9NNcCIQaNaRkkU 8VtwOGtUSOAAp52Sbyxt0g8= X-Google-Smtp-Source: ACHHUZ7xuKTPe9mc7rIywbuPM9N04DCJ630BZK/z73DeRwqR4/lgboe+19qnLyPcvUbFtYICCVsY1Q== X-Received: by 2002:a17:906:6a07:b0:989:a806:d197 with SMTP id qw7-20020a1709066a0700b00989a806d197mr4574413ejc.3.1687421850757; Thu, 22 Jun 2023 01:17:30 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id k22-20020a056402049600b0051bc58b8dbcsm3577886edv.59.2023.06.22.01.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 01:17:30 -0700 (PDT) From: Benjamin Bara Date: Thu, 22 Jun 2023 10:17:22 +0200 Subject: [PATCH v5 1/3] usb: misc: onboard-hub: support multiple power supplies MIME-Version: 1.0 Message-Id: <20230620-hx3-v5-1-319c9c4c846f@skidata.com> References: <20230620-hx3-v5-0-319c9c4c846f@skidata.com> In-Reply-To: <20230620-hx3-v5-0-319c9c4c846f@skidata.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara Cc: Alexander Stein , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.12.2 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Benjamin Bara As some of the onboard hubs require multiple power supplies, provide the environment to support them. Signed-off-by: Benjamin Bara --- v5: - use ARRAY_SIZE(supply_names) for MAX_SUPPLIES v4: - set num_supplies=1 for the existing hubs - drop duplicate num_supplies in onboard_hub struct - clarify connection between supply_names and MAX_SUPPLIES v3: - fix nits mentioned in v2 v2: - replace (err != 0) with (err) --- drivers/usb/misc/onboard_usb_hub.c | 37 +++++++++++++++++++++++++++++-------- drivers/usb/misc/onboard_usb_hub.h | 7 +++++++ 2 files changed, 36 insertions(+), 8 deletions(-) diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index 12fc6eb67c3b..1bbbc6948484 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -27,6 +27,17 @@ #include "onboard_usb_hub.h" +/* + * Use generic names, as the actual names might differ between hubs. If a new + * hub requires more than the currently supported supplies, add a new one here. + */ +static const char * const supply_names[] = { + "vdd", + "vdd2", +}; + +#define MAX_SUPPLIES ARRAY_SIZE(supply_names) + static void onboard_hub_attach_usb_driver(struct work_struct *work); static struct usb_device_driver onboard_hub_usbdev_driver; @@ -40,7 +51,7 @@ struct usbdev_node { }; struct onboard_hub { - struct regulator *vdd; + struct regulator_bulk_data supplies[MAX_SUPPLIES]; struct device *dev; const struct onboard_hub_pdata *pdata; struct gpio_desc *reset_gpio; @@ -55,9 +66,9 @@ static int onboard_hub_power_on(struct onboard_hub *hub) { int err; - err = regulator_enable(hub->vdd); + err = regulator_bulk_enable(hub->pdata->num_supplies, hub->supplies); if (err) { - dev_err(hub->dev, "failed to enable regulator: %d\n", err); + dev_err(hub->dev, "failed to enable supplies: %d\n", err); return err; } @@ -75,9 +86,9 @@ static int onboard_hub_power_off(struct onboard_hub *hub) gpiod_set_value_cansleep(hub->reset_gpio, 1); - err = regulator_disable(hub->vdd); + err = regulator_bulk_disable(hub->pdata->num_supplies, hub->supplies); if (err) { - dev_err(hub->dev, "failed to disable regulator: %d\n", err); + dev_err(hub->dev, "failed to disable supplies: %d\n", err); return err; } @@ -232,6 +243,7 @@ static int onboard_hub_probe(struct platform_device *pdev) const struct of_device_id *of_id; struct device *dev = &pdev->dev; struct onboard_hub *hub; + unsigned int i; int err; hub = devm_kzalloc(dev, sizeof(*hub), GFP_KERNEL); @@ -246,9 +258,18 @@ static int onboard_hub_probe(struct platform_device *pdev) if (!hub->pdata) return -EINVAL; - hub->vdd = devm_regulator_get(dev, "vdd"); - if (IS_ERR(hub->vdd)) - return PTR_ERR(hub->vdd); + if (hub->pdata->num_supplies > MAX_SUPPLIES) + return dev_err_probe(dev, -EINVAL, "max %d supplies supported!\n", + MAX_SUPPLIES); + + for (i = 0; i < hub->pdata->num_supplies; i++) + hub->supplies[i].supply = supply_names[i]; + + err = devm_regulator_bulk_get(dev, hub->pdata->num_supplies, hub->supplies); + if (err) { + dev_err(dev, "Failed to get regulator supplies: %d\n", err); + return err; + } hub->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h index aca5f50eb0da..41a4127a92dc 100644 --- a/drivers/usb/misc/onboard_usb_hub.h +++ b/drivers/usb/misc/onboard_usb_hub.h @@ -8,30 +8,37 @@ struct onboard_hub_pdata { unsigned long reset_us; /* reset pulse width in us */ + unsigned int num_supplies; /* number of supplies */ }; static const struct onboard_hub_pdata microchip_usb424_data = { .reset_us = 1, + .num_supplies = 1, }; static const struct onboard_hub_pdata realtek_rts5411_data = { .reset_us = 0, + .num_supplies = 1, }; static const struct onboard_hub_pdata ti_tusb8041_data = { .reset_us = 3000, + .num_supplies = 1, }; static const struct onboard_hub_pdata genesys_gl850g_data = { .reset_us = 3, + .num_supplies = 1, }; static const struct onboard_hub_pdata genesys_gl852g_data = { .reset_us = 50, + .num_supplies = 1, }; static const struct onboard_hub_pdata vialab_vl817_data = { .reset_us = 10, + .num_supplies = 1, }; static const struct of_device_id onboard_hub_match[] = { From patchwork Thu Jun 22 08:17:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Bara X-Patchwork-Id: 696221 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04E8EEB64DA for ; Thu, 22 Jun 2023 08:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229896AbjFVIRi (ORCPT ); Thu, 22 Jun 2023 04:17:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229784AbjFVIRe (ORCPT ); Thu, 22 Jun 2023 04:17:34 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CF8D1A4; Thu, 22 Jun 2023 01:17:33 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-51bec5c09ecso226025a12.2; Thu, 22 Jun 2023 01:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687421852; x=1690013852; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hsTfcmeZLSti/WbWnSJd6vFVwFkHrC8fIGZrK2b/Xtc=; b=o8thvPezk81i99v1b7tTy4SNJp78pLvwur0omjQNopZthDASYL8truAx+XjOMpHuGk 1xrP0jfvjpLBot+vNOXdHm2kB6I08Z2az5OOZjhlGLlqIvHpTWhO2DKwU+Yr25Xza6NN 7L33jUoKexgMSQrUqg6L6LxaOiW4/671wHDYeadMNHBUz/p6H4BQwOisykszxP/TlrMu 0R312IgXINkE9ACX5t5Tqb9vx0itZB88w0BAdgfEB8ee4xi4uiLdvoUEJA/mKoumyUuG LKdfJKQPEAWzSBe86ST4eSm2+m0cPZxu0EL0z67j0bWN1UGCASS/b7QA+wBE5m/lr/JC jaMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687421852; x=1690013852; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hsTfcmeZLSti/WbWnSJd6vFVwFkHrC8fIGZrK2b/Xtc=; b=k7/iqtoe11Tl7dLO+Apu0irWEn5JYRBu4wr/ujgEIrbfuqR+yEesOuQsHC1SCPFJ8O ewWsE+ItjKxUukYy8IysBNNA8kpbl7I5sUsqpRYkkL/KXKcuF6SLBpmDf+DyDHuyOpx8 dq5M2FZIDHQIFzbrOOONPLwR6h5fQbZ+ZFwICYKjUfeq1lZ3v6Bn+EcaUsf21kF/rpJY hKeO4EW/Sd4dos/a2aj1Y9vCAOHKFxlAxq5GJ4D3JLzMOGTN+VZQSegNeyWMTTW8GPoR QJyrJUL6h5NtX+yHUwiD5NAa+g39CBD/v9y+xupoDmXy80Sjd0zDkD8jSDve0ihIQPPn kElQ== X-Gm-Message-State: AC+VfDx8QGKKuZMeygTljc6cz9DgdHE5jn36+EEstb+luX+uaPfXVAFn kiwHVSCbhGSMPhbon6D4IGduC3G2C1KsXw== X-Google-Smtp-Source: ACHHUZ4p1+u7e5mHg1dqd0Px9ZNy4KBCEjGtP2FLrRg92lTt9lKe5tuN5PINVvC9Bs3H+4X2dz1AWA== X-Received: by 2002:a05:6402:4b:b0:51b:d79b:28ed with SMTP id f11-20020a056402004b00b0051bd79b28edmr2824607edu.12.1687421851683; Thu, 22 Jun 2023 01:17:31 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id k22-20020a056402049600b0051bc58b8dbcsm3577886edv.59.2023.06.22.01.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 01:17:31 -0700 (PDT) From: Benjamin Bara Date: Thu, 22 Jun 2023 10:17:23 +0200 Subject: [PATCH v5 2/3] usb: misc: onboard-hub: add support for Cypress HX3 USB 3.0 family MIME-Version: 1.0 Message-Id: <20230620-hx3-v5-2-319c9c4c846f@skidata.com> References: <20230620-hx3-v5-0-319c9c4c846f@skidata.com> In-Reply-To: <20230620-hx3-v5-0-319c9c4c846f@skidata.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara Cc: Alexander Stein , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.12.2 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Benjamin Bara The HX3 comes in different variants (up to 4 USB 3.0 ports; multi-TT), e.g. CYUSB330x/CYUSB331x/CYUSB332x/CYUSB230x. It operates with two different power supplies: 1V2 and 3V3. Add the support for this hub, for controlling the reset pin and the power supplies. Reset time is extracted from data sheet, page 24: "The RESETN pin can be tied to VDD_IO through an external resistor and to ground (GND) through an external capacitor (minimum 5 ms time constant)." V_IH min is given at 0.7 * 3V3 (page 34), therefore use 10ms. Also add USB PIDs for the USB 2.0 and USB 3.0 root hub. Acked-by: Matthias Kaehlcke Signed-off-by: Benjamin Bara --- drivers/usb/misc/onboard_usb_hub.c | 3 +++ drivers/usb/misc/onboard_usb_hub.h | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index 1bbbc6948484..5a528de1189c 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -350,6 +350,7 @@ static struct platform_driver onboard_hub_driver = { /************************** USB driver **************************/ +#define VENDOR_ID_CYPRESS 0x04b4 #define VENDOR_ID_GENESYS 0x05e3 #define VENDOR_ID_MICROCHIP 0x0424 #define VENDOR_ID_REALTEK 0x0bda @@ -428,6 +429,8 @@ static void onboard_hub_usbdev_disconnect(struct usb_device *udev) } static const struct usb_device_id onboard_hub_id_table[] = { + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6504) }, /* CYUSB33{0,1,2}x/CYUSB230x 3.0 */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6506) }, /* CYUSB33{0,1,2}x/CYUSB230x 2.0 */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G USB 2.0 */ { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 */ diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h index 41a4127a92dc..6f446fe7d2f7 100644 --- a/drivers/usb/misc/onboard_usb_hub.h +++ b/drivers/usb/misc/onboard_usb_hub.h @@ -26,6 +26,11 @@ static const struct onboard_hub_pdata ti_tusb8041_data = { .num_supplies = 1, }; +static const struct onboard_hub_pdata cypress_hx3_data = { + .reset_us = 10000, + .num_supplies = 2, +}; + static const struct onboard_hub_pdata genesys_gl850g_data = { .reset_us = 3, .num_supplies = 1, @@ -46,6 +51,8 @@ static const struct of_device_id onboard_hub_match[] = { { .compatible = "usb424,2517", .data = µchip_usb424_data, }, { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, { .compatible = "usb451,8142", .data = &ti_tusb8041_data, }, + { .compatible = "usb4b4,6504", .data = &cypress_hx3_data, }, + { .compatible = "usb4b4,6506", .data = &cypress_hx3_data, }, { .compatible = "usb5e3,608", .data = &genesys_gl850g_data, }, { .compatible = "usb5e3,610", .data = &genesys_gl852g_data, }, { .compatible = "usbbda,411", .data = &realtek_rts5411_data, }, From patchwork Thu Jun 22 08:17:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Bara X-Patchwork-Id: 695204 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89FAFEB64DB for ; Thu, 22 Jun 2023 08:17:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229950AbjFVIRn (ORCPT ); Thu, 22 Jun 2023 04:17:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbjFVIRf (ORCPT ); Thu, 22 Jun 2023 04:17:35 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72B4E1BCB; Thu, 22 Jun 2023 01:17:34 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-988b75d8b28so525904966b.3; Thu, 22 Jun 2023 01:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687421852; x=1690013852; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vQAW8yZCFSnADhBud7nfo4RU3cNf5kaZDT6uTQ+OwQc=; b=kARsZqFr4PYS5kVV4NlRTkCQZQl1+2YkJcJ/wMB+wnuZKnPkxd8DmIFYtmv41dRfJy 4az3ItTyb1ExtxPqmb+QgMl856FuoyOfjrdDUA9Bnp6zzLiHLI4Z8yyYN3fjZRVBwHAr DHcKX+Lo5xxBIoVCwd/P5jZlvVIjhuOHzXOnZo7N+9dxTn/wDjthVh86RFWrxuQyJWgw ohGqKrC0EUByoaYrhKlJ+wG0eOgEilhQNGzpZ8upuHp40Cvi2MX6MqHi8ln1NR6q4NGd F50cPuK/drDFlvCb9TtbvJ3cIxoUlaElPDG6dv9P7f3bwtu2ggBiwhJiSS9hi2IibY+r hAoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687421852; x=1690013852; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vQAW8yZCFSnADhBud7nfo4RU3cNf5kaZDT6uTQ+OwQc=; b=lLRfRQha3rWLC/D5+7SmBGLLJBskL81N1gNjWoDp9rYCH68N/WvahYKluTWgwA1eIb mRTp4zDkFEbse4uiwZ8g2zc0/r44YdxeN3phhgBo8cAtkEkfyeoieZAZEBpB1fGEgMnw He0gWP1hinTukourYOiOJQcXV5u26JlnerliwTpJVjZi71BmaAjr9xvChIoEcmnPmYhM QYRePtdeq0Gx+pvnV88CTqBSeyI1WZq7mszmf2nbON7Lpd2X0VuQi6rVsQBwPPquqco6 vLqsFwiysFLUdkpgdGWhH6+jlsIs8oUx3Us/H+1anCljtYj/EmHy2p45x71xxwjeCYGW 6nQg== X-Gm-Message-State: AC+VfDw2zaIw/jrPnOYYvPCsufvcMjDQP5SSJp0w6TW4xpwXv4yjm9Wy 9/mr7hJHw9/KdKuoYbLLyyo= X-Google-Smtp-Source: ACHHUZ76Q3bXBfAZvU8u8NWc41WchzEkD1d48/cXmceYw0WhwFthHHtW16u20G5hpJ4oaZev3mlmXQ== X-Received: by 2002:a17:907:c0a:b0:96f:d345:d0f7 with SMTP id ga10-20020a1709070c0a00b0096fd345d0f7mr15611192ejc.62.1687421852485; Thu, 22 Jun 2023 01:17:32 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id k22-20020a056402049600b0051bc58b8dbcsm3577886edv.59.2023.06.22.01.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 01:17:32 -0700 (PDT) From: Benjamin Bara Date: Thu, 22 Jun 2023 10:17:24 +0200 Subject: [PATCH v5 3/3] dt-bindings: usb: Add binding for Cypress HX3 USB 3.0 family MIME-Version: 1.0 Message-Id: <20230620-hx3-v5-3-319c9c4c846f@skidata.com> References: <20230620-hx3-v5-0-319c9c4c846f@skidata.com> In-Reply-To: <20230620-hx3-v5-0-319c9c4c846f@skidata.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara Cc: Alexander Stein , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring X-Mailer: b4 0.12.2 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Benjamin Bara The HX3 family comes in different variants (up to 4 USB 3.0 ports; multi-TT), e.g. CYUSB330x/CYUSB331x/CYUSB332x/CYUSB230x. This initial version of the binding only describes USB related aspects of the HX3 family, it does not cover the option of connecting the controller as an i2c slave. Reviewed-by: Rob Herring Signed-off-by: Benjamin Bara --- .../devicetree/bindings/usb/cypress,hx3.yaml | 77 ++++++++++++++++++++++ 1 file changed, 77 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/cypress,hx3.yaml b/Documentation/devicetree/bindings/usb/cypress,hx3.yaml new file mode 100644 index 000000000000..47add0d85fb8 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/cypress,hx3.yaml @@ -0,0 +1,77 @@ +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/cypress,hx3.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cypress HX3 USB 3.0 hub controller family + +maintainers: + - Benjamin Bara + +allOf: + - $ref: usb-device.yaml# + +properties: + compatible: + enum: + - usb4b4,6504 + - usb4b4,6506 + + reg: true + + reset-gpios: + items: + - description: GPIO specifier for RESETN pin. + + vdd-supply: + description: + 1V2 power supply (VDD_EFUSE, AVDD12, DVDD12). + + vdd2-supply: + description: + 3V3 power supply (AVDD33, VDD_IO). + + peer-hub: + $ref: /schemas/types.yaml#/definitions/phandle + description: + phandle to the peer hub on the controller. + +required: + - compatible + - reg + - peer-hub + - vdd-supply + - vdd2-supply + +additionalProperties: false + +examples: + - | + #include + + usb { + dr_mode = "host"; + #address-cells = <1>; + #size-cells = <0>; + + /* 2.0 hub on port 1 */ + hub_2_0: hub@1 { + compatible = "usb4b4,6504"; + reg = <1>; + peer-hub = <&hub_3_0>; + reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; + vdd-supply = <®_1v2_usb>; + vdd2-supply = <®_3v3_usb>; + }; + + /* 3.0 hub on port 2 */ + hub_3_0: hub@2 { + compatible = "usb4b4,6506"; + reg = <2>; + peer-hub = <&hub_2_0>; + reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; + vdd-supply = <®_1v2_usb>; + vdd2-supply = <®_3v3_usb>; + }; + };