From patchwork Thu Jun 22 10:18:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 695202 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DD8EB64D8 for ; Thu, 22 Jun 2023 10:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbjFVKSV (ORCPT ); Thu, 22 Jun 2023 06:18:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbjFVKSU (ORCPT ); Thu, 22 Jun 2023 06:18:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9107FDD; Thu, 22 Jun 2023 03:18:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D8B5617C8; Thu, 22 Jun 2023 10:18:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCD4DC433C8; Thu, 22 Jun 2023 10:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687429098; bh=ON66HbfJ1HJ3YKs4MkYfePaKxVL3lLiSW463cMoqJN4=; h=From:To:Cc:Subject:Date:From; b=igRdryfErkXMOmpAXCPL6+iCdcz1mTZRIYVlWMjPI8b0SqJC69hTsbH+P/YSsAHai XP7sqjUe/IKYNNB+3suFT2wCKtmI25VVLv5GPH/pbDbdY3W6RKGBu4AHgH3mDUB1L4 TSlqXiW2Gbzk0kUakH7H1bF4MPnIV017QO2Mtf2ZIqJwRgu6QRYbua6Y6zNC/802uD Bcrlt3rKaoeT1toTidzbR8C6lSKx7br+blH7glaHq1bGY9DEd5Vzmvd1uaazGqDPJy otbwxq/Gs5Hg6u5WmoO+aOhtm781Nux25vjrlV9h0lfFe/GluICxaHSHrXHmfGlV+J geWn76zimRrxg== From: Arnd Bergmann To: Heikki Krogerus , Greg Kroah-Hartman , Neil Armstrong , Dmitry Baryshkov Cc: Arnd Bergmann , Bjorn Andersson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: typec: nb7vpq904m: add CONFIG_DRM dependency Date: Thu, 22 Jun 2023 12:18:09 +0200 Message-Id: <20230622101813.3453772-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Arnd Bergmann This driver calls directly into DRM functions and fails to link if that is disabled: ld.lld: error: undefined symbol: devm_drm_bridge_add ld.lld: error: undefined symbol: devm_drm_of_get_bridge >>> referenced by nb7vpq904m.c >>> drivers/usb/typec/mux/nb7vpq904m.o:(nb7vpq904m_probe) in archive vmlinux.a Fixes: 88d8f3ac9c67e ("usb: typec: add support for the nb7vpq904m Type-C Linear Redriver") Signed-off-by: Arnd Bergmann --- drivers/usb/typec/mux/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig index 8c4d6b8fb75c3..f53ae24b6c048 100644 --- a/drivers/usb/typec/mux/Kconfig +++ b/drivers/usb/typec/mux/Kconfig @@ -37,7 +37,7 @@ config TYPEC_MUX_INTEL_PMC config TYPEC_MUX_NB7VPQ904M tristate "On Semiconductor NB7VPQ904M Type-C redriver driver" - depends on I2C + depends on I2C && DRM select REGMAP_I2C help Say Y or M if your system has a On Semiconductor NB7VPQ904M Type-C