From patchwork Wed Jun 21 15:58:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Bara X-Patchwork-Id: 695216 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F5AAC001B3 for ; Wed, 21 Jun 2023 15:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233818AbjFUP6z (ORCPT ); Wed, 21 Jun 2023 11:58:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233777AbjFUP6s (ORCPT ); Wed, 21 Jun 2023 11:58:48 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1341F1; Wed, 21 Jun 2023 08:58:46 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-98bcc533490so120995166b.0; Wed, 21 Jun 2023 08:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687363125; x=1689955125; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kCPr+EfHlZTTO9JEAGikCO7r8p4Wro+SruNHk/6WAj8=; b=kjrMisJLe4zIjhjFexTLiQ6L3aIXSHRJVYspOPhK2eVWwf388l+JcXV/zpsKqTfe69 E1d5PxUJASm1md2G5G2DkByJ5J2wpRnsdyVugYL9ShCgF0q8+cg6dKIQddQizDajX2wP R9JUxRwPIw4YW1YLp0veNnuRCwc4ZfBXXj1oICLOCQKSJoBsVxgFcb26eWYYYP/9mjnX 3nJRE/xgHq1t/xgnftT2Xn3AWUfOQMvXn+LZLUXf/QkY9GsZl2i97rN0odYQInHa/Rjw V4aWV1bATYPRRaqmkOyOfzpMvjXzCKYvy1zic5qmni6eA6ijWhNv2h5+6bQ0krUq5eMC uR+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687363125; x=1689955125; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kCPr+EfHlZTTO9JEAGikCO7r8p4Wro+SruNHk/6WAj8=; b=E/fzAKntjvp2yIbg/IlAF2z2kEircLWHz9TY1QIr7opu/2uR2fh9AgR4SlRJy7KZ50 K4OEyNdcOi7hxwX8uwQdmmR+1+e6JFcwbab1OP6PGvUqXSlDM8TLJ71nny0NZUwvwiCf lciRCujUK4skPcuxaluxrW8x0gmRAizyuPAfwYf6judmqw7FVr2ScVTjbV/wkJqBI/gq YBHpUsfYOhLtG6PV4urSKRk10fpCbjYt5OORG0WpZOI3W9JGv8yMS9bRpx6VrdW1uEaH 55KPFfXi+3BrQMf7SzscrQkjoXNPlIzzAFISzlMI+wncy4eWjFiuJpKd+onD0u2t/T5K 7lOQ== X-Gm-Message-State: AC+VfDzLSP3XLAQWS6qstV1vnTQIFl9REwa8BMfcCaAnurvmo5aAGu3e 4culGgwssAbouNtkXeIebrk= X-Google-Smtp-Source: ACHHUZ7fMKapLIJ1aUqKY51NhYvdy53Hfxxf04628jLhouWXzuhizLSYZB/EPsOWor608TZvngXUvA== X-Received: by 2002:a17:907:848:b0:988:aeb7:2a37 with SMTP id ww8-20020a170907084800b00988aeb72a37mr8123254ejb.33.1687363125237; Wed, 21 Jun 2023 08:58:45 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id w20-20020a1709060a1400b00977eec7b7e8sm3349316ejf.68.2023.06.21.08.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 08:58:45 -0700 (PDT) From: Benjamin Bara Date: Wed, 21 Jun 2023 17:58:30 +0200 Subject: [PATCH v3 1/3] usb: misc: onboard-hub: support multiple power supplies MIME-Version: 1.0 Message-Id: <20230620-hx3-v3-1-2acbc03ca949@skidata.com> References: <20230620-hx3-v3-0-2acbc03ca949@skidata.com> In-Reply-To: <20230620-hx3-v3-0-2acbc03ca949@skidata.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.12.2 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Benjamin Bara As some of the onboard hubs require multiple power supplies, provide the environment to support them. Signed-off-by: Benjamin Bara --- v3: - fix nits mentioned in v2 v2: - replace (err != 0) with (err) --- drivers/usb/misc/onboard_usb_hub.c | 39 ++++++++++++++++++++++++++++++-------- drivers/usb/misc/onboard_usb_hub.h | 1 + 2 files changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index 12fc6eb67c3b..a56e712d3a45 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -27,6 +27,13 @@ #include "onboard_usb_hub.h" +#define MAX_SUPPLIES 2 + +static const char * const supply_names[] = { + "vdd", + "vdd2", +}; + static void onboard_hub_attach_usb_driver(struct work_struct *work); static struct usb_device_driver onboard_hub_usbdev_driver; @@ -40,7 +47,8 @@ struct usbdev_node { }; struct onboard_hub { - struct regulator *vdd; + struct regulator_bulk_data supplies[MAX_SUPPLIES]; + unsigned int num_supplies; struct device *dev; const struct onboard_hub_pdata *pdata; struct gpio_desc *reset_gpio; @@ -55,9 +63,9 @@ static int onboard_hub_power_on(struct onboard_hub *hub) { int err; - err = regulator_enable(hub->vdd); + err = regulator_bulk_enable(hub->num_supplies, hub->supplies); if (err) { - dev_err(hub->dev, "failed to enable regulator: %d\n", err); + dev_err(hub->dev, "failed to enable supplies: %d\n", err); return err; } @@ -75,9 +83,9 @@ static int onboard_hub_power_off(struct onboard_hub *hub) gpiod_set_value_cansleep(hub->reset_gpio, 1); - err = regulator_disable(hub->vdd); + err = regulator_bulk_disable(hub->num_supplies, hub->supplies); if (err) { - dev_err(hub->dev, "failed to disable regulator: %d\n", err); + dev_err(hub->dev, "failed to disable supplies: %d\n", err); return err; } @@ -232,6 +240,7 @@ static int onboard_hub_probe(struct platform_device *pdev) const struct of_device_id *of_id; struct device *dev = &pdev->dev; struct onboard_hub *hub; + unsigned int i; int err; hub = devm_kzalloc(dev, sizeof(*hub), GFP_KERNEL); @@ -246,9 +255,23 @@ static int onboard_hub_probe(struct platform_device *pdev) if (!hub->pdata) return -EINVAL; - hub->vdd = devm_regulator_get(dev, "vdd"); - if (IS_ERR(hub->vdd)) - return PTR_ERR(hub->vdd); + if (hub->pdata->num_supplies > MAX_SUPPLIES) + return dev_err_probe(dev, -EINVAL, "max %d supplies supported!\n", + MAX_SUPPLIES); + + if (hub->pdata->num_supplies) + hub->num_supplies = hub->pdata->num_supplies; + else + hub->num_supplies = 1; + + for (i = 0; i < MAX_SUPPLIES; i++) + hub->supplies[i].supply = supply_names[i]; + + err = devm_regulator_bulk_get(dev, hub->num_supplies, hub->supplies); + if (err) { + dev_err(dev, "Failed to get regulator supplies: %d\n", err); + return err; + } hub->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h index aca5f50eb0da..7a6d497ce849 100644 --- a/drivers/usb/misc/onboard_usb_hub.h +++ b/drivers/usb/misc/onboard_usb_hub.h @@ -8,6 +8,7 @@ struct onboard_hub_pdata { unsigned long reset_us; /* reset pulse width in us */ + unsigned int num_supplies; /* number of supplies: 0 considered as 1 */ }; static const struct onboard_hub_pdata microchip_usb424_data = { From patchwork Wed Jun 21 15:58:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Bara X-Patchwork-Id: 694870 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5BE9EB64D7 for ; Wed, 21 Jun 2023 15:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233834AbjFUP64 (ORCPT ); Wed, 21 Jun 2023 11:58:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233780AbjFUP6s (ORCPT ); Wed, 21 Jun 2023 11:58:48 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CFC710A; Wed, 21 Jun 2023 08:58:47 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-987a977f62aso560032066b.1; Wed, 21 Jun 2023 08:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687363126; x=1689955126; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gz7/LsPoj07PHZZXl5TA0hPQYcayGa5OFB1Suxc3qHk=; b=HxS/vtFfvo1S+gNIE8SlCZwfaiMOw4gQjS/nLFWlpFbMkPlzJXA4FVQkSr8RGqkDWm MAXBitqAD1qthvkeiCebCZhGD7RXpgfnCtVCqtv1BdjIbeEcoT5zy7UgLl8hIyRtYW7T EInl+Vtt0buAhjrBnSwl/X+ruDz90x8AfKpHd2hereqBsQJqliQ84pB9ev0wF+Y3pSWC /oDOEk15dw2YdJjodu+OsUtn6LAxSn1B0cSn0ZR3UiytUlZjd6MeB8mMQ4yS9NSORUHM wmu0ao3qEwUQL1uzrPE1MXBZFZ208sUCzYTW/F1bF5MT3t64KD29fqlpPiCkw2KsgU5D Iy8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687363126; x=1689955126; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gz7/LsPoj07PHZZXl5TA0hPQYcayGa5OFB1Suxc3qHk=; b=dKHhiUJfwOSeRU0xhVGCKQWC69rnZUEDPPfKWjXoItjHbsBM0Ox6P/b7U4kRtdbCnY bzUtmm8LhLcKYNXNNeBHdnO+mgCHoGlEvzJ3T3R2q0yi9NZRTGFIVUrufUL4fkjpjw5t vGUwGsUZ1yMU1aALfgZZ9YrS64HzkOOqA55rAu2z5wrEUJq6CRhwmEqawwMayImTVeWc Ph242jKRP3ZJX6dWUn633BE4flrrBPAqDoBU9d1FiqR+jwiM/koh0JtHcTQggXZbjdar 27CMc898hnBeNAEmDs7m9chiZCP7n24S2yaJMxfs0Q3xCkjCtbL6IYPkC0i0EdoUmftY NcwQ== X-Gm-Message-State: AC+VfDxF59AVJUObGch4ZH38LoKyU8KZIBQw0XPA23fOAiI9eUNGSxiZ oJeuY0TOD4fiKPSwrozb1C0= X-Google-Smtp-Source: ACHHUZ5xqgn171ILi/CO5qFwGxxRXF5fl94v+gA61qXv1JQ9zIfx5YWlkYU/1TKufvBqvUX2prP1SA== X-Received: by 2002:a17:907:d17:b0:989:57c0:444f with SMTP id gn23-20020a1709070d1700b0098957c0444fmr2826474ejc.77.1687363126001; Wed, 21 Jun 2023 08:58:46 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id w20-20020a1709060a1400b00977eec7b7e8sm3349316ejf.68.2023.06.21.08.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 08:58:45 -0700 (PDT) From: Benjamin Bara Date: Wed, 21 Jun 2023 17:58:31 +0200 Subject: [PATCH v3 2/3] usb: misc: onboard-hub: add support for Cypress HX3 USB 3.0 family MIME-Version: 1.0 Message-Id: <20230620-hx3-v3-2-2acbc03ca949@skidata.com> References: <20230620-hx3-v3-0-2acbc03ca949@skidata.com> In-Reply-To: <20230620-hx3-v3-0-2acbc03ca949@skidata.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.12.2 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Benjamin Bara The HX3 comes in different variants (up to 4 USB 3.0 ports; multi-TT), e.g. CYUSB330x/CYUSB331x/CYUSB332x/CYUSB230x. It operates with two different power supplies: 1V2 and 3V3. Add the support for this hub, for controlling the reset pin and the power supplies. Reset time is extracted from data sheet, page 24: "The RESETN pin can be tied to VDD_IO through an external resistor and to ground (GND) through an external capacitor (minimum 5 ms time constant)." V_IH min is given at 0.7 * 3V3 (page 34), therefore use 10ms. Also add USB PIDs for the USB 2.0 and USB 3.0 root hub. Acked-by: Matthias Kaehlcke Signed-off-by: Benjamin Bara --- drivers/usb/misc/onboard_usb_hub.c | 3 +++ drivers/usb/misc/onboard_usb_hub.h | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index a56e712d3a45..3826f4fdcaee 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -352,6 +352,7 @@ static struct platform_driver onboard_hub_driver = { /************************** USB driver **************************/ +#define VENDOR_ID_CYPRESS 0x04b4 #define VENDOR_ID_GENESYS 0x05e3 #define VENDOR_ID_MICROCHIP 0x0424 #define VENDOR_ID_REALTEK 0x0bda @@ -430,6 +431,8 @@ static void onboard_hub_usbdev_disconnect(struct usb_device *udev) } static const struct usb_device_id onboard_hub_id_table[] = { + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6504) }, /* CYUSB33{0,1,2}x/CYUSB230x 3.0 */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6506) }, /* CYUSB33{0,1,2}x/CYUSB230x 2.0 */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G USB 2.0 */ { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 */ diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h index 7a6d497ce849..8f8e1001368e 100644 --- a/drivers/usb/misc/onboard_usb_hub.h +++ b/drivers/usb/misc/onboard_usb_hub.h @@ -23,6 +23,11 @@ static const struct onboard_hub_pdata ti_tusb8041_data = { .reset_us = 3000, }; +static const struct onboard_hub_pdata cypress_hx3_data = { + .reset_us = 10000, + .num_supplies = 2, +}; + static const struct onboard_hub_pdata genesys_gl850g_data = { .reset_us = 3, }; @@ -40,6 +45,8 @@ static const struct of_device_id onboard_hub_match[] = { { .compatible = "usb424,2517", .data = µchip_usb424_data, }, { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, { .compatible = "usb451,8142", .data = &ti_tusb8041_data, }, + { .compatible = "usb4b4,6504", .data = &cypress_hx3_data, }, + { .compatible = "usb4b4,6506", .data = &cypress_hx3_data, }, { .compatible = "usb5e3,608", .data = &genesys_gl850g_data, }, { .compatible = "usb5e3,610", .data = &genesys_gl852g_data, }, { .compatible = "usbbda,411", .data = &realtek_rts5411_data, }, From patchwork Wed Jun 21 15:58:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Bara X-Patchwork-Id: 695215 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DA87EB64DD for ; Wed, 21 Jun 2023 15:59:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233777AbjFUP67 (ORCPT ); Wed, 21 Jun 2023 11:58:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230004AbjFUP6t (ORCPT ); Wed, 21 Jun 2023 11:58:49 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5446F186; Wed, 21 Jun 2023 08:58:48 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-978863fb00fso926917966b.3; Wed, 21 Jun 2023 08:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687363127; x=1689955127; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cXp+vDAywJj5cJVg/DGBbIIG0LrSwQcuzIbyxZXKO/k=; b=Gb0TzHqwzv+RP62LSJ5Lt6UkdvX0M2muoGWBR0e6byr6bsn/YJ2+MRGJs3PECwO4NW an/fwqqeu2Q5yHmmUmFMcnzsv1i/dg03aRtHinJAle3rXcfzRDBlatfppktjkVEx8PSW qDKccS+VKRZ9lCt92x47XN8TwIVJ1VAWgGCOPRY6uXMFOxtCDUvfoVbXBNfn8a0ORZbr 1T5R2ZSm7wq05lD7XwTGtJcLi0znJOfFJ1jmA88TZtgvtl1egqvKMFvcHNAqXBD8c0i1 qDWSw4PK0jLfiHLdmdTiErNAZq5EBUdeypjEhTjD68wHbpFtY6P+E6Ap4EcKa47hWrwF c3+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687363127; x=1689955127; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cXp+vDAywJj5cJVg/DGBbIIG0LrSwQcuzIbyxZXKO/k=; b=CekqBatEwwXzFeiVTo3Q0ZRpHwSzbS+Pi8XohCifDYqSwTMxSUqYjjlxxqyslJu/PF wVzzuAWCGGX00dlFyCN4Rkl+70LAKPzuhxo7d4b13lyJWJZusi9HnNfZwaVxJy63M7N1 kFb1SUm6FzwA+rkzSDcfnyaToQ1y/t6cc52dR0mUnahE6OKfks4b2kB09vwmohUxxfze o6cvgkWmzOVhuUqpCFj7fsBQ+ykj15Rwxtb8972R+OllOFWlZfQAkZdE4SWNuYgIHmHv hh9X23PlpGgMKaelVMmy5FVHzx520XnoACmu3Um3r0NGoZ3aUaiUn/S0QCC1kQT8GzlT Hk5Q== X-Gm-Message-State: AC+VfDyCsLnENBO+47PtTQ0KKxIOlbkkUV07EGjben26isVcV+i9izmW j4IGt/C1y1cySqD7f0MoF81KGgzqd3l9Tw== X-Google-Smtp-Source: ACHHUZ6iDd8OnFoFXyuyEiDuhqCz1LfwMXgR0d/91+nypJbXgHUQYPJx6t0ysho5OcIwD2jD2mWGRw== X-Received: by 2002:a17:907:60d6:b0:973:ca90:1f18 with SMTP id hv22-20020a17090760d600b00973ca901f18mr16990926ejc.76.1687363126769; Wed, 21 Jun 2023 08:58:46 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id w20-20020a1709060a1400b00977eec7b7e8sm3349316ejf.68.2023.06.21.08.58.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 08:58:46 -0700 (PDT) From: Benjamin Bara Date: Wed, 21 Jun 2023 17:58:32 +0200 Subject: [PATCH v3 3/3] dt-bindings: usb: Add binding for Cypress HX3 USB 3.0 family MIME-Version: 1.0 Message-Id: <20230620-hx3-v3-3-2acbc03ca949@skidata.com> References: <20230620-hx3-v3-0-2acbc03ca949@skidata.com> In-Reply-To: <20230620-hx3-v3-0-2acbc03ca949@skidata.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.12.2 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Benjamin Bara The HX3 family comes in different variants (up to 4 USB 3.0 ports; multi-TT), e.g. CYUSB330x/CYUSB331x/CYUSB332x/CYUSB230x. This initial version of the binding only describes USB related aspects of the HX3 family, it does not cover the option of connecting the controller as an i2c slave. Signed-off-by: Benjamin Bara --- .../devicetree/bindings/usb/cypress,hx3.yaml | 77 ++++++++++++++++++++++ 1 file changed, 77 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/cypress,hx3.yaml b/Documentation/devicetree/bindings/usb/cypress,hx3.yaml new file mode 100644 index 000000000000..47add0d85fb8 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/cypress,hx3.yaml @@ -0,0 +1,77 @@ +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/cypress,hx3.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cypress HX3 USB 3.0 hub controller family + +maintainers: + - Benjamin Bara + +allOf: + - $ref: usb-device.yaml# + +properties: + compatible: + enum: + - usb4b4,6504 + - usb4b4,6506 + + reg: true + + reset-gpios: + items: + - description: GPIO specifier for RESETN pin. + + vdd-supply: + description: + 1V2 power supply (VDD_EFUSE, AVDD12, DVDD12). + + vdd2-supply: + description: + 3V3 power supply (AVDD33, VDD_IO). + + peer-hub: + $ref: /schemas/types.yaml#/definitions/phandle + description: + phandle to the peer hub on the controller. + +required: + - compatible + - reg + - peer-hub + - vdd-supply + - vdd2-supply + +additionalProperties: false + +examples: + - | + #include + + usb { + dr_mode = "host"; + #address-cells = <1>; + #size-cells = <0>; + + /* 2.0 hub on port 1 */ + hub_2_0: hub@1 { + compatible = "usb4b4,6504"; + reg = <1>; + peer-hub = <&hub_3_0>; + reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; + vdd-supply = <®_1v2_usb>; + vdd2-supply = <®_3v3_usb>; + }; + + /* 3.0 hub on port 2 */ + hub_3_0: hub@2 { + compatible = "usb4b4,6506"; + reg = <2>; + peer-hub = <&hub_2_0>; + reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; + vdd-supply = <®_1v2_usb>; + vdd2-supply = <®_3v3_usb>; + }; + };