From patchwork Wed Jun 21 09:14:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 694759 Delivered-To: patch@linaro.org Received: by 2002:adf:e885:0:0:0:0:0 with SMTP id d5csp736890wrm; Wed, 21 Jun 2023 02:15:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7h7EbjRdqrsKYwx76LIe4BUlCgRUdTZmVHW+T8smy8k4bzdYGlVRYEoUEDDv/5nXdbm074 X-Received: by 2002:a05:620a:38c9:b0:762:4f1d:28bc with SMTP id qq9-20020a05620a38c900b007624f1d28bcmr10838240qkn.32.1687338916961; Wed, 21 Jun 2023 02:15:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687338916; cv=none; d=google.com; s=arc-20160816; b=GTcRGfwIu3YVZaCfnStmNKgw0r2VwlSlXBDsBY+YEAmYJt8tubqOIwCzpc2tt4FTXB URc0dTbVNSyxe+up3gxqxnkei7yRCPvSEkCTZbpvRLFFIM3ZnzSyhPSbrFMjTKQolRgF 4u2GxYcTj2fLe9RNkqFXbYU+60osu2MV6PaiGIPi4C/kzUXBtZFmIBJtYNPCyHxHoD5l SciuDl3cLRM29YaGrS3hEVrfOARXhAxNs36I4m91x2/ArBPX3JtlCDiPVCJIY7s1Hnc/ 5Pdd7+Na8QWuL0ulJwbS23GDyKq/piSKHX4zqZeCk2drPLiGsQX7PoXoF83xBfeMaJpP SoXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=flknc6IAMOkvaHLJcij+gC86DpoYwTv6WZ4YwzFNM78=; b=xSwYweuqwjz7PJ79rn6V6YnxwFTO7Z8rgUdrj2UPNukndlxe+YiX30lSHqjNga+G7o hT+TKb9D8LvCCjfx8oJzRhG7FjfrYowhA15NiJTVNzLJLTGK+Tb7UB+QJtrVq30IMOL7 EBXbtQ7LCiOYEUQqTN9o5PqarV6i9Q92Du7KE77xQ/5xbrHNtZr3EZpHbcF8nGR2E4l3 Zkshog2Zg437T2Gr0DSPcgDmhRM89UFfX9e9HGA/b65zShRzhXPW0XKRxMe4JheAzUn6 d1fNwBmnXHOEn3VOWru8RikOCVGSvR4uTj6K6AVCXIPxNYsYr2SIemYkbbrbr5zEJYDW t5Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ybC27lIg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id dw26-20020a05620a601a00b0075cce2d5099si1572104qkb.375.2023.06.21.02.15.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Jun 2023 02:15:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ybC27lIg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBtvT-0006af-Cp; Wed, 21 Jun 2023 05:14:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBtvO-0006XE-CY for qemu-devel@nongnu.org; Wed, 21 Jun 2023 05:14:50 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBtvL-0004UW-HK for qemu-devel@nongnu.org; Wed, 21 Jun 2023 05:14:49 -0400 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-9881b9d8cbdso742779266b.1 for ; Wed, 21 Jun 2023 02:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687338886; x=1689930886; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=flknc6IAMOkvaHLJcij+gC86DpoYwTv6WZ4YwzFNM78=; b=ybC27lIgVb62eFQrygXuZkBNvQ1jO382ivTf/8HizlfNgyrIh10LBuWVmhKxdxzC84 OAZ920RS5pXl/jSy4UUvBH9l4YhEMUp0U8Y60k8UjYfCG1ykBEp+d3qALosmLLVT+BJ8 4vmnnw8euMMykpK9hoAcQYGDT0qKm3PrVz2q0c41YuLpsvkHcgQ9JAgkHst1xMBlbdTk WxgVTWUtzRYF4Vg+5YBKAoOYT4hE47MeoaRQxxf9ZF0I/Q8uNk+thd/esdXMoMZYf/PX MgUY8a8m5BGTQs3mI0cHNsPrhup1kRngVyq3piuW8CNPJctzBvejSqDc4lzFhwhkUkXK djmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687338886; x=1689930886; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=flknc6IAMOkvaHLJcij+gC86DpoYwTv6WZ4YwzFNM78=; b=kQ/76hhh4hV1eDi26Av6QkEpOuiluYJC8URKqIHHBsrmZhdMqV1iEeaya42yUjmczj yiT+gJoJFwTzEJlxjdAocxbTjjPVEYZTznvvL2XUnbY/kyOeu2gLHSWKVxmZIh2NHxwl C94hUh3TG33b5ey++1apz3Np8BXuuuOoTpLbnkt6Fn98redByScEqG5ffvNgZpAKudtV 1/3RxBdVV1CZkkszEthavj4DNv2B18dSi7EhuOxxVInxlBIKlu/6a+ahMoJK9bTorVOH QQVt3R5kwgDRHBiyp8H4wBs+mLQMfDOvTsPiejnRoo4+EOpm4gI0FjVeMP3SJ4/3gkTg LiTQ== X-Gm-Message-State: AC+VfDwj0FYMlnx/X26xzGbsjZV5eprLix3Z3vkh8oct2ZmXEHx46XqN Na8V5C63pMKMSe/wYBGgvC96Uqr4NS1gHz97JVVAXu13 X-Received: by 2002:a17:906:58cd:b0:989:d9d:d90a with SMTP id e13-20020a17090658cd00b009890d9dd90amr5508881ejs.34.1687338885804; Wed, 21 Jun 2023 02:14:45 -0700 (PDT) Received: from stoup.lan ([176.176.128.70]) by smtp.gmail.com with ESMTPSA id i15-20020a170906850f00b00982cac5fbbbsm2803297ejx.62.2023.06.21.02.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 02:14:45 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: alex.bennee@linaro.org Subject: [PATCH v2] tests/plugin: Remove duplicate insn log from libinsn.so Date: Wed, 21 Jun 2023 11:14:43 +0200 Message-Id: <20230621091443.1187290-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=richard.henderson@linaro.org; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This is a perfectly natural occurrence for x86 "rep movb", where the "rep" prefix forms a counted loop of the one insn. During the tests/tcg/multiarch/memory test, this logging is triggered over 350000 times. Within the context of cross-i386-tci build, which is already slow by nature, the logging is sufficient to push the test into timeout. Signed-off-by: Richard Henderson --- tests/tcg/i386/Makefile.softmmu-target | 9 --------- tests/tcg/i386/Makefile.target | 6 ------ tests/tcg/x86_64/Makefile.softmmu-target | 9 --------- 3 files changed, 24 deletions(-) diff --git a/tests/tcg/i386/Makefile.softmmu-target b/tests/tcg/i386/Makefile.softmmu-target index ed922d59c8..5266f2335a 100644 --- a/tests/tcg/i386/Makefile.softmmu-target +++ b/tests/tcg/i386/Makefile.softmmu-target @@ -33,14 +33,5 @@ EXTRA_RUNS+=$(MULTIARCH_RUNS) memory: CFLAGS+=-DCHECK_UNALIGNED=1 -# non-inline runs will trigger the duplicate instruction heuristics in libinsn.so -run-plugin-%-with-libinsn.so: - $(call run-test, $@, \ - $(QEMU) -monitor none -display none \ - -chardev file$(COMMA)path=$@.out$(COMMA)id=output \ - -plugin ../../plugin/libinsn.so$(COMMA)inline=on \ - -d plugin -D $*-with-libinsn.so.pout \ - $(QEMU_OPTS) $*) - # Running QEMU_OPTS+=-device isa-debugcon,chardev=output -device isa-debug-exit,iobase=0xf4,iosize=0x4 -kernel diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target index 821822ed0c..f2ee7a4db7 100644 --- a/tests/tcg/i386/Makefile.target +++ b/tests/tcg/i386/Makefile.target @@ -63,12 +63,6 @@ else SKIP_I386_TESTS+=test-i386-fprem endif -# non-inline runs will trigger the duplicate instruction heuristics in libinsn.so -run-plugin-%-with-libinsn.so: - $(call run-test, $@, $(QEMU) $(QEMU_OPTS) \ - -plugin ../../plugin/libinsn.so$(COMMA)inline=on \ - -d plugin -D $*-with-libinsn.so.pout $*) - # Update TESTS I386_TESTS:=$(filter-out $(SKIP_I386_TESTS), $(ALL_X86_TESTS)) TESTS=$(MULTIARCH_TESTS) $(I386_TESTS) diff --git a/tests/tcg/x86_64/Makefile.softmmu-target b/tests/tcg/x86_64/Makefile.softmmu-target index 7207fee94c..1bd763f2e6 100644 --- a/tests/tcg/x86_64/Makefile.softmmu-target +++ b/tests/tcg/x86_64/Makefile.softmmu-target @@ -33,14 +33,5 @@ EXTRA_RUNS+=$(MULTIARCH_RUNS) memory: CFLAGS+=-DCHECK_UNALIGNED=1 -# non-inline runs will trigger the duplicate instruction heuristics in libinsn.so -run-plugin-%-with-libinsn.so: - $(call run-test, $@, \ - $(QEMU) -monitor none -display none \ - -chardev file$(COMMA)path=$@.out$(COMMA)id=output \ - -plugin ../../plugin/libinsn.so$(COMMA)inline=on \ - -d plugin -D $*-with-libinsn.so.pout \ - $(QEMU_OPTS) $*) - # Running QEMU_OPTS+=-device isa-debugcon,chardev=output -device isa-debug-exit,iobase=0xf4,iosize=0x4 -kernel