From patchwork Mon Jun 17 12:41:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 167009 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp2814443ilk; Mon, 17 Jun 2019 05:42:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqyh2HfVadlmMh3gB2GjFOcdjQp4gnLVs5x/w3SJEM/3s6HK4kFjvgw4oqdfG4+kTNBFfxOh X-Received: by 2002:a63:8841:: with SMTP id l62mr47473209pgd.246.1560775320270; Mon, 17 Jun 2019 05:42:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560775320; cv=none; d=google.com; s=arc-20160816; b=vjCbSePu3ZAjLWhjfK2SEYWkhzE2WWInfMXcW0nbYs9kr2HUCDDE3TveDC7+fl5PTT 71JQx6SO3qJ5ZW8DKVs0pvp1Mm/o5vA2IhNBcewBUJQgoKhDfmXrLkhv5uV2VfkH09Lf NdpETvce3n88eIs6yG5/K+OwgcI1lHVDlyDk3bVUO7s1tjmgloVI5dVAKTcLlAGjqcHw pQ3P5gUcxxLrLenClGxIgTLG9lFLvwXwWtlukIuX09vq7esaK1SHa6cEMQusARcHkQ4Q eovo95ehhupqjwu5q4AJJTHXCfNTYlSfiWG/o7VrJupfYrn9K8WW0l/A+oMxHW1fV0aZ d5iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=0R9AtvAbuJCG4tceExjiF/ZhkyMUMUHVVC0wFrx0csI=; b=vDewXgnmkcFzFWKJGPZvX+2UiHqRrpJd/5aPyco7bpsNnSUpbkny0AhzYMN7XnhODh X12YgEKXzKsKRyF4e8UXJYBwPKc3YmDsy6jfqP/H35mDlZvbAPEQ3TA1k88h2s21ska9 kNdLOOHBSJ8GEo7lRYEwQ4ZcWBAOxjlA9C3a+KjPqIWQ9V8mF6f6tbNqhWr0BUUTOwXh De5IV3HzV3wE1RXbBxQIDM+pHZvWqImFUg/sNwp4M6cPzPYZd9OwUUclzC9o2jW+xSq1 5t8PFOtrmCavJvKSu4PIAIKtWHCyJNKAvB3bmCG5o/Dot+FlLfJgGo7kFMoewf2rz6UG Ma0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si10101071pgp.382.2019.06.17.05.41.59; Mon, 17 Jun 2019 05:42:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727749AbfFQMl6 (ORCPT + 27 others); Mon, 17 Jun 2019 08:41:58 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:37155 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726005AbfFQMl6 (ORCPT ); Mon, 17 Jun 2019 08:41:58 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id 1N7Qkv-1iheZG478H-017ooU; Mon, 17 Jun 2019 14:41:52 +0200 From: Arnd Bergmann To: Oded Gabbay , Greg Kroah-Hartman Cc: Arnd Bergmann , Omer Shpigelman , Mike Rapoport , Dalit Ben Zoor , Tomer Tayar , linux-kernel@vger.kernel.org Subject: [PATCH] habanalabs: use u64_to_user_ptr() for reading user pointers Date: Mon, 17 Jun 2019 14:41:33 +0200 Message-Id: <20190617124150.989515-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:6kBQWmB9Eiix9XGPUT/rWP2iXwrCtStMVjD4YJLXaKmrcjyeybc 75IXtxsfP9mXX5V5LeHkToTr/XCOowMSiUXxHAcYx1jm4pYev6xgJgSSVtU61Rs0eCJOclR IpIMJ+PpOvYBI0FWidEYaxiMg+xhPjPUpiI9xiNrzlz9EPTLbfwzvrgQiWOxhx/ivoAl0Sg AHmItyeNBi8iQFXzgDFpw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:uSN/4pOj6Iw=:KZ1W+0SgQnY08CT7Z1gNmS 7Jxfd5qLGxDOcEIg0U3uS2bbF3D8Zdtgv0232wUnB+Mt1dq6mUDAQXKxYqrbRoRwlrEJOZitC BJMyuotOD/stQ2jOh84w6eZJk+Oe9rjLdDeMkMWtdGBGOMRrnPgD1Oo+u7KruagowOgShdzoD Z74NrxEufJGzzqcW6vsqf68100zsPujgNRv7b8UOHkhWpps8l2BbxAYtrFuU+nlZErTvjduFl wBqXpxpW2zRyBiDSBW7pIodwHoWZ93Wm5XxyR17g21EosHd0kqfMVSu3f0lzksn7z/G55aDOb 1vcasmmq9E59yrZCFa6nkLRm6Mg0bs6C1upRV1MFN9v1hW1rqYPzoX9pFb254au3KbnNzjTNy Wg6niceBjbHntsbHwzfJQ7lFQx4xCp40sEqghJJ3O6hyDBgRMk5DB9QW3IiEyp7rJgfCPxtAL mdUHVVh+IR3LUZTLxreE3v+60Kw9xmFdeZuqRtA7I6YKWp7QTGvmpm/YUjbg4kG6VYiaxoUSo O/bmgRgZWmQBldBIWNNjw6ImiRBDVnM/E7CQxEuDCn+gCa5F5qO2zLTsuzkK9NQN0y3kYXQc2 ktl1RailC8isQH5kt9V+HWw3+q3413bnooJiOsLuSI4DizS6RBmiYJT3kbc+NfbN1ywRqltk1 6bxAQ+wIPquINtib8Vk/WakkV72movflD9KZIaom1tXd46axT5rEOhI90pEL8hL8skS1nRvlF PJVmqheHpTAnr2/f3FHKEdhB0WfUIxE1Snouyw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We cannot cast a 64-bit integer to a pointer on 32-bit architectures without a warning: drivers/misc/habanalabs/habanalabs_ioctl.c: In function 'debug_coresight': drivers/misc/habanalabs/habanalabs_ioctl.c:143:23: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] input = memdup_user((const void __user *) args->input_ptr, Use the macro that was defined for this purpose. Fixes: 315bc055ed56 ("habanalabs: add new IOCTL for debug, tracing and profiling") Signed-off-by: Arnd Bergmann --- drivers/misc/habanalabs/habanalabs_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 diff --git a/drivers/misc/habanalabs/habanalabs_ioctl.c b/drivers/misc/habanalabs/habanalabs_ioctl.c index eeefb22023e9..b7a0eecf6b6c 100644 --- a/drivers/misc/habanalabs/habanalabs_ioctl.c +++ b/drivers/misc/habanalabs/habanalabs_ioctl.c @@ -140,7 +140,7 @@ static int debug_coresight(struct hl_device *hdev, struct hl_debug_args *args) params->op = args->op; if (args->input_ptr && args->input_size) { - input = memdup_user((const void __user *) args->input_ptr, + input = memdup_user(u64_to_user_ptr(args->input_ptr), args->input_size); if (IS_ERR(input)) { rc = PTR_ERR(input);