From patchwork Wed May 31 08:46:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ChiYuan Huang X-Patchwork-Id: 688102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC6BC7EE24 for ; Wed, 31 May 2023 08:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235113AbjEaIri (ORCPT ); Wed, 31 May 2023 04:47:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234424AbjEaIrT (ORCPT ); Wed, 31 May 2023 04:47:19 -0400 Received: from mg.richtek.com (mg.richtek.com [220.130.44.152]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AB78611C; Wed, 31 May 2023 01:47:08 -0700 (PDT) X-MailGates: (flag:4,DYNAMIC,BADHELO,RELAY,NOHOST:PASS)(compute_score:DE LIVER,40,3) Received: from 192.168.10.47 by mg.richtek.com with MailGates ESMTP Server V5.0(746:0:AUTH_RELAY) (envelope-from ); Wed, 31 May 2023 16:46:54 +0800 (CST) Received: from ex4.rt.l (192.168.10.47) by ex4.rt.l (192.168.10.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Wed, 31 May 2023 16:46:54 +0800 Received: from linuxcarl2.richtek.com (192.168.10.154) by ex4.rt.l (192.168.10.45) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Wed, 31 May 2023 16:46:54 +0800 From: To: , , , CC: , , , , Subject: [PATCH] dt-bindings: power: supply: Fix rt9467 charger enable gpio active level Date: Wed, 31 May 2023 16:46:53 +0800 Message-ID: <1685522813-14481-1-git-send-email-cy_huang@richtek.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org From: ChiYuan Huang The RT9467 charger enable pin is an external signal that used to enable battery charging. From the datasheet, the active level is low. Although it's already configured to logic low at driver probe function, but the current binding example declared it as 'GPIO_ACTIVE_LOW', this causes this pin be output high and disable battery charging. Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger") Signed-off-by: ChiYuan Huang --- Hi, This patch is to fix the active level for charger enable gpio polarity. Currently, the wrong active level makes the user confused and unexpectedly disable battery charging by default. --- Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml index 3723717..cdc7678 100644 --- a/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml +++ b/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml @@ -69,7 +69,7 @@ examples: reg = <0x5b>; wakeup-source; interrupts-extended = <&gpio_intc 32 IRQ_TYPE_LEVEL_LOW>; - charge-enable-gpios = <&gpio26 1 GPIO_ACTIVE_LOW>; + charge-enable-gpios = <&gpio26 1 GPIO_ACTIVE_HIGH>; rt9467_otg_vbus: usb-otg-vbus-regulator { regulator-name = "rt9467-usb-otg-vbus";