From patchwork Thu Jun 1 13:05:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?4oCcUnlhbg==?= X-Patchwork-Id: 687731 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E94ECC7EE29 for ; Thu, 1 Jun 2023 13:08:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 26C196C1; Thu, 1 Jun 2023 15:07:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 26C196C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1685624878; bh=XJxseORK7ZnAl3eP8lVEVc6boBA1ecjsed6zPEinIPI=; h=From:To:Cc:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=PDuhx3MTarceq6nMpQIQVIisBSR35u3iPyG9q4kx4DNPYeAwI05l+qGhWyu/eHxyl ucRJYtQlSoVq+eILbvFlnGgKKFecFGv1oOkHk1kDqWalR89+c08nA5PyHsjATg5ss6 UMzCU3bHZR8NhCMsYYQFn35Fje7bauYp6IfO6gZw= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0BDBDF80494; Thu, 1 Jun 2023 15:06:40 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6FCC3F80494; Thu, 1 Jun 2023 15:06:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E42C2F8016B; Thu, 1 Jun 2023 15:06:35 +0200 (CEST) Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5175AF800C1 for ; Thu, 1 Jun 2023 15:06:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5175AF800C1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=cRNwyrR6 Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-256712d65ceso288486a91.1 for ; Thu, 01 Jun 2023 06:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685624778; x=1688216778; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tm7KDaSSjYvTYPu798lAyVQ8TuXxD3ciaiRSHMe2MWI=; b=cRNwyrR6RhCtm54eNkfyDGqAwseqfMo+xydQcUdKy/QlVcZqFRAlkI3bQCOaN1cDu7 9d6pDMsFJC703p+mSJAHYKXwKJfhiv+Fv6yeoln1PUPfZvi4RBw1AedgK+hc9fazXGqN YI4kXpD4+O6j3R5pvJzSFx9Eo50ooTzwSOI+oqFQPglxckMxS/CGqotCZCb2AQWvrlv2 DD3BASB+s/Rnsb/Fwi5Jr2rJiCPDeA7cKgjinyR/+9l6NFzj1l5eRpN2tvDDdCMoiN99 oqBYLUgewJAAb4/T43J0AF+fLzTPbkkB75g0c/+HahjIt0tlrAkeJVkOOfKKZfLKM7Qg Djzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685624778; x=1688216778; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tm7KDaSSjYvTYPu798lAyVQ8TuXxD3ciaiRSHMe2MWI=; b=bhUuZZoV5FIE5iIspqHqlxz3PHvhysIYnDEEcnX+GUrKyrDrIoDgJ6FvwpjNECLfsc IczBCan4wo6kW/uSJlgXY5lMdDVOB38uvud2vMBneYoqDoauCBlUwoSOyYlD8LLDUFMK lP1P7mUrypc0n6X2nWwY8MHPvqlR5HFgs4u0aOKfJfQtWTlh+Xkcn3jxajbuVySKx91p v1BbD7W2YHGXZVuSYR1CtGCjeUcDRZoXbroafDBTbzDKe2omHBZqzgdlqDvae0Snh8e/ 9JNad4Aqa0KD8xisEvz/A++k/xXW522AeD7WZbF64J6ueK44NC0z3O9232IQYWcFf3uT 2vmQ== X-Gm-Message-State: AC+VfDxPAtKpJ2u1KDBE9dbdZKEWpCif64u9fUIx0U1i6QsA6YrYlwXa PRx5kPbE9dG50DtwBW93FHI= X-Google-Smtp-Source: ACHHUZ417r58s1N53t2yURhkDqH5J9VetxhvfpIj4hjoAzs3iSk/8iUou1gI/nCvjvcxUdqMBSoWtg== X-Received: by 2002:a17:90a:a40e:b0:256:8cb7:2b2b with SMTP id y14-20020a17090aa40e00b002568cb72b2bmr6413171pjp.14.1685624777949; Thu, 01 Jun 2023 06:06:17 -0700 (PDT) Received: from ryan-ThinkPad-T470.. (c-24-6-63-212.hsd1.ca.comcast.net. [24.6.63.212]) by smtp.gmail.com with ESMTPSA id s34-20020a17090a2f2500b0024df6bbf5d8sm1430096pjd.30.2023.06.01.06.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 06:06:17 -0700 (PDT) From: =?utf-8?b?4oCcUnlhbg==?= To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, ryans.lee@analog.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: jairaj.arava@intel.com Subject: [PATCH 1/2] ASoC: max98363: Removed 32bit support Date: Thu, 1 Jun 2023 06:05:59 -0700 Message-Id: <20230601130600.25344-1-ryan.lee.analog@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Message-ID-Hash: RVIATWML6RFN3MNNFUNF5O3YQU2Q5D5P X-Message-ID-Hash: RVIATWML6RFN3MNNFUNF5O3YQU2Q5D5P X-MailFrom: ryan.lee.analog@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Ryan Lee MAX98363 does not support 32bit depth audio. Removed 32bit from the supported format list. Instead, added 16bit and 24bit to the list. Signed-off-by: Ryan Lee --- sound/soc/codecs/max98363.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98363.c b/sound/soc/codecs/max98363.c index 4585ebb1e82c..8aa9d9c67aa2 100644 --- a/sound/soc/codecs/max98363.c +++ b/sound/soc/codecs/max98363.c @@ -211,7 +211,7 @@ static int max98363_io_init(struct sdw_slave *slave) } #define MAX98363_RATES SNDRV_PCM_RATE_8000_192000 -#define MAX98363_FORMATS (SNDRV_PCM_FMTBIT_S32_LE) +#define MAX98363_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE) static int max98363_sdw_dai_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params, From patchwork Thu Jun 1 13:06:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?4oCcUnlhbg==?= X-Patchwork-Id: 688278 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD0B9C77B7A for ; Thu, 1 Jun 2023 13:08:24 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 53A2D207; Thu, 1 Jun 2023 15:07:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 53A2D207 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1685624902; bh=PZgpQmAhXGQkr8TsrTzePzM+36hwwsd+HeqKfauYxDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=obo74vIOMe7mv1NX6z8irVDWf0irtmIiLLdIpLcumVYDYmQzCIPWTJ+5K9gDl45Bd 4Lbdorz9IZg19bdyN8Ri5dHJAysLgpabXEBTgNLRGYWCQTJeg1nGxTOTQccC2UOIcj HMWJFF3CeOGcm/IxSJbozRbC5adeA1QhUNVohqS4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id A30FBF80563; Thu, 1 Jun 2023 15:06:42 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 33701F8047D; Thu, 1 Jun 2023 15:06:42 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3D696F80149; Thu, 1 Jun 2023 15:06:37 +0200 (CEST) Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 865B8F800ED for ; Thu, 1 Jun 2023 15:06:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 865B8F800ED Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=RdSP/OEU Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-53f70f7c2d2so385590a12.3 for ; Thu, 01 Jun 2023 06:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685624779; x=1688216779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w+80VYIfhjZ5fSjcUibNsG+b2Hi4A7lyy0lDCFEbZBs=; b=RdSP/OEUyw387gUXs4br35uVFKo5guW8++Hou3cYfb7YCLhJMNQHx0nY5w8nffjBkM DddJF2l7xiFfCvYAErVvbOKXfXK87LvjsJyA1Wn1/uGZEg6vADkS6jE+tfwI+Yp9H3Jw 2pkiNKyMxdsBS+3ZLMANxPjzX0Pm/VO4EJkb9FGd2St73BTQStxSN1CXVYXLWE50MBsB fwYmcu2bUrLeWKCerok1e7fFLabA58hrgW56dnTDv6ls37XYC1yS7V/fVcMMkbLS9u3h qYOP+U4DY3n3gNtJavEp19/1aICn9Y/ZtpQf2jdHQE8+ylIove6pIe9U6hVMfZEbRSN7 1oFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685624779; x=1688216779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w+80VYIfhjZ5fSjcUibNsG+b2Hi4A7lyy0lDCFEbZBs=; b=kfObJGTwLDQYUIUx7uVU5iVyBbxMMRmlJ+Szh+TtzMZgejbLA9DTecb5h6XEOXaiWz 6iLiThpgbPjp45HIZLIF0Nfx3l19rUqndAfwa2l2ZnL0fsDHJLVaRH9hbkzIZENskwlB oN/EcT4W5Pc5n3crEAIiAYPpdpF8INFJik6IKZeN5mX/ead2U46SlG3U5O7zM2sHSct1 sl6HElrLy+dUuzqE7WhM5IhghZTQabdpl7hOh/HPZcGU+m31/zjSXzrq0JODli9BQGSO vscYsmK+H7O+Cj8VBgmuW6Qt8AzsyAEdg4qHoAygSlmVc+BPUEuYkqSjR7KIEw7YA6xx d8kQ== X-Gm-Message-State: AC+VfDx6sQLXGKCCpuVjNhDl/RjxOQrsKuzvye8Low6TULnwvL0SB+A+ v+RLLiK0/NS5mMkEnm+UQxs= X-Google-Smtp-Source: ACHHUZ4/y8r7bunqlmbBydPYg4Y2Y9+zIUnPo4YaUaKfFxXcl6U6oJWx60TAFQel2zyVw3KAkTfULw== X-Received: by 2002:a17:90b:17ca:b0:253:572f:79b2 with SMTP id me10-20020a17090b17ca00b00253572f79b2mr6352859pjb.36.1685624778892; Thu, 01 Jun 2023 06:06:18 -0700 (PDT) Received: from ryan-ThinkPad-T470.. (c-24-6-63-212.hsd1.ca.comcast.net. [24.6.63.212]) by smtp.gmail.com with ESMTPSA id s34-20020a17090a2f2500b0024df6bbf5d8sm1430096pjd.30.2023.06.01.06.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 06:06:18 -0700 (PDT) From: =?utf-8?b?4oCcUnlhbg==?= To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, ryans.lee@analog.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: jairaj.arava@intel.com Subject: [PATCH 2/2] ASoC: max98363: limit the number of channel to 1 Date: Thu, 1 Jun 2023 06:06:00 -0700 Message-Id: <20230601130600.25344-2-ryan.lee.analog@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230601130600.25344-1-ryan.lee.analog@gmail.com> References: <20230601130600.25344-1-ryan.lee.analog@gmail.com> MIME-Version: 1.0 Message-ID-Hash: JR6GS2TEBB7IDNNX24XZSJ4VBUGWMEOY X-Message-ID-Hash: JR6GS2TEBB7IDNNX24XZSJ4VBUGWMEOY X-MailFrom: ryan.lee.analog@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Ryan Lee MAX98363 is a mono amplifier. The number of channel needs to be always 1. Signed-off-by: Ryan Lee --- sound/soc/codecs/max98363.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98363.c b/sound/soc/codecs/max98363.c index 8aa9d9c67aa2..7f5062ac4523 100644 --- a/sound/soc/codecs/max98363.c +++ b/sound/soc/codecs/max98363.c @@ -246,7 +246,7 @@ static int max98363_sdw_dai_hw_params(struct snd_pcm_substream *substream, stream_config.frame_rate = params_rate(params); stream_config.bps = snd_pcm_format_width(params_format(params)); stream_config.direction = direction; - stream_config.ch_count = params_channels(params); + stream_config.ch_count = 1; if (stream_config.ch_count > runtime->hw.channels_max) { stream_config.ch_count = runtime->hw.channels_max;