From patchwork Tue May 23 15:46:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 685035 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E184AC7EE2D for ; Tue, 23 May 2023 15:47:59 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D72991EC; Tue, 23 May 2023 17:47:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D72991EC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684856876; bh=DZAJhfnYRSa7iGmUkW2ZPvzu87HPo+s2rOulnRFJEGc=; h=From:To:Cc:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=mDWoZ+4aO25Z8Pe8uiwuvbHo2ppGrbw3NdW44D2ssMrLWaqXprvQOLXEV5B81YWm6 FdBoQzZJr4GEdepIrZnZ1VIuobx5/IfOv6vL6hZRvLjL85VmtLZQtdnuSiVY+8lRiR uxPaeQh3NioCp5kna0vS/pk94AcTkzjpNjrXTGmE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6D01EF800DF; Tue, 23 May 2023 17:46:36 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id CE6FDF800DF; Tue, 23 May 2023 17:46:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 19135F8026A; Tue, 23 May 2023 17:46:32 +0200 (CEST) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7B312F80086 for ; Tue, 23 May 2023 17:46:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7B312F80086 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=nWNoA6Sj Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f6042d60b5so26592655e9.2 for ; Tue, 23 May 2023 08:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684856783; x=1687448783; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PfRw2ALokx9vLy8rQUgzg1qNBvtdQEE/4htl4GPyFIo=; b=nWNoA6Sjt7sar6bT5Wo7aS7Yc7m34FIb/IPgWD81u2XmfxqZy8KlLpQjOWv16/jon5 r9ollhVW6YH7NfbuUpGGiFI2PoQsBLoeInpaFEAFlbMtNr/hC+EMEAcNhtOpzJEyLd54 7C+AXOqYLclUAvF/sNsb2Bph/vJoPsj+7wFJnrV9n36DSEjRrJ5DivQ7lCMZJVhG2E+x osQRnx+JV6XS7XazzwU6kFsLuDGgV0o3IEblDcwD6iDseVAZKJZb3xcMuuydJ0O53+D/ 1kAnyuwPYstnRQs46f5u26CXhFu20A3z+IeYSdm+azQaZs3NGE6eO/K3Ila8h2n5Gpqw TGZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684856783; x=1687448783; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PfRw2ALokx9vLy8rQUgzg1qNBvtdQEE/4htl4GPyFIo=; b=gPEY0V6p9FJL64uzhPvxcr95c1LyotVDgI0Qd/MDGUFhdaS6p27RFQdltRAR6FZV8S 3KsTCSaPB1t2QWm0A4aQ+R/U3PNlwdxSsBnj4tjsBwo7+aIo3ntR31rUXO19ZcfWEcNH QOYBNNKXknu0SKGPogADJwyyoF7XzOuED4Tg+S9jdQhN5ceQWXw4fU8Zp3R/1wfGCbyu KaiKbYT3LZPeysIAu3gCzi9BomwsrHPWtmn2TU8pIbByutfjKvPzkadCCKh4aTRXglLY ncNwjhalwWk9hcIfnTEp635JwWveBuq/PyTTdrHFVxtnjurREovtJFUXxHbH/WLzI1tS rJCg== X-Gm-Message-State: AC+VfDw69Y50ePrncbz3vLcM5d7PeNGxN0LXjuettXg3a+eDIXDMR3tN 94zdjzuMH/4aQSsPRAwLbT+3Dw== X-Google-Smtp-Source: ACHHUZ71Rz/9C0SXOP97Z5WNP/e5538De6w5FC/OjCJcrWWF8rV5viic9V4O3MIuQsYQihYn5e5MXA== X-Received: by 2002:a1c:e905:0:b0:3f5:fbd0:94ab with SMTP id q5-20020a1ce905000000b003f5fbd094abmr7809138wmc.3.1684856783483; Tue, 23 May 2023 08:46:23 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id f4-20020a1c6a04000000b003f1978bbcd6sm3374063wmc.3.2023.05.23.08.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 08:46:22 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, Srinivas Kandagatla Subject: [PATCH 1/2] ASoC: codecs: wsa883x: do not set can_multi_write flag Date: Tue, 23 May 2023 16:46:04 +0100 Message-Id: <20230523154605.4284-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Message-ID-Hash: G6ZBEYNGQPEBNOBJOYSNAVXAA3HPJME3 X-Message-ID-Hash: G6ZBEYNGQPEBNOBJOYSNAVXAA3HPJME3 X-MailFrom: srinivas.kandagatla@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: regmap-sdw does not support multi register writes, so there is no point in setting this flag. This also leads to incorrect programming of WSA codecs with regmap_multi_reg_write() call. This invalid configuration should have been rejected by regmap-sdw. Fixes: 43b8c7dc85a1 ("ASoC: codecs: add wsa883x amplifier support") Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/wsa883x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c index b83b5b0d4bab..2faf66c60703 100644 --- a/sound/soc/codecs/wsa883x.c +++ b/sound/soc/codecs/wsa883x.c @@ -946,7 +946,6 @@ static struct regmap_config wsa883x_regmap_config = { .writeable_reg = wsa883x_writeable_register, .reg_format_endian = REGMAP_ENDIAN_NATIVE, .val_format_endian = REGMAP_ENDIAN_NATIVE, - .can_multi_write = true, .use_single_read = true, }; From patchwork Tue May 23 15:46:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 686461 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B92BC7EE26 for ; Tue, 23 May 2023 15:48:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AB749209; Tue, 23 May 2023 17:47:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AB749209 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684856897; bh=w2BzP5duWeWoc6UANe8vrexOTMesxRdeRkaZhP8Dz4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=WIslorOoRLI2uCmLwzxh7W3EXTfOmVbe/yUNdNqVK3AhHIgLEWuQNpV662WI/6i++ g+54EenLrJFoe5oMDo0aOETnoQos991d5PWer5qSOjzM17M+mL42LJ7Pc7eyyKLA8x l0q89Ob93lCwzTVyvwOuJdlSkPN0m8ZMHy5+RscU= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C6ED7F8055B; Tue, 23 May 2023 17:46:37 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5AEE6F80552; Tue, 23 May 2023 17:46:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BE4FBF8024E; Tue, 23 May 2023 17:46:33 +0200 (CEST) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 16A35F800DF for ; Tue, 23 May 2023 17:46:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 16A35F800DF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=qzXoE7KK Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3f60e536250so4586175e9.1 for ; Tue, 23 May 2023 08:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684856785; x=1687448785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HY78bpvovATO4WTiWWCs/PyinwWE+HdEDWAOWfiu7IY=; b=qzXoE7KKxl8W7e9Ja/36EZNThJM8rZx06KxNTz3pu/jWCjkNW83xPrSo87iAGb5eod tYOi1jkZbAiEFgKV594n50+88hyF1C9ftpmv8HxaiYgOAr0mRStKnWG+cwq6WqGzPBy+ OG0Fj1AxfEX3J2sgJB/WYBzgD3A3lm+Iauu5wrSl7fbwLIGt/Y8q202YcqU71xBs7rg8 exjOndDRf3smAaxgYEkP67pAQ2MP+1JSlYAj4IJkNJWH3Fms6lP5Ntt7CNXklyrsFbPz x70ZRlAc4zhIbWw7zEW6a+yRuEpQJ3pvYuXGBsuieV5suQ5IyViTHuX6eTk44TSxkqVG vE7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684856785; x=1687448785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HY78bpvovATO4WTiWWCs/PyinwWE+HdEDWAOWfiu7IY=; b=Cd0Oru1lJX+xJkQ6AbOcJtBl9ZP8yVnbVjSr8wv4XvM9bHuZm8/67ke6FbeF9NWO98 h9rfwlPwGfHR/DbmhSbO3mQZvfUbQGjJBxKt22X6LxKIGUhelVB5dhcSzjUlJxwNzZtr GfwLd3SL4sVPw8GXzEQZ8XSfyvtOTbHm0LRxBRaR5UrBoSEMPMyuts1UzOxpL3UaezVj sgqU/xyAhc8vgBSwJvNZquV2XsYV7vlfBqADDVqFjHmn4dVjhLq+TEHWFhbgqI59opbi J+mEw7d1m+tsKvWZ2eQR65jR8TOqTb8cL/ofphXSMU4vgmDk7JJfLyeqr87VVaePxiz7 I96g== X-Gm-Message-State: AC+VfDxlBcV+n1xp6gWljOtFeND5OiSI3N6FqCjSbElizlsXvKOE1sYl QyxzrX9OVQO7Uohju4i9hUSDcQ== X-Google-Smtp-Source: ACHHUZ5UPojsYEPmPMD6YBrtM2ogvSu7gGXAEL3nSBCW0XABVz487ZQkY16kEyIPnERnW6fC5GGhGQ== X-Received: by 2002:a05:600c:3549:b0:3f5:a54:9f97 with SMTP id i9-20020a05600c354900b003f50a549f97mr11115515wmq.0.1684856784731; Tue, 23 May 2023 08:46:24 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id f4-20020a1c6a04000000b003f1978bbcd6sm3374063wmc.3.2023.05.23.08.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 08:46:23 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, Srinivas Kandagatla Subject: [PATCH 2/2] ASoC: codecs: wsa881x: do not set can_multi_write flag Date: Tue, 23 May 2023 16:46:05 +0100 Message-Id: <20230523154605.4284-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20230523154605.4284-1-srinivas.kandagatla@linaro.org> References: <20230523154605.4284-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Message-ID-Hash: OIKBIJHKQSWLFTOW3ZMBBDE5VJ2QX7J2 X-Message-ID-Hash: OIKBIJHKQSWLFTOW3ZMBBDE5VJ2QX7J2 X-MailFrom: srinivas.kandagatla@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: regmap-sdw does not support multi register writes, so there is no point in setting this flag. This also leads to incorrect programming of WSA codecs with regmap_multi_reg_write() call. This invalid configuration should have been rejected by regmap-sdw. Fixes: a0aab9e1404a ("ASoC: codecs: add wsa881x amplifier support") Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/wsa881x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index 4ce72a7f01b6..211b154bc514 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -645,7 +645,6 @@ static struct regmap_config wsa881x_regmap_config = { .readable_reg = wsa881x_readable_register, .reg_format_endian = REGMAP_ENDIAN_NATIVE, .val_format_endian = REGMAP_ENDIAN_NATIVE, - .can_multi_write = true, }; enum {