From patchwork Mon May 8 01:06:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Lausen X-Patchwork-Id: 679953 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D5EAC77B7C for ; Mon, 8 May 2023 01:06:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232024AbjEHBGT (ORCPT ); Sun, 7 May 2023 21:06:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbjEHBGT (ORCPT ); Sun, 7 May 2023 21:06:19 -0400 Received: from devico.uberspace.de (devico.uberspace.de [185.26.156.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F8D5100C1 for ; Sun, 7 May 2023 18:06:16 -0700 (PDT) Received: (qmail 8302 invoked by uid 990); 8 May 2023 01:06:14 -0000 Authentication-Results: devico.uberspace.de; auth=pass (plain) MIME-Version: 1.0 Date: Mon, 08 May 2023 01:06:13 +0000 From: "Leonard Lausen" Message-ID: TLS-Required: No Subject: [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay" To: regressions@lists.linux.dev, "Bjorn Andersson" , "Dmitry Baryshkov" , "Rob Clark" , "Abhinav Kumar" , "Stephen Boyd" , "Kuogee Hsieh" , "Johan Hovold" , "Sankeerth Billakanti" Cc: "Sean Paul" , "David Airlie" , "Daniel Vetter" , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Nikita Travkin" X-Rspamd-Bar: - X-Rspamd-Report: MIME_GOOD(-0.1) BAYES_HAM(-2.999968) SUSPICIOUS_RECIPS(1.5) X-Rspamd-Score: -1.599968 Received: from unknown (HELO unkown) (::1) by devico.uberspace.de (Haraka/3.0.1) with ESMTPSA; Mon, 08 May 2023 03:06:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lausen.nl; s=uberspace; h=from; bh=Ew+ga4R4XmyLDd+z40yzIO7CFGKrkhYk+0CcdiQL9Sw=; b=od7KhyxiI988/H0wo80l6KXEewxhiWVhz0SfXY/weB6DUvv7GRv3Rb/20C0sRcopopbYInGJAy u0LpHpGjdT10DN1ywJ9gw54CY4sTZ1EK+qfwoWlK6Lse+2EHQ/egTwgmIjUs+3z5u3Wwgf2Iy6Ov 8+JjmHzraSUXx1gN376lVMSrsd5uBADfq6ae0aeSTI+rNg4zf6AV1xa3l5aiQndVbCH6lE0WEeEm zYVDBem9t6Hx3ZS8gyRPqIkcfQbP90eDXu/W0EeiG19jKZPa/Y3Co/7K7W63phd7QdspH60A9w7K VwwVw/VfIp+qZk7/k1/P+Ml6xftCKNVMRj0wvXjVH2HF+ZiYSdtQCAuN2GHBFd/loesiMFjEzv+I 0HosD/qeYweyP2l7P8Zo5M9BCVOS5D+sQ7hANY/c0S9Gs+r1qOHyYh7Ao3RIPYs40pW2Dkyg2jEQ aHQ0tdpJavp7CCkSAp/9YrYiLAwe3X5B7EZtR/Ps98/1/vbTd/qmkEGg92iF9QRm/5ksjayNrbY7 /bELzo3Iku+i5IQJi3ViM9T2NYaNUCbY2b3VCzRVNM6rEuAIGMOjqs3/oNj+fY9fwnQ54frY+pk0 l6ggn2GIbzVozsNkDoO3VfNBRY9HlabFLpLiNVWt7loWZDv2y3sxN83aeCKOHQIdTZq+mLtgvcaJ E= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This reverts commit e17af1c9d861dc177e5b56009bd4f71ace688d97. Removing the delay of 100 units broke hot plug detection for USB-C displays on qcom sc7180 lazor devices. Lazor uses mdss for hot plug detection and declares dp_hot_plug_det in the dts. Other sc7180 based devices like aspire1 were not affected by the regression, as they do not rely on mdss and dp_hot_plug_det for hot plug detection. Signed-off-by: Leonard Lausen Tested-by: Leonard Lausen # Trogdor (sc7180) Suggested-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index bde1a7ce442f..db9783ffd5cf 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -1506,7 +1506,7 @@ void msm_dp_irq_postinstall(struct msm_dp *dp_display) dp = container_of(dp_display, struct dp_display_private, dp_display); if (!dp_display->is_edp) - dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 0); + dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100); } bool msm_dp_wide_bus_available(const struct msm_dp *dp_display)