From patchwork Mon May 8 03:01:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Greengas X-Patchwork-Id: 679916 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAD51C7EE2D for ; Mon, 8 May 2023 07:52:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F35B912EB; Mon, 8 May 2023 09:51:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F35B912EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683532334; bh=WkhMR5D5tb01834+1eW9MD58gsfJiiwdpu1FEdTchEg=; h=From:Date:Subject:To:CC:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=p3k63mlw1ZqR6Lc4hS5ZQOjf9tMe/8ilTPGnaYuWIT8EaGzmFgnD1nklpC/qiGdV7 y7QUl9B6NPTdr3RE6+6hhSsYuxbzfBDevA2y2sADVx4c71THBDt5kDkzFaL8ClSsYI kTg9sstaWaLAoq5pnfE2Vt6laSTqWOCYTVWZE/qg= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2519FF805F8; Mon, 8 May 2023 09:46:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8A760F8032D; Mon, 8 May 2023 05:02:22 +0200 (CEST) Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 46F82F802E8 for ; Mon, 8 May 2023 05:02:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 46F82F802E8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=JtkuanBe Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-55c939fb24dso35358677b3.2 for ; Sun, 07 May 2023 20:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683514922; x=1686106922; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=EM9Ubq1vKCbrmde66NfhmeEaWj16YcxY8NtZkiWkINs=; b=JtkuanBesqAGz3BWwpSZHk6hojBGzIiQkhaMnMkA4g8Jji1yzmjPoFYDBo1mdi+xUa 7oRtt+dTFQRbQvhsMzUL+61t29sc7rajHZLljLspbmTPuzhW2KcwryZryPsJh2LsH3hZ tE2gIY2MMQ3nB/E1be/Vvl0wFzh46gePgKtH/HxTZvBju5RWM46HI3y1JqDLSpb/SDCz su+WrF6/1RyMtuHEj/DIIt9GGadbWwjga8bTK+X/fKMBzVX3JAaISZA/6/ZlGkBzWnKU FgExdM6yuFoFgGoA+cC9w1joFaLwT4N/Mr8XEZWQFOwfxyvdT+BgpNqE7HR8RrGRnnTA G4Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683514922; x=1686106922; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EM9Ubq1vKCbrmde66NfhmeEaWj16YcxY8NtZkiWkINs=; b=bmWVLO6oorAJ8AuLHbcR9Q2pbz/FCHSYQHkkzbve5vUOJUAOx9MCcCQlV6Vg+m9RoT uu8wYzWjO+zP7j8uiDPoeuDpuGFhl7psiSrcKgnFmF6jRUkjjx+kKvhvT27yOGkHtk2A YLqn355OPIe0Mwfh18WfeVcidnyAZ9gVpRK3SayGCK+OVeUbKWpQ+SCqHcJe4MCDzUuE buPvUZsLne7vLdGFfCBLbs78dINMVLdGsUrsmMBxmVD/PS5tJWzO0Ya1q7YRcePhkYgJ rZUZx/fwIOVZ0nruoZkAYbb0yveqjjwElou96RTJ/cKSrKxvMr9kXP3Yevc2T9y8BvRa FqZw== X-Gm-Message-State: AC+VfDw47dP5v3kAqLpDwmo68uS16uzX9skwj8Qm/NnL+2EJrk/Dm4m4 4ctFlbouTRJqflXb6j/QjsAdVc33eolwSy+5GMo= X-Google-Smtp-Source: ACHHUZ7tMZv8tYXxs3jC3Tst3y9RRf8/win4hiQoN723jII2e00W5Wb6k4bwvPg32x0pxbDMnSSjDceczxn3wSJSdyk= X-Received: by 2002:a0d:ccc8:0:b0:55a:6efe:8e2f with SMTP id o191-20020a0dccc8000000b0055a6efe8e2fmr8903859ywd.45.1683514922494; Sun, 07 May 2023 20:02:02 -0700 (PDT) MIME-Version: 1.0 From: Dave Greengas Date: Sun, 7 May 2023 22:01:51 -0500 Message-ID: Subject: Patch for HP Spectre x360 Convertible 14t-ea100 Sound (patch_realtek.c) To: linux-kernel@vger.kernel.org X-MailFrom: dave.greengas@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: FU227N5ZIWVTLLNDI47VQJTY5GOQVZJ4 X-Message-ID-Hash: FU227N5ZIWVTLLNDI47VQJTY5GOQVZJ4 X-Mailman-Approved-At: Mon, 08 May 2023 07:46:29 +0000 X-Content-Filtered-By: Mailman/MimeDel 3.3.8 CC: Takashi Iwai , alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The sound for this laptop does not work without a patch to patch_realtek.c. I noticed that it has an ALC245 sound card, but a different product id. I have been running this patch for months and it works well. There is the known issue with the top-mounted speakers, but this is the same as when I manually run the hda-verbs as described on a forum post on kernel.org for similar models. I added the following line: SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), Only the model 0x89da is different. I ran the diff command against a 62 kernel, but noticed that 63 has the same file and showed no commits. I have been running this patch successfully for many months on the 62 branch, but I do not know anyone else with this same laptop model to confirm that it works for them. If there is a different process for submitting the patch, please let me know. Kernel 63 was just released for my distribution and I plan to test the patch there as well, but I do not expect it to work differently. --------------------------------- David Greengas --- ../../linux63/src/linux-6.3/sound/pci/hda/patch_realtek.c 2023-04-23 14:02:52.000000000 -0500 +++ linux-6.2/sound/pci/hda/patch_realtek.c 2023-05-07 14:28:08.979524705 -0500 @@ -9409,6 +9409,7 @@ SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f6, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), + SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8811, "HP Spectre x360 15-eb1xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1),