From patchwork Mon May 1 11:30:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maximilian Weigand X-Patchwork-Id: 678267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63086C7EE21 for ; Mon, 1 May 2023 11:30:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229482AbjEALaz (ORCPT ); Mon, 1 May 2023 07:30:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232159AbjEALay (ORCPT ); Mon, 1 May 2023 07:30:54 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B872510FA; Mon, 1 May 2023 04:30:53 -0700 (PDT) Received: from koko.localdomain ([213.196.213.13]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N7iKo-1qNbbV2mws-014k2Q; Mon, 01 May 2023 13:30:43 +0200 From: Maximilian Weigand To: Linus Walleij , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Maximilian Weigand , Alistair Francis Subject: [PATCH v2 1/6] Input: cyttsp5 - fix array length Date: Mon, 1 May 2023 13:30:05 +0200 Message-Id: <20230501113010.891786-2-mweigand@mweigand.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501113010.891786-1-mweigand@mweigand.net> References: <20230501113010.891786-1-mweigand@mweigand.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:p/5GtVKUJPnHQuTfJuon7vGN4jRyuRUKN4lAKxXfbccB7EmDnaC 3KBBK8At5C65x/HXFnSQmx/Nrl322WQXn5iKsdvENkEbpQGOByUN+Kt2vx+hSzEP0gL8pg0 M6BmLjOPt0mNnx1qw+qemgDs049TLxzDBNCsE+AnampUPKQo1Z39sxj7E15SPMZZh5sd7ou S8pK4sHuSP3YBtA4n8Fvw== UI-OutboundReport: notjunk:1;M01:P0:sk8asawXIvw=;XQvol0O474AgmlBRt3WdtGpLEJo 2uHuXyIzIE9YLtQ3CFaWbHweOqriHM691A+gUdkwmZnzwhHyKipG+DTVx+Rj91ruz4sSGj5IT oxtnF7WQvm/TEIvl15fP78Hlj+E5NIndxwxWGOuVQpawfYdP3Boc4MLkAirMOkiSDl5L/bo86 lsxIYDQr7lpPMGzWACdEMuqsPAapHCSSpYC5QaUUkG+1e8023a35GuvwYBUVlzxwn88h0mA03 K7DIBFyrKmu2/jIYlJKeSZnUHSEokpFs/tFBY03Q55SVJfi65DLrxrgm5pKWvzwSiNXNpD//x sMNOx7gIliDMV0yTOqM0WwId4RkTkTZofQIN5sI/VQAnPe3cT0tIGITzWncto9SVlgsdd8Eoe DEiaHGtdaxhVQgExvNFoG8B7y2aZL5njjybfm+MDaSxnx28kAADDy7cXV2gZt3uRA6K94Bi1N hHSWyMKQsJl+jyfCPgH/KY01T9wH1rgFkPeACEbfgm9yZhWQzC337Vp5LmasUO0bD8ko8J5bH H98/3Jbj4bZUO3lBBPWfNuWTkqhGSEiF1em4j/63Od5iTh+G0RCXOXlGH9/WAbK/eNZ2Qd1yJ 3+pEC25KWjlf2TXfPQHEZNU4ZQ2fHD2r4GoGUjsvuQhw5GqVGh5g8HyS23uMv8d/G7PETFegc g7mpKDeY/gbJJvbQoqwoMebRMHIO3FSU2zeCNbOQAQ== Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org The cmd array should be initialized with the proper command size and not with the actual command value that is sent to the touchscreen. Signed-off-by: Maximilian Weigand Reviewed-by: Alistair Francis --- drivers/input/touchscreen/cyttsp5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c index 30102cb80fac..3c9d07218f48 100644 --- a/drivers/input/touchscreen/cyttsp5.c +++ b/drivers/input/touchscreen/cyttsp5.c @@ -560,7 +560,7 @@ static int cyttsp5_hid_output_get_sysinfo(struct cyttsp5 *ts) static int cyttsp5_hid_output_bl_launch_app(struct cyttsp5 *ts) { int rc; - u8 cmd[HID_OUTPUT_BL_LAUNCH_APP]; + u8 cmd[HID_OUTPUT_BL_LAUNCH_APP_SIZE]; u16 crc; put_unaligned_le16(HID_OUTPUT_BL_LAUNCH_APP_SIZE, cmd); From patchwork Mon May 1 11:30:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maximilian Weigand X-Patchwork-Id: 678266 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B45C77B61 for ; Mon, 1 May 2023 11:31:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232214AbjEALbH (ORCPT ); Mon, 1 May 2023 07:31:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232331AbjEALbF (ORCPT ); Mon, 1 May 2023 07:31:05 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50827172A; Mon, 1 May 2023 04:31:02 -0700 (PDT) Received: from koko.localdomain ([213.196.213.13]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MfHIZ-1qTuDu0fvf-00grO3; Mon, 01 May 2023 13:30:53 +0200 From: Maximilian Weigand To: Linus Walleij , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Maximilian Weigand , Alistair Francis Subject: [PATCH v2 3/6] dt-bindings: input: cypress,tt21000 - fix interrupt type in dts example Date: Mon, 1 May 2023 13:30:07 +0200 Message-Id: <20230501113010.891786-4-mweigand@mweigand.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501113010.891786-1-mweigand@mweigand.net> References: <20230501113010.891786-1-mweigand@mweigand.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:4skmoJaGKcxINrXaVpa0550kK2r50u4dFgDEnFRnenh8PTS0fl0 pHOOokYa8UhpVMfVhZbaRDjMH/oSyuzqfiLnnyvs4/xVI8b/qxnEv/Tym3UyY9PI63nKWz7 LihlEyDqqn5yrU1IPIi+ycppxUV2U13g1JXLsAt0iQrjLuwwHD8+m+WCTVHp/kR1XrBmjT8 Qc7Bwj3Ei09ECmT45ScFg== UI-OutboundReport: notjunk:1;M01:P0:BpfJcb7jkiw=;F6cKvf2fjVbXv9lF6nBsQsW1wtt P2a+QeD5BIVxesm073QbzQgwnNOWJ6S1b/ijblvaBhFq3tfCUZcp8T+s29FEMAErwV8JMBzdv T4amjDFC3MboQboY0CxVE7DFqxp+nGsXRtGPmzkSZWM2A4PxG49mb1LiENZ3gpTj7EVfXCjrr FHIyqwvhOrMHobJIRz5uR5uJHDsTvRsCV7sS3b3GlUGDQb2rC8pLIOaMqCD+1e7gBMpBqHkB7 Q8suPxb7GZuTBddRsDhsQpGmghI9h1CnL6CDyWX15kySLf34MOt/ltcp2E+2ik1UGWGAcMe0f iaY2IJS8GVqrVGm9PUfgviNf+SKW32gogD5EnBmwfHr44WE373OlZUhiFYSKptqexHxiiv4yF r/4LY8hEYiUUAYHTgGJdhjqumuLx2JbraF7K74vt0UmqrRkWCjWdWNE4kdB9pRUXUQcSVmQVr xK7TIqwmmc2MF7TPWYf6sxsAFrCSK+e14ey2muP/nfZ1rkGppVhAbiOimxb6Mkww/2yaKAg3b +VJ2o9ao9qsIJwFiosqOrB/MjTGI0tbmuf7FJOdwSSpk/Fq9PfsU325Q+YjMtdnEZsJ/fClLr Ekh/3ZJ0Ihq4CAgL7ELDCK95MZo0PrsJDdKQd3yZBQAYuSfjMe2gflMG5zmWtV4+MDZA13L7N YhXWv2LVt/CcnX43dx9niQl8nB4KdRXCaD3ZQyah5Q== Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Triggering the interrupt of the IRQ_TYPE_LEVEL_LOW type can lead to probing issues with the device for the current driver (encountered on the Pine64 PineNote). Basically the interrupt would be triggered before certain commands were sent to the device, leading to a race between the device responding fast enough and the irq handler fetching a data frame from it. Actually all devices currently using the driver already use a falling edge trigger. Signed-off-by: Maximilian Weigand Reviewed-by: Alistair Francis Reviewed-by: Linus Walleij --- .../devicetree/bindings/input/touchscreen/cypress,tt21000.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml index 1959ec394768..a77203c78d6e 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml @@ -83,7 +83,7 @@ examples: pinctrl-names = "default"; pinctrl-0 = <&tp_reset_ds203>; interrupt-parent = <&pio>; - interrupts = <1 5 IRQ_TYPE_LEVEL_LOW>; + interrupts = <1 5 IRQ_TYPE_EDGE_FALLING>; reset-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; vdd-supply = <®_touch>; From patchwork Mon May 1 11:30:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maximilian Weigand X-Patchwork-Id: 678265 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D37FDC7EE22 for ; Mon, 1 May 2023 11:31:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232255AbjEALbV (ORCPT ); Mon, 1 May 2023 07:31:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232192AbjEALbS (ORCPT ); Mon, 1 May 2023 07:31:18 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 381121731; Mon, 1 May 2023 04:31:07 -0700 (PDT) Received: from koko.localdomain ([213.196.213.13]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MOzKm-1pd2v041EK-00PKCW; Mon, 01 May 2023 13:30:59 +0200 From: Maximilian Weigand To: Linus Walleij , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Maximilian Weigand , Alistair Francis Subject: [PATCH v2 5/6] dt-bindings: input: cypress,tt21000 - add wakeup-source entry to documentation Date: Mon, 1 May 2023 13:30:09 +0200 Message-Id: <20230501113010.891786-6-mweigand@mweigand.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501113010.891786-1-mweigand@mweigand.net> References: <20230501113010.891786-1-mweigand@mweigand.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:K12RZay6xcOkocB4SCgqAg9ozfRV1XCB0ieaU5zXhREJ55ndb0W YABy3DAEGMpJYRlfBip2FVYbhlZLPaqfjn4oT1+73SMNth7FCE4KSRiVhp7Vsx24hpqWfKH HS2T8+WVjrQ3e7ATyhH1Z+PhQv7Ht8W4FoOJ6cxqUZmfe/PkuEzTK5/rQAdNZPIRAugs7Jn fgeHXLkROMwPKlyQRZ7Jg== UI-OutboundReport: notjunk:1;M01:P0:03PkLQoI9ZI=;IYEV2oX7Q9E3svd43HzMYF+xtsn gi2vcj3wCARtXcT1CY1EG22Yh+u/ft2Co74Kens6W0ZZylEZ9JQysdMvkC8E4/veR3hs63lS3 7JtP6/582ZdVX12SVd5SPHWiMtmeCHeDGW2xoUTVwHWNudQEKiYWNCzqRjaKvOeBTf6yc3Jky gr5lHBJ7wY/bR35fAv5rmQijvdokQpcu6KXIQ0VcYJb8MVea3/ddMocoYw9/C9kJBuMO3glAw Umgo/bQWn9KTj32780fXbsmIHHBH5vePW3G59rsmC4l3QCh8BuA9RlsoaYfmzWvSxPDXuJI5F lmRO93GjHu7HFCprE0TJRqFsJ6ww/vkPEpfmA8a02zlOR4lPCNW7cwMJoX3UZxcsUC1n1QPBV YfD7FbNFNReeTa5J8ZyTcudPH+1oJK6gNX0E4X5nTbn+dD8at+MdySuEpF8hSGLGK31OnNQIX EMkDGmNWoGknD39Ec2qe9R2aU3CaWvcNPGJJ9p8h+Jx5/gVRRYZbhqaDQ5Dxr9o+uuWGj/MyG /wOGB1ZLBRb4qAz2+GggfwwalzuAGhSaBKCNZ1Isba7TgaRfB8AACygcQ1+xq/mPR67MJvXA4 2LykuBKOSfP8/RBfWkvvukZp83e3kFWF4/Lw7LYTjQrhYta7mlJC1XB1i+Z+nlWjiH2CCORxV RCSpl+lH9Un0Nsf6ll6fax71cqrZi0e54NGFqml8bg== Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org The touchscreen can be used to wake up systems from sleep and therefore the wakeup-source entry should be included in the documentation. Signed-off-by: Maximilian Weigand Reviewed-by: Alistair Francis Reviewed-by: Linus Walleij --- .../devicetree/bindings/input/touchscreen/cypress,tt21000.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml index a77203c78d6e..e2da13b7991d 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml @@ -40,6 +40,8 @@ properties: linux,keycodes: description: EV_ABS specific event code generated by the axis. + wakeup-source: true + patternProperties: "^button@[0-9]+$": type: object