From patchwork Mon May 1 21:24:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 678124 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 802B7C83003 for ; Mon, 1 May 2023 21:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232754AbjEAV0D (ORCPT ); Mon, 1 May 2023 17:26:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229627AbjEAV0C (ORCPT ); Mon, 1 May 2023 17:26:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC8752706 for ; Mon, 1 May 2023 14:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682976310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TuHaeHAXI9GPugBSTpdzSqqdOtmVVSm+cOC6UAbi8I0=; b=YXxCXEt5yt8A5EL1D04ZkvlO8JrjbsagcN5FvUak40BCLDtefrpfeImtnSA8TJVxAsKwkf BCJueL/xh0RGpdSft4eVZApe59azeIW1mLpA+qC+f/M6sfdLSMdsKscU2nbLuJWenuaaeL 3TezQrBLGfIbl6NJ44xx7DHWVMwYt6w= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-363-qUXGtGP0Oi-FobA3co9BSQ-1; Mon, 01 May 2023 17:25:08 -0400 X-MC-Unique: qUXGtGP0Oi-FobA3co9BSQ-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-549dbb14e1eso1739853eaf.3 for ; Mon, 01 May 2023 14:25:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682976308; x=1685568308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TuHaeHAXI9GPugBSTpdzSqqdOtmVVSm+cOC6UAbi8I0=; b=PsAZDF3s195WyjCNgobBJuK6QvzxzJs3TpaT1nSAHXFxi5nJlU//ttDJX62njtXbpB yPOGyHwmC7wtER2ViXeS+3Wn+NEtqRfG6kJRPPyHIxiZEi04jasQGuIaukM+h6xCe6IU MZGY9RHjhC/NtM1fjj0hWEfpvUQELvOx7UkPvMMZv0Yk/PAd9F8avmFxKaxC6YndArcp hskB/fBQLh+rHUee8KhU1IXC8vnQT0egqhysn2CVUtMuc4f3gNeujRL/zLXgBkWFFACY A05nYd/ZjMOx3qMV9C4a02OA857JQJzwZ7K0uf2t09FVPuS/SkWUixNh9pE75lTtajAW kTnw== X-Gm-Message-State: AC+VfDxDNKM8vFDanJ+qYJcaE+56FmgNZ0uwc3u0/yz+AN3pZeKn6i5z WRRjz3YRi73OVFScquN+qcKTT1wzJ4YKbH/kd846a0+Ad/kw4C5HapDjkbq+cuEXefklGV7HAsO K1QP9A4ZwxBk8Oo6j69B1D8EcqQ== X-Received: by 2002:a05:6808:5a:b0:38d:f298:6cfc with SMTP id v26-20020a056808005a00b0038df2986cfcmr7224352oic.0.1682976308098; Mon, 01 May 2023 14:25:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4SbvWwmykUItBzmqFI5W2I8HfTV/ULJhJO3zEWw6FZxUduhjFzNK4MGF6+18C35B4vrbEWQA== X-Received: by 2002:a05:6808:5a:b0:38d:f298:6cfc with SMTP id v26-20020a056808005a00b0038df2986cfcmr7224342oic.0.1682976307919; Mon, 01 May 2023 14:25:07 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id q5-20020acac005000000b0038756901d1esm11911385oif.35.2023.05.01.14.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 14:25:07 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v4 1/4] arm64: dts: qcom: sa8155p-adp: Make compatible the first property Date: Mon, 1 May 2023 16:24:43 -0500 Message-Id: <20230501212446.2570364-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501212446.2570364-1-ahalaney@redhat.com> References: <20230501212446.2570364-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As stated at the below link in another review, compatible is always the first property. Follow suit here to avoid copying incorrectly in the future. Link: https://lore.kernel.org/netdev/20230331215804.783439-1-ahalaney@redhat.com/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3 Reviewed-by: Konrad Dybcio Signed-off-by: Andrew Halaney --- Changes since v3: * None Changes since v2: * Collect tags Changes since v1: * None arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 339fea522509..029b23198b3a 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -352,19 +352,18 @@ ðernet { max-speed = <1000>; mdio { + compatible = "snps,dwmac-mdio"; #address-cells = <0x1>; #size-cells = <0x0>; - compatible = "snps,dwmac-mdio"; - /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { + compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; interrupt-parent = <&tlmm>; interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ device_type = "ethernet-phy"; - compatible = "ethernet-phy-ieee802.3-c22"; }; }; }; From patchwork Mon May 1 21:24:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 678123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED61C7EE21 for ; Mon, 1 May 2023 21:26:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232172AbjEAV0U (ORCPT ); Mon, 1 May 2023 17:26:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232957AbjEAV0P (ORCPT ); Mon, 1 May 2023 17:26:15 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 910962102 for ; Mon, 1 May 2023 14:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682976329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8n1iKzbSEbcRTyERJXwfTcGMwG21ns2eb1EhMK8ImtQ=; b=MIB9iG+6v10nKouwDSEkgA/O92cwtkCkVR7ZIakdl1gsxr6mFvSyF0Qsan7Dkjp8cVAz8H 2/i0UtIHAsL7CS8OxAuTPG0S5FrEGtS3MbWSOuGma/Jdh5vXmu0V+IhfO0DKY5BGXUC75B yIWDjnvSEk3EyXlO5K0GCij6r3Nl6n0= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-We0zLAeqOkS9WvI-MmGP9w-1; Mon, 01 May 2023 17:25:28 -0400 X-MC-Unique: We0zLAeqOkS9WvI-MmGP9w-1 Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-38eab7030c2so506480b6e.0 for ; Mon, 01 May 2023 14:25:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682976327; x=1685568327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8n1iKzbSEbcRTyERJXwfTcGMwG21ns2eb1EhMK8ImtQ=; b=A6fCJDK+GGL/OADaV+N65ox1hQul5YtUM+06PNGMd9ZarmDOXLxXW+qip3QshNto/F VM8EM9CIhKjqILAqraeok/xv9Lz4tcll4K537Imucf2I6IA0XyBnJpBgPzGDlJHrYmd0 wNz4MagnnwyExTEhCm5MBA6dqy6x9Xw0Xa8ln0/+c9kWW94o9R41Mz++mDuV/ojeYUG+ 4pdslDAr/eXqmTEeGpMpr0Bd2yvL3VdyrqYxDHEBbdRPjTcnxWQWpdwyGwi3JPRBsGao A7h10xGGEn4gH7N8XsP2mH71y2XRTA4x3dqohjmd/Km7n6OwxCV1KT/30dbTQe83j1yN vyVA== X-Gm-Message-State: AC+VfDzpNAihsmVVh31xRukPVviTqUCRHxKNv1qy2GFb1qL42jkqk6/9 nTpmsvahCiIF343R7XUoAHgOFo4FPg7DY/G+UxeEFd3FH/FuT8aIn4F2++lk7J6Mde3TT0Bj0wD XTmr3cRkp4lUgpLjLw28skIPu1w== X-Received: by 2002:a05:6808:3096:b0:390:983c:4ab1 with SMTP id bl22-20020a056808309600b00390983c4ab1mr6117845oib.42.1682976327754; Mon, 01 May 2023 14:25:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4xKd0hSXYgwrrx7dYRkQ/OFyeE0kBY0kJvUuw2acvC3o4uOA025xxiX27bG2NBLyZMIKhc7g== X-Received: by 2002:a05:6808:3096:b0:390:983c:4ab1 with SMTP id bl22-20020a056808309600b00390983c4ab1mr6117841oib.42.1682976327429; Mon, 01 May 2023 14:25:27 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id q5-20020acac005000000b0038756901d1esm11911385oif.35.2023.05.01.14.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 14:25:27 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v4 3/4] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information Date: Mon, 1 May 2023 16:24:45 -0500 Message-Id: <20230501212446.2570364-4-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501212446.2570364-1-ahalaney@redhat.com> References: <20230501212446.2570364-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Using interrupts-extended already indicates what the interrupt-parent is, so drop the explicit interrupt-parent. The comment about this being the phy-intr is not helpful either, since this is the only interrupt in the phy node. Suggested-by: Konrad Dybcio Reviewed-by: Konrad Dybcio Signed-off-by: Andrew Halaney --- Changes since v3: * None Changes since v2: * Collect tags Changes since v1: * New patch (Konrad) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index ac52a8dfeba1..b65e0203d783 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -361,8 +361,7 @@ rgmii_phy: phy@7 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; - interrupt-parent = <&tlmm>; - interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ + interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; device_type = "ethernet-phy"; }; };