From patchwork Fri Apr 14 16:41:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Denose X-Patchwork-Id: 673279 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 714C9C77B71 for ; Fri, 14 Apr 2023 16:41:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbjDNQl2 (ORCPT ); Fri, 14 Apr 2023 12:41:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbjDNQl0 (ORCPT ); Fri, 14 Apr 2023 12:41:26 -0400 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D168110 for ; Fri, 14 Apr 2023 09:41:26 -0700 (PDT) Received: by mail-ot1-x332.google.com with SMTP id l13-20020a0568302b0d00b006a416ec44ccso4966649otv.2 for ; Fri, 14 Apr 2023 09:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681490485; x=1684082485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qCROuI9qGjr1e6FaOJtEHxCuk9OEai2bcsOdmRyfB1c=; b=kyYl6bs2HrKDvZh6E9n298QmLiL7EjVs/iO/39n8M8kJVVNrOKfK2EYRFhTripHtij qVpXzXi5x2YhDQYFYxRZqvEHCwUQWM4tOJ1Y0PyJbYwjQJbegz3y7T8NF4q2kCyragGS PxSm0oqrcTBmRi6y7Bmv8gahjU42BwW8y9KRA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681490485; x=1684082485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qCROuI9qGjr1e6FaOJtEHxCuk9OEai2bcsOdmRyfB1c=; b=UPS0+Gh6yDauTshENUydqvRi+j6d/CRFgl5NiFQpfu+YqJ5souiGExtHfe7FIWXlns 33zgktqyjO88u0HGUwIRSKZeS8W3nvYzn+vJa0H5nm09JDEZYw64NI6FUK9rbN8sVrD7 oIeDAGVWGRRFLPH84thSB+LVvmj0L+E1VYRT0EgMXywX82bMehnmgIi90U6rBG8Aognf CGk8s6TppXw83U9WlaqZcS2wO+AveZn0SjWqjiU2NsYBs6gAeOmvT5LH//om3aaNjLyN jxY8FQ451z8cU+CneIJapTyjj/jh4uC/M/qS0ZQ4pm2Dm1LBZI18e9OzsZ5fk3E05rVO GmRg== X-Gm-Message-State: AAQBX9c0KGJ5vPppUQ/OmiDx7xIxXoLQ3BtSpxELQrHQPpnYuUnwTKSE gac5atBSvxsCqEHzYXWZwai0qQ== X-Google-Smtp-Source: AKy350ag+kyBqmzLO90L50j5ns7SVe4q/2efsusk0PADyjaMpFOY3TbikCHSfyucmDOHnQicca5+sg== X-Received: by 2002:a9d:7f0e:0:b0:6a4:2a63:ed64 with SMTP id j14-20020a9d7f0e000000b006a42a63ed64mr2730851otq.0.1681490485395; Fri, 14 Apr 2023 09:41:25 -0700 (PDT) Received: from jdenose34.roam.corp.google.com (99-137-158-190.lightspeed.cicril.sbcglobal.net. [99.137.158.190]) by smtp.gmail.com with ESMTPSA id u8-20020a056830118800b006a2fd720f82sm1870354otq.7.2023.04.14.09.41.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 09:41:24 -0700 (PDT) From: Jonathan Denose X-Google-Original-From: Jonathan Denose To: lyude@redhat.com Cc: aduggan@synaptics.com, amandhoot12@gmail.com, dmitry.torokhov@gmail.com, jdenose@chromium.org, jdenose@google.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, markpearson@lenovo.com, wsa+renesas@sang-engineering.com Subject: [PATCH v2] Input: synaptics - disable intertouch for Lenovo L440 Date: Fri, 14 Apr 2023 11:41:15 -0500 Message-ID: <20230414092353.v2.1.Ieb687047a5b75c7b7ee5dd258207ef5ca9a3b728@changeid> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <063c8f77c216ffac463532023009124542d54c19.camel@redhat.com> References: <063c8f77c216ffac463532023009124542d54c19.camel@redhat.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org When intertouch is enabled for the L440 a (deep)sleep/resume cycle causes the touchpad driver to hang which causes the touchpad to become unresponsive. Disable intertouch resolves this issue and the touchpad is fine after resume from sleep. Additionally, when the PNP id for the L440 is only removed from the topbuttonpad_pnp_ids list, a message is logged to enable psmouse.synaptics_intertouch, which would cause the sleep/resume issue again. By removing the PNP id from topbutton_pnp_ids and then adding it to the forcepad_pnp_ids array, intertouch is disabled and the message is not logged. Signed-off-by: Jonathan Denose --- Changes in v2: - remove debug statement drivers/input/mouse/synaptics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index fa021af8506e4..b7218b7652c20 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -150,7 +150,6 @@ static const char * const topbuttonpad_pnp_ids[] = { "LEN2001", /* Edge E431 */ "LEN2002", /* Edge E531 */ "LEN2003", - "LEN2004", /* L440 */ "LEN2005", "LEN2006", /* Edge E440/E540 */ "LEN2007", @@ -198,6 +197,7 @@ static const char * const smbus_pnp_ids[] = { static const char * const forcepad_pnp_ids[] = { "SYN300D", "SYN3014", + "LEN2004", /* L440 */ NULL };