From patchwork Fri Mar 31 12:23:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ranjan Kumar X-Patchwork-Id: 669371 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C374DC76196 for ; Fri, 31 Mar 2023 12:24:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232201AbjCaMYM (ORCPT ); Fri, 31 Mar 2023 08:24:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232311AbjCaMYK (ORCPT ); Fri, 31 Mar 2023 08:24:10 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E94BD1F781 for ; Fri, 31 Mar 2023 05:23:43 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id q102so20239044pjq.3 for ; Fri, 31 Mar 2023 05:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1680265422; x=1682857422; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=JYHKj23D802bSvSmXe1AS7KTplgiyizlRpQA51s2wGU=; b=eRC5rP2hTAP8+qCWecjc0rfG3WGsCRMDieXPeuJHHInzt0N2H3Jeaq77mi2U58+v1u /NoHdyV2dTkmX6Fy4vx5EQVAtDpT2X9qMjYngK2JBh3FVvw8PHWHb7gLV8em6Ol5dMlJ 9AGURfZ/Q86KzgxjAnRwnswhxPjK3r1868Fqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680265422; x=1682857422; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JYHKj23D802bSvSmXe1AS7KTplgiyizlRpQA51s2wGU=; b=6th8ov8EZg2jaLEzlkbgxVBj/TtaJfT2qBgKRG2+0PodTDlLOIIZpqnRA5qrngiGNc fKKBNEfiJU9CNuob/3DPERZUAQWpIvBlcb6sZpaBACz5UKe6+euyAJHfh9lN3zQwrdWd fsB5zMaQolV4TYNWHsoWHbnIU2sKasTqItC0ywvgKhTXFsymcjgXIXGWz1zxxJN3ehJO QCTP+8vyFRXTnd/tZnasUXZBAUXYqlDnz8W6GIOl/4cPFQdoZep+AAMejhDHWK0UmzZs IrBkI0xogG6Im0REQRQGoNsuvyKvv6gHgGg8oZbLD0PcU8Gmz6aImSRLcEssHZscoVrM JJHg== X-Gm-Message-State: AO0yUKXwiiwGDgMWukPBz2UC/jDox2n/PkK5Wx8QjJwCMWWddoCW6eGs jTwe7NTfCksi1k9vvYtnV9MwK9LaumkioR0sGGz3/yiqoxJMAeUDbaH+FNFVRIH59qpcSxymZ94 gToTv8uEwhCr+JNY3EHGZ/RdBv8I9PWojA/yRyD2vfK6WZB5XctP255lc4hOci/4DogV978UoD2 1uemPucfECqg== X-Google-Smtp-Source: AK7set8wIEvgWgNab4H26juRarkp7LzPKWD0X8NwMBvISuxHvn+HsBK28h+iSGS5J7lfcHPKpmt7vA== X-Received: by 2002:a05:6a20:3baf:b0:da:a06f:7e91 with SMTP id b47-20020a056a203baf00b000daa06f7e91mr23468726pzh.44.1680265422029; Fri, 31 Mar 2023 05:23:42 -0700 (PDT) Received: from localhost.localdomain ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id l26-20020a62be1a000000b0058dbd7a5e0esm1707255pff.89.2023.03.31.05.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 05:23:40 -0700 (PDT) From: Ranjan Kumar To: linux-scsi@vger.kernel.org, martin.petersen@oracle.com Cc: rajsekhar.chundru@broadcom.com, sathya.prakash@broadcom.com, sumit.saxena@broadcom.com, chandrakanth.patil@broadcom.com, Ranjan Kumar Subject: [PATCH] mpi3mr: soft reset in progress fault code (0xF002) handling Date: Fri, 31 Mar 2023 17:53:17 +0530 Message-Id: <20230331122317.11391-1-ranjan.kumar@broadcom.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The driver is exiting from the fault watchdog thread if it sees the 0xF002 (Soft reset in progress) fault code, If the driver initiates the soft reset, then the driver restarts the watchdog at the end of the soft reset completion. However, if the soft reset is initiated by the firmware asynchronously then the driver will never restart the watchdog and never re-initialize the controller after the asynchronous soft reset completion. Signed-off-by: Ranjan Kumar --- drivers/scsi/mpi3mr/mpi3mr_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c index a565817aa56d..d109a4ceb72b 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_fw.c +++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c @@ -2526,7 +2526,7 @@ static void mpi3mr_watchdog_work(struct work_struct *work) mrioc->unrecoverable = 1; goto schedule_work; case MPI3_SYSIF_FAULT_CODE_SOFT_RESET_IN_PROGRESS: - return; + goto schedule_work; case MPI3_SYSIF_FAULT_CODE_CI_ACTIVATION_RESET: reset_reason = MPI3MR_RESET_FROM_CIACTIV_FAULT; break;