From patchwork Wed Mar 29 07:51:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Bulwahn X-Patchwork-Id: 668527 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CADDFC761A6 for ; Wed, 29 Mar 2023 07:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230256AbjC2HwB (ORCPT ); Wed, 29 Mar 2023 03:52:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230036AbjC2Hvi (ORCPT ); Wed, 29 Mar 2023 03:51:38 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA1B830EB; Wed, 29 Mar 2023 00:51:29 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id er13so18688305edb.9; Wed, 29 Mar 2023 00:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680076288; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z6w306TzGpctk6hvXcFo39ZzdVVVQM4aAQXrijEamw0=; b=P3wJ1cENYx2/rNhpfP8C+yusiRCZw0A6v+miJQUC2iLXbFwpURJUJ/lusWfHAJ3obZ EbZrCT1O3XeIKBCn3qOdNexSkMVVrO+1XiqTiPoTJHV2IbcEUnAvqrM/6tsNtpkwcKtU BMIptleEVQAbED2+rL5uQwYIg9fJrOfO6jimulthw6eGkqJTPeBXo/KylSpLTn0PO6Y4 XyBS+fGRrfoXvUQkxAMg356wMFwHZ9Hvo+nFUAjDfcZ1KxKqETXrREZhwHa/jRF5UOhL 5ZIWHWYkiDUsuwxB2QXsjpPCkjW2pCBUGXb0aBpvdSObVSpqZs58SIOBPpLgGJY1pneG YLVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680076288; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z6w306TzGpctk6hvXcFo39ZzdVVVQM4aAQXrijEamw0=; b=BGkNn88Wvq7G0RsVHiCvaAoEvGy5KRn/89xuv5ZYDwmEsE8C5RLxj1F7Nyg8PxExT7 4LBpy+t0EbeyIPVVob+bExExXfB4unuDBF7yDElhP6b4oyttgT6v51tRPJVoBuGZS194 MRuKYtoyHUGuKyP/sv/ffVnQygTL4vc4++DwbClyHcjabDD4WE7933TrfoWAekGT2/Gf ATKHSYPym2CVNJeMPo6w5mpaoqMCAsdferqswduiwoBrCkp228+HL0fAHT1l5ZxDf6OY MpOa3aXPtvJ/o7PSvYGp0P5s0Vbzebgjjw3K0UemBCl/JbcTgnT83C+/a1dKakwk1W7G Vh+g== X-Gm-Message-State: AAQBX9edOwhvuxmcfXWxv9/YYhywxUgxyjD3im9ECtALrPrROuwOi5nH wl8KB7+/Qh+2uxG0632rgwqCV1FkXEg2Mg== X-Google-Smtp-Source: AKy350bq0KYRLc1JaTwBnlAqByxMA1wzhgtqwfdhA+4P/ecYeMLrYhPkQ1MqoMiaN6i2r4ksIT37Vg== X-Received: by 2002:a17:906:d1d5:b0:93f:5170:c3d7 with SMTP id bs21-20020a170906d1d500b0093f5170c3d7mr15531446ejb.47.1680076288200; Wed, 29 Mar 2023 00:51:28 -0700 (PDT) Received: from felia.fritz.box ([2a02:810d:2a40:1104:d1ab:705f:18f7:3e0a]) by smtp.gmail.com with ESMTPSA id w17-20020a170906b19100b0093fa8c2e877sm5016402ejy.80.2023.03.29.00.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 00:51:28 -0700 (PDT) From: Lukas Bulwahn To: Greg Kroah-Hartman , linux-usb@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH] usb: move config USB_USS720 to usb's misc Kconfig Date: Wed, 29 Mar 2023 09:51:25 +0200 Message-Id: <20230329075125.32352-1-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The USS720 parport driver source code is in drivers/usb/misc/, the corresponding config is defined in drivers/usb/Kconfig. Some digging in the kernel's history revealed no good reason why it needs to be defined in USB's top-level Kconfig file, and why the config for the USS720 parport driver should be the first in the list of USB port drivers, while all other configs for drivers in drivers/usb/misc are in the USB Miscellaneous driver configuration file. Most probably, it was simply considered a bit more special when the USB Miscellaneous driver configuration file (drivers/usb/misc/Config.in back then) was initially created, and this config simply survived to remain at the top-level USB Kconfig file with all further code/Kconfig transformations and additions later on. Users rarely notice this config being at this position, as CONFIG_PARPORT (Parallel port support) needs to be enabled and only few users enable that. Nowadays, this USB_USS720 driver is probably not that special that it needs to be listed as first item of the USB port drivers. Move the configuration of the USS720 parport driver to the top of the USB Miscellaneous drivers section, as the configurations does not have a lot of specific ordering USB Miscellaneous drivers. This way, the USS720 parport driver is moved to the comment "USB Miscellaneous drivers", fitting to the driver's source code location, but still is at the top of the list for those few acquainted users of Kconfig UIs that might be looking for the config that was once at the top of the list of the USB port drivers. Put this config definition to a more local place. No semantic change. Signed-off-by: Lukas Bulwahn --- Details to the historic digging: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit?id=fa67c3c55d814169652a26b625096a48c2d3701c moved all other configs of misc drivers into misc/Config.in. https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/drivers/usb/Config.in?id=7a2deb32924142696b8174cdf9b38cd72a11fc96 shows the USS720 parport driver to exist already at the beginning of the kernel history.git. All of this is more than two decades ago, and the rationales from those historic times are probably outdated at this point in time anyway. drivers/usb/Kconfig | 29 ----------------------------- drivers/usb/misc/Kconfig | 29 +++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index a871a988829d..7f33bcc315f2 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -133,35 +133,6 @@ comment "USB port drivers" if USB -config USB_USS720 - tristate "USS720 parport driver" - depends on PARPORT - select PARPORT_NOT_PC - help - This driver is for USB parallel port adapters that use the Lucent - Technologies USS-720 chip. These cables are plugged into your USB - port and provide USB compatibility to peripherals designed with - parallel port interfaces. - - The chip has two modes: automatic mode and manual mode. In automatic - mode, it looks to the computer like a standard USB printer. Only - printers may be connected to the USS-720 in this mode. The generic - USB printer driver ("USB Printer support", above) may be used in - that mode, and you can say N here if you want to use the chip only - in this mode. - - Manual mode is not limited to printers, any parallel port - device should work. This driver utilizes manual mode. - Note however that some operations are three orders of magnitude - slower than on a PCI/ISA Parallel Port, so timing critical - applications might not work. - - Say Y here if you own an USS-720 USB->Parport cable and intend to - connect anything other than a printer to it. - - To compile this driver as a module, choose M here: the - module will be called uss720. - source "drivers/usb/serial/Kconfig" source "drivers/usb/misc/Kconfig" diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig index a5f7652db7da..801c87e0dd29 100644 --- a/drivers/usb/misc/Kconfig +++ b/drivers/usb/misc/Kconfig @@ -4,6 +4,35 @@ # comment "USB Miscellaneous drivers" +config USB_USS720 + tristate "USS720 parport driver" + depends on PARPORT + select PARPORT_NOT_PC + help + This driver is for USB parallel port adapters that use the Lucent + Technologies USS-720 chip. These cables are plugged into your USB + port and provide USB compatibility to peripherals designed with + parallel port interfaces. + + The chip has two modes: automatic mode and manual mode. In automatic + mode, it looks to the computer like a standard USB printer. Only + printers may be connected to the USS-720 in this mode. The generic + USB printer driver ("USB Printer support", above) may be used in + that mode, and you can say N here if you want to use the chip only + in this mode. + + Manual mode is not limited to printers, any parallel port + device should work. This driver utilizes manual mode. + Note however that some operations are three orders of magnitude + slower than on a PCI/ISA Parallel Port, so timing critical + applications might not work. + + Say Y here if you own an USS-720 USB->Parport cable and intend to + connect anything other than a printer to it. + + To compile this driver as a module, choose M here: the + module will be called uss720. + config USB_EMI62 tristate "EMI 6|2m USB Audio interface support" help