From patchwork Mon May 20 18:12:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 164665 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp603952ili; Mon, 20 May 2019 11:14:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqyI5jFkSGUW2DiSLqQokCIin3dil4fImOs98suXBnkOBpjj7v2hgA8mxuHHO+NXrBvdJLM3 X-Received: by 2002:a02:95aa:: with SMTP id b39mr48294761jai.45.1558376086884; Mon, 20 May 2019 11:14:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558376086; cv=none; d=google.com; s=arc-20160816; b=Qm61wSNK7zptz8KQ6/dVy8m1YySSDGFOW9aWBw2JhFiPLskB1Om4O3BjV/6OnV+4ro 9yR0nh91liF3F4wmWQdUvNgR/Pd1wYuCFTYU34ZV8olMSGc/RSA/wYtTok9203D9f/A3 E+Qi7th8zP0uxEh8xEmLvSc8NKjncKh6CbgNZZQKc5iyTT7dDRRHYMIqm/xmQpV/Wflf KUqQj0vDX0AGZXHGqs+BPR8dDlt48TRrEMrnswQHav9P/QBXuMRlM6U9M1zK8xqG4phS 5pb4E0xa6P64DHIohWy3xD59iwjVuOPEQS5vI+LXQy9fG+ln2awZmvZhtu5f2z5VGRx+ pcFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:message-id:date:to:from; bh=mb+CU8/P5xImg9mDVoK/4aWf9y+54jqOH6R08bWGhBg=; b=NQTzb0Lq12z8aM67f6wzy+IwxGgbRFx0Q8FGDlBT+t479YYBo+uYJrEmvA+tXT9WEY DOFhKpqLd0CIAy5zbkCDPgsYFz6YgMThNQFxGdqKh0tGuISxxA3XmCCKo9xOnuukAm3E gh1xFPu3az3ZbcUusCjjMluKG6ha8fC7wprBm3UHNL4vMZWXkGTUBHro67SyS5/MbTup sGg8pKQ3qUecTqUkmqHYZ/FuURJOTIg/7LLVFPGNEOWC4pUFgOMLAghHr4UYvGh5zGyp G1KEYw4gbtxpgIbZWNT8b71fnkB0/1elo5ZbS4F4esfLmAPqfLPjTPofH/y33vtYIug1 pOpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id q192si178386itb.93.2019.05.20.11.14.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 11:14:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hSmmR-0004u2-QX; Mon, 20 May 2019 18:12:59 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hSmmP-0004tx-QL for xen-devel@lists.xenproject.org; Mon, 20 May 2019 18:12:57 +0000 X-Inumbo-ID: e4ac7471-7b2a-11e9-8980-bc764e045a96 Received: from foss.arm.com (unknown [217.140.101.70]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTP id e4ac7471-7b2a-11e9-8980-bc764e045a96; Mon, 20 May 2019 18:12:56 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 64D0B374; Mon, 20 May 2019 11:12:56 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0D3433F5AF; Mon, 20 May 2019 11:12:54 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 20 May 2019 19:12:50 +0100 Message-Id: <20190520181250.17404-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH] xen/public: arch-arm: Restrict the visibility of struct vcpu_guest_core_regs X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , wei.liu2@citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, Julien Grall , jbeulich@suse.com MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Currently, the structure vcpu_guest_core_regs is part of the public API. This implies that any change in the structure should be backward compatible. However, the structure is only needed by the tools and Xen. It is also not expected to be ever used outside of that context. So we could save us some headache by only declaring the structure for Xen and tools. Suggested-by: Andrew Cooper Signed-off-by: Julien Grall --- This is a follow-up of the discussion [1]. As this is now Xen and tools only, I am wondering whether the check on GNU_C is still necessary. I am happy to send a follow-up patch (or fold in this one) if it can be removed. [1] <3c245c5b-51c6-1d0e-ad6c-42414573166f@arm.com> --- xen/include/public/arch-arm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index eb424e8286..e9a86d8eb8 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -197,6 +197,7 @@ } while ( 0 ) #define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val) +#if defined(__XEN__) || defined(__XEN_TOOLS__) #if defined(__GNUC__) && !defined(__STRICT_ANSI__) /* Anonymous union includes both 32- and 64-bit names (e.g., r0/x0). */ # define __DECL_REG(n64, n32) union { \ @@ -272,6 +273,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_core_regs_t); #undef __DECL_REG +#endif + typedef uint64_t xen_pfn_t; #define PRI_xen_pfn PRIx64 #define PRIu_xen_pfn PRIu64