From patchwork Fri Mar 17 16:50:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 664559 Delivered-To: patch@linaro.org Received: by 2002:a5d:5602:0:0:0:0:0 with SMTP id l2csp504823wrv; Fri, 17 Mar 2023 09:52:03 -0700 (PDT) X-Google-Smtp-Source: AK7set/LWWvhKaD5jbFLuDaJMOm3ihaYLxeCP3CMaYSQRu7UbPyoAQWRKh9aY1yjDMRbGHRh/VKE X-Received: by 2002:ac8:5b87:0:b0:3b9:bcac:725b with SMTP id a7-20020ac85b87000000b003b9bcac725bmr15254236qta.22.1679071923203; Fri, 17 Mar 2023 09:52:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679071923; cv=none; d=google.com; s=arc-20160816; b=i8jut5MmNyX101j0EUbfU0kT+zaESq+1YgRY1KTK9jIOQbTkAUOsiqPD0mVUHJR4R+ pSL96xbEB90K1sfTAALJUQBF+At9cCJwsTCv18TpQAPiWns0JBE1Jq+sd1BSTOshoc9O JZL3ud+kSCCD3PpXEiTGMP74DwLa5wzU8msbdm+4fjtxluM1LZJE6+NEAcxLxJHJIU4a M0JcZxFIXDLpqAQGLG4VxhEO828pe7xgftY+0C3gWbW9Dv51ihYiFvkfZwFYvUEivziq gffm8wQ6GbTYmNymLKT8AFkCZFkiFKwwBGhYbLOZZpiFEhmSUa2Oyg3NzxlJFG9g44zF U1/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=pcjeNQpYtfjnbCVp1jPfUN6yC3n9EwkQ1XDGv0Ar4fQ=; b=GIzh+8uzkV14DnKkZji2ikcfvXI9emFVc21cHSp6pPlQcoqou47rKjJxVkU+vHsbjM nqYHQoDeEPPquMDxbKkfdZJp9UfA5rekLpJlkBn6rQNCrFu8tIrHv0OT4EJQAq0Nl7l9 Tc/7x63HM4+U7CyDnuGoQnsmD6RjMlELkVdfSOCkt2+h+JJmnunA+5ZJ+ziiUVDAss/S euJOf9brRpziltt/9qS5bMud4+KCUO5PzBpsWb0bEfqqOqgYUliEnq/QCaBsdreOpOZA 1Qr0w0yUvGPJdEbOA44gTnG6Sm0K6rcAe/FUNJQd30g59ptM30+kWMnGHmtpZc+AmPlY XXAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="IR4T/+vw"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h1-20020ac85841000000b003ba1a35fbd8si1716815qth.756.2023.03.17.09.52.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Mar 2023 09:52:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="IR4T/+vw"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdDII-0001Uf-Hp; Fri, 17 Mar 2023 12:51:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdDIG-0001U7-PM for qemu-devel@nongnu.org; Fri, 17 Mar 2023 12:51:04 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdDIE-0000yj-4e for qemu-devel@nongnu.org; Fri, 17 Mar 2023 12:51:04 -0400 Received: by mail-wm1-x32b.google.com with SMTP id fm20-20020a05600c0c1400b003ead37e6588so5500380wmb.5 for ; Fri, 17 Mar 2023 09:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679071860; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pcjeNQpYtfjnbCVp1jPfUN6yC3n9EwkQ1XDGv0Ar4fQ=; b=IR4T/+vwPMsWe13l5Ri/VHW+QLrQi+hBBZq2nUG/G1I7bUM55W3uFiErbJT03HYtM0 5KO9W0MpwMFbFq8jg/zLda7UtCnHfPLA3tKD38J0/aPkUV6p6xSulVygC2HVsQdsP2pi AdHrekxgCFAnH3NID6OdO9AwRgU1aVgpV9Jf+9kjDDJxU7wLXiJI8lv//WCuzCeqE0Iq 6YyQrL8jcXPLaH8D8sZ95UM1/0W8aEvy57lZy4fQhSHN2YT/yv8ef4VZMsVlyVLc1RCE +S8Eg08fK5lV0jX1eHDvshNaiR1eFm3eTMOSf1Vk7mFR9bnIlP2D+IpzaIpHs9RcFG4/ gYhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679071860; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pcjeNQpYtfjnbCVp1jPfUN6yC3n9EwkQ1XDGv0Ar4fQ=; b=tx2EE/Oj4eUdtlKLnvnf/bsHFW70d9nK/+auuw6NmSiPTFIcGs280IsM6VPxidZDN7 yNz+ZEN/1grfOJeggDfPylP6Ck3PFfstLeUMsPHIkR1u7vzaC+CE/7VcDg9XbKEuEBnG yERItxPgKob3mbAuvT8naKvKulbh8dYQqDJHehejnOha/wGLe1h6fGtc80Aj8thllZjz PnEnngaRYVUU3F2DISRfTf51QOj5FoNPBpq7SZ5NZJx01A4z/7ruxn5Ge9p/AltfRm16 Fb/hvMEsAqYM3MxwQZWngO5O+nfwo9wHNVhbY1RLqJ3YSnTaZ36BzGFxP38e7G9enDS9 kKLw== X-Gm-Message-State: AO0yUKWBjhB68N7sbzn5jCdNWEPygMmkhDrVU6RLsruuvPEMRm1MOBMO ZK026rjBiTmwpJqnMVKhxjPvgg== X-Received: by 2002:a05:600c:3c83:b0:3ea:ed4d:38eb with SMTP id bg3-20020a05600c3c8300b003eaed4d38ebmr24571505wmb.24.1679071860295; Fri, 17 Mar 2023 09:51:00 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id y6-20020a05600c364600b003ed2c0a0f37sm2460106wmq.35.2023.03.17.09.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 09:50:59 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson , Luis Machado Subject: [PATCH for-8.0] target/arm: Don't advertise aarch64-pauth.xml to gdb Date: Fri, 17 Mar 2023 16:50:57 +0000 Message-Id: <20230317165057.1522743-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Unfortunately a bug in older versions of gdb means that they will crash if QEMU sends them the aarch64-pauth.xml. This bug is fixed in gdb commit 1ba3a3222039eb25, and there are plans to backport that to affected gdb release branches, but since the bug affects gdb 9 through 12 it is very widely deployed (for instance by distros). It is not currently clear what the best way to deal with this is; it has been proposed to define a new XML feature name that old gdb will ignore but newer gdb can handle. Since QEMU's 8.0 release is imminent and at least one of our CI runners is now falling over this, disable the pauth XML for the moment. We can follow up with a more considered fix either in time for 8.0 or else for the 8.1 release. Signed-off-by: Peter Maydell --- target/arm/gdbstub.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c index 78105b8078b..3bd86cee979 100644 --- a/target/arm/gdbstub.c +++ b/target/arm/gdbstub.c @@ -520,11 +520,18 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu) aarch64_gdb_set_fpu_reg, 34, "aarch64-fpu.xml", 0); } +#if 0 + /* + * GDB versions 9 through 12 have a bug which means they will + * crash if they see this XML from QEMU; disable it for the 8.0 + * release, pending a better solution. + */ if (isar_feature_aa64_pauth(&cpu->isar)) { gdb_register_coprocessor(cs, aarch64_gdb_get_pauth_reg, aarch64_gdb_set_pauth_reg, 4, "aarch64-pauth.xml", 0); } +#endif #endif } else { if (arm_feature(env, ARM_FEATURE_NEON)) {