From patchwork Fri Mar 17 14:35:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 664544 Delivered-To: patch@linaro.org Received: by 2002:a5d:5602:0:0:0:0:0 with SMTP id l2csp433903wrv; Fri, 17 Mar 2023 07:36:00 -0700 (PDT) X-Google-Smtp-Source: AK7set/xlNteNtF0IgzNOnhJTVLfflYvIK6T6YnNGY44JxA8idQNKOUVSOBnFsHYKJ+WbtUHZmxL X-Received: by 2002:a05:6102:354d:b0:425:b9b7:3b54 with SMTP id e13-20020a056102354d00b00425b9b73b54mr125734vss.2.1679063760092; Fri, 17 Mar 2023 07:36:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679063760; cv=none; d=google.com; s=arc-20160816; b=DmS6iGlIWAqd+I7iqLZtoMpYUGrpvshzdr+yDZmobCF1gRt4n7PlOdP0Xqb+CCoqYF zRB9cm9jHRwD4JKtBI2m5Yb+ynDa9yWS35k5oDwzw0cnrun4P3oekg94Y2JtPLKdx8X6 GmVtaL7qA0UIRNd052M9b5Kw6DziZ8lIcQ1Z1LiLLY/5XXUZfSdB6JYe3/Ztljjf0iIj +WUSU5w6m9Krk9UEIRb9W9yzwjNCaiaS0hpJEnTuWtlnmZWt0xV7AjlHMb/fEP/OKbH/ 7Q6hct1ED6TE3gn0syE/hKHpq4M7JgpdqKURB+2LN6XrbcNMDYTI6Mr0c2BXJ4O5vm4i S3fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=eDfCXi+1MsfqN5nrWBY5TwBGn9vJCmCJssbkM46yiM8=; b=VAVh25d0jl8Q2/8SBCJ6bftq6hQ+2xjYxBI+R2rCwSrqY0cXquqio+fAUjd2FUYQIp O/i6KPTOozs6kaifs/6GPubQAxxUQWsTAlm6KjSGjSCLJSr5HN+mf2dRKXYKweW3aDmS OV64RZMt9w63jMbJhQGcMTkpAYtonZadJ0qItJLU6/9gb2w6Yobg7gJWZKH0S0RrJo0a Tky79DnUFASbZ11mSU+lL9H7yx8CfWikBjRtM3wD1G37Qp+KQFZb9fEB2+Y0RT20hcvX xWghjniUDBmW38NYhlMgDbhcoRl7dnzpS7i3LsZGCBOhI0wgBwiGMTWsIPsq9GbyGH0G tt2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XoPQs64V; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n10-20020a67e44a000000b004120a83f622si707135vsm.601.2023.03.17.07.35.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Mar 2023 07:36:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XoPQs64V; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdBBF-0003tT-Jc; Fri, 17 Mar 2023 10:35:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdBBD-0003t3-VM for qemu-devel@nongnu.org; Fri, 17 Mar 2023 10:35:40 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdBBC-0001oA-Aa for qemu-devel@nongnu.org; Fri, 17 Mar 2023 10:35:39 -0400 Received: by mail-wr1-x42d.google.com with SMTP id j2so4619482wrh.9 for ; Fri, 17 Mar 2023 07:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679063736; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eDfCXi+1MsfqN5nrWBY5TwBGn9vJCmCJssbkM46yiM8=; b=XoPQs64VO/ud7ue7O5FnQIIccx4rc0vBxbAHRqH3VtOimrWpR22YzkoBwdTMZ+40Bo c+uRhwi7BhoIQ1ZBcJrhWFEB+I/7c96VvUOXoC5DkqAk2K9wFZ9rS/n7qc6+Vl8Bt65x yeD10kQZ8wKKRG4rTSS4Zmen+7udea2DTVUB7qKCg3+OYnjo0pP6eiraL5UfzsYwVj1V yY9rqW/DSWJ6WKdsCY5L6h8v5+gWFjVdZuh5QcuHikqHYF+Mrw/66G6wendvnsFIJD51 C4B/+Hqe73mC/ZYTIY0VRkL7fNXdeam1gSyGQ1ggnHWpTvtUtbZxiZ9H/SrYdgbYjh59 kAKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679063736; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eDfCXi+1MsfqN5nrWBY5TwBGn9vJCmCJssbkM46yiM8=; b=c//WlB2XeBw/Uv9J0nHQBB5ChVZuqP9iviITTG2BTZ2PpsZlLSXpsXBaUJW9e/ABg6 P++ScjsKARs4/NHEvieLZXW8qDWLRiuRgCtTAsIr1P/62K/pevz0LA2BITB7wkBHtm8n Y9OAahOMHCT6nXAf1iVxk6gMTYX0VkgGzXlmG3aMaGzVX1PgQhs62WyOERbXMMaVYkQG g5gxUxrrOzfqe9JbcOw7Xy6hLL4XklqDsStcbrPeWUfSkmDVTN36+JKnTWCg2HaKtQyV +EkkwoMtaPxBURiuO4I50NVRJFub8p0gZ15XJTI2QeGslF6TN3SDON0ahEHdSlVMkfhY P8GQ== X-Gm-Message-State: AO0yUKVaO2mnk+a7kVStVfjuTj6obaNF6jI3ES40MmJKFProD1u4QgYp yJTeZkqxAl8xZFxFLrKHYbQ+HVUBRu3E8M1OqYk= X-Received: by 2002:adf:fb0d:0:b0:2ce:a758:d6fb with SMTP id c13-20020adffb0d000000b002cea758d6fbmr2676785wrr.1.1679063736525; Fri, 17 Mar 2023 07:35:36 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id d6-20020a5d6dc6000000b002c53f6c7599sm2104346wrz.29.2023.03.17.07.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 07:35:36 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Thomas Huth Subject: [PATCH for-8.0] tests/unit/test-blockjob: Disable complete_in_standby test Date: Fri, 17 Mar 2023 14:35:34 +0000 Message-Id: <20230317143534.1481947-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The blockjob/complete_in_standby test is flaky and fails intermittently in CI: 172/621 qemu:unit / test-blockjob ERROR 0.26s killed by signal 6 SIGABRT 11:03:46 MALLOC_PERTURB_=176 G_TEST_SRCDIR=/Users/pm215/src/qemu-for-merges/tests/unit G_TEST_BUILDDIR=/Users/pm215/src/qemu-for-merges/build/all/tests/unit /Users/pm215/src/qemu-for-merges/build/all/tests/unit/test-blockjob --tap -k ----------------------------------- output ----------------------------------- stdout: # random seed: R02S8c79d6e1c01ce0b25475b2210a253242 1..9 # Start of blockjob tests ok 1 /blockjob/ids stderr: Assertion failed: (job->status == JOB_STATUS_STANDBY), function test_complete_in_standby, file ../../tests/unit/test-blockjob.c, line 499. Seen on macOS/x86_64, FreeBSD 13/x86_64, msys2-64bit, eg: https://gitlab.com/qemu-project/qemu/-/jobs/3872508803 https://gitlab.com/qemu-project/qemu/-/jobs/3950667240 Disable this subtest until somebody has time to investigate. Signed-off-by: Peter Maydell --- tests/unit/test-blockjob.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/unit/test-blockjob.c b/tests/unit/test-blockjob.c index c0426bd10ca..a130f6fefba 100644 --- a/tests/unit/test-blockjob.c +++ b/tests/unit/test-blockjob.c @@ -531,6 +531,13 @@ int main(int argc, char **argv) g_test_add_func("/blockjob/cancel/standby", test_cancel_standby); g_test_add_func("/blockjob/cancel/pending", test_cancel_pending); g_test_add_func("/blockjob/cancel/concluded", test_cancel_concluded); - g_test_add_func("/blockjob/complete_in_standby", test_complete_in_standby); + + /* + * This test is flaky and sometimes fails in CI and otherwise: + * don't run unless user opts in via environment variable. + */ + if (getenv("QEMU_TEST_FLAKY_TESTS")) { + g_test_add_func("/blockjob/complete_in_standby", test_complete_in_standby); + } return g_test_run(); }