From patchwork Wed Mar 1 21:49:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 658086 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89126C7EE23 for ; Wed, 1 Mar 2023 21:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbjCAVuK (ORCPT ); Wed, 1 Mar 2023 16:50:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbjCAVuA (ORCPT ); Wed, 1 Mar 2023 16:50:00 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B26737541 for ; Wed, 1 Mar 2023 13:49:59 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id d2-20020a254f02000000b00a316be8a939so1759674ybb.9 for ; Wed, 01 Mar 2023 13:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677707398; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EpgIbXU90/hputcGUyYvUs2slzqLS52o251K2JuSVM8=; b=WaP00pOPIPdoTKkboEHT7Thc02cLx/1EyuvJqzfTtmWLWA1jQ7YPettxWnzX2TZ4nW 3ZOPzjYi2AIW7hhE3FXtgR+HEl3l8QjhIDd1S0RqidjWKH3J8sP5oyIeYRCXUICPfwiv 80TWtSEdZuCUaHNKXjmuE1Teqqmh4yRnBVe7Iz3tRKJ9qbqvIKvYBZg+wb9eLepwTDcg YUMb9SaMw1WyJWCu5TttIIzoEfBQRNMutAeaYMWK9fY6Xml97VcqZFGbfZdvXwPXlw5m dUGLd+VAEHnuULkYSsjmdc4zDZoHUfivc9i72rN6URuBLxXr5z1o/u/G6HTJngAmXsc3 iJMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677707398; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EpgIbXU90/hputcGUyYvUs2slzqLS52o251K2JuSVM8=; b=S7QfBy32nGJn+7CAVL/ltubQuaZ6joorikxMBLshNFx9vUsF18jkcWzZ7KAB2TT5DT X1+OCPWQkWd8UdZxC+11HEIa/jniJhx185/j9th7K9XNgt3It4j+2ZjAJ2HvdmUllZcu 9cAv394BPQ+9bel0EcBumfayl7Kye+iCPLIbiTpL5alfeGA1ZiWwff5HizBO34uAg8ND Jd9uDNPU5El42ZgHMtW9NkRxYyzT1nk6tQVKl4cwseLhuNP22eBsb618omeDadkgBuMR m6h1JNgi+EzHjVX9ztkzguLULoLReApPDy5YftTMfoT1jChz9lkK0euJe0tfvPOsQ62n B8RA== X-Gm-Message-State: AO0yUKWgXsCkpWk3+UfeNwJtpZ5SfECLgAVdOEpAkvg6WrrClstBBdT6 hrFFh5zfXKiP7wF3T6MHhW6D4WIadIr7F20= X-Google-Smtp-Source: AK7set82rOfXzXOZ9yj4WBRb6uaFtTB5S3WLT17i5Dm6MSyoMsbRAM5JC31qi17jLdC0x0otk/S0lMBW9GeEcZU= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:debf:1aed:5c45:c92]) (user=saravanak job=sendgmr) by 2002:a0d:fd41:0:b0:527:ad7e:8e1a with SMTP id n62-20020a0dfd41000000b00527ad7e8e1amr18ywf.216.1677707398396; Wed, 01 Mar 2023 13:49:58 -0800 (PST) Date: Wed, 1 Mar 2023 13:49:48 -0800 In-Reply-To: <20230301214952.2190757-1-saravanak@google.com> Message-Id: <20230301214952.2190757-2-saravanak@google.com> Mime-Version: 1.0 References: <20230301214952.2190757-1-saravanak@google.com> X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Subject: [PATCH v1 1/4] usb: typec: stusb160x: Remove use of fw_devlink_purge_absent_suppliers() From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Heikki Krogerus , Guenter Roeck , Andy Shevchenko , Daniel Scally , Sakari Ailus , Len Brown Cc: Saravana Kannan , Yongqin Liu , Sumit Semwal , Martin Kepplinger , Amelie Delaunay , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This reverts commit 6b63376722d9 (usb: typec: stusb160x: Don't block probing of consumer of "connector" nodes, 2021-07-16). After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, we no longer need to call fw_devlink_purge_absent_suppliers(). Signed-off-by: Saravana Kannan Cc: Amelie Delaunay Reviewed-by: Heikki Krogerus --- drivers/usb/typec/stusb160x.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c index 494b371151e0..482bffeb8a8f 100644 --- a/drivers/usb/typec/stusb160x.c +++ b/drivers/usb/typec/stusb160x.c @@ -685,15 +685,6 @@ static int stusb160x_probe(struct i2c_client *client) if (!fwnode) return -ENODEV; - /* - * This fwnode has a "compatible" property, but is never populated as a - * struct device. Instead we simply parse it to read the properties. - * This it breaks fw_devlink=on. To maintain backward compatibility - * with existing DT files, we work around this by deleting any - * fwnode_links to/from this fwnode. - */ - fw_devlink_purge_absent_suppliers(fwnode); - /* * When both VDD and VSYS power supplies are present, the low power * supply VSYS is selected when VSYS voltage is above 3.1 V. From patchwork Wed Mar 1 21:49:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 658085 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EE8C7EE23 for ; Wed, 1 Mar 2023 21:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbjCAVuQ (ORCPT ); Wed, 1 Mar 2023 16:50:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbjCAVuJ (ORCPT ); Wed, 1 Mar 2023 16:50:09 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B21A742BFF for ; Wed, 1 Mar 2023 13:50:01 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id w192-20020a25dfc9000000b009fe14931caaso1780435ybg.7 for ; Wed, 01 Mar 2023 13:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677707401; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=dxQv5waFu3xv0IisW1bjLsRrEXTjdfJSWFhFeoxtPOI=; b=N0u2emcPqt+w7HnP6S48oXIFPSC90k8hPUi9FBqczZs2DLe8JGmBZf1tTzSI/9AJH9 R3FeC2qBR0N/gzkaEhSFWOlLBGf99HsTk0r1gK3GpRCXRnpK5SiC0Yx225WQheq0SlzC gEYBGiYbZvVIaQntfs/IHBIlqcngYC0LYQFg5yIub0ACOUKSxh6/QjCCsPBWToMY8k2i OJ6IoUK5EckhAroQDcpi60bjmLR6gu2GB7HtnbPBOScP7J08EmqazMAPZfvRnAnp3bjp H0Bn3xnSH5bFiIwDSIR4cc5jzdqq4WJY3DUuQ7FpLxhP0MHcVbnjLTKsr9NYP2cE3X42 2Olw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677707401; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dxQv5waFu3xv0IisW1bjLsRrEXTjdfJSWFhFeoxtPOI=; b=2nDjI4/u9Pym/neSsqoXD+op6xPUqGmVDvzon0dKilwINrnUSYoGXasyrfdDp2LKO+ tP++CCCmO9G6OYxEbJLnUdc3FnGc3WYGlCAEQMmrTGJYc3lOg/B74TV/voG2EbXKkd4n jFjyywDtdVKWtEVPDKwnph/fzPZ8jjIBF7QP8y/+5+WzkkA9qb00xRka4Uhn4zBDqeoq OSBPSNIaXdqg/mZbIu908pGgkl9klaGqQJ28Eb9bK7esxz9coTkv8Ss/ro8AKKxmpCXR OPffwG4OcDyvgl3lrQqAZ9p2nFu4o9WN3UVDRnBdNKYh8xrdngqIa29dD8qj652IE92c hToA== X-Gm-Message-State: AO0yUKUymMq57+IzdTh8dbQicRpjbrhQLqTjYwDs7eShf3rE5V+zCghw WSorqHgl3uhILUqSym4wyCOCBOdx78IrYew= X-Google-Smtp-Source: AK7set/xyvoFhdWMtePqqoxkiFKJ9A1bLedjGccifdYq3F7anLkOM2Yz4H0fTroMYl9LFY2P1BNgvnKva6FUsqQ= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:debf:1aed:5c45:c92]) (user=saravanak job=sendgmr) by 2002:a81:86c2:0:b0:536:e8b5:e7a5 with SMTP id w185-20020a8186c2000000b00536e8b5e7a5mr22ywf.239.1677707400820; Wed, 01 Mar 2023 13:50:00 -0800 (PST) Date: Wed, 1 Mar 2023 13:49:49 -0800 In-Reply-To: <20230301214952.2190757-1-saravanak@google.com> Message-Id: <20230301214952.2190757-3-saravanak@google.com> Mime-Version: 1.0 References: <20230301214952.2190757-1-saravanak@google.com> X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Subject: [PATCH v1 2/4] usb: typec: tipd: Remove use of fw_devlink_purge_absent_suppliers() From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Heikki Krogerus , Guenter Roeck , Andy Shevchenko , Daniel Scally , Sakari Ailus , Len Brown Cc: Saravana Kannan , Yongqin Liu , Sumit Semwal , Martin Kepplinger , Amelie Delaunay , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, we no longer need to call fw_devlink_purge_absent_suppliers(). Signed-off-by: Saravana Kannan Cc: Martin Kepplinger Reviewed-by: Heikki Krogerus --- drivers/usb/typec/tipd/core.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 485b90c13078..92401622bc4e 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -764,16 +764,7 @@ static int tps6598x_probe(struct i2c_client *client) if (ret < 0) goto err_clear_mask; - /* - * This fwnode has a "compatible" property, but is never populated as a - * struct device. Instead we simply parse it to read the properties. - * This breaks fw_devlink=on. To maintain backward compatibility - * with existing DT files, we work around this by deleting any - * fwnode_links to/from this fwnode. - */ fwnode = device_get_named_child_node(&client->dev, "connector"); - if (fwnode) - fw_devlink_purge_absent_suppliers(fwnode); tps->role_sw = fwnode_usb_role_switch_get(fwnode); if (IS_ERR(tps->role_sw)) { From patchwork Wed Mar 1 21:49:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 658398 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D571DC678D4 for ; Wed, 1 Mar 2023 21:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbjCAVuM (ORCPT ); Wed, 1 Mar 2023 16:50:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbjCAVuK (ORCPT ); Wed, 1 Mar 2023 16:50:10 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE13238014 for ; Wed, 1 Mar 2023 13:50:03 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id w192-20020a25dfc9000000b009fe14931caaso1780524ybg.7 for ; Wed, 01 Mar 2023 13:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677707403; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Lzd1Gwx96VUjXcS7KYwf3MWxr5hmHFJA81n84b7nbV0=; b=fC+1elqqEoVt0zxPvdBGjmtJXVH+4DPH170Jc2W7/L9XGci4IjNQG2TY+yEUHIx3AP GGpK6hXJwjsUWfv2oYNKD/GswLKAmG869Q5A6sKAmSVRTlUP8GVCc9709jcPZK2lkTUJ gtQbxQrsFnAms1c7PwafHvvxALWBuCvL7ZbCfbAx2dq0jWtcmRVp80JKhszxCiwgHUAy /rpVF22HWjBs2ZdEjmheoS3srZ7rlD8HrCgHUyIASZ748YXz7aX0i5l/YWScyHgTKbVO 5FY5CR1LB+bwlRJ4XmjCGFBkWb7X8y+gxLvACdvpGugxK33VX9qTglPXxL+z2MaLIUpg PinQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677707403; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lzd1Gwx96VUjXcS7KYwf3MWxr5hmHFJA81n84b7nbV0=; b=Sx8uf3l820tFYx5MCNFSoxtgXV6KQyct3Ur4sbR1YH2/zxTl8Iphz4aPq26Rtd8v8v z4Ot6eYlK5cp6N3iPPb0n5SErWk7U5gqbIc41Ds61qOh6f4MuG0mzWOfPa1XFdZN7eYq Ob65J4GXUM0Ho534U46Ajnw6J8ObQxG9n6rGN66BUluAdMa5gZHNNO4J1lGsRo2pvQKQ nweiTzHjl2wDkWeB88+ioLaC53tkYMRP4QXw3v4yMsEsWngUgabBfdBNM949eKgy3A/e D39Hh9XIbaKoFqhis3XJOf2iOmIqQuO3ffy3nY/vwNmJ0phnNd0ieHVJ/9fQNxOSYPsS BrhQ== X-Gm-Message-State: AO0yUKXZ5NWKiJbP0pTHFFCBBCuyAK58XDuWi0zpMH417YTpqN3Kfykr Lkthi00Z/sFnVhKAk4034dNb6axqsxHsm+w= X-Google-Smtp-Source: AK7set9NsJzKEjU1HYT7Nzg6ByPOFB0TqyhmDlmEGQSkAt2ogDssPNGIoPEWtkQYvzsOdZTdZOOr7UE+/OhEKkQ= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:debf:1aed:5c45:c92]) (user=saravanak job=sendgmr) by 2002:a81:b705:0:b0:533:9185:fc2c with SMTP id v5-20020a81b705000000b005339185fc2cmr4923042ywh.7.1677707403606; Wed, 01 Mar 2023 13:50:03 -0800 (PST) Date: Wed, 1 Mar 2023 13:49:50 -0800 In-Reply-To: <20230301214952.2190757-1-saravanak@google.com> Message-Id: <20230301214952.2190757-4-saravanak@google.com> Mime-Version: 1.0 References: <20230301214952.2190757-1-saravanak@google.com> X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Subject: [PATCH v1 3/4] usb: typec: tcpm: Remove use of fw_devlink_purge_absent_suppliers() From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Heikki Krogerus , Guenter Roeck , Andy Shevchenko , Daniel Scally , Sakari Ailus , Len Brown Cc: Saravana Kannan , Yongqin Liu , Sumit Semwal , Martin Kepplinger , Amelie Delaunay , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, we no longer need to call fw_devlink_purge_absent_suppliers(). Signed-off-by: Saravana Kannan Cc: Yongqin Liu Cc: Sumit Semwal Reviewed-by: Heikki Krogerus --- drivers/usb/typec/tcpm/tcpm.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index a0d943d78580..fd131f07020c 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -6112,15 +6112,6 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, if (!fwnode) return -EINVAL; - /* - * This fwnode has a "compatible" property, but is never populated as a - * struct device. Instead we simply parse it to read the properties. - * This it breaks fw_devlink=on. To maintain backward compatibility - * with existing DT files, we work around this by deleting any - * fwnode_links to/from this fwnode. - */ - fw_devlink_purge_absent_suppliers(fwnode); - ret = typec_get_fw_cap(&port->typec_caps, fwnode); if (ret < 0) return ret; From patchwork Wed Mar 1 21:49:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 658397 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33265C678D4 for ; Wed, 1 Mar 2023 21:50:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjCAVuP (ORCPT ); Wed, 1 Mar 2023 16:50:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbjCAVuK (ORCPT ); Wed, 1 Mar 2023 16:50:10 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50F284AFFE for ; Wed, 1 Mar 2023 13:50:07 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-536bbaeceeaso292048287b3.11 for ; Wed, 01 Mar 2023 13:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677707406; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Wpj5qaodj5ScmnNVI3rS9lV8D5wtu+qpU9VuY7cTTKw=; b=NhNtT+6dGVHh00iSdAACqfRBFAA8gf6z22UVtLG48MBccW6lc47mdX6u4S3FN+9QmZ mWWKZ5GQQ1LHaoHzaYhg7xIPc9gr9tlfVsFAFUMIlKhSaJEUxwWfZ/Ebk3+Wsu8Nf3hS zafom0jKpVZTLmC/AdVJT01uxzJbu6KIYR0YLBrtu8ZHJ3NA9QefB4xo4T6PunQ5irJr OQjaIKArceRovZJc10UY0aVk5gijhFDZoUVpQh2GwEbo8Bmrkte13+eq5rEb/Vv2hzn+ sYInPfBEeQLT2HBq/aAPIGTo82S94stYrqWyb+PqmSh930CFo13uC0ItSG3CpfNv87bV Vttw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677707406; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wpj5qaodj5ScmnNVI3rS9lV8D5wtu+qpU9VuY7cTTKw=; b=LR6Wqg4s5F4TU9ePzl/+L5lOQ5suneQdHiF8iXY8/s/wLzpXgKU6BeGAZmZ0llNfwh UfXjwH3wZ2xCJrgZUwqp5rNISdVGlO/r1Eukf/baciGbCjs/iN5HvE1/bNrNpsVgzF9/ TeWKl3vsPxfCXZu3vG1LQw17OjsmTAuEvdh21d8BQM4Cr2K20PGJ+XuOxwhTy5Yo/n2x vdAmEKmlDjFG/JnLhAL6J59/Ji+ZI/RhBXSw3I9k5r8YOHhnxX3qwpWttEqiNSnI2lE4 SBjNF8qUhcAoNKRBvyqGArkW3/rYajVjD6a4MSzYpOSbAJBnPekcasJO5BiDZ8PRYFgh Avtg== X-Gm-Message-State: AO0yUKVjAhQijhfRPS++mbc/TGlYUJM9/IHg74vNZxsvxTDfMwg+mQOe /HBddah0goPzTrT5QEVxKwqeTL+z5n0AFwA= X-Google-Smtp-Source: AK7set81Xd2tYA4JOiqSKDhL+z8UEtfehns/zS6Rq/x95FFMqWM3N6FEq8Q+gfDREO1ct62FNHlpEoore1o1Hvs= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:debf:1aed:5c45:c92]) (user=saravanak job=sendgmr) by 2002:a05:6902:1003:b0:9f5:af6b:6f69 with SMTP id w3-20020a056902100300b009f5af6b6f69mr14719319ybt.5.1677707406553; Wed, 01 Mar 2023 13:50:06 -0800 (PST) Date: Wed, 1 Mar 2023 13:49:51 -0800 In-Reply-To: <20230301214952.2190757-1-saravanak@google.com> Message-Id: <20230301214952.2190757-5-saravanak@google.com> Mime-Version: 1.0 References: <20230301214952.2190757-1-saravanak@google.com> X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Subject: [PATCH v1 4/4] driver core: Delete fw_devlink_purge_absent_suppliers() From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Heikki Krogerus , Guenter Roeck , Andy Shevchenko , Daniel Scally , Sakari Ailus , Len Brown Cc: Saravana Kannan , Yongqin Liu , Sumit Semwal , Martin Kepplinger , Amelie Delaunay , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, there's no need for any driver or framework to call fw_devlink_purge_absent_suppliers() anymore and we can delete it. Signed-off-by: Saravana Kannan Acked-by: Heikki Krogerus --- drivers/base/core.c | 16 ---------------- include/linux/fwnode.h | 1 - 2 files changed, 17 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 6878dfcbf0d6..46364c4d1983 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -186,22 +186,6 @@ void fwnode_links_purge(struct fwnode_handle *fwnode) fwnode_links_purge_consumers(fwnode); } -void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode) -{ - struct fwnode_handle *child; - - /* Don't purge consumer links of an added child */ - if (fwnode->dev) - return; - - fwnode->flags |= FWNODE_FLAG_NOT_DEVICE; - fwnode_links_purge_consumers(fwnode); - - fwnode_for_each_available_child_node(fwnode, child) - fw_devlink_purge_absent_suppliers(child); -} -EXPORT_SYMBOL_GPL(fw_devlink_purge_absent_suppliers); - /** * __fwnode_links_move_consumers - Move consumer from @from to @to fwnode_handle * @from: move consumers away from this fwnode diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index 5700451b300f..63972c863fcd 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h @@ -210,6 +210,5 @@ static inline void fwnode_dev_initialized(struct fwnode_handle *fwnode, extern bool fw_devlink_is_strict(void); int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup); void fwnode_links_purge(struct fwnode_handle *fwnode); -void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode); #endif