From patchwork Wed Mar 1 21:49:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 657878 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F3BC7EE30 for ; Wed, 1 Mar 2023 21:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229534AbjCAVuK (ORCPT ); Wed, 1 Mar 2023 16:50:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjCAVuA (ORCPT ); Wed, 1 Mar 2023 16:50:00 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A85236FFC for ; Wed, 1 Mar 2023 13:49:59 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-536c039f859so295743707b3.21 for ; Wed, 01 Mar 2023 13:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677707398; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EpgIbXU90/hputcGUyYvUs2slzqLS52o251K2JuSVM8=; b=WaP00pOPIPdoTKkboEHT7Thc02cLx/1EyuvJqzfTtmWLWA1jQ7YPettxWnzX2TZ4nW 3ZOPzjYi2AIW7hhE3FXtgR+HEl3l8QjhIDd1S0RqidjWKH3J8sP5oyIeYRCXUICPfwiv 80TWtSEdZuCUaHNKXjmuE1Teqqmh4yRnBVe7Iz3tRKJ9qbqvIKvYBZg+wb9eLepwTDcg YUMb9SaMw1WyJWCu5TttIIzoEfBQRNMutAeaYMWK9fY6Xml97VcqZFGbfZdvXwPXlw5m dUGLd+VAEHnuULkYSsjmdc4zDZoHUfivc9i72rN6URuBLxXr5z1o/u/G6HTJngAmXsc3 iJMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677707398; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EpgIbXU90/hputcGUyYvUs2slzqLS52o251K2JuSVM8=; b=ubWhMnPK/ZZBjh8pnqqPbmfMcKu8HfRBlzNpweji44np1zXJiIyUkCPWvUyPLWd7dr bdA/o1I3Qnorot6ZOVGY/uri/Sq8+TEidLkxmpscsZ3QW1g6SVt7rzVCLn2FzkxFNcXL b5KzFVXcxJ8/Y1ldNCXydOJK79tgG9l57TK4Zduj3P3XGedhh5/S0CPJWP/X3GI/yInk R4/xrWT88DlN8wzYp3qXqRIi3Smnc3L6JL2axPkOH2+xiDUtoJJl6LTcPH7/HVQNFvov kB95bB9P/UuIGKa+CJDlwp5T2AQRZsRTWTMoUvvmHvggFjA3APumni3AApAQNjq/8fk4 LGNw== X-Gm-Message-State: AO0yUKVrHEEnPlJ54fxLYJDa1XC9BjxNkXnZgvyWzNjKj4qKeXP9t28Q vgdnGApqveEevpp0HQxJBV+scsxw4m+Jvk0= X-Google-Smtp-Source: AK7set82rOfXzXOZ9yj4WBRb6uaFtTB5S3WLT17i5Dm6MSyoMsbRAM5JC31qi17jLdC0x0otk/S0lMBW9GeEcZU= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:debf:1aed:5c45:c92]) (user=saravanak job=sendgmr) by 2002:a0d:fd41:0:b0:527:ad7e:8e1a with SMTP id n62-20020a0dfd41000000b00527ad7e8e1amr18ywf.216.1677707398396; Wed, 01 Mar 2023 13:49:58 -0800 (PST) Date: Wed, 1 Mar 2023 13:49:48 -0800 In-Reply-To: <20230301214952.2190757-1-saravanak@google.com> Message-Id: <20230301214952.2190757-2-saravanak@google.com> Mime-Version: 1.0 References: <20230301214952.2190757-1-saravanak@google.com> X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Subject: [PATCH v1 1/4] usb: typec: stusb160x: Remove use of fw_devlink_purge_absent_suppliers() From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Heikki Krogerus , Guenter Roeck , Andy Shevchenko , Daniel Scally , Sakari Ailus , Len Brown Cc: Saravana Kannan , Yongqin Liu , Sumit Semwal , Martin Kepplinger , Amelie Delaunay , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org This reverts commit 6b63376722d9 (usb: typec: stusb160x: Don't block probing of consumer of "connector" nodes, 2021-07-16). After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, we no longer need to call fw_devlink_purge_absent_suppliers(). Signed-off-by: Saravana Kannan Cc: Amelie Delaunay Reviewed-by: Heikki Krogerus --- drivers/usb/typec/stusb160x.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c index 494b371151e0..482bffeb8a8f 100644 --- a/drivers/usb/typec/stusb160x.c +++ b/drivers/usb/typec/stusb160x.c @@ -685,15 +685,6 @@ static int stusb160x_probe(struct i2c_client *client) if (!fwnode) return -ENODEV; - /* - * This fwnode has a "compatible" property, but is never populated as a - * struct device. Instead we simply parse it to read the properties. - * This it breaks fw_devlink=on. To maintain backward compatibility - * with existing DT files, we work around this by deleting any - * fwnode_links to/from this fwnode. - */ - fw_devlink_purge_absent_suppliers(fwnode); - /* * When both VDD and VSYS power supplies are present, the low power * supply VSYS is selected when VSYS voltage is above 3.1 V. From patchwork Wed Mar 1 21:49:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 658504 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A14EEC7EE33 for ; Wed, 1 Mar 2023 21:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbjCAVuL (ORCPT ); Wed, 1 Mar 2023 16:50:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229612AbjCAVuK (ORCPT ); Wed, 1 Mar 2023 16:50:10 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B01AC41B5F for ; Wed, 1 Mar 2023 13:50:01 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-536a4eba107so294322237b3.19 for ; Wed, 01 Mar 2023 13:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677707401; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=dxQv5waFu3xv0IisW1bjLsRrEXTjdfJSWFhFeoxtPOI=; b=N0u2emcPqt+w7HnP6S48oXIFPSC90k8hPUi9FBqczZs2DLe8JGmBZf1tTzSI/9AJH9 R3FeC2qBR0N/gzkaEhSFWOlLBGf99HsTk0r1gK3GpRCXRnpK5SiC0Yx225WQheq0SlzC gEYBGiYbZvVIaQntfs/IHBIlqcngYC0LYQFg5yIub0ACOUKSxh6/QjCCsPBWToMY8k2i OJ6IoUK5EckhAroQDcpi60bjmLR6gu2GB7HtnbPBOScP7J08EmqazMAPZfvRnAnp3bjp H0Bn3xnSH5bFiIwDSIR4cc5jzdqq4WJY3DUuQ7FpLxhP0MHcVbnjLTKsr9NYP2cE3X42 2Olw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677707401; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dxQv5waFu3xv0IisW1bjLsRrEXTjdfJSWFhFeoxtPOI=; b=Q3yhwCk8iNIiqD0ZksBNIU1/lKuvwNzcfpG0fpR+/MDQTZTgb962ZWohDNNSGeDnUd nJxvZEm4a4ebRQGb9PpRbcbTZxlG7BhtK/1ZXPNnrPCEFy9MH+CE3QfVCx9g6ckBgON0 rrqiGJRHIL02H8/H+3efun2lnAL3lOAB4BIEPfmO3nr6/dG4nNxbfsy/jJUZzvH7Qe83 c2FzixayQJP4Jz7jOWCuq7UYUzdoc+HOCaWa/fJ4pE/ZIe7lvImW6WEXw5OrNsULrafv uhTyfRu1bgsc2nj/SUWT502iGuDbdSd2bKGoj8ysJXfgXu2x+ACayjqb1n/i4E6YOLe3 QflA== X-Gm-Message-State: AO0yUKXWHor7GjgtQviTqBJK76gTTKCGiARtJJ1QRKkq9UgOZ/a8q0he czIGFOtRFSqfc6NheXXH1+EsJjjnpZZhPNo= X-Google-Smtp-Source: AK7set/xyvoFhdWMtePqqoxkiFKJ9A1bLedjGccifdYq3F7anLkOM2Yz4H0fTroMYl9LFY2P1BNgvnKva6FUsqQ= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:debf:1aed:5c45:c92]) (user=saravanak job=sendgmr) by 2002:a81:86c2:0:b0:536:e8b5:e7a5 with SMTP id w185-20020a8186c2000000b00536e8b5e7a5mr22ywf.239.1677707400820; Wed, 01 Mar 2023 13:50:00 -0800 (PST) Date: Wed, 1 Mar 2023 13:49:49 -0800 In-Reply-To: <20230301214952.2190757-1-saravanak@google.com> Message-Id: <20230301214952.2190757-3-saravanak@google.com> Mime-Version: 1.0 References: <20230301214952.2190757-1-saravanak@google.com> X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Subject: [PATCH v1 2/4] usb: typec: tipd: Remove use of fw_devlink_purge_absent_suppliers() From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Heikki Krogerus , Guenter Roeck , Andy Shevchenko , Daniel Scally , Sakari Ailus , Len Brown Cc: Saravana Kannan , Yongqin Liu , Sumit Semwal , Martin Kepplinger , Amelie Delaunay , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, we no longer need to call fw_devlink_purge_absent_suppliers(). Signed-off-by: Saravana Kannan Cc: Martin Kepplinger --- drivers/usb/typec/tipd/core.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 485b90c13078..92401622bc4e 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -764,16 +764,7 @@ static int tps6598x_probe(struct i2c_client *client) if (ret < 0) goto err_clear_mask; - /* - * This fwnode has a "compatible" property, but is never populated as a - * struct device. Instead we simply parse it to read the properties. - * This breaks fw_devlink=on. To maintain backward compatibility - * with existing DT files, we work around this by deleting any - * fwnode_links to/from this fwnode. - */ fwnode = device_get_named_child_node(&client->dev, "connector"); - if (fwnode) - fw_devlink_purge_absent_suppliers(fwnode); tps->role_sw = fwnode_usb_role_switch_get(fwnode); if (IS_ERR(tps->role_sw)) { From patchwork Wed Mar 1 21:49:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 657877 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DBA5C7EE33 for ; Wed, 1 Mar 2023 21:50:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbjCAVuM (ORCPT ); Wed, 1 Mar 2023 16:50:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjCAVuK (ORCPT ); Wed, 1 Mar 2023 16:50:10 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5189C4391F for ; Wed, 1 Mar 2023 13:50:04 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5395c8fc4a1so247625717b3.5 for ; Wed, 01 Mar 2023 13:50:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677707403; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Lzd1Gwx96VUjXcS7KYwf3MWxr5hmHFJA81n84b7nbV0=; b=fC+1elqqEoVt0zxPvdBGjmtJXVH+4DPH170Jc2W7/L9XGci4IjNQG2TY+yEUHIx3AP GGpK6hXJwjsUWfv2oYNKD/GswLKAmG869Q5A6sKAmSVRTlUP8GVCc9709jcPZK2lkTUJ gtQbxQrsFnAms1c7PwafHvvxALWBuCvL7ZbCfbAx2dq0jWtcmRVp80JKhszxCiwgHUAy /rpVF22HWjBs2ZdEjmheoS3srZ7rlD8HrCgHUyIASZ748YXz7aX0i5l/YWScyHgTKbVO 5FY5CR1LB+bwlRJ4XmjCGFBkWb7X8y+gxLvACdvpGugxK33VX9qTglPXxL+z2MaLIUpg PinQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677707403; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lzd1Gwx96VUjXcS7KYwf3MWxr5hmHFJA81n84b7nbV0=; b=rEbMbFCO1c4+wxHYSkvS5kRY2e3HQDFqEn7fVBoNi5kzpOMwpYMRQWO5eS0GEaadUI EyhD5Z9VXL/O6oIXdzG3i6Gsxz7C+GOi3/o/+I22mkqDiGFKcPyltEv0BuZK2ActnLQn XgpEPq5c88KDE+g9HQUV/7K3lEO49BGKcdji7trgplfjWEdaXEIwD0uqbPebwQfDmw9h 8t1Ih5wY9hlh/DO+rV87e2VV7fbMGBs5nJGm2wUzFL+BcjIKNl9xR+/tVn0O4q3SQPKR gk9RiwZOcDDQNA4zLAfDC3oXNLDbdrJGO6ytaSEGsHL56iicfMrWfTw6t9S5OPvl6rP0 mgJA== X-Gm-Message-State: AO0yUKUEudq1syqo+3Swq5MGKQbs/P8Cljvo88w0ARPrarNkLtNuedOC O1bHBR6hfb6XUVqlt/E/CggF/avBXDNo1bc= X-Google-Smtp-Source: AK7set9NsJzKEjU1HYT7Nzg6ByPOFB0TqyhmDlmEGQSkAt2ogDssPNGIoPEWtkQYvzsOdZTdZOOr7UE+/OhEKkQ= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:debf:1aed:5c45:c92]) (user=saravanak job=sendgmr) by 2002:a81:b705:0:b0:533:9185:fc2c with SMTP id v5-20020a81b705000000b005339185fc2cmr4923042ywh.7.1677707403606; Wed, 01 Mar 2023 13:50:03 -0800 (PST) Date: Wed, 1 Mar 2023 13:49:50 -0800 In-Reply-To: <20230301214952.2190757-1-saravanak@google.com> Message-Id: <20230301214952.2190757-4-saravanak@google.com> Mime-Version: 1.0 References: <20230301214952.2190757-1-saravanak@google.com> X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Subject: [PATCH v1 3/4] usb: typec: tcpm: Remove use of fw_devlink_purge_absent_suppliers() From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Heikki Krogerus , Guenter Roeck , Andy Shevchenko , Daniel Scally , Sakari Ailus , Len Brown Cc: Saravana Kannan , Yongqin Liu , Sumit Semwal , Martin Kepplinger , Amelie Delaunay , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, we no longer need to call fw_devlink_purge_absent_suppliers(). Signed-off-by: Saravana Kannan Cc: Yongqin Liu Cc: Sumit Semwal Reviewed-by: Heikki Krogerus --- drivers/usb/typec/tcpm/tcpm.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index a0d943d78580..fd131f07020c 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -6112,15 +6112,6 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, if (!fwnode) return -EINVAL; - /* - * This fwnode has a "compatible" property, but is never populated as a - * struct device. Instead we simply parse it to read the properties. - * This it breaks fw_devlink=on. To maintain backward compatibility - * with existing DT files, we work around this by deleting any - * fwnode_links to/from this fwnode. - */ - fw_devlink_purge_absent_suppliers(fwnode); - ret = typec_get_fw_cap(&port->typec_caps, fwnode); if (ret < 0) return ret; From patchwork Wed Mar 1 21:49:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 658503 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8163BC7EE37 for ; Wed, 1 Mar 2023 21:50:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229586AbjCAVuN (ORCPT ); Wed, 1 Mar 2023 16:50:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbjCAVuK (ORCPT ); Wed, 1 Mar 2023 16:50:10 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5266B4BE9D for ; Wed, 1 Mar 2023 13:50:07 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-536e8d6d9ceso294170997b3.12 for ; Wed, 01 Mar 2023 13:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677707406; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Wpj5qaodj5ScmnNVI3rS9lV8D5wtu+qpU9VuY7cTTKw=; b=NhNtT+6dGVHh00iSdAACqfRBFAA8gf6z22UVtLG48MBccW6lc47mdX6u4S3FN+9QmZ mWWKZ5GQQ1LHaoHzaYhg7xIPc9gr9tlfVsFAFUMIlKhSaJEUxwWfZ/Ebk3+Wsu8Nf3hS zafom0jKpVZTLmC/AdVJT01uxzJbu6KIYR0YLBrtu8ZHJ3NA9QefB4xo4T6PunQ5irJr OQjaIKArceRovZJc10UY0aVk5gijhFDZoUVpQh2GwEbo8Bmrkte13+eq5rEb/Vv2hzn+ sYInPfBEeQLT2HBq/aAPIGTo82S94stYrqWyb+PqmSh930CFo13uC0ItSG3CpfNv87bV Vttw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677707406; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wpj5qaodj5ScmnNVI3rS9lV8D5wtu+qpU9VuY7cTTKw=; b=ilCXeRmId4+v+a6tHoD8ulLo55z/lovNDeWZTR6gNFIdYymnjgIB3RBOrlmnjTPcRr qSSGQZqZVEW95tNOZ9WdCm0zBtGp/NvdmxcOQAScEe3GcPaS87upr5rXZsCIJ/GVZEii f1Fjm5pCLGy74UkKFtpSowApx5oP6PFAJdyA3RvoyUfVUI+hUhbiPuY9F3VKbiw0HTvS CyOiJ/lc859IZbRr4ZOajy3mLeFyw/egyBejVnhAlpozLNMIrnltvrmW4nRq1ICPwa6W 0UygzqM3M+5QtK4ZlR9tgw321TxaL1LPsOdw9wimYKabgO7FTyFl3v2TvoZqDen0PUzG 1gjg== X-Gm-Message-State: AO0yUKWNlNw73VtNGi28gHjc9UKpg5bh3VZhSF6dXI0vREhvevkQc6bp tfQ/1oO4FgIjfUGQfcJR2OLnfixVrHtMBH4= X-Google-Smtp-Source: AK7set81Xd2tYA4JOiqSKDhL+z8UEtfehns/zS6Rq/x95FFMqWM3N6FEq8Q+gfDREO1ct62FNHlpEoore1o1Hvs= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:debf:1aed:5c45:c92]) (user=saravanak job=sendgmr) by 2002:a05:6902:1003:b0:9f5:af6b:6f69 with SMTP id w3-20020a056902100300b009f5af6b6f69mr14719319ybt.5.1677707406553; Wed, 01 Mar 2023 13:50:06 -0800 (PST) Date: Wed, 1 Mar 2023 13:49:51 -0800 In-Reply-To: <20230301214952.2190757-1-saravanak@google.com> Message-Id: <20230301214952.2190757-5-saravanak@google.com> Mime-Version: 1.0 References: <20230301214952.2190757-1-saravanak@google.com> X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Subject: [PATCH v1 4/4] driver core: Delete fw_devlink_purge_absent_suppliers() From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Heikki Krogerus , Guenter Roeck , Andy Shevchenko , Daniel Scally , Sakari Ailus , Len Brown Cc: Saravana Kannan , Yongqin Liu , Sumit Semwal , Martin Kepplinger , Amelie Delaunay , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, there's no need for any driver or framework to call fw_devlink_purge_absent_suppliers() anymore and we can delete it. Signed-off-by: Saravana Kannan --- drivers/base/core.c | 16 ---------------- include/linux/fwnode.h | 1 - 2 files changed, 17 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 6878dfcbf0d6..46364c4d1983 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -186,22 +186,6 @@ void fwnode_links_purge(struct fwnode_handle *fwnode) fwnode_links_purge_consumers(fwnode); } -void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode) -{ - struct fwnode_handle *child; - - /* Don't purge consumer links of an added child */ - if (fwnode->dev) - return; - - fwnode->flags |= FWNODE_FLAG_NOT_DEVICE; - fwnode_links_purge_consumers(fwnode); - - fwnode_for_each_available_child_node(fwnode, child) - fw_devlink_purge_absent_suppliers(child); -} -EXPORT_SYMBOL_GPL(fw_devlink_purge_absent_suppliers); - /** * __fwnode_links_move_consumers - Move consumer from @from to @to fwnode_handle * @from: move consumers away from this fwnode diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index 5700451b300f..63972c863fcd 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h @@ -210,6 +210,5 @@ static inline void fwnode_dev_initialized(struct fwnode_handle *fwnode, extern bool fw_devlink_is_strict(void); int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup); void fwnode_links_purge(struct fwnode_handle *fwnode); -void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode); #endif