From patchwork Sat Feb 25 02:50:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Li X-Patchwork-Id: 656582 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76E56C6FA8E for ; Sat, 25 Feb 2023 02:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229503AbjBYCud (ORCPT ); Fri, 24 Feb 2023 21:50:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjBYCuc (ORCPT ); Fri, 24 Feb 2023 21:50:32 -0500 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 211F730192 for ; Fri, 24 Feb 2023 18:50:31 -0800 (PST) Received: by mail-il1-x12f.google.com with SMTP id r4so921794ila.2 for ; Fri, 24 Feb 2023 18:50:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squareup.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O+YiAWwD8438C4tpslppodUi5tXVxOBGLkh2sIdNhgM=; b=NM4onbE5kbJIC0Pu2oA4ilBbS8Qd2u8P1r7xVkZNXEUXe1jitBE1DxDpNOaS/drNvH pIKCgTjpBEimZ8lwrED9t29WBGjsC+BZJZSdsAxcz6kXy+bW2K6VUMBHPgYm42fpv+M2 ONwo+HquBQ1s/jkvlWXPrR/wdCtyHxuN13dAo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O+YiAWwD8438C4tpslppodUi5tXVxOBGLkh2sIdNhgM=; b=xMo1qnOu1xSa1TNpULNMUT2eKSE3rei7iDGbALCBglrBgLqqmdxkl+4QoQexFUa4Wx qgGCDh/UZY0CLoxDe+CAjSpPMzxyRm/28g+HYOoTdVRHkin9/UOxjVPArncsX2p8xIAh /0aCfxLSGE2OWZ4sYCNOxyRHpTyxG8nv1Lpn65F0VRo8liam2XbsSKiCiUieaJtS8WZ/ xY3MM/GFX7JDr5qU6bgLxGuzNA6VjvZKZIR8HVi13IkfeDjox4JFaVkpRZCvZRArPcy9 e6M/62QMBaRvHwFTQVw6oCjvS4RFz/kDpjRsE7qfowi5ycJMuLUt7npAnVtDK9GV1DXs cBig== X-Gm-Message-State: AO0yUKUr2ur4hFzzbIA8N28t1Ti064my9+qlkHCQaq0KlqCabScb3brJ GpEHKRV5HwqAoooObjDn/QjgKRdoUar9u7Qc X-Google-Smtp-Source: AK7set++90ycix9cZzbhlxwpM0aa5o3kZigFXVm8NvbasN6o0DSRRRGeWQRT+ib10MYcw485qzb4pw== X-Received: by 2002:a92:740e:0:b0:315:375c:dc62 with SMTP id p14-20020a92740e000000b00315375cdc62mr13555237ilc.29.1677293430056; Fri, 24 Feb 2023 18:50:30 -0800 (PST) Received: from localhost (137-025-033-021.res.spectrum.com. [137.25.33.21]) by smtp.gmail.com with ESMTPSA id w4-20020a029684000000b003c4e9b78e0asm180046jai.2.2023.02.24.18.50.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 18:50:29 -0800 (PST) From: Benjamin Li To: linux-gpio@vger.kernel.org, Bartosz Golaszewski Cc: Benjamin Li Subject: [libgpiod,1/2] tools: use getprogname() when available to remove dependency on glibc Date: Fri, 24 Feb 2023 18:50:21 -0800 Message-Id: <20230225025022.3871665-2-benl@squareup.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230225025022.3871665-1-benl@squareup.com> References: <20230225025022.3871665-1-benl@squareup.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Platforms like Bionic libc don't have program_invocation_[short_]name, which is a GNU extension. Use getprogname() from stdlib.h, another widely agreed extension, when it's available. It seemed a little heavyweight to add gnulib to this project's autotools set-up just for making one function portable, so I've just added the portabilty shim to tools-common.c for the moment. --- configure.ac | 11 ++++++++--- tools/gpiodetect.c | 4 ++-- tools/gpioget.c | 4 ++-- tools/gpioinfo.c | 4 ++-- tools/gpiomon.c | 4 ++-- tools/gpionotify.c | 4 ++-- tools/gpioset.c | 4 ++-- tools/tools-common.c | 16 +++++++++------- tools/tools-common.h | 4 +++- 9 files changed, 32 insertions(+), 23 deletions(-) diff --git a/configure.ac b/configure.ac index 0a56074..7a77151 100644 --- a/configure.ac +++ b/configure.ac @@ -117,9 +117,14 @@ AM_CONDITIONAL([WITH_GPIOSET_INTERACTIVE], AS_IF([test "x$with_tools" = xtrue], [# These are only needed to build tools AC_CHECK_FUNC([daemon], [], [FUNC_NOT_FOUND_TOOLS([daemon])]) - AC_CHECK_FUNC([asprintf], [], [FUNC_NOT_FOUND_LIB([asprintf])]) - AC_CHECK_FUNC([scandir], [], [FUNC_NOT_FOUND_LIB([scandir])]) - AC_CHECK_FUNC([alphasort], [], [FUNC_NOT_FOUND_LIB([alphasort])]) + AC_CHECK_FUNC([asprintf], [], [FUNC_NOT_FOUND_TOOLS([asprintf])]) + AC_CHECK_FUNC([scandir], [], [FUNC_NOT_FOUND_TOOLS([scandir])]) + AC_CHECK_FUNC([alphasort], [], [FUNC_NOT_FOUND_TOOLS([alphasort])]) + AC_CHECK_FUNC([getprogname], + [AC_DEFINE([HAVE_GETPROGNAME], 1, [Define to 1 if getprogname() is available.])], + [AC_CHECK_DECL([program_invocation_short_name], [], + [FUNC_NOT_FOUND_TOOLS([getprogname or program_invocation_short_name])], + [#include ])]) AS_IF([test "x$with_gpioset_interactive" = xtrue], [PKG_CHECK_MODULES([LIBEDIT], [libedit >= 3.1])]) ]) diff --git a/tools/gpiodetect.c b/tools/gpiodetect.c index f0211da..f5bdc01 100644 --- a/tools/gpiodetect.c +++ b/tools/gpiodetect.c @@ -12,7 +12,7 @@ static void print_help(void) { - printf("Usage: %s [OPTIONS] [chip]...\n", get_progname()); + printf("Usage: %s [OPTIONS] [chip]...\n", getprogname()); printf("\n"); printf("List GPIO chips, print their labels and number of GPIO lines.\n"); printf("\n"); @@ -51,7 +51,7 @@ static int parse_config(int argc, char **argv) print_version(); exit(EXIT_SUCCESS); case '?': - die("try %s --help", get_progname()); + die("try %s --help", getprogname()); default: abort(); } diff --git a/tools/gpioget.c b/tools/gpioget.c index 08c17e6..43abdf0 100644 --- a/tools/gpioget.c +++ b/tools/gpioget.c @@ -26,7 +26,7 @@ struct config { static void print_help(void) { - printf("Usage: %s [OPTIONS] ...\n", get_progname()); + printf("Usage: %s [OPTIONS] ...\n", getprogname()); printf("\n"); printf("Read values of GPIO lines.\n"); printf("\n"); @@ -120,7 +120,7 @@ static int parse_config(int argc, char **argv, struct config *cfg) print_version(); exit(EXIT_SUCCESS); case '?': - die("try %s --help", get_progname()); + die("try %s --help", getprogname()); case 0: break; default: diff --git a/tools/gpioinfo.c b/tools/gpioinfo.c index 1ec7f63..960f661 100644 --- a/tools/gpioinfo.c +++ b/tools/gpioinfo.c @@ -20,7 +20,7 @@ struct config { static void print_help(void) { - printf("Usage: %s [OPTIONS] [line]...\n", get_progname()); + printf("Usage: %s [OPTIONS] [line]...\n", getprogname()); printf("\n"); printf("Print information about GPIO lines.\n"); printf("\n"); @@ -83,7 +83,7 @@ static int parse_config(int argc, char **argv, struct config *cfg) print_version(); exit(EXIT_SUCCESS); case '?': - die("try %s --help", get_progname()); + die("try %s --help", getprogname()); case 0: break; default: diff --git a/tools/gpiomon.c b/tools/gpiomon.c index 93ff463..69ec2c1 100644 --- a/tools/gpiomon.c +++ b/tools/gpiomon.c @@ -34,7 +34,7 @@ struct config { static void print_help(void) { - printf("Usage: %s [OPTIONS] ...\n", get_progname()); + printf("Usage: %s [OPTIONS] ...\n", getprogname()); printf("\n"); printf("Wait for events on GPIO lines and print them to standard output.\n"); printf("\n"); @@ -195,7 +195,7 @@ static int parse_config(int argc, char **argv, struct config *cfg) print_version(); exit(EXIT_SUCCESS); case '?': - die("try %s --help", get_progname()); + die("try %s --help", getprogname()); case 0: break; default: diff --git a/tools/gpionotify.c b/tools/gpionotify.c index a0976f7..9242ae8 100644 --- a/tools/gpionotify.c +++ b/tools/gpionotify.c @@ -27,7 +27,7 @@ struct config { static void print_help(void) { - printf("Usage: %s [OPTIONS] ...\n", get_progname()); + printf("Usage: %s [OPTIONS] ...\n", getprogname()); printf("\n"); printf("Wait for changes to info on GPIO lines and print them to standard output.\n"); printf("\n"); @@ -144,7 +144,7 @@ static int parse_config(int argc, char **argv, struct config *cfg) print_version(); exit(EXIT_SUCCESS); case '?': - die("try %s --help", get_progname()); + die("try %s --help", getprogname()); case 0: break; default: diff --git a/tools/gpioset.c b/tools/gpioset.c index a7084a3..291f727 100644 --- a/tools/gpioset.c +++ b/tools/gpioset.c @@ -36,7 +36,7 @@ struct config { static void print_help(void) { - printf("Usage: %s [OPTIONS] ...\n", get_progname()); + printf("Usage: %s [OPTIONS] ...\n", getprogname()); printf("\n"); printf("Set values of GPIO lines.\n"); printf("\n"); @@ -212,7 +212,7 @@ static int parse_config(int argc, char **argv, struct config *cfg) print_version(); exit(EXIT_SUCCESS); case '?': - die("try %s --help", get_progname()); + die("try %s --help", getprogname()); case 0: break; default: diff --git a/tools/tools-common.c b/tools/tools-common.c index 0a54571..67530a9 100644 --- a/tools/tools-common.c +++ b/tools/tools-common.c @@ -20,17 +20,19 @@ #include "tools-common.h" -const char *get_progname(void) +#ifndef HAVE_GETPROGNAME +const char *getprogname(void) { - return program_invocation_name; + return program_invocation_short_name; } +#endif void print_error(const char *fmt, ...) { va_list va; va_start(va, fmt); - fprintf(stderr, "%s: ", program_invocation_name); + fprintf(stderr, "%s: ", getprogname()); vfprintf(stderr, fmt, va); fprintf(stderr, "\n"); va_end(va); @@ -41,7 +43,7 @@ void print_perror(const char *fmt, ...) va_list va; va_start(va, fmt); - fprintf(stderr, "%s: ", program_invocation_name); + fprintf(stderr, "%s: ", getprogname()); vfprintf(stderr, fmt, va); fprintf(stderr, ": %s\n", strerror(errno)); va_end(va); @@ -52,7 +54,7 @@ void die(const char *fmt, ...) va_list va; va_start(va, fmt); - fprintf(stderr, "%s: ", program_invocation_name); + fprintf(stderr, "%s: ", getprogname()); vfprintf(stderr, fmt, va); fprintf(stderr, "\n"); va_end(va); @@ -65,7 +67,7 @@ void die_perror(const char *fmt, ...) va_list va; va_start(va, fmt); - fprintf(stderr, "%s: ", program_invocation_name); + fprintf(stderr, "%s: ", getprogname()); vfprintf(stderr, fmt, va); fprintf(stderr, ": %s\n", strerror(errno)); va_end(va); @@ -76,7 +78,7 @@ void die_perror(const char *fmt, ...) void print_version(void) { printf("%s (libgpiod) v%s\n", - program_invocation_short_name, gpiod_api_version()); + getprogname(), gpiod_api_version()); printf("Copyright (C) 2017-2023 Bartosz Golaszewski\n"); printf("License: GPL-2.0-or-later\n"); printf("This is free software: you are free to change and redistribute it.\n"); diff --git a/tools/tools-common.h b/tools/tools-common.h index 434e5ba..3aebef0 100644 --- a/tools/tools-common.h +++ b/tools/tools-common.h @@ -78,7 +78,9 @@ struct line_resolver { struct resolved_line lines[]; }; -const char *get_progname(void); +#ifndef HAVE_GETPROGNAME +const char *getprogname(void); +#endif void print_error(const char *fmt, ...) PRINTF(1, 2); void print_perror(const char *fmt, ...) PRINTF(1, 2); void die(const char *fmt, ...) NORETURN PRINTF(1, 2); From patchwork Sat Feb 25 02:50:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Li X-Patchwork-Id: 656668 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87405C64ED8 for ; Sat, 25 Feb 2023 02:50:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229572AbjBYCuf (ORCPT ); Fri, 24 Feb 2023 21:50:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjBYCuf (ORCPT ); Fri, 24 Feb 2023 21:50:35 -0500 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F8FF36699 for ; Fri, 24 Feb 2023 18:50:34 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id b16so921785iln.3 for ; Fri, 24 Feb 2023 18:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squareup.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TKKEYQoCM0g01h3qkxIdgeyEK1Tl9v//zTRgithkokY=; b=O1V0hV6RDlHbCpR+s/45Ooj/5xygVpSzYkf6SGJWxqmpjYKGrKr4hh5hzC/FcapVfR ZZYSwyQhSsmb7DK3c9+nzjUaS4zn3DAiRpa6VeveqxEQTU9+KWyQiLlGJkszJW+sHCNj LXefvWuPfEDlHE700ztYT+FFiRr+2F3+uY+ok= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TKKEYQoCM0g01h3qkxIdgeyEK1Tl9v//zTRgithkokY=; b=312HHxRD3UsejB3cMF0IupYRPaBzeg5V7aLkk8FKYspUSbauK24DnSO1xgnurXktGB FLWuk3B2T/HiGtv09qczbaLc7HVyFNZtZ2hAbLL+m/ELXgFapl27K6vghEk5cB3FudUm qjLKQkyyiDAhP/fLRCrmncpmDL+9CZcozxiFyy8cqC0f8naYvMWf3EIJmZXC4xCX9ufD mxoC4t05p+yqxsmncNySS5fcVmke5PFXKFGF/YRMBTSq8onwXZ4hgRynScW4pMeqPULf 0qezWeJjCnMLTiXwLqUSf01fnyiaLqxhssfcKkP+VDbeGarwyyc3/HrtqMNapNxKzqXt 12FQ== X-Gm-Message-State: AO0yUKURMn/NYjdqG43JZwHcCPg2FHzegNg4uOW5z6VCsiN/v6zxKj9z pZL9LjFFPoIPSe09ey1iaiVKdNghsDgP9/uZ X-Google-Smtp-Source: AK7set+jX56UHIMzsUJ/c9/bwMsxIcrLTAG49sJZKbGvNoMwnuZSm9bELQKzXaQRUWCiZVFaQFUXog== X-Received: by 2002:a05:6e02:1051:b0:317:34d1:e4dc with SMTP id p17-20020a056e02105100b0031734d1e4dcmr448553ilj.23.1677293433098; Fri, 24 Feb 2023 18:50:33 -0800 (PST) Received: from localhost (137-025-033-021.res.spectrum.com. [137.25.33.21]) by smtp.gmail.com with ESMTPSA id j19-20020a02a693000000b003c4e02148e5sm169966jam.53.2023.02.24.18.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 18:50:32 -0800 (PST) From: Benjamin Li To: linux-gpio@vger.kernel.org, Bartosz Golaszewski Cc: Benjamin Li Subject: [libgpiod,2/2] build: add Android.bp to build within Android tree Date: Fri, 24 Feb 2023 18:50:22 -0800 Message-Id: <20230225025022.3871665-3-benl@squareup.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230225025022.3871665-1-benl@squareup.com> References: <20230225025022.3871665-1-benl@squareup.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Add an Android.bp file for Soong, the Android build system, to build the library including C++ bindings along with all the CLI tools. --- Android.bp | 129 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 129 insertions(+) create mode 100644 Android.bp diff --git a/Android.bp b/Android.bp new file mode 100644 index 0000000..55ddcc8 --- /dev/null +++ b/Android.bp @@ -0,0 +1,129 @@ +// +// libgpiod main library +// + +cc_library { + name: "libgpiod", + defaults: [ + "libgpiod_defaults", + ], + srcs: [ + "lib/*.c", + "bindings/cxx/*.cpp", + ], + export_include_dirs: [ + "include", + // Not great to mix sources and includes in this dir. + "bindings/cxx", + ], +} + +cc_defaults { + name: "libgpiod_defaults", + device_specific: true, + cpp_std: "gnu++17", + cflags: [ + "-DGPIOD_VERSION_STR=\"2.0-rc3\"", + "-DHAVE_GETPROGNAME=1", + ], + cppflags: [ + // Google C++ style is to not use exceptions, but this library does + // use them. + "-fexceptions", + ], + // Google C++ style is to not use runtime type information, but this + // library does use it. + rtti: true, +} + +// +// libgpiod tools +// + +phony { + name: "libgpiod_tools", + required: [ + "gpiodetect", + "gpioget", + "gpioinfo", + "gpiomon", + "gpionotify", + "gpioset", + ], +} + +cc_binary { + name: "gpiodetect", + defaults: [ + "libgpiod_defaults", + "libgpiod_tools_defaults", + ], + srcs: [ + "tools/gpiodetect.c", + ], +} + +cc_binary { + name: "gpioget", + defaults: [ + "libgpiod_defaults", + "libgpiod_tools_defaults", + ], + srcs: [ + "tools/gpioget.c", + ], +} + +cc_binary { + name: "gpioinfo", + defaults: [ + "libgpiod_defaults", + "libgpiod_tools_defaults", + ], + srcs: [ + "tools/gpioinfo.c", + ], +} + +cc_binary { + name: "gpiomon", + defaults: [ + "libgpiod_defaults", + "libgpiod_tools_defaults", + ], + srcs: [ + "tools/gpiomon.c", + ], +} + +cc_binary { + name: "gpionotify", + defaults: [ + "libgpiod_defaults", + "libgpiod_tools_defaults", + ], + srcs: [ + "tools/gpionotify.c", + ], +} + +cc_binary { + name: "gpioset", + defaults: [ + "libgpiod_defaults", + "libgpiod_tools_defaults", + ], + srcs: [ + "tools/gpioset.c", + ], +} + +cc_defaults { + name: "libgpiod_tools_defaults", + srcs: [ + "tools/tools-common.c", + ], + shared_libs: [ + "libgpiod", + ], +}