From patchwork Sat Feb 25 09:48:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 656546 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1364802wrb; Sat, 25 Feb 2023 01:50:24 -0800 (PST) X-Google-Smtp-Source: AK7set/JfnFQrnnwTQUMesEjX8sW/qTfLskBKRU2yR0hMOd42mpH1gMcfXT5muZOdKQddlxSlRsl X-Received: by 2002:a05:6214:19cf:b0:535:1d24:2c5a with SMTP id j15-20020a05621419cf00b005351d242c5amr31416586qvc.31.1677318623923; Sat, 25 Feb 2023 01:50:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677318623; cv=none; d=google.com; s=arc-20160816; b=rlICLcQ9imRMIfq+z0LYCQ4Yfh+oU/h1K/q5mZ/aXgwwuJ4OGRsIJrwWv/Gi39u1ZY CN5nl6EvSf78NEHgWEP+k8lsmnX0/ezYnWUr38C2RxWXR6LsV8+rHNV90xuHfBRS5mfD LvS8fsnx+y5rK36KFZ29yoTryxfrFbpa2/CsAhbJgV29mAR57lEKSrUjVUnH1iZfHZFo Mvjn5jBFLjmr2nqkpBgzPMD9qSBp6RqxOgU0WiLB5CIUKWrHUHGq4xg34isTsIjz3+G9 G229o6qr+09VZUCpZ6qGfqN5YnWrrUtZMFbFcwflYbvD1hZqZ1zcG3I5+ndQyc9ULLBX o6CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=246xagcTsnQ1kTR2FWcWjuRTykOQzJVC1A3AAvRLwWQ=; b=LFMzZKlPAncXm9IjqF0AnV4d724kOMkECnfxa6TTN9/3QeNzyOI6TvD3LwYdXTR2iq UjSbvH7ZDgF/gmB2IshU6mReE5BCZv698uQtanJ27tFmlk2OhAHKqKwqQx6E3LHUq540 Xow0szVfQwfHOcBlXJlc0folR8Oge9pvS6warwv2kgwUOWnRF2BNGn+gTlG3zH1uwirm X3sUDK9rDqx6ZhLqykofIpV9X9MOXQWgVW8Cgh01UMR+QPVWxZ8xe9cF1amXrzTPGLDY K4yltfbF9tl1c9LUCQb+sTj9/+XJmp6BgDQB8zXpcm8R+GOnJ77m74gBhT5XZzrcd2p7 UbDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nVdAtlkX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 29-20020a05620a049d00b0073ba88f6edbsi1410983qkr.80.2023.02.25.01.50.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2023 01:50:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nVdAtlkX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVrB8-0008I6-1T; Sat, 25 Feb 2023 04:49:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVrB6-0008HP-7l for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:49:16 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVrB4-0000M8-LV for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:49:16 -0500 Received: by mail-wm1-x336.google.com with SMTP id p16so1284670wmq.5 for ; Sat, 25 Feb 2023 01:49:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=246xagcTsnQ1kTR2FWcWjuRTykOQzJVC1A3AAvRLwWQ=; b=nVdAtlkXPxM3OTiTLluZqNrT9rsJrlRpDUlsPdLxxr/oi9GEUwB7p8iaPwZAeg4hvR MCrPBAfbj5mI+XwrwIdCwfjJh3/k1Vc6RyM5Gx9IzW2R928zYz8EHz8fTN+uzxJc8PKj ZNvKn77NdUbOibDbUZpPEajIegG7gXUA3DhjwxL1FproHY9LuzNvraMYTnT6Lm7+5+/+ YYhUmR9TdZtcKaxcAq6n/nqokxF3nfT2IaPMOa+eaYOR4OADOphqBam+oaoRAiZgzAaZ Z3DPpcnVfV/p1mOVvQMT1NdgTg7ppfbtx0zFQ5i+DY+OlvK87OxyNVzc+76S/PzPddD9 FwuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=246xagcTsnQ1kTR2FWcWjuRTykOQzJVC1A3AAvRLwWQ=; b=bfgt8V9n9M9ybId79bItnS6k/4Xzf0Sfka9OKJ3y1FE3Nimojr8cVWqbs+ATE7Fapb SxE4U0XmOcqI/IvTkXOWPUUKHHpTAydz1+GcK+eRORMlVd8hldOg4qGRFyy8dLsvs0NF KgS7ns1hXj1zQH+3DBV1QiqWvR4vNFDphUyHKGwBiiiNzvv4jk/Z6/2+dcuGxYoP3fxz eYyegSdCMS3xjSr9jXi5RyYMXRuqM0chpEnWoaY3TB0Wr5VNnNlFSb0ntR4oVfKs+hZz 5QU2dj5zqMMkKvL8mGZuBipeulfNL/HbNYYeWHMzz7IZWVaMhnB0JYwqPLZUh98mSLPO 8kew== X-Gm-Message-State: AO0yUKW1GYvsDJWue+k/5MeR8Y22A0mOC0S3RzRV6z+1z1PHD2bpOgH+ KLkNCnJ/kg7DbDDmdoGiho/gj3OuIb+qoFrvNoc= X-Received: by 2002:a05:600c:44d2:b0:3ea:4af0:3475 with SMTP id f18-20020a05600c44d200b003ea4af03475mr7090621wmo.1.1677318553043; Sat, 25 Feb 2023 01:49:13 -0800 (PST) Received: from localhost.localdomain (120.red-95-127-35.staticip.rima-tde.net. [95.127.35.120]) by smtp.gmail.com with ESMTPSA id r14-20020adff70e000000b002c567881dbcsm1292986wrp.48.2023.02.25.01.49.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 25 Feb 2023 01:49:12 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Janosch Frank , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v6 1/5] dump: Replace tswapN() -> cpu_to_dumpN() Date: Sat, 25 Feb 2023 10:48:59 +0100 Message-Id: <20230225094903.53167-2-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230225094903.53167-1-philmd@linaro.org> References: <20230225094903.53167-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org All uses of tswap in that file are wrong, and should be using cpu_to_dumpN, which correctly tests the endianness of the output. Reported-by: Richard Henderson Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- dump/dump.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dump/dump.c b/dump/dump.c index 1362810991..0ab229e5e9 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -907,13 +907,13 @@ static void get_note_sizes(DumpState *s, const void *note, if (dump_is_64bit(s)) { const Elf64_Nhdr *hdr = note; note_head_sz = sizeof(Elf64_Nhdr); - name_sz = tswap64(hdr->n_namesz); - desc_sz = tswap64(hdr->n_descsz); + name_sz = cpu_to_dump64(s, hdr->n_namesz); + desc_sz = cpu_to_dump64(s, hdr->n_descsz); } else { const Elf32_Nhdr *hdr = note; note_head_sz = sizeof(Elf32_Nhdr); - name_sz = tswap32(hdr->n_namesz); - desc_sz = tswap32(hdr->n_descsz); + name_sz = cpu_to_dump32(s, hdr->n_namesz); + desc_sz = cpu_to_dump32(s, hdr->n_descsz); } if (note_head_size) { From patchwork Sat Feb 25 09:49:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 656544 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1364630wrb; Sat, 25 Feb 2023 01:49:46 -0800 (PST) X-Google-Smtp-Source: AK7set86AP5UHbMxPDMMDqclYfqCA9pCsMob4ZuVFClNT/y/vgR9deABw+je/vgVMaugEAyYfSki X-Received: by 2002:a05:622a:4d:b0:3b0:e83e:4331 with SMTP id y13-20020a05622a004d00b003b0e83e4331mr35275014qtw.44.1677318586739; Sat, 25 Feb 2023 01:49:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677318586; cv=none; d=google.com; s=arc-20160816; b=JzVleqHPY9Pt/hZrpkiGArT2L5HXZIornTn4bQSwh1uhS8v6kfamWV7fihfk4voYlS ZUhUM/wBHmls8sX6Gevs+Y2yGZ7RSkvpft86bbB+xULHolleqiBsg6I6TD5V8cAXB7gB Mlc57SnSG26bvgl+OoBKUiUuH3Md25bKzp9LkWag1XQ5yNzxR904f3ofqaA4CkTXgQVs TcNA5NwtMKQTy4plQpyU8wjVL3XcBawR1Hz4YLXmVRw8dXzyiS+hrIDXWeTOAJb5kJ9x E4n5Z4Z5Vm2CnuVwXbtmvn3+cC1WoiijTgyHFB+wADT/FWVw3VjuxWwa1n8lKsLUBYVS ypUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CfMvlZ8pAKruenJ/ugwQdJE7H5ZPrvj71nw3+8tK1yc=; b=aTIHg0mUHB8gcktAUt8gS77wsm5NnGCqKutw0EVjtD9rT3AVwaWU7FIMq7mQB146mC uc2VdrraRXe0wq128gthcJ6nk8s6cpIvMrh7vcuSMJD5poAjG2/UHwMLu7TteghIYIk5 6/92enQWi0YORnOj8H5Eay9uYcCPxWuH4W9e4V+gEhjtrqkXZdvPXHnUpGY7f1ebOmod r4UTWZBiDqY3PZ7tCrZ56pbbex1oXgQ9iiLIhEp/JSiCn3qbNOlxZs5jcmyTIbYoz+7w JfUO7hc3X3qXht3Q4gwYYY80wojS2sCPV9G2WPCI7+Im8P9tSp0f10SQBoBwNo4XNj7q IZcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CDqLZRel; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j5-20020a05620a410500b00742427a562esi1523464qko.290.2023.02.25.01.49.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2023 01:49:46 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CDqLZRel; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVrBD-0008Iu-Lf; Sat, 25 Feb 2023 04:49:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVrBC-0008Id-F1 for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:49:22 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVrBA-0000N7-TJ for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:49:22 -0500 Received: by mail-wr1-x431.google.com with SMTP id 6so1536685wrb.11 for ; Sat, 25 Feb 2023 01:49:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CfMvlZ8pAKruenJ/ugwQdJE7H5ZPrvj71nw3+8tK1yc=; b=CDqLZRel53fBCuqBD5TvO1kIRRfT06GYX4K5bGYyc3XhsQfsqTVMwAgfNztGX2CqEE x0N4+Shg2G/iLa4fHC5G2G/aqXXWtxCwVuUU6EgdxvcjDqCkX77lrccQIVFKl0U38ubH aOpJpKKUeZNNe0FHEbhQtghC29hPnVEr38anju5uSqApRmALeHwlD2HplUv6zcwTjss9 iroL/OpLabskX72v8fKku1+UygyJS6+rfGqNRU/3YyqBiM9/4dyYDzK/pNtTm+tHT6av vIJEBirumoP0Ueb611abK+UBLjtdEBm2q0QkdaVSvQTpuFttE8VBlWXRxQSihICU8LeW t0wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CfMvlZ8pAKruenJ/ugwQdJE7H5ZPrvj71nw3+8tK1yc=; b=D/Vp+U/Y+n4aatQAcngs+aS3AI9kae3sXH/WdsK9tjWprZzaTUm48Zyv0soHN7wC9a dqdZF72rZNZXyhcYcBC1BtOLRXkYBjPoq4SXVaxS5NbRCWyQ/c7oEozqAteMdNVUvkmQ DT/CPyygAP4xyurk8T3BA2uh3YSNFoGjbZthfj24KFjHj0E9l5e6vbAsI/UcgfgmLAPb XkQRv7eH/G6ULfP5GPsh1wg4PdA7TecKOK1Zaon1rrMDUx7BET4nX9rOzYz+1pwvblb9 MlZiSB4QJ9lZAi1LSS1PQSLZXvN4U8THPB9MDeSwKwwN6J1+HnZ5pRQJcgqgoi0Lfjn/ V6Rg== X-Gm-Message-State: AO0yUKUN2WibpLuP96X06MReFtqA69TtP9e4B/wtuK6famzaraqGZrez WBccqjsxNQILBzloBq6+W9Cl0g7dPvWIUFmNs1M= X-Received: by 2002:adf:e64d:0:b0:2c5:6cfe:aabf with SMTP id b13-20020adfe64d000000b002c56cfeaabfmr16522143wrn.9.1677318559382; Sat, 25 Feb 2023 01:49:19 -0800 (PST) Received: from localhost.localdomain (120.red-95-127-35.staticip.rima-tde.net. [95.127.35.120]) by smtp.gmail.com with ESMTPSA id k18-20020a056000005200b002c54c7153f0sm1344425wrx.1.2023.02.25.01.49.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 25 Feb 2023 01:49:19 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Janosch Frank , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v6 2/5] dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size() Date: Sat, 25 Feb 2023 10:49:00 +0100 Message-Id: <20230225094903.53167-3-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230225094903.53167-1-philmd@linaro.org> References: <20230225094903.53167-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org TARGET_PAGE_SIZE is target specific. In preparation of making dump.c target-agnostic, replace the compile-time TARGET_PAGE_SIZE definition by runtime qemu_target_page_size(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- dump/dump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dump/dump.c b/dump/dump.c index 0ab229e5e9..4d68a74ffa 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -15,6 +15,7 @@ #include "qemu/cutils.h" #include "elf.h" #include "exec/hwaddr.h" +#include "exec/target_page.h" #include "monitor/monitor.h" #include "sysemu/kvm.h" #include "sysemu/dump.h" @@ -1860,7 +1861,7 @@ static void dump_init(DumpState *s, int fd, bool has_format, } if (!s->dump_info.page_size) { - s->dump_info.page_size = TARGET_PAGE_SIZE; + s->dump_info.page_size = qemu_target_page_size(); } s->note_size = cpu_get_note_size(s->dump_info.d_class, From patchwork Sat Feb 25 09:49:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 656547 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1364829wrb; Sat, 25 Feb 2023 01:50:29 -0800 (PST) X-Google-Smtp-Source: AK7set8V0PhbDeUwjECh9Ddeg1+mLiNqAnf3rXKot+8SVdM4pzeYIIdl0HujkT000KlTLV/vX66T X-Received: by 2002:ac8:5b06:0:b0:3b8:3a7c:d204 with SMTP id m6-20020ac85b06000000b003b83a7cd204mr15701382qtw.58.1677318629304; Sat, 25 Feb 2023 01:50:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677318629; cv=none; d=google.com; s=arc-20160816; b=JQQR0e89LWgqsNXGCAK62hh0SY+qrXLDwO6DNLVvw4b2ztwVIUYFScJZ/yQaxGLOZH BMzzn3jlJVcCb3ZaW7d7PBKRV6qccFVXIswGpR8JJRdVZAzgAyPMlgqtuLYwSE1T2cZk OxtZjsj5Wqk15ZGHazHAOyKX6d5cDNMYIkGUADvUJpfNOBjmfJ4mB6KRbAjOg3KulRBu 26I+qr+tmfOQ1iWWKBQyVb1WUH+zcKWN0FTDHrzVszK+05yRdkRaYyU7yaR3ixcm95MS N+XwSPIG+ZreBjs63io5Csmv/vYpw73Is9xvV/8RWldZ5wBCNyMof4uSOOc7SOOfYQrL MOaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hUi5JZWgtGe/HPtd1a91JzPK7NOPEzO7wKibYvhikkw=; b=brfGWqu1UUeRr/IdxWerUMVMoVizgHh8u1VT4LTyMiIfTGz7eQN6kvVmzuSHz5/La6 e6kJvNi4P/nEHTD4Irh0yt+eAvdUtdAR4taHgMxH68pVTXqaG+pFgxssXIrDU9x+qIiR RdDlqJqQF+zL+mNtGjqeQ6batkyMNd9Zxh0zcfUoocodt68bfvQXW5eB6yKED7Coep/3 JVYGSmmWciYiJCTtrb+5lbji1Evr61M0McVmulyg3y6B4NREctVl8GtawNEv6AYmUkpt BBPxi0BSxyA1h22YPqC7vhKcvxMupKH+9vTkgWdl30P9zEXZI6toX9pLl/J1s1WQR1Pd csYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FBuJLECQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id bp44-20020a05620a45ac00b00704be560b16si1596296qkb.443.2023.02.25.01.50.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2023 01:50:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FBuJLECQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVrBN-0008Sk-1O; Sat, 25 Feb 2023 04:49:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVrBK-0008MO-8P for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:49:30 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVrBI-0000Pf-JM for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:49:30 -0500 Received: by mail-wm1-x332.google.com with SMTP id m25-20020a7bcb99000000b003e7842b75f2so983770wmi.3 for ; Sat, 25 Feb 2023 01:49:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hUi5JZWgtGe/HPtd1a91JzPK7NOPEzO7wKibYvhikkw=; b=FBuJLECQflDxkDWSI7MQjY/AkSukimuaLC4B+b4opw6gTkCHqcSOUOvAALKqfU0G2B OJ/WkrUfYNFFeg+/pZl79M7KxhtapXH9ynLjh3z+FiH/xQTj22KBxYmgBCLFMwfo6OTo 57ewjg2vAUry5gjzQPCJuvz3hRnf0uhU3GruD/OGhlTB76CR5EVcZTgySeRaVVGEmbwE LuUbrNB+2+jcqCbCkx45YbuVowUyiumRhEiEAjq/30qxhuVNTmrWj4ThNxEb6fuGTG3k giil+7gi6DizPdMOtzyN6FK0ETvvzY0I4vt89vc36H7KPefU8CbGSIy1L/kl3wyLevOS IK4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hUi5JZWgtGe/HPtd1a91JzPK7NOPEzO7wKibYvhikkw=; b=luHMIm7ED9CiYSQb787aBwhFD9ir/qlfg+I2OAPxi9VLPFWzrdhTCiyJhCjccqqwrR 7+dYdfJg53oJuOpGVVBsnDySxtm9c8pgjX7GIIyxnUJIolkiIO0XeO5gIQEJU6/HHsGo 54MTDRoCYy0z8YV/eVBrINx6mdK3tolN9HS6icRavnVm3YVZQvy9NBpH7hsf1QyOmtun +RMTNdZ2MhMFVokMTBsED3OyD3c8DVYtUswznzA9fwzZ/Pfg6NSRqe1EfVKn2vNz9J9G ittX6kXIrqbvtr9cS/U1V7ASI8L2mn0MfQnhvSHXlg8lfcoS1x1uLXvL1+QUTwDjQ487 Cldw== X-Gm-Message-State: AO0yUKV/SPb4ZmMvHnyQxZnCSpS6WepJYdJDBmv9AI3yh+2mWps/SEOo CfjozzQPL7F3sX1wHYvABy7L0DDPbQ8is4Mlnl8= X-Received: by 2002:a05:600c:1898:b0:3e2:20c7:6553 with SMTP id x24-20020a05600c189800b003e220c76553mr14829622wmp.13.1677318567000; Sat, 25 Feb 2023 01:49:27 -0800 (PST) Received: from localhost.localdomain (120.red-95-127-35.staticip.rima-tde.net. [95.127.35.120]) by smtp.gmail.com with ESMTPSA id s17-20020adff811000000b002c758fe9689sm1288801wrp.52.2023.02.25.01.49.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 25 Feb 2023 01:49:26 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Janosch Frank , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v6 3/5] dump: Clean included headers Date: Sat, 25 Feb 2023 10:49:01 +0100 Message-Id: <20230225094903.53167-4-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230225094903.53167-1-philmd@linaro.org> References: <20230225094903.53167-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org "qemu/win_dump_defs.h" is only required by win_dump.c, but win_dump.h requires "sysemu/dump.h" which declares the DumpState type. Remove various unused headers. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- dump/dump-hmp-cmds.c | 2 +- dump/dump.c | 6 ++---- dump/win_dump.c | 15 +++++---------- dump/win_dump.h | 2 +- 4 files changed, 9 insertions(+), 16 deletions(-) diff --git a/dump/dump-hmp-cmds.c b/dump/dump-hmp-cmds.c index e5053b04cd..b038785fee 100644 --- a/dump/dump-hmp-cmds.c +++ b/dump/dump-hmp-cmds.c @@ -1,5 +1,5 @@ /* - * Human Monitor Interface commands + * Windows crashdump (Human Monitor Interface commands) * * This work is licensed under the terms of the GNU GPL, version 2 or later. * See the COPYING file in the top-level directory. diff --git a/dump/dump.c b/dump/dump.c index 4d68a74ffa..da63129825 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -14,22 +14,20 @@ #include "qemu/osdep.h" #include "qemu/cutils.h" #include "elf.h" -#include "exec/hwaddr.h" +#include "qemu/bswap.h" #include "exec/target_page.h" #include "monitor/monitor.h" -#include "sysemu/kvm.h" #include "sysemu/dump.h" -#include "sysemu/memory_mapping.h" #include "sysemu/runstate.h" #include "sysemu/cpus.h" #include "qapi/error.h" #include "qapi/qapi-commands-dump.h" #include "qapi/qapi-events-dump.h" #include "qapi/qmp/qerror.h" -#include "qemu/error-report.h" #include "qemu/main-loop.h" #include "hw/misc/vmcoreinfo.h" #include "migration/blocker.h" +#include "hw/core/cpu.h" #ifdef TARGET_X86_64 #include "win_dump.h" diff --git a/dump/win_dump.c b/dump/win_dump.c index f20b6051b6..ba7fa404fe 100644 --- a/dump/win_dump.c +++ b/dump/win_dump.c @@ -1,5 +1,5 @@ /* - * Windows crashdump + * Windows crashdump (target specific implementations) * * Copyright (c) 2018 Virtuozzo International GmbH * @@ -9,19 +9,14 @@ */ #include "qemu/osdep.h" -#include "qemu/cutils.h" -#include "elf.h" -#include "exec/hwaddr.h" -#include "monitor/monitor.h" -#include "sysemu/kvm.h" #include "sysemu/dump.h" -#include "sysemu/memory_mapping.h" -#include "sysemu/cpus.h" #include "qapi/error.h" #include "qapi/qmp/qerror.h" -#include "qemu/error-report.h" -#include "hw/misc/vmcoreinfo.h" +#include "exec/cpu-defs.h" +#include "hw/core/cpu.h" +#include "qemu/win_dump_defs.h" #include "win_dump.h" +#include "cpu.h" static size_t win_dump_ptr_size(bool x64) { diff --git a/dump/win_dump.h b/dump/win_dump.h index b8c25348f4..56f63683c3 100644 --- a/dump/win_dump.h +++ b/dump/win_dump.h @@ -11,7 +11,7 @@ #ifndef WIN_DUMP_H #define WIN_DUMP_H -#include "qemu/win_dump_defs.h" +#include "sysemu/dump.h" void create_win_dump(DumpState *s, Error **errp); From patchwork Sat Feb 25 09:49:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 656545 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1364714wrb; Sat, 25 Feb 2023 01:50:02 -0800 (PST) X-Google-Smtp-Source: AK7set/bJytjyQnseskJdD4h1mNiTG4hJy1xglgkYoGZ9tGxJGZ0Gh5k9cQzDtBKhDx8/ZVswnEb X-Received: by 2002:a05:622a:44f:b0:3ba:13dd:f253 with SMTP id o15-20020a05622a044f00b003ba13ddf253mr34097629qtx.7.1677318602692; Sat, 25 Feb 2023 01:50:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677318602; cv=none; d=google.com; s=arc-20160816; b=E13y1EqZjGTNfwy80jk5bY6KN7UFUiLbp9DyN6swRsGgYhm3Yjmxlx51dx0LlvPnBY zMylvtXwsMrR4L881YR0iskBIKH452+exMhcD3vmh5lIlTN+kALN4Pf2wpy1oXIAvCQ/ LrXQH4V/q4ELpcqiszj6dWj3IZ7jFKutUNAmKWfEaGX3bZr94jXlcRHlZZeViwxHAsPb RXqpQjOtJ2dcDLTLt57bwj+8wkKcwdwbIQgnvriCjHU+vU3RDBFGhziVjbUHiSD2WZq9 iOivMxzmLl+srLj1j2ILKrdhdLQav0Yw/GSOHFvJlivVBfLkmg/Vx9rarkTDBmbzaES0 G9UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ctL4KXUjEttAEhfjTfJB9VEH6H9wRZDJy/S9HVcuPtg=; b=hFgafDapaCrjFmn91ob5ie86+7Sb26CdSI/NjxLxAsFzr0pj+F20sx87Shak+OXLU1 Gdj0cS7g0rb5c6aVhsiDnXcIFDfFMhUo+RgFso1CDK0eG3dg4BHVRUQFq/YFgHEBg6Jn WPr1mlPeLCvKu3FcHcWou+ODZAEzGGL8zz62dNVHqQSDHeZx4ORIclPDc3ybLiO2SpgW k+WK1ejQnzjIBJQvhfMsrP2iBcHbYzurIzoGutnY21Ydqcr21xM4Sxln8gOTy2a1MKko ksFOBIf+IxhOqT1093wPsLwaHn2YJJjlujLnhrbcHFNeYdSoWlTcHnlQccoVM0Z7IjSR x6kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wzGN95Aa; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d5-20020ac85ac5000000b003b676a1b5edsi1741741qtd.421.2023.02.25.01.50.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2023 01:50:02 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wzGN95Aa; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVrBT-0000Sn-9m; Sat, 25 Feb 2023 04:49:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVrBQ-0000Pn-RQ for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:49:37 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVrBP-0000Qd-5V for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:49:36 -0500 Received: by mail-wm1-x330.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso487844wmb.0 for ; Sat, 25 Feb 2023 01:49:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ctL4KXUjEttAEhfjTfJB9VEH6H9wRZDJy/S9HVcuPtg=; b=wzGN95Aa/1MT179TjccGrtswYIaifT77hyyEyX0+nMR3NlGsilC20tufTphpC57Vdc IzfCOoEdv0vfbe8NYv+J9v2nPnVPxiWwHSpGbgXhiVV9hqelFDY5tHRWSVtEcYFPdvVq qZ1CPww4pkAVmngAT56shoIQVjXkgYA0VVUo5MjcHKC5t+zaPgRno5EEjL3nDJa1pjsV ii22IQxW+qSRcvSyeGBOdL+LAoQb8fF2z/w9KQPZ5bKMfvDXLNsW5OZNAVDIMjePeqth WBfYsErfXjX4yC/Kp2TbEi7KzpFtp3T8WaLDnzNPNX3E7StJFMZNfs7SGytUqxKOtwCB 9+rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ctL4KXUjEttAEhfjTfJB9VEH6H9wRZDJy/S9HVcuPtg=; b=YV4BDOR7oX+ztOzwZRO5Zw9xxad4MarQiO5rNWFIBUOR9D4Jf1B17mynWTIGLl6FT/ tozhyamKnR1yGXh4r3ewqYbC2eyOd5yAWydYRqA9uU60eVbmSw3xelmObAlVwBmVvz1l fKaz5EXjBv/16h+VBgOukFy3PeroQ2/RaIeWasneoCfOhkWP1Z2iqnl9hMyp0GxisCMV k0pds6nJZplshOazmNQI78XIPkUyodQqhUF1Qq43Fz1qjrBrJ3PZc3AjssZlx+Dq8pCk beL1xXoC7DFSM2I8YeKexg1IOeX9B50nP3Z39mg90KEQkkBtSdcjbQS0NhyOygBeTWvG lIGA== X-Gm-Message-State: AO0yUKVIdW8DTt3ydXDp1RpU37+3FBo5MHf8SrgDDpO15sKUB7uJ/yWI T0swFYNtY2fZh7Z28ZkX51qGpB3oIZNY6xp8o4I= X-Received: by 2002:a05:600c:1716:b0:3dc:5302:ad9 with SMTP id c22-20020a05600c171600b003dc53020ad9mr9320958wmn.27.1677318573284; Sat, 25 Feb 2023 01:49:33 -0800 (PST) Received: from localhost.localdomain (120.red-95-127-35.staticip.rima-tde.net. [95.127.35.120]) by smtp.gmail.com with ESMTPSA id t1-20020a5d6a41000000b002c70a68111asm1287864wrw.83.2023.02.25.01.49.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 25 Feb 2023 01:49:32 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Janosch Frank , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v6 4/5] dump: Simplify compiling win_dump.o by introducing win_dump_available() Date: Sat, 25 Feb 2023 10:49:02 +0100 Message-Id: <20230225094903.53167-5-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230225094903.53167-1-philmd@linaro.org> References: <20230225094903.53167-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org To make dump.c less target dependent, move the TARGET_X86_64 #ifdef'ry from dump.c to win_dump.c (introducing a win_dump_available() method there). By doing so we can build win_dump.c on any target, and simplify the meson rule. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- dump/dump.c | 16 +++++----------- dump/meson.build | 2 +- dump/win_dump.c | 18 ++++++++++++++++++ dump/win_dump.h | 3 +++ 4 files changed, 27 insertions(+), 12 deletions(-) diff --git a/dump/dump.c b/dump/dump.c index da63129825..fa650980d8 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -28,10 +28,7 @@ #include "hw/misc/vmcoreinfo.h" #include "migration/blocker.h" #include "hw/core/cpu.h" - -#ifdef TARGET_X86_64 #include "win_dump.h" -#endif #include #ifdef CONFIG_LZO @@ -2126,12 +2123,10 @@ void qmp_dump_guest_memory(bool paging, const char *file, } #endif -#ifndef TARGET_X86_64 - if (has_format && format == DUMP_GUEST_MEMORY_FORMAT_WIN_DMP) { - error_setg(errp, "Windows dump is only available for x86-64"); + if (has_format && format == DUMP_GUEST_MEMORY_FORMAT_WIN_DMP + && !win_dump_available(errp)) { return; } -#endif #if !defined(WIN32) if (strstart(file, "fd:", &p)) { @@ -2213,10 +2208,9 @@ DumpGuestMemoryCapability *qmp_query_dump_guest_memory_capability(Error **errp) QAPI_LIST_APPEND(tail, DUMP_GUEST_MEMORY_FORMAT_KDUMP_SNAPPY); #endif - /* Windows dump is available only if target is x86_64 */ -#ifdef TARGET_X86_64 - QAPI_LIST_APPEND(tail, DUMP_GUEST_MEMORY_FORMAT_WIN_DMP); -#endif + if (win_dump_available(NULL)) { + QAPI_LIST_APPEND(tail, DUMP_GUEST_MEMORY_FORMAT_WIN_DMP); + } return cap; } diff --git a/dump/meson.build b/dump/meson.build index 2eff29c3ea..f13b29a849 100644 --- a/dump/meson.build +++ b/dump/meson.build @@ -1,4 +1,4 @@ softmmu_ss.add(files('dump-hmp-cmds.c')) specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, lzo]) -specific_ss.add(when: ['CONFIG_SOFTMMU', 'TARGET_X86_64'], if_true: files('win_dump.c')) +specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: files('win_dump.c')) diff --git a/dump/win_dump.c b/dump/win_dump.c index ba7fa404fe..ff9c5bd339 100644 --- a/dump/win_dump.c +++ b/dump/win_dump.c @@ -18,6 +18,13 @@ #include "win_dump.h" #include "cpu.h" +#if defined(TARGET_X86_64) + +bool win_dump_available(Error **errp) +{ + return true; +} + static size_t win_dump_ptr_size(bool x64) { return x64 ? sizeof(uint64_t) : sizeof(uint32_t); @@ -470,3 +477,14 @@ out_cr3: return; } + +#else /* !TARGET_X86_64 */ + +bool win_dump_available(Error **errp) +{ + error_setg(errp, "Windows dump is only available for x86-64"); + + return false; +} + +#endif diff --git a/dump/win_dump.h b/dump/win_dump.h index 56f63683c3..c9b49f87dc 100644 --- a/dump/win_dump.h +++ b/dump/win_dump.h @@ -13,6 +13,9 @@ #include "sysemu/dump.h" +/* Check Windows dump availability for the current target */ +bool win_dump_available(Error **errp); + void create_win_dump(DumpState *s, Error **errp); #endif /* WIN_DUMP_H */ From patchwork Sat Feb 25 09:49:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 656548 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1364831wrb; Sat, 25 Feb 2023 01:50:29 -0800 (PST) X-Google-Smtp-Source: AK7set9DgH3Gcyvef/WqpW7mNv2+NX9OplDx7VEAACA8l+kHctFuTNSEI5kPhNz6fVwDnUzLOghG X-Received: by 2002:ac8:7f13:0:b0:3bc:fa1a:6032 with SMTP id f19-20020ac87f13000000b003bcfa1a6032mr20201531qtk.24.1677318629605; Sat, 25 Feb 2023 01:50:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677318629; cv=none; d=google.com; s=arc-20160816; b=vYjb1b+GkLKOrrVrK9TdspEESj/dYyZdv8yOyvtro2nzfBeQM2U6YBqqwAJC5V0X8q IjiHfucGCaWrB9UdLJJru3ng0GKN5rCZEyYmt728HfO/4aIC6vH2oO+C6yvvizYaRHZk 5+bM31zdplQPMLkFLnzu9/kzh16H8SmI1tVUmhCxGCdNXIS4D/UgFh1UuCCgsGaRgy+A 0cnHcRgiKZG8ZaVFq7g3uVh0JW7tRIdiiq9vBoQWqKuU7CByd97RBlfl2ugaCPvfD/Js ZqafI9myn1TwcfssKwrHDLAFgPo3c0GwDxTzCDuKPqmKu9FaTdKI/GU6DTZlquvMJhZV V7Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dHwEoMi3MEImb9Gq1/MR47PuMg0pIyHWlD7SUPk6AuQ=; b=ikQly9k8A26W4sfbdSlszRMgSAgyCR0Qr7u7/1AxZQK8lj577iyXVpjtaiVrmYdZnV zPzjpjQQ7e8q26GUVo591PcF25NBXSuKxWT9cr/3+IQemj1I/njdPX/NctiaBWmCm9Lx 7QISv1p/UeiKljOToDA8PEhR+HP1LaGz7VZUq1QGT+bT+dQn3uempKC772pkEjrNC0Yx 0w36mREob0H7eKyN1+UZhPpNR2cXkOWrywUXLwEKB5WIu/Qs83bfEWvaCk0cZHnqn7iE 6WyUPhR5sef4cttURyMIpjaYhYsQjdQScsOfvoiIRzYE5ZWtBh/YmmSSgjxnrYTAQ/ij AGQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h95h92uL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x9-20020a05620a258900b00721bf7bec5fsi1465627qko.441.2023.02.25.01.50.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2023 01:50:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h95h92uL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVrBc-0000cG-T6; Sat, 25 Feb 2023 04:49:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVrBV-0000TU-VB for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:49:42 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVrBU-0000Pf-CF for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:49:41 -0500 Received: by mail-wm1-x332.google.com with SMTP id m25-20020a7bcb99000000b003e7842b75f2so983948wmi.3 for ; Sat, 25 Feb 2023 01:49:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dHwEoMi3MEImb9Gq1/MR47PuMg0pIyHWlD7SUPk6AuQ=; b=h95h92uLFlFw1V3bNCihM9QJHeANSD6LhfNBL9C3rB/Z2+ZKR3hoOJ0PNgslW4bDjq QeSFw8AxHHTaRu7xo72I0YUmZ6iekZkxPovUExWkUJtihouM6R14d7EBOM/qZYiY+2tr 4l8dPVPws6P8lRHYZiOgsFJD68fykHbkdAQYhgUcF9GS2hKPpSOns7jOS2/chRFHLnhL GootXhh/HODPMpdLPXUmq5X8FfTMRfPUlx8lI2sRM3Gyl//eZvrZiWWNEWhLpRrSwtQO 2bv3+QDwKN5dfTY08yOJxYaSHhuJkB1j8nqDDUkK8aojhtPNoYX91ND9LJvMbKIiWAQo 88Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dHwEoMi3MEImb9Gq1/MR47PuMg0pIyHWlD7SUPk6AuQ=; b=eU1kaIYYqAoiOdE6X2I/2psHBVVURpPNKBtyVFhGQDpC9SVzDF9LJYeKnmrqbkMvRp iOODc+SGIX/B1i6/tURKGKeZhhjjno9U55hKIYQ9ZrrHhOxhegjId2zr5mOoHDZyFo++ ZDxxcwIUvH4bmlG6Oev/I5y9MVSY1w0NAW8LkAElkWDRYuuYcLCKIfpY4TZzscglu9ZX W6/lZFUu8m6/uxFAGc829TB4XaTB/FCTrqCW3CVipzyvPla/Vc9g0+Q8DLbLmJnzuYvw rapEDGZTuXSW/SN6vhlstlmgVjKD/Xcn1uh8bvyJWceYQxO6o7nl3T1hxQd9/JfxVJ5C wJjA== X-Gm-Message-State: AO0yUKWNfdbSjJdZVPSwv4FLyTvj93jtaN9vfPiG2Lfg0PgdWylj/Ypr HKxiPZe1HyT8BDitiAGkQPbgRqeYxTv5rHZB5Wc= X-Received: by 2002:a05:600c:a698:b0:3e2:1e31:36bc with SMTP id ip24-20020a05600ca69800b003e21e3136bcmr13408091wmb.12.1677318579469; Sat, 25 Feb 2023 01:49:39 -0800 (PST) Received: from localhost.localdomain (120.red-95-127-35.staticip.rima-tde.net. [95.127.35.120]) by smtp.gmail.com with ESMTPSA id t23-20020a1c7717000000b003daf672a616sm1976931wmi.22.2023.02.25.01.49.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 25 Feb 2023 01:49:39 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Janosch Frank , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v6 5/5] dump: Add create_win_dump() stub for non-x86 targets Date: Sat, 25 Feb 2023 10:49:03 +0100 Message-Id: <20230225094903.53167-6-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230225094903.53167-1-philmd@linaro.org> References: <20230225094903.53167-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Implement the non-x86 create_win_dump(). We can remove the last TARGET_X86_64 #ifdef'ry in dump.c, which thus becomes target-independent. Update meson accordingly. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- dump/dump.c | 2 -- dump/meson.build | 4 +--- dump/win_dump.c | 5 +++++ 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/dump/dump.c b/dump/dump.c index fa650980d8..544d5bce3a 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -2018,9 +2018,7 @@ static void dump_process(DumpState *s, Error **errp) DumpQueryResult *result = NULL; if (s->has_format && s->format == DUMP_GUEST_MEMORY_FORMAT_WIN_DMP) { -#ifdef TARGET_X86_64 create_win_dump(s, errp); -#endif } else if (s->has_format && s->format != DUMP_GUEST_MEMORY_FORMAT_ELF) { create_kdump_vmcore(s, errp); } else { diff --git a/dump/meson.build b/dump/meson.build index f13b29a849..df52ee4268 100644 --- a/dump/meson.build +++ b/dump/meson.build @@ -1,4 +1,2 @@ -softmmu_ss.add(files('dump-hmp-cmds.c')) - -specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, lzo]) +softmmu_ss.add([files('dump.c', 'dump-hmp-cmds.c'), snappy, lzo]) specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: files('win_dump.c')) diff --git a/dump/win_dump.c b/dump/win_dump.c index ff9c5bd339..0152f7330a 100644 --- a/dump/win_dump.c +++ b/dump/win_dump.c @@ -487,4 +487,9 @@ bool win_dump_available(Error **errp) return false; } +void create_win_dump(DumpState *s, Error **errp) +{ + win_dump_available(errp); +} + #endif