From patchwork Mon Feb 20 12:12:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jianhua Lu X-Patchwork-Id: 655193 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2554DC64EC4 for ; Mon, 20 Feb 2023 12:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231566AbjBTMNJ (ORCPT ); Mon, 20 Feb 2023 07:13:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230383AbjBTMNI (ORCPT ); Mon, 20 Feb 2023 07:13:08 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8232F7EC6; Mon, 20 Feb 2023 04:13:07 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id bh1so1140867plb.11; Mon, 20 Feb 2023 04:13:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vxAFz2rVLxj2kv0iP8aQ04yRu+OY9bVx6kbZibMveqI=; b=UZBGmoL/hq/IHXODoVnESRITuITuEb3YU7ByNcwDfgcWNHM4CtHLDo6qx/rDuX8tPV FZfIQS5vNFojlVjKFQ9aes2UlgnNkoTHu5qLm6jxujlaTsrX4UGRsltriHTg7sTP7uSQ 64dvYgfbU/8c3yml6lVGzvtPQD27jqV4DSgSxS3Q7aTKt2NhAaXFhmB6e0dXZmDnMlXb oDzN1O0BQSFjrOZ+8rYOu/oXCRWuZhn70/Q6HNx+CV3TgiXoSeJKbO9t/tjQWNXgjMO7 mhzfQcfDgvwz9lfPG3H2CkInD5/t+JgyZtC5HVyizN8IJDqkWJtLH7rmU+W1Jg9CH8Gh vmIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vxAFz2rVLxj2kv0iP8aQ04yRu+OY9bVx6kbZibMveqI=; b=aj42yWSMX81njOkQ9VdHspYqSFfKdBndbBcDZLZ+7EjgjWzI81MhnBRDLKfIVd1DM5 ND/EOKLdUAOG0x2cmQkJKeEMDVj13I0tcU+BjPfLN06VevilwCgNwBrwP81PI2YC7lVH p7eb8jvmWnpq+UNvTXIbEyujxzZjIUMS8U8aOJOBnM37t59RUmsx6BIq43DF0/wmPMKQ Uf8x7RWlBAjO1ls6iiPtebIliviOpC2vX3IY5uSgJjZGr5CZIy9GE5MJgmHP9eFVLjX0 kK9KLpIuyz1f3nYoIpAdDVJmm6xtFdbhZk/gSOoZvZYQc2wbleRx2pHYbA6ERSTZo30w LMaw== X-Gm-Message-State: AO0yUKW/gl1t5oKkBlHkfQBaOVS67L9n9JZRSyD6npu8lMAw166DxwQA KmeHfGeIbbHguXM362wsLkg= X-Google-Smtp-Source: AK7set8JlZ9xeDW8rXHdBvDt22y0ZTlD8dNdfbAv9PKB6i/MR6N9zGfnENMmtZ343qaZOWXOirUeQw== X-Received: by 2002:a17:90a:1da:b0:233:fa78:7c9e with SMTP id 26-20020a17090a01da00b00233fa787c9emr2790288pjd.12.1676895186906; Mon, 20 Feb 2023 04:13:06 -0800 (PST) Received: from localhost.localdomain (n220246252084.netvigator.com. [220.246.252.84]) by smtp.gmail.com with ESMTPSA id d14-20020a17090a498e00b00233790759cesm207799pjh.47.2023.02.20.04.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 04:13:06 -0800 (PST) From: Jianhua Lu To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Jianhua Lu Subject: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings Date: Mon, 20 Feb 2023 20:12:57 +0800 Message-Id: <20230220121258.10727-1-lujianhua000@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Novatek NT36523 is a display driver IC used to drive DSI panels. Signed-off-by: Jianhua Lu --- Changes in v2: - Drop unnecessary description - dsi0 -> dsi - Correct indentation .../display/panel/novatek,nt36523.yaml | 95 +++++++++++++++++++ 1 file changed, 95 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml new file mode 100644 index 000000000000..544c3c6e568b --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml @@ -0,0 +1,95 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/novatek,nt36523.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Novatek NT36523 based DSI display Panels + +maintainers: + - Jianhua Lu + +description: | + The Novatek NT36523 is a generic DSI Panel IC used to drive dsi + panels. Support video mode panels from China Star Optoelectronics + Technology (CSOT) and BOE Technology. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - enum: + - xiaomi,elish-boe-nt36523 + - xiaomi,elish-csot-nt36523 + - const: novatek,nt36523 + + reset-gpios: + maxItems: 1 + description: phandle of gpio for reset line - This should be 8mA + + vddio-supply: + description: regulator that supplies the I/O voltage + + vddpos-supply: + description: positive boost supply regulator + + vddneg-supply: + description: negative boost supply regulator + + reg: true + ports: true + backlight: true + +required: + - compatible + - reg + - vddio-supply + - vddpos-supply + - vddneg-supply + - reset-gpios + - ports + +unevaluatedProperties: false + +examples: + - | + #include + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "xiaomi,elish-csot-nt36523", "novatek,nt36523"; + reg = <0>; + vddio-supply = <&vreg_l14a_1p88>; + vddpos-supply = <&lcd_vddpos_5p5>; + vddneg-supply = <&lcd_vddneg_5p5>; + + backlight = <&backlight>; + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + panel_in_0: endpoint { + remote-endpoint = <&dsi0_out>; + }; + }; + + port@1{ + reg = <1>; + panel_in_1: endpoint { + remote-endpoint = <&dsi1_out>; + }; + }; + }; + }; + }; + +... From patchwork Mon Feb 20 12:12:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jianhua Lu X-Patchwork-Id: 655566 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9102C636CC for ; Mon, 20 Feb 2023 12:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231759AbjBTMNS (ORCPT ); Mon, 20 Feb 2023 07:13:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230383AbjBTMNR (ORCPT ); Mon, 20 Feb 2023 07:13:17 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D057869C; Mon, 20 Feb 2023 04:13:14 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id q11so1466083plx.5; Mon, 20 Feb 2023 04:13:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8egQrCUY7sOiNLe0kMyfzdxtIEbe5wvebXCfpq6G7Ck=; b=P/+FdlS23A3m3lSnegxTGmkpJaga0uxu2W0qyTk/6mhiWPRZ163yTwv6iG3BF8cSLR yL9u8S/7+lkjS7XJmEk85JyK5qjGVRLFvpZ6TU5epKWtCXNG7OBtkU/FFi8+IEXPpPzW BqfeUOBPJt0t8giGpyFGyfIMpi8mZNshufX8rXKFb4lwRNM6P8k4WiG90n4bNwGozZZd uO7Axe5NVOk1t2zqZl5f6Lu2J3frNO0SO1itTuFw+MoCNw3WfwdFYhvFhCXsH5whhfeo umv5E+/IvMCREw86z/uIGdve/MmPBtUSNQHuhEegUcp8JOijbSFlLp5uQJ0DarQn27JX kmiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8egQrCUY7sOiNLe0kMyfzdxtIEbe5wvebXCfpq6G7Ck=; b=XH40W3A5RWHaFMb+BGwxmdcu90l3PyZV8bNKSagWfO8AM+aouyUjT5af/9uhxpWO4w BCKiNnEkmLqQoESxSyerxEJx73Ni+W4MqAOgA28/KcAZV4+P2Bvh9dYDLG3FmnISE5O0 +EGEjReUbBdGon0PKCIE2D/z98ghTzT3MIB3MmQe7rwB3LadsP5C/njb+7R8p73I8xpV b75AlqGa79/DZOWdXpELZ8K6cGyoYQ84WDhCPgtzNqcUqLnj37v4z/kwcygSinalPPUi K44qgu7Wi+qfVnOci9ayINNAoj9fXeNbnt5H01hsIcWYHhglNxi7w9ZpGBPcpFGZiHHc hgcA== X-Gm-Message-State: AO0yUKU0OS4NYrrnY4YwbHuRrTaabDoF8JqICtX/ozUbT4/wtDrKlgX6 4O/vz61uZcGC+8+Oi6n7yps= X-Google-Smtp-Source: AK7set8rzVpQ0IufYoUDt4/ejUpb+ImJ98uHU97TxAWNmr4HUgo8qlTz7x1mLU5lt6NOcqqOjNi2Cw== X-Received: by 2002:a17:90b:1041:b0:234:bc98:359d with SMTP id gq1-20020a17090b104100b00234bc98359dmr3676808pjb.47.1676895193623; Mon, 20 Feb 2023 04:13:13 -0800 (PST) Received: from localhost.localdomain (n220246252084.netvigator.com. [220.246.252.84]) by smtp.gmail.com with ESMTPSA id d14-20020a17090a498e00b00233790759cesm207799pjh.47.2023.02.20.04.13.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 04:13:13 -0800 (PST) From: Jianhua Lu To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Jianhua Lu Subject: [PATCH v2 2/2] drm/panel: Add driver for Novatek NT36523 Date: Mon, 20 Feb 2023 20:12:58 +0800 Message-Id: <20230220121258.10727-2-lujianhua000@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230220121258.10727-1-lujianhua000@gmail.com> References: <20230220121258.10727-1-lujianhua000@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v2: - Refactor and clean up source code MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-novatek-nt36523.c | 832 ++++++++++++++++++ 4 files changed, 850 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36523.c diff --git a/MAINTAINERS b/MAINTAINERS index 6b91bcbbc22f..3423c6a255ff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6538,6 +6538,13 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml F: drivers/gpu/drm/panel/panel-novatek-nt35560.c +DRM DRIVER FOR NOVATEK NT36523 PANELS +M: Jianhua Lu +S: Maintained +T: git git://anongit.freedesktop.org/drm/drm-misc +F: Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml +F: drivers/gpu/drm/panel/panel-novatek-nt36523.c + DRM DRIVER FOR NOVATEK NT36672A PANELS M: Sumit Semwal S: Maintained diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 8eeee71c0000..268508743b5c 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -377,6 +377,16 @@ config DRM_PANEL_NOVATEK_NT35950 Sharp panels used in Sony Xperia Z5 Premium and XZ Premium mobile phones. +config DRM_PANEL_NOVATEK_NT36523 + tristate "Novatek NT36523 panel driver" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for the panels built + around the Novatek NT36523 display controller, such as some + Boe panels used in Xiaomi Mi Pad 5 and 5 Pro tablets. + config DRM_PANEL_NOVATEK_NT36672A tristate "Novatek NT36672A DSI panel" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index c05aa9e23907..570eab8bf2b2 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -35,6 +35,7 @@ obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3052C) += panel-newvision-nv3052c.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35950) += panel-novatek-nt35950.o +obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36523) += panel-novatek-nt36523.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36672A) += panel-novatek-nt36672a.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT39016) += panel-novatek-nt39016.o obj-$(CONFIG_DRM_PANEL_MANTIX_MLAF057WE51) += panel-mantix-mlaf057we51.o diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c new file mode 100644 index 000000000000..1516e243d98e --- /dev/null +++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c @@ -0,0 +1,832 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Novatek NT36523 DriverIC panels driver + * This driver based on the source code of panel-boe-tv101wum-nl6.c + * and panel-novatek-nt35950.c + * + * Copyright (c) 2022, 2023 Jianhua Lu + */ + +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#define DSI_NUM_MIN 1 + +struct panel_desc { + unsigned int width_mm; + unsigned int height_mm; + + unsigned int bpc; + unsigned int lanes; + unsigned long mode_flags; + enum mipi_dsi_pixel_format format; + + const struct drm_display_mode *modes; + const struct mipi_dsi_device_info dsi_info; + const struct panel_init_cmd *init_cmds; + bool is_dual_dsi; +}; + +struct panel_info { + struct drm_panel panel; + struct mipi_dsi_device *dsi[2]; + const struct panel_desc *desc; + + struct gpio_desc *reset_gpio; + struct backlight_device *backlight; + struct regulator_bulk_data supplies[3]; + + bool prepared; +}; + +enum dsi_cmd_type { + INIT_DCS_CMD, + DELAY_CMD, +}; + +struct panel_init_cmd { + enum dsi_cmd_type type; + size_t len; + const char *data; +}; + +#define _INIT_DCS_CMD(...) { \ + .type = INIT_DCS_CMD, \ + .len = sizeof((char[]){__VA_ARGS__}), \ + .data = (char[]){__VA_ARGS__} } + +#define _INIT_DELAY_CMD(...) { \ + .type = DELAY_CMD,\ + .len = sizeof((char[]){__VA_ARGS__}), \ + .data = (char[]){__VA_ARGS__} } + +static const char * const nt36523_regulator_names[] = { + "vddio", + "vddpos", + "vddneg", +}; + +static const unsigned long nt36523_regulator_enable_loads[] = { + 62000, + 100000, + 100000 +}; + +static const struct panel_init_cmd elish_boe_init_cmds[] = { + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xB9, 0x05), + _INIT_DCS_CMD(0xFF, 0x20), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x18, 0x40), + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xB9, 0x02), + _INIT_DCS_CMD(0xFF, 0x23), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x00, 0x80), + _INIT_DCS_CMD(0x01, 0x84), + _INIT_DCS_CMD(0x05, 0x2D), + _INIT_DCS_CMD(0x06, 0x00), + _INIT_DCS_CMD(0x07, 0x00), + _INIT_DCS_CMD(0x08, 0x01), + _INIT_DCS_CMD(0x09, 0x45), + _INIT_DCS_CMD(0x11, 0x02), + _INIT_DCS_CMD(0x12, 0x80), + _INIT_DCS_CMD(0x15, 0x83), + _INIT_DCS_CMD(0x16, 0x0C), + _INIT_DCS_CMD(0x29, 0x0A), + _INIT_DCS_CMD(0x30, 0xFF), + _INIT_DCS_CMD(0x31, 0xFE), + _INIT_DCS_CMD(0x32, 0xFD), + _INIT_DCS_CMD(0x33, 0xFB), + _INIT_DCS_CMD(0x34, 0xF8), + _INIT_DCS_CMD(0x35, 0xF5), + _INIT_DCS_CMD(0x36, 0xF3), + _INIT_DCS_CMD(0x37, 0xF2), + _INIT_DCS_CMD(0x38, 0xF2), + _INIT_DCS_CMD(0x39, 0xF2), + _INIT_DCS_CMD(0x3A, 0xEF), + _INIT_DCS_CMD(0x3B, 0xEC), + _INIT_DCS_CMD(0x3D, 0xE9), + _INIT_DCS_CMD(0x3F, 0xE5), + _INIT_DCS_CMD(0x40, 0xE5), + _INIT_DCS_CMD(0x41, 0xE5), + _INIT_DCS_CMD(0x2A, 0x13), + _INIT_DCS_CMD(0x45, 0xFF), + _INIT_DCS_CMD(0x46, 0xF4), + _INIT_DCS_CMD(0x47, 0xE7), + _INIT_DCS_CMD(0x48, 0xDA), + _INIT_DCS_CMD(0x49, 0xCD), + _INIT_DCS_CMD(0x4A, 0xC0), + _INIT_DCS_CMD(0x4B, 0xB3), + _INIT_DCS_CMD(0x4C, 0xB2), + _INIT_DCS_CMD(0x4D, 0xB2), + _INIT_DCS_CMD(0x4E, 0xB2), + _INIT_DCS_CMD(0x4F, 0x99), + _INIT_DCS_CMD(0x50, 0x80), + _INIT_DCS_CMD(0x51, 0x68), + _INIT_DCS_CMD(0x52, 0x66), + _INIT_DCS_CMD(0x53, 0x66), + _INIT_DCS_CMD(0x54, 0x66), + _INIT_DCS_CMD(0x2B, 0x0E), + _INIT_DCS_CMD(0x58, 0xFF), + _INIT_DCS_CMD(0x59, 0xFB), + _INIT_DCS_CMD(0x5A, 0xF7), + _INIT_DCS_CMD(0x5B, 0xF3), + _INIT_DCS_CMD(0x5C, 0xEF), + _INIT_DCS_CMD(0x5D, 0xE3), + _INIT_DCS_CMD(0x5E, 0xDA), + _INIT_DCS_CMD(0x5F, 0xD8), + _INIT_DCS_CMD(0x60, 0xD8), + _INIT_DCS_CMD(0x61, 0xD8), + _INIT_DCS_CMD(0x62, 0xCB), + _INIT_DCS_CMD(0x63, 0xBF), + _INIT_DCS_CMD(0x64, 0xB3), + _INIT_DCS_CMD(0x65, 0xB2), + _INIT_DCS_CMD(0x66, 0xB2), + _INIT_DCS_CMD(0x67, 0xB2), + _INIT_DCS_CMD(0xFF, 0x2A), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x25, 0x47), + _INIT_DCS_CMD(0x30, 0x47), + _INIT_DCS_CMD(0x39, 0x47), + _INIT_DCS_CMD(0xFF, 0x26), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x19, 0x10), + _INIT_DCS_CMD(0x1A, 0xE0), + _INIT_DCS_CMD(0x1B, 0x10), + _INIT_DCS_CMD(0x1C, 0x00), + _INIT_DCS_CMD(0x2A, 0x10), + _INIT_DCS_CMD(0x2B, 0xE0), + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xFF, 0xF0), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x84, 0x08), + _INIT_DCS_CMD(0x85, 0x0C), + _INIT_DCS_CMD(0xFF, 0x20), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x51, 0x00), + _INIT_DCS_CMD(0xFF, 0x25), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x91, 0x1F), + _INIT_DCS_CMD(0x92, 0x0F), + _INIT_DCS_CMD(0x93, 0x01), + _INIT_DCS_CMD(0x94, 0x18), + _INIT_DCS_CMD(0x95, 0x03), + _INIT_DCS_CMD(0x96, 0x01), + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0xB0, 0x01), + _INIT_DCS_CMD(0xFF, 0x25), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x19, 0x1F), + _INIT_DCS_CMD(0x1B, 0x1B), + _INIT_DCS_CMD(0xFF, 0x24), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xB8, 0x28), + _INIT_DCS_CMD(0xFF, 0x27), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xD0, 0x31), + _INIT_DCS_CMD(0xD1, 0x20), + _INIT_DCS_CMD(0xD2, 0x30), + _INIT_DCS_CMD(0xD4, 0x08), + _INIT_DCS_CMD(0xDE, 0x80), + _INIT_DCS_CMD(0xDF, 0x02), + _INIT_DCS_CMD(0xFF, 0x26), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x00, 0x81), + _INIT_DCS_CMD(0x01, 0xB0), + _INIT_DCS_CMD(0xFF, 0x22), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x9F, 0x50), + _INIT_DCS_CMD(0x6F, 0x01), + _INIT_DCS_CMD(0x70, 0x11), + _INIT_DCS_CMD(0x73, 0x01), + _INIT_DCS_CMD(0x74, 0x49), + _INIT_DCS_CMD(0x76, 0x01), + _INIT_DCS_CMD(0x77, 0x49), + _INIT_DCS_CMD(0xA0, 0x3F), + _INIT_DCS_CMD(0xA9, 0x50), + _INIT_DCS_CMD(0xAA, 0x28), + _INIT_DCS_CMD(0xAB, 0x28), + _INIT_DCS_CMD(0xAD, 0x10), + _INIT_DCS_CMD(0xB8, 0x00), + _INIT_DCS_CMD(0xB9, 0x49), + _INIT_DCS_CMD(0xBA, 0x49), + _INIT_DCS_CMD(0xBB, 0x49), + _INIT_DCS_CMD(0xBE, 0x04), + _INIT_DCS_CMD(0xBF, 0x49), + _INIT_DCS_CMD(0xC0, 0x04), + _INIT_DCS_CMD(0xC1, 0x59), + _INIT_DCS_CMD(0xC2, 0x00), + _INIT_DCS_CMD(0xC5, 0x00), + _INIT_DCS_CMD(0xC6, 0x01), + _INIT_DCS_CMD(0xC7, 0x48), + _INIT_DCS_CMD(0xCA, 0x43), + _INIT_DCS_CMD(0xCB, 0x3C), + _INIT_DCS_CMD(0xCE, 0x00), + _INIT_DCS_CMD(0xCF, 0x43), + _INIT_DCS_CMD(0xD0, 0x3C), + _INIT_DCS_CMD(0xD3, 0x43), + _INIT_DCS_CMD(0xD4, 0x3C), + _INIT_DCS_CMD(0xD7, 0x00), + _INIT_DCS_CMD(0xDC, 0x43), + _INIT_DCS_CMD(0xDD, 0x3C), + _INIT_DCS_CMD(0xE1, 0x43), + _INIT_DCS_CMD(0xE2, 0x3C), + _INIT_DCS_CMD(0xF2, 0x00), + _INIT_DCS_CMD(0xF3, 0x01), + _INIT_DCS_CMD(0xF4, 0x48), + _INIT_DCS_CMD(0xFF, 0x25), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x13, 0x01), + _INIT_DCS_CMD(0x14, 0x23), + _INIT_DCS_CMD(0xBC, 0x01), + _INIT_DCS_CMD(0xBD, 0x23), + _INIT_DCS_CMD(0xFF, 0x2A), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x97, 0x3C), + _INIT_DCS_CMD(0x98, 0x02), + _INIT_DCS_CMD(0x99, 0x95), + _INIT_DCS_CMD(0x9A, 0x03), + _INIT_DCS_CMD(0x9B, 0x00), + _INIT_DCS_CMD(0x9C, 0x0B), + _INIT_DCS_CMD(0x9D, 0x0A), + _INIT_DCS_CMD(0x9E, 0x90), + _INIT_DCS_CMD(0xFF, 0x22), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x9F, 0x50), + _INIT_DCS_CMD(0xFF, 0x23), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xA3, 0x50), + _INIT_DCS_CMD(0xFF, 0xE0), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x14, 0x60), + _INIT_DCS_CMD(0x16, 0xC0), + _INIT_DCS_CMD(0x4F, 0x02), + _INIT_DCS_CMD(0xFF, 0xF0), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x3A, 0x08), + _INIT_DCS_CMD(0xFF, 0xD0), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x02, 0xAF), + _INIT_DCS_CMD(0x09, 0xEE), + _INIT_DCS_CMD(0x1C, 0x99), + _INIT_DCS_CMD(0x1D, 0x09), + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x51, 0x0F, 0xFF), + _INIT_DCS_CMD(0x53, 0x2C), + _INIT_DCS_CMD(0x35, 0x00), + _INIT_DCS_CMD(0xBB, 0x13), + _INIT_DCS_CMD(0x3B, 0x03, 0xAC, 0x1A, 0x04, 0x04), + _INIT_DCS_CMD(0x11), + _INIT_DELAY_CMD(70), + _INIT_DCS_CMD(0x29), + {}, +}; + +static const struct panel_init_cmd elish_csot_init_cmds[] = { + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xB9, 0x05), + _INIT_DCS_CMD(0xFF, 0x20), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x18, 0x40), + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xB9, 0x02), + _INIT_DCS_CMD(0xFF, 0xD0), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x02, 0xAF), + _INIT_DCS_CMD(0x00, 0x30), + _INIT_DCS_CMD(0x09, 0xEE), + _INIT_DCS_CMD(0x1C, 0x99), + _INIT_DCS_CMD(0x1D, 0x09), + _INIT_DCS_CMD(0xFF, 0xF0), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x3A, 0x08), + _INIT_DCS_CMD(0xFF, 0xE0), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x4F, 0x02), + _INIT_DCS_CMD(0xFF, 0x20), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x58, 0x40), + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x35, 0x00), + _INIT_DCS_CMD(0xFF, 0x23), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x00, 0x80), + _INIT_DCS_CMD(0x01, 0x84), + _INIT_DCS_CMD(0x05, 0x2D), + _INIT_DCS_CMD(0x06, 0x00), + _INIT_DCS_CMD(0x07, 0x00), + _INIT_DCS_CMD(0x08, 0x01), + _INIT_DCS_CMD(0x09, 0x45), + _INIT_DCS_CMD(0x11, 0x02), + _INIT_DCS_CMD(0x12, 0x80), + _INIT_DCS_CMD(0x15, 0x83), + _INIT_DCS_CMD(0x16, 0x0C), + _INIT_DCS_CMD(0x29, 0x0A), + _INIT_DCS_CMD(0x30, 0xFF), + _INIT_DCS_CMD(0x31, 0xFE), + _INIT_DCS_CMD(0x32, 0xFD), + _INIT_DCS_CMD(0x33, 0xFB), + _INIT_DCS_CMD(0x34, 0xF8), + _INIT_DCS_CMD(0x35, 0xF5), + _INIT_DCS_CMD(0x36, 0xF3), + _INIT_DCS_CMD(0x37, 0xF2), + _INIT_DCS_CMD(0x38, 0xF2), + _INIT_DCS_CMD(0x39, 0xF2), + _INIT_DCS_CMD(0x3A, 0xEF), + _INIT_DCS_CMD(0x3B, 0xEC), + _INIT_DCS_CMD(0x3D, 0xE9), + _INIT_DCS_CMD(0x3F, 0xE5), + _INIT_DCS_CMD(0x40, 0xE5), + _INIT_DCS_CMD(0x41, 0xE5), + _INIT_DCS_CMD(0x2A, 0x13), + _INIT_DCS_CMD(0x45, 0xFF), + _INIT_DCS_CMD(0x46, 0xF4), + _INIT_DCS_CMD(0x47, 0xE7), + _INIT_DCS_CMD(0x48, 0xDA), + _INIT_DCS_CMD(0x49, 0xCD), + _INIT_DCS_CMD(0x4A, 0xC0), + _INIT_DCS_CMD(0x4B, 0xB3), + _INIT_DCS_CMD(0x4C, 0xB2), + _INIT_DCS_CMD(0x4D, 0xB2), + _INIT_DCS_CMD(0x4E, 0xB2), + _INIT_DCS_CMD(0x4F, 0x99), + _INIT_DCS_CMD(0x50, 0x80), + _INIT_DCS_CMD(0x51, 0x68), + _INIT_DCS_CMD(0x52, 0x66), + _INIT_DCS_CMD(0x53, 0x66), + _INIT_DCS_CMD(0x54, 0x66), + _INIT_DCS_CMD(0x2B, 0x0E), + _INIT_DCS_CMD(0x58, 0xFF), + _INIT_DCS_CMD(0x59, 0xFB), + _INIT_DCS_CMD(0x5A, 0xF7), + _INIT_DCS_CMD(0x5B, 0xF3), + _INIT_DCS_CMD(0x5C, 0xEF), + _INIT_DCS_CMD(0x5D, 0xE3), + _INIT_DCS_CMD(0x5E, 0xDA), + _INIT_DCS_CMD(0x5F, 0xD8), + _INIT_DCS_CMD(0x60, 0xD8), + _INIT_DCS_CMD(0x61, 0xD8), + _INIT_DCS_CMD(0x62, 0xCB), + _INIT_DCS_CMD(0x63, 0xBF), + _INIT_DCS_CMD(0x64, 0xB3), + _INIT_DCS_CMD(0x65, 0xB2), + _INIT_DCS_CMD(0x66, 0xB2), + _INIT_DCS_CMD(0x67, 0xB2), + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x51, 0x0F, 0xFF), + _INIT_DCS_CMD(0x53, 0x2C), + _INIT_DCS_CMD(0x55, 0x00), + _INIT_DCS_CMD(0xBB, 0x13), + _INIT_DCS_CMD(0x3B, 0x03, 0xAC, 0x1A, 0x04, 0x04), + _INIT_DCS_CMD(0xFF, 0x2A), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x25, 0x46), + _INIT_DCS_CMD(0x30, 0x46), + _INIT_DCS_CMD(0x39, 0x46), + _INIT_DCS_CMD(0xFF, 0x26), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x01, 0xB0), + _INIT_DCS_CMD(0x19, 0x10), + _INIT_DCS_CMD(0x1A, 0xE0), + _INIT_DCS_CMD(0x1B, 0x10), + _INIT_DCS_CMD(0x1C, 0x00), + _INIT_DCS_CMD(0x2A, 0x10), + _INIT_DCS_CMD(0x2B, 0xE0), + _INIT_DCS_CMD(0xFF, 0xF0), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x84, 0x08), + _INIT_DCS_CMD(0x85, 0x0C), + _INIT_DCS_CMD(0xFF, 0x20), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x51, 0x00), + _INIT_DCS_CMD(0xFF, 0x25), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x91, 0x1F), + _INIT_DCS_CMD(0x92, 0x0F), + _INIT_DCS_CMD(0x93, 0x01), + _INIT_DCS_CMD(0x94, 0x18), + _INIT_DCS_CMD(0x95, 0x03), + _INIT_DCS_CMD(0x96, 0x01), + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0xB0, 0x01), + _INIT_DCS_CMD(0xFF, 0x25), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x19, 0x1F), + _INIT_DCS_CMD(0x1B, 0x1B), + _INIT_DCS_CMD(0xFF, 0x24), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xB8, 0x28), + _INIT_DCS_CMD(0xFF, 0x27), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xD0, 0x31), + _INIT_DCS_CMD(0xD1, 0x20), + _INIT_DCS_CMD(0xD4, 0x08), + _INIT_DCS_CMD(0xDE, 0x80), + _INIT_DCS_CMD(0xDF, 0x02), + _INIT_DCS_CMD(0xFF, 0x26), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x00, 0x81), + _INIT_DCS_CMD(0x01, 0xB0), + _INIT_DCS_CMD(0xFF, 0x22), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x6F, 0x01), + _INIT_DCS_CMD(0x70, 0x11), + _INIT_DCS_CMD(0x73, 0x01), + _INIT_DCS_CMD(0x74, 0x4D), + _INIT_DCS_CMD(0xA0, 0x3F), + _INIT_DCS_CMD(0xA9, 0x50), + _INIT_DCS_CMD(0xAA, 0x28), + _INIT_DCS_CMD(0xAB, 0x28), + _INIT_DCS_CMD(0xAD, 0x10), + _INIT_DCS_CMD(0xB8, 0x00), + _INIT_DCS_CMD(0xB9, 0x4B), + _INIT_DCS_CMD(0xBA, 0x96), + _INIT_DCS_CMD(0xBB, 0x4B), + _INIT_DCS_CMD(0xBE, 0x07), + _INIT_DCS_CMD(0xBF, 0x4B), + _INIT_DCS_CMD(0xC0, 0x07), + _INIT_DCS_CMD(0xC1, 0x5C), + _INIT_DCS_CMD(0xC2, 0x00), + _INIT_DCS_CMD(0xC5, 0x00), + _INIT_DCS_CMD(0xC6, 0x3F), + _INIT_DCS_CMD(0xC7, 0x00), + _INIT_DCS_CMD(0xCA, 0x08), + _INIT_DCS_CMD(0xCB, 0x40), + _INIT_DCS_CMD(0xCE, 0x00), + _INIT_DCS_CMD(0xCF, 0x08), + _INIT_DCS_CMD(0xD0, 0x40), + _INIT_DCS_CMD(0xD3, 0x08), + _INIT_DCS_CMD(0xD4, 0x40), + _INIT_DCS_CMD(0xFF, 0x25), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0xBC, 0x01), + _INIT_DCS_CMD(0xBD, 0x1C), + _INIT_DCS_CMD(0xFF, 0x2A), + _INIT_DCS_CMD(0xFB, 0x01), + _INIT_DCS_CMD(0x9A, 0x03), + _INIT_DCS_CMD(0xFF, 0x10), + _INIT_DCS_CMD(0x11), + _INIT_DELAY_CMD(70), + _INIT_DCS_CMD(0x29), + {}, +}; + +static const struct drm_display_mode elish_boe_mode = { + /* Current max freqency is 104HZ, TODO 120HZ */ + .clock = (1600 + 60 + 8 + 60) * (2560 + 26 + 4 + 168) * 104 / 1000, + .hdisplay = 1600, + .hsync_start = 1600 + 60, + .hsync_end = 1600 + 60 + 8, + .htotal = 1600 + 60 + 8 + 60, + .vdisplay = 2560, + .vsync_start = 2560 + 26, + .vsync_end = 2560 + 26 + 4, + .vtotal = 2560 + 26 + 4 + 168, +}; + +static const struct drm_display_mode elish_csot_mode = { + /* Current max freqency is 104HZ, TODO 120HZ */ + .clock = (1600 + 200 + 40 + 52) * (2560 + 26 + 4 + 168) * 104 / 1000, + .hdisplay = 1600, + .hsync_start = 1600 + 200, + .hsync_end = 1600 + 200 + 40, + .htotal = 1600 + 200 + 40 + 52, + .vdisplay = 2560, + .vsync_start = 2560 + 26, + .vsync_end = 2560 + 26 + 4, + .vtotal = 2560 + 26 + 4 + 168, +}; + +static const struct panel_desc elish_boe_desc = { + .modes = &elish_boe_mode, + .dsi_info = { + .type = "NT36523", + .channel = 0, + .node = NULL, + }, + .width_mm = 127, + .height_mm = 203, + .bpc = 8, + .lanes = 3, + .format = MIPI_DSI_FMT_RGB888, + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM, + .init_cmds = elish_boe_init_cmds, + .is_dual_dsi = true, +}; + +static const struct panel_desc elish_csot_desc = { + .modes = &elish_csot_mode, + .dsi_info = { + .type = "NT36523", + .channel = 0, + .node = NULL, + }, + .width_mm = 127, + .height_mm = 203, + .bpc = 8, + .lanes = 3, + .format = MIPI_DSI_FMT_RGB888, + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM, + .init_cmds = elish_csot_init_cmds, + .is_dual_dsi = true, +}; + +static inline struct panel_info *to_panel_info(struct drm_panel *panel) +{ + return container_of(panel, struct panel_info, panel); +} + +static void nt36523_reset(struct panel_info *pinfo) +{ + gpiod_set_value_cansleep(pinfo->reset_gpio, 1); + usleep_range(12000, 13000); + gpiod_set_value_cansleep(pinfo->reset_gpio, 0); + usleep_range(12000, 13000); + gpiod_set_value_cansleep(pinfo->reset_gpio, 1); + usleep_range(12000, 13000); + gpiod_set_value_cansleep(pinfo->reset_gpio, 0); + usleep_range(12000, 13000); +} + +static int send_panel_init_cmds(struct drm_panel *panel, const struct panel_init_cmd *cmds) +{ + struct panel_info *pinfo = to_panel_info(panel); + int i, j, err; + + if (!cmds) + return -EFAULT; + + for (i = 0; cmds[i].len != 0; i++) { + const struct panel_init_cmd *cmd = &cmds[i]; + + switch (cmd->type) { + case DELAY_CMD: + msleep(cmd->data[0]); + break; + case INIT_DCS_CMD: + for (j = 0; j < DSI_NUM_MIN + pinfo->desc->is_dual_dsi; j++) { + err = mipi_dsi_dcs_write(pinfo->dsi[j], cmd->data[0], + cmd->len <= 1 ? NULL : &cmd->data[1], + cmd->len - 1); + if (err < 0) { + dev_err(&pinfo->dsi[j]->dev, "failed to write command %u\n", i); + return err; + } + } + break; + default: + return -EINVAL; + } + } + + return 0; +} + +static int nt36523_prepare(struct drm_panel *panel) +{ + struct panel_info *pinfo = to_panel_info(panel); + int i, ret; + + if (pinfo->prepared) + return 0; + + ret = regulator_bulk_enable(ARRAY_SIZE(pinfo->supplies), pinfo->supplies); + if (ret < 0) + return ret; + + nt36523_reset(pinfo); + + for (i = 0; i < DSI_NUM_MIN + pinfo->desc->is_dual_dsi; i++) + pinfo->dsi[i]->mode_flags |= MIPI_DSI_MODE_LPM; + + ret = send_panel_init_cmds(&pinfo->panel, pinfo->desc->init_cmds); + if (ret < 0) { + regulator_bulk_disable(ARRAY_SIZE(pinfo->supplies), pinfo->supplies); + dev_err(panel->dev, "failed to initialize panel: %d\n", ret); + return ret; + } + + pinfo->prepared = true; + + return 0; +} + +static int nt36523_disable(struct drm_panel *panel) +{ + struct panel_info *pinfo = to_panel_info(panel); + int i, ret; + + for (i = 0; i < DSI_NUM_MIN + pinfo->desc->is_dual_dsi; i++) + pinfo->dsi[i]->mode_flags &= ~MIPI_DSI_MODE_LPM; + + for (i = 0; i < DSI_NUM_MIN + pinfo->desc->is_dual_dsi; i++) { + ret = mipi_dsi_dcs_set_display_off(pinfo->dsi[i]); + if (ret < 0) + dev_err(&pinfo->dsi[i]->dev, "failed to set display off: %d\n", ret); + } + + for (i = 0; i < DSI_NUM_MIN + pinfo->desc->is_dual_dsi; i++) { + ret = mipi_dsi_dcs_enter_sleep_mode(pinfo->dsi[i]); + if (ret < 0) + dev_err(&pinfo->dsi[i]->dev, "failed to enter sleep mode: %d\n", ret); + } + + msleep(70); + + return 0; +} + +static int nt36523_unprepare(struct drm_panel *panel) +{ + struct panel_info *pinfo = to_panel_info(panel); + + if (!pinfo->prepared) + return 0; + + gpiod_set_value_cansleep(pinfo->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(pinfo->supplies), pinfo->supplies); + + pinfo->prepared = false; + + return 0; +} + +static void nt36523_remove(struct mipi_dsi_device *dsi) +{ + struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi); + int ret; + + ret = mipi_dsi_detach(pinfo->dsi[0]); + if (ret < 0) + dev_err(&dsi->dev, "failed to detach from DSI0 host: %d\n", ret); + + if (pinfo->desc->is_dual_dsi) { + ret = mipi_dsi_detach(pinfo->dsi[1]); + if (ret < 0) + dev_err(&pinfo->dsi[1]->dev, "failed to detach from DSI1 host: %d\n", ret); + mipi_dsi_device_unregister(pinfo->dsi[1]); + } + + drm_panel_remove(&pinfo->panel); +} + +static int nt36523_get_modes(struct drm_panel *panel, + struct drm_connector *connector) +{ + struct panel_info *pinfo = to_panel_info(panel); + const struct drm_display_mode *m = pinfo->desc->modes; + struct drm_display_mode *mode; + + mode = drm_mode_duplicate(connector->dev, m); + if (!mode) { + dev_err(panel->dev, "failed to add mode %ux%u@%u\n", + m->hdisplay, m->vdisplay, drm_mode_vrefresh(m)); + return -ENOMEM; + } + + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; + drm_mode_set_name(mode); + drm_mode_probed_add(connector, mode); + + connector->display_info.width_mm = pinfo->desc->width_mm; + connector->display_info.height_mm = pinfo->desc->height_mm; + connector->display_info.bpc = pinfo->desc->bpc; + + return 1; +} + +static const struct drm_panel_funcs nt36523_panel_funcs = { + .disable = nt36523_disable, + .prepare = nt36523_prepare, + .unprepare = nt36523_unprepare, + .get_modes = nt36523_get_modes, +}; + +static int nt36523_probe(struct mipi_dsi_device *dsi) +{ + struct device *dev = &dsi->dev; + struct device_node *dsi1; + struct mipi_dsi_host *dsi1_host; + struct panel_info *pinfo; + const struct mipi_dsi_device_info *info; + int i, ret; + + pinfo = devm_kzalloc(dev, sizeof(*pinfo), GFP_KERNEL); + if (!pinfo) + return -ENOMEM; + + for (i = 0; i < ARRAY_SIZE(pinfo->supplies); i++) + pinfo->supplies[i].supply = nt36523_regulator_names[i]; + + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(pinfo->supplies), + pinfo->supplies); + if (ret < 0) + return dev_err_probe(dev, ret, "failed to get regulators\n"); + + for (i = 0; i < ARRAY_SIZE(pinfo->supplies); i++) { + ret = regulator_set_load(pinfo->supplies[i].consumer, + nt36523_regulator_enable_loads[i]); + if (ret) + return dev_err_probe(dev, ret, "failed to set regulator enable loads\n"); + } + + pinfo->desc = of_device_get_match_data(dev); + if (!pinfo->desc) + return -ENODEV; + + pinfo->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(pinfo->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(pinfo->reset_gpio), "failed to get reset gpio\n"); + + /* If the panel is dual dsi, register DSI1 */ + if (pinfo->desc->is_dual_dsi) { + info = &pinfo->desc->dsi_info; + + dsi1 = of_graph_get_remote_node(dsi->dev.of_node, 1, -1); + if (!dsi1) { + dev_err(dev, "cannot get secondary DSI node.\n"); + return -ENODEV; + } + + dsi1_host = of_find_mipi_dsi_host_by_node(dsi1); + of_node_put(dsi1); + if (!dsi1_host) { + dev_err(dev, "cannot get secondary DSI host\n"); + return -EPROBE_DEFER; + } + + pinfo->dsi[1] = mipi_dsi_device_register_full(dsi1_host, info); + if (!pinfo->dsi[1]) { + dev_err(dev, "cannot get secondary DSI device\n"); + return -ENODEV; + } + } + + pinfo->dsi[0] = dsi; + mipi_dsi_set_drvdata(dsi, pinfo); + drm_panel_init(&pinfo->panel, dev, &nt36523_panel_funcs, DRM_MODE_CONNECTOR_DSI); + + ret = drm_panel_of_backlight(&pinfo->panel); + if (ret) + return dev_err_probe(dev, ret, "failed to get backlight\n"); + + drm_panel_add(&pinfo->panel); + + for (i = 0; i < DSI_NUM_MIN + pinfo->desc->is_dual_dsi; i++) { + pinfo->dsi[i]->lanes = pinfo->desc->lanes; + pinfo->dsi[i]->format = pinfo->desc->format; + pinfo->dsi[i]->mode_flags = pinfo->desc->mode_flags; + + ret = mipi_dsi_attach(pinfo->dsi[i]); + if (ret < 0) + return dev_err_probe(dev, ret, "cannot attach to DSI%d host.\n", i); + } + + return 0; +} + +static const struct of_device_id nt36523_of_match[] = { + { + .compatible = "xiaomi,elish-boe-nt36523", + .data = &elish_boe_desc + }, + { + .compatible = "xiaomi,elish-csot-nt36523", + .data = &elish_csot_desc + }, + {}, +}; +MODULE_DEVICE_TABLE(of, nt36523_of_match); + +static struct mipi_dsi_driver nt36523_driver = { + .probe = nt36523_probe, + .remove = nt36523_remove, + .driver = { + .name = "panel-novatek-nt36523", + .of_match_table = nt36523_of_match, + }, +}; +module_mipi_dsi_driver(nt36523_driver); + +MODULE_AUTHOR("Jianhua Lu "); +MODULE_DESCRIPTION("Novatek NT36523 DriverIC panels driver"); +MODULE_LICENSE("GPL");