From patchwork Fri Feb 17 15:58:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 654779 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBFFEC677F1 for ; Fri, 17 Feb 2023 15:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230210AbjBQP6w (ORCPT ); Fri, 17 Feb 2023 10:58:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbjBQP6u (ORCPT ); Fri, 17 Feb 2023 10:58:50 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACF783B85A for ; Fri, 17 Feb 2023 07:58:48 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id ee31so7496722edb.3 for ; Fri, 17 Feb 2023 07:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/AdPiwh3b8A+zGiRoWfdq4qtMfxRdZ+CJHCAn9rHssM=; b=NOxz72QPbXJ3FlLpmA9orNXQV7RHz+HVkf7e59E8kduNeQ1x994jq3mmmK3Cih6fyd lkzTKzN0xhPvp0+uLa1pQcPx+XEk4hzlLOguCPdtYAu+hIjqlAkWPis87L3zMMuS8EUX ttoqE6sXqA06pHBYh28ALZ0yA8z/BF4Eoc2SCXsS11NsyEiSpkLuRW/uFFpJstm7f8vv H50+nZ68TOPCvLfm5USzBqleq4knxdfObRzvuH5CeE3w9jighOILVq9jbz3tSjtrplc3 i3bGkzTF3Ax1cKfM+wFrwuMfsXWAEPN3n/XSHaffrDCE7K2IDqcWmBJrwoCD+GVtvcvT xczA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/AdPiwh3b8A+zGiRoWfdq4qtMfxRdZ+CJHCAn9rHssM=; b=Al4hLBzlrQGwx4qQJNjUsOdIue93Y79fkkziBL0gI670z5DDKttr/xesUqZFwAN/d2 0ELQ0cmKMN+LSk8mPwpSbLT8Cy0XTXYBtAjGaDmO4QyzWsoxAri2RPTborcPRwYfZi+m JbRO3xBS8+J/+vks0rECZMqD8I4TqW5OGyEKuDeFP1ZOqHu3b9HKoxuGhxFEEYgTg2By mfN1CvRstYSd/gYB7llRnr2Nee8SuAkz5FxDQNbX0vowNJMKTh+fiCESTsY4pnQS47iD WWKcYlkoxgQpYt06Zz3gUdFaiihNwjD+upB14B/UDHI+Mwv8vVGTb+UGcios8TzAbLaN 91hg== X-Gm-Message-State: AO0yUKWyiFxCNHgEx9o5DU1nLUVr4+hfMK+btolVpRweqelRWKdvo5S8 4NLDhe2KpZg6d3rDCvOpdhKC2g== X-Google-Smtp-Source: AK7set/fhUZ+YsPyas6G5lnBSvnhDlmTuRWFwJI7Z0eOSZGDUbnuYLhTVBUIjvN84F6WDlxXSS7NHw== X-Received: by 2002:a17:906:90c9:b0:8aa:502c:44d3 with SMTP id v9-20020a17090690c900b008aa502c44d3mr10810229ejw.41.1676649526740; Fri, 17 Feb 2023 07:58:46 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id i15-20020a17090685cf00b008b1435bd1cbsm2290068ejy.105.2023.02.17.07.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 07:58:46 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/3] arm64: dts: qcom: sc7280-herobrine-audio-rt5682: add missing supplies Date: Fri, 17 Feb 2023 16:58:37 +0100 Message-Id: <20230217155838.848403-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230217155838.848403-1-krzysztof.kozlowski@linaro.org> References: <20230217155838.848403-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Bindings expect DBVDD-supply and LDO1-IN-supply: sc7280-herobrine-evoker-lte.dtb: codec@1a: 'DBVDD-supply' is a required property sc7280-herobrine-evoker-lte.dtb: codec@1a: 'LDO1-IN-supply' is a required property In sc7180-trogdor.dtsi they come from the same regulator, so let's assume intention was the same here. Signed-off-by: Krzysztof Kozlowski --- .../arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi index 1ca11a14104d..485f9942e128 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi @@ -94,6 +94,8 @@ alc5682: codec@1a { interrupts = <101 IRQ_TYPE_EDGE_BOTH>; AVDD-supply = <&pp1800_alc5682>; + DBVDD-supply = <&pp1800_alc5682>; + LDO1-IN-supply = <&pp1800_alc5682>; MICVDD-supply = <&pp3300_codec>; realtek,dmic1-data-pin = <1>; diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi index 69e7aa7b2f6c..8b855345e5c7 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi @@ -76,6 +76,8 @@ alc5682: codec@1a { interrupts = <101 IRQ_TYPE_EDGE_BOTH>; AVDD-supply = <&pp1800_alc5682>; + DBVDD-supply = <&pp1800_alc5682>; + LDO1-IN-supply = <&pp1800_alc5682>; MICVDD-supply = <&pp3300_codec>; realtek,dmic1-data-pin = <1>; From patchwork Fri Feb 17 15:58:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 654780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17378C64EC4 for ; Fri, 17 Feb 2023 15:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbjBQP6v (ORCPT ); Fri, 17 Feb 2023 10:58:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbjBQP6u (ORCPT ); Fri, 17 Feb 2023 10:58:50 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B62815B2C3 for ; Fri, 17 Feb 2023 07:58:48 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id i28so5482448eda.8 for ; Fri, 17 Feb 2023 07:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4jPvyv9I5wiu0UqUhJgWDDuJNNlu5P2BsRi/wHIwDbc=; b=a9uV58GEk+FUc8K7phf4KPxjwtO8DkbANSvWnfJPr0pZcuysJRUp2ohKo1ISVOR5A8 443/0uLCDjColq3lUZmG19UutF4m6yIRu3WM93AxK12WGv15TzHYQDOXoxbjgHBSlges H80lh3YYcbIkSDTv6qFSyQkZ70bgwP4BGZEmWuSFYxa2pqk28oJbW1p/SNZpEDxzMim5 UR1eK/Noyqo+EU2Lm7JqgNgktVHQuNOtE+DY2g0QZc3ELSDPV7+PuCG5Hc8ATvF/PLUp 0aedsHuOCn24rP23RYTNQLUUyTHpKIdLNUQHOm28TiSN2bg1mvEkKv1DTmVnciFbeq8n nvDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4jPvyv9I5wiu0UqUhJgWDDuJNNlu5P2BsRi/wHIwDbc=; b=Li9UO1Scw53JERdqDUG5NwpLFgwBTTrMFRVKYLd4gp0dUSxrPHYQGINTLhykOu70eI ZUk40Wbhcz63xbO+lZ+PXPJv8XvajGRyxs0vha3KUeouuYtTiSmW8IYQy4wp5qS7eknV FyUCViINfTz5cxPuNpA90K7hF/U055idJC+0GH5/vEmZyZlNpXwoZQAwRV1Teyanwz5Y Kv7WeeA9SmNMBkZH6s0WPCmOy5pmaboTcOuYHWAGrsEa56/+Tk/aFmVb88e74cvr24Tr xWVzNqfcHoxA4OIw38SkqurGhQsLHePtXB2NdQkU6QOMWgAnZ18XjD5S3VQOOtvrBGW9 nKzA== X-Gm-Message-State: AO0yUKX8uaQ3DvEhIDAkcc+y90y52x+wQi5645dhLvLtrLyKTYVkUy2z a+BHqDLwi7r9mQ3ti/Lnkp/ohQ== X-Google-Smtp-Source: AK7set+joMfcLjTQD7eFiwgWm7xq5oE5NIIl4xcpSk5vjv9sKXfP5mg+4NzC2uQkmP+DVQ40Tu0pcg== X-Received: by 2002:a17:906:2c15:b0:874:e17e:2526 with SMTP id e21-20020a1709062c1500b00874e17e2526mr214039ejh.72.1676649528379; Fri, 17 Feb 2023 07:58:48 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id i15-20020a17090685cf00b008b1435bd1cbsm2290068ejy.105.2023.02.17.07.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 07:58:48 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/3] arm64: dts: qcom: sc7280: align RPMh regulator nodes with bindings Date: Fri, 17 Feb 2023 16:58:38 +0100 Message-Id: <20230217155838.848403-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230217155838.848403-1-krzysztof.kozlowski@linaro.org> References: <20230217155838.848403-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Device node names should be generic and bindings expect certain pattern for RPMh regulator nodes. Signed-off-by: Krzysztof Kozlowski --- I was fixing these in other boards, but missed SC7280. Previous (applied) set: https://lore.kernel.org/r/20230127114347.235963-4-krzysztof.kozlowski@linaro.org --- arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 2 +- arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 2 +- arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++-- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts index 1185141f348e..afae7f46b050 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts @@ -27,7 +27,7 @@ chosen { }; &apps_rsc { - pmg1110-regulators { + regulators-2 { compatible = "qcom,pmg1110-rpmh-regulators"; qcom,pmic-id = "k"; diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts index 4e0b013e25f4..df39a64da923 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts @@ -40,7 +40,7 @@ vreg_edp_bl_crd: vreg-edp-bl-crd-regulator { /* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */ &apps_rsc { - pmg1110-regulators { + regulators-2 { compatible = "qcom,pmg1110-rpmh-regulators"; qcom,pmic-id = "k"; diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts index ba64316b4427..15222e92e3f5 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts @@ -25,7 +25,7 @@ chosen { }; &apps_rsc { - pmr735a-regulators { + regulators-2 { compatible = "qcom,pmr735a-rpmh-regulators"; qcom,pmic-id = "e"; diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 8b5293e7fd2a..8ebcf763b3c7 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -184,7 +184,7 @@ codec { }; &apps_rsc { - pm7325-regulators { + regulators-0 { compatible = "qcom,pm7325-rpmh-regulators"; qcom,pmic-id = "b"; @@ -279,7 +279,7 @@ vreg_l19b_1p8: ldo19 { }; }; - pm8350c-regulators { + regulators-1 { compatible = "qcom,pm8350c-rpmh-regulators"; qcom,pmic-id = "c"; diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi index 88204f794ccb..cb0cc2ba2fa3 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi @@ -87,7 +87,7 @@ &apps_rsc { * are left out of here since they are managed elsewhere. */ - pm7325-regulators { + regulators-0 { compatible = "qcom,pm7325-rpmh-regulators"; qcom,pmic-id = "b"; @@ -188,7 +188,7 @@ vreg_l19b_1p8: ldo19 { }; }; - pm8350c-regulators { + regulators-1 { compatible = "qcom,pm8350c-rpmh-regulators"; qcom,pmic-id = "c";