From patchwork Mon Apr 29 04:06:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 163008 Delivered-To: patch@linaro.org Received: by 2002:a92:7e86:0:0:0:0:0 with SMTP id q6csp1409764ill; Sun, 28 Apr 2019 21:07:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzwnMTwHNts7tK5AJev6EnFeaBNYxFzQY22bWD0TUYE8iWAaTd4J6ARubwDvgekdKvE1Bo4 X-Received: by 2002:a65:6294:: with SMTP id f20mr56197585pgv.415.1556510835616; Sun, 28 Apr 2019 21:07:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556510835; cv=none; d=google.com; s=arc-20160816; b=ydzfGFj8UgYRQ8afj5c4OtUbI9vfWaj0viU4Bg2q6N4fC3uhhRhheUbe2VwWVinKnR 05xYvK2w0fJ01jYH+CBG2/M8AA7+wa/q20Z0cDbTInkMrh9N9V63HyJGAfvMHHx/zso0 Nt8D8G4rusRDJbrTj4X+J3v1OwAdQATqAKTMTOTdgqZHubfNpR5bAulP8L9qzS8lXcGg 4wwdXq+hrT6AfQpb3E/cbdSQ/LJ47KTE9WWuSY0Hp0QZqwgh37zbgT+rcsDEexLiuh7p VfBCiSsbafIPdUrXwXc3n0vxLUPpm62JAlUpgKFVfdPE57d11XtZ+MPgKrWcLcocW8Mo odsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=Bob1QfvAat3FkajVVhYUSYwY5ffmgFQaoKrn24XXkYQ=; b=RKH/hkQakc56azScLRV3M5aMS3+zFFE8UczRVWxDAkuKHwpYJydglWpjoiOddfWTht CHcUkTlwy+yGSoLN36EOqsu5StR94TzzfvU6LJtT0L3zh3vg09o8jirtwjiOwNOFpjYd f40xBUcdb924gkCC6gO4LeUT4NW3KTsRtnOQPqX8qWeZE3zn5vdJor21EwCcmSq6KMn4 LOIjhC0pOeqEdYg0KjaX1QzhaUvUz+BbkuM7eVX+HbjXf8FQeKfPTwDXzeczCzGvSA7P ASXX9YBjgsAMT0DaMRsoc73yOK0ZwAEsYJBOgd2rwTv2XOEwvhykYB+UIA/6za2ovPWo 6N9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=MvD94gkA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g189si30461035pgc.112.2019.04.28.21.07.15; Sun, 28 Apr 2019 21:07:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=MvD94gkA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726139AbfD2EHH (ORCPT + 30 others); Mon, 29 Apr 2019 00:07:07 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:61852 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfD2EHG (ORCPT ); Mon, 29 Apr 2019 00:07:06 -0400 Received: from grover.flets-west.jp (softbank126125154137.bbtec.net [126.125.154.137]) (authenticated) by conuserg-10.nifty.com with ESMTP id x3T46o87012916; Mon, 29 Apr 2019 13:06:50 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x3T46o87012916 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1556510810; bh=Bob1QfvAat3FkajVVhYUSYwY5ffmgFQaoKrn24XXkYQ=; h=From:To:Cc:Subject:Date:From; b=MvD94gkAOFNDETi657i9eQDDhRGRZMq+BR9PUQbs1j6XF4eDJGRz7KRBIfXN6tu1e 2baD7oMaJf5x39DjplW4/ulYYhpSZJ+pNIQRrljHRQZI7sEomgNU38NEUcZOfykvFb 4b8nm/CrRhtUDsQp4byhGj2R4YZLh0nrqqe2jOETA+VKmpq8DJ/WSzcPct0AAgkFE2 C479QpNFXsk9cGy8fz9z41Pai66vDYuA2kI9prgCi4e5mVNQHWbDzWOqQyTaYfUZKK ap390UF3XOiVXCHff8mab5gK3kE7nXa9sDEuYTX3mdZ0WeEVe2nIVHh9t8V0oIdWrh QnAdasnPxkl4Q== X-Nifty-SrcIP: [126.125.154.137] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Sergey Senozhatsky , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH] scripts/tags.sh: fix direct execution of scripts/tags.sh Date: Mon, 29 Apr 2019 13:06:43 +0900 Message-Id: <1556510803-5628-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I thought this script was run via "make tags" etc. but some people run it directly. Prior to commit a9a49c2ad9b9 ("kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree build"), in such a usecase, "tree" was set empty since KBUILD_SRC is undefined. Now, "tree" is set to "${srctree}/", which is evaluated to "/". Fix it by taking into account the case where "srctree" is unset. Link: https://lkml.org/lkml/2019/4/19/501 Fixes: a9a49c2ad9b9 ("kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree build") Reported-by: Sergey Senozhatsky Signed-off-by: Masahiro Yamada --- scripts/tags.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/scripts/tags.sh b/scripts/tags.sh index 6a55180..70e14c6 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -19,7 +19,7 @@ ignore="$ignore ( -name *.mod.c ) -prune -o" # Do not use full path if we do not use O=.. builds # Use make O=. {tags|cscope} # to force full paths for a non-O= build -if [ "${srctree}" = "." ]; then +if [ "${srctree}" = "." -o -z "${srctree}" ]; then tree= else tree=${srctree}/