From patchwork Tue Feb 7 19:29:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 651400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E686C636D3 for ; Tue, 7 Feb 2023 19:29:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231348AbjBGT3o (ORCPT ); Tue, 7 Feb 2023 14:29:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230249AbjBGT3i (ORCPT ); Tue, 7 Feb 2023 14:29:38 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67EB73E634 for ; Tue, 7 Feb 2023 11:29:19 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id bk16so14617788wrb.11 for ; Tue, 07 Feb 2023 11:29:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hO5H0Nap/rA7n7JTyZf5zLflpWg3VbovGW4CVXHbCK4=; b=pi4BF1tbHVMh6DjSFOMxLSqBN7I485NtNf0wtShJCIWnuaPJ1f+bgaEDoNbCtkr81P f398/d5NXSkauPmUCVmc+LrJEKlAtIQaqZ1NlWqxiFzloxtTDDy+JvF23rABn9SPckmX xdnzhKBvnzygCFIbPXg+gaaVni3QrF1kpeRhNvaHHYaXv5i+CHjin9TSk5kWBDmjjx1M rLYmEM5m6Ypk46Mpx/si2EX6QHrzjaYIPSVzwBQIyrD3mgKANQx6RgAmpTBy0y6d7W7m hWFRLQgH4iFYKmxYtYEnxBgzEkbSMB5SlQ3IEkb6BVzdp3ZCEuF29ttomF4LHFyP4kRu DWrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hO5H0Nap/rA7n7JTyZf5zLflpWg3VbovGW4CVXHbCK4=; b=ka0yTg6LxlcV3045zIjj52c64t8HU6RmhDMADVI3UnygPUt+Evc3CuGxvKyKm6SbNd TTa52XVW4taPZxi8Len4id5PalZXJfLNtO9Eb5FvQI9WkptLgoPE6jAyI4H4pSOVD9PM ui899QGLdDrq18AO2d/3VFsgdqzJoB/A1jRysR1PUp+FiHMawc0w0+dIJmdvYb4L/FLi 2mLxjoUnhG9S9k3yFZZI2d8UKY0sN8R1ZW1LDe1QFPYjEOwatABVYW5gmeyF0x0PkRl3 VmrTswYaTjjFEDu8zYepJDFf8lA9j0qD7oZ901eKZNUtvrjJg8FyUo4bpVhinbkzhHOE 2kHg== X-Gm-Message-State: AO0yUKXMtmAzRH3cWS6sSTCQhCFGu5DCACDgRYwNg7d6pEXn7B/GxchC gWu6fB9U1CWNw3lFcyo7E95yoQ== X-Google-Smtp-Source: AK7set/G1foflXy9cnv/SVtLj/1btjN14gR0xivM/JvDx2dXNtmiHGcQQSiLDGKmOFsiTQVsmg1BoA== X-Received: by 2002:a5d:6941:0:b0:2bf:cfbd:44be with SMTP id r1-20020a5d6941000000b002bfcfbd44bemr3491040wrw.69.1675798157787; Tue, 07 Feb 2023 11:29:17 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id bd16-20020a05600c1f1000b003db0ee277b2sm19858623wmb.5.2023.02.07.11.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 11:29:17 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] media: samsung: exynos4-is: drop simple-bus from compatibles Date: Tue, 7 Feb 2023 20:29:13 +0100 Message-Id: <20230207192914.549309-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Driver should explicitly populate all its children devices. Signed-off-by: Krzysztof Kozlowski --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 98a60f01129d..70c4ca7844d3 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1440,6 +1440,10 @@ static int fimc_md_probe(struct platform_device *pdev) if (!fmd) return -ENOMEM; + ret = devm_of_platform_populate(dev); + if (ret < 0) + return -ENOMEM; + spin_lock_init(&fmd->slock); INIT_LIST_HEAD(&fmd->pipelines); fmd->pdev = pdev;