From patchwork Tue Feb 7 20:58:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 651398 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C50C636CC for ; Tue, 7 Feb 2023 20:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229615AbjBGU6p (ORCPT ); Tue, 7 Feb 2023 15:58:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbjBGU6o (ORCPT ); Tue, 7 Feb 2023 15:58:44 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA31B11649 for ; Tue, 7 Feb 2023 12:58:42 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id az4-20020a05600c600400b003dff767a1f1so14786wmb.2 for ; Tue, 07 Feb 2023 12:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PoMfks5Pi2TAoCgRVsoQ1C6g7O43cRdI/G6Mr7ISRn4=; b=rqB6aQWQXXK0ao4JHOkfgdGuPUpCbCE2deHTaQQffNIrwCaCjse2g8b0W9RZzk5DYF 4OPSf2Ny5DW3A5rqDgqk2VfPJSlS8NQ5iOs/s/md60pjpOqm3Wv5lGN+opgQAz055zbZ dEsY6iu27kXRwanAzT7WfUT1kp0AhEvXZB/9T7QR72HhHO0odF9VHXV3jWTr2Ydo98zf thLTDWrNHOWPciBFNe1eMzLrJ0NPqw7s1s08/STrDABCE/qdy79Vf0DdSl2pXVMpsjSh H8s8X8tfvknB180sxMePHNAkDigo0kbZ9Y3yFpxIgf2wGE/dSaNN4wC0cmVHbnViguta hcOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PoMfks5Pi2TAoCgRVsoQ1C6g7O43cRdI/G6Mr7ISRn4=; b=e/4JvZjd2JWXsGjG8o4Nn+YMDQALF39h3EpVzWD3TLNqqSvV4WIGb4YyZ+wcx3fc+G RWrqe7rR8Vs5mB54nQjy7yY6qxloiS2+VNaqjDUE08W4golsGnwFA87+cvg9wwiQkFwf qYe6S4qjeMxr9U/xGUGKUkUtNXGfNS5akCMWsd/KNTHRVMk12/hXQNN+l6mctJuOUtR+ sRRLP8/A/DKz2kkY73NAuWxyzm3Xfl3ku22AJIpkZ4og+5Hm/ZH82w/c0NOhaSa7Noec f4V/SlhCusSEcua3+g0p1cEEj68XczEfAWh3rj5g58/0Gd/sS+jygd6Vi2iwfKtvdCx/ cnfg== X-Gm-Message-State: AO0yUKVrEnLLS1oRs+VkVz02na2NqgfvG7oVONSP8KllUVVT/mOEWhBN Ljgeqem61Br0R5RSWcols1gjKw== X-Google-Smtp-Source: AK7set8Q72ioTFcT19F9jM5+EYeJZLiNJr2rD2fLqftya65j/IfRY0HWMv1i/xlLir0XRTm0WZEADg== X-Received: by 2002:a05:600c:3d0e:b0:3df:efdd:9dc7 with SMTP id bh14-20020a05600c3d0e00b003dfefdd9dc7mr281774wmb.10.1675803521352; Tue, 07 Feb 2023 12:58:41 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:41 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 1/4] media: dt-bindings: samsung-fimc: drop simple-bus Date: Tue, 7 Feb 2023 21:58:31 +0100 Message-Id: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Drop the simple-bus compatible and expect driver to explicitly populate children devices. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring --- Changes since v1: 1. None --- Documentation/devicetree/bindings/media/samsung-fimc.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt index 20447529c985..f90267f1180e 100644 --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt @@ -15,7 +15,7 @@ Common 'camera' node Required properties: -- compatible: must be "samsung,fimc", "simple-bus" +- compatible: must be "samsung,fimc" - clocks: list of clock specifiers, corresponding to entries in the clock-names property; - clock-names : must contain "sclk_cam0", "sclk_cam1", "pxl_async0", @@ -156,8 +156,8 @@ Example: }; }; - camera { - compatible = "samsung,fimc", "simple-bus"; + camera@11800000 { + compatible = "samsung,fimc"; clocks = <&clock 132>, <&clock 133>, <&clock 351>, <&clock 352>; clock-names = "sclk_cam0", "sclk_cam1", "pxl_async0", @@ -166,6 +166,7 @@ Example: clock-output-names = "cam_a_clkout", "cam_b_clkout"; pinctrl-names = "default"; pinctrl-0 = <&cam_port_a_clk_active>; + ranges; #address-cells = <1>; #size-cells = <1>; From patchwork Tue Feb 7 20:58:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 651397 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4725CC64EC7 for ; Tue, 7 Feb 2023 20:58:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbjBGU6u (ORCPT ); Tue, 7 Feb 2023 15:58:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbjBGU6r (ORCPT ); Tue, 7 Feb 2023 15:58:47 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31BDF1C592 for ; Tue, 7 Feb 2023 12:58:46 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id hn2-20020a05600ca38200b003dc5cb96d46so814wmb.4 for ; Tue, 07 Feb 2023 12:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=DqtTAyD+/DfVIXIixTTLeibbPWfARnoKPtZ503G/plOAdpSOZov9AsNRpB3pUQJUCv 5FCNQSbkC0AV7x/c4JKBbGIsoJuPYgqyzs2xF/miMtoLpyWrGtikd+RQT0vvCwpOV1c/ LVTXvBnhyoXTiKlSEA51+3WcZhlTyji8x5IDX0Mn2tghG16exPAaIpGzWridsqZMAxkx VxKKiazE0E9AuPVSkwv+0S9b9bro79BmeeJuIJsR8uaXenubEjuo5LA+Zoz2D1YzSnPv MGCiAbPamcfmHPYxaGJLC6H7KwYpZsFvUAOhnYsAIRJaKV7/5/MSyTniqrwxKqarbPsk QrEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=eT/JZ5yk86byy2uPi/li8ZVME5tCmh1AIKcogk18XSfmXYLWPIAsBQKIi+awIF1Y4W TMLRGmgTqewv07MfMESDx2XgdqN97kMQJpRo7yOLgQlUkzdxkC5Y4j3f71MOsfCz1tcp b366JSMYSy/b9C7WsVScrPlKBG7HH90HKJGXaNeRDCDyh9m6R8XU/sNelljOHNi2zzzR YL5BIknPcV7ETz9tsc/ipqlvWyvj/LcC0q0CcQJqGj44YVAYzKu3Umnt/HQ+nSRdMbrL J8xEpzmQJSqVjP0WMwCQZVjJvkCYCUMVyi9jx4Qbhs5RzusOhk+P1OugQumvZZjGOLiv 4NfA== X-Gm-Message-State: AO0yUKWaw9POMrAq/aL7Bpydc4Kjenx+vWMqhXspw6AqKurQaaY9CN4I Xyp6NbIeblL7KVLmszH+W3HG2Q== X-Google-Smtp-Source: AK7set8unV2JpGoXq+wRRje/TXgj4zlNonWi0Sr7sORRaCG8wxSrplHwWE6VetjIA5RfaZHnpx1ibg== X-Received: by 2002:a05:600c:4383:b0:3dc:57e8:1d1c with SMTP id e3-20020a05600c438300b003dc57e81d1cmr5511078wmn.9.1675803524727; Tue, 07 Feb 2023 12:58:44 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:44 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 3/4] media: samsung: exynos4-is: do not require pinctrl Date: Tue, 7 Feb 2023 21:58:33 +0100 Message-Id: <20230207205834.673163-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> References: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Driver does not handle pin configuration switching and several DTS provide empty pinctrl property, just to satisfy the driver's requirement for it. Drop requirement for pinctrl property as it is really optional. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. New patch --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 98a60f01129d..22baa429ed5d 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1470,10 +1470,8 @@ static int fimc_md_probe(struct platform_device *pdev) goto err_v4l2dev; pinctrl = devm_pinctrl_get(dev); - if (IS_ERR(pinctrl)) { - ret = dev_err_probe(dev, PTR_ERR(pinctrl), "Failed to get pinctrl\n"); - goto err_clk; - } + if (IS_ERR(pinctrl)) + dev_dbg(dev, "Failed to get pinctrl: %pe\n", pinctrl); platform_set_drvdata(pdev, fmd);