From patchwork Fri Apr 26 14:56:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 162925 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp846457jan; Fri, 26 Apr 2019 07:56:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqzF8/MovCRK5uywJAfwQnL3qDnES0x9TGgbw1nCYSms5OVAwazvuA80Syludc0Ec/GjzsVw X-Received: by 2002:a63:201c:: with SMTP id g28mr30483762pgg.39.1556290591112; Fri, 26 Apr 2019 07:56:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556290591; cv=none; d=google.com; s=arc-20160816; b=Bdjc+WJ8Jb+RKFEwaS4M1bGynZT8Sxx/4/bMNiCQLCboxNMVJsR4WLxVwa9cSuZPs4 bWN3bmTRC094f1OtmM8lFmPV4vIhLe5GLbFZGqu3aRFJnxvFXt/TdtMkgZLByk6MkNEr lSwfNpdhzmKcImYB4CzJ/KH6WrGovRwjk/qYTJd3R20Rlyp5Gcp/qYscwBMmLO6ln75d yAMPKAxfoiTw+hbbDrkwa4bryx+i6N62pUHUzi6gaHTC93sFSLEaeYQbCQIahODXJhz2 gGnqPQSd3/Pu1E8MxMeqQiURKla4f/iUWODTG62ZU047NyumZj3lxvqw8WzqkLrLO9+B Jtkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=P/8yV+a/T08imYC3vTXPW0fijdBwwchB1T9zwvXvL2w=; b=VmdsXPl66NGz7/puqPK8vvKPNIT5jNmduyJRk9K3CDcROa1vWyf4Z7aoKYnG0Z7Pm0 DZteyGwW1AMkwzc7U+LmSqe9dj7HEnFX84w3nfcobhQzdKF/5gQ69ZqrNarTXFzzVJXR eJXU//HhAzPrgb+upLxfL2MhMUYQZ1ymOdYHrn7/lldf5g9mOQRrxeIt2xgQq9eh/hCR WM5/dWX4iaYwPjX+AJ6hbfPprs1z8dxrsV2o6S6ygx35t1vY2Xg2Be0ldXIrWm2YKFsB BEkw7GWDvQor9RdRU21gbc0HNwrMmE6kVJBMubFjhd/gK9KM+F1MdwOUFuE5hrM4vadS LmXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k6si23622839pgq.300.2019.04.26.07.56.30; Fri, 26 Apr 2019 07:56:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726310AbfDZO43 (ORCPT + 30 others); Fri, 26 Apr 2019 10:56:29 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:53081 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726138AbfDZO43 (ORCPT ); Fri, 26 Apr 2019 10:56:29 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPA (Nemesis) id 1MiMIY-1gpuFN2ziA-00fWM8; Fri, 26 Apr 2019 16:56:23 +0200 From: Arnd Bergmann To: Russell King , Thierry Reding , Jonathan Hunter Cc: Arnd Bergmann , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] amba: tegra-ahb: mark PM functions as __maybe_unused Date: Fri, 26 Apr 2019 16:56:03 +0200 Message-Id: <20190426145617.2342824-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:sOT3r6fkwRywuIzcyDd5YHhYsKXG8TCD1p+LxyP5gEak1TT7Ua4 28esKCt19z9DcJNB8IwAZJBnmgdQTuaj2KbfxqExadgrpi+NQKv5Bc8DCc5QlxEzy2y4TVQ iLT4kitQLxSAV2QIbwH3TxzxHAmlt3/+XjrwYD1YJ1+bITyFvVMlOyeSPAEvKcItrPMC4+n HEzOqlyLHeRyPa5zrG1AQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:yjC718efDKQ=:2BlhEIXX9lB49C0yktOLhd CaK7PnyEdKOtSA4EpiLHcQglg9Eim5sHI6u6Zm3mZyu72S18EnbCDCXj9TJ8PoYTJWG2yQUQ+ 2IKLjgcmYDJRNi3Ye3J2OPPqlyNomLa/HJ3GbJJpvbF/fZdFq+fw5eJRmLdv1cJEhqI2+/oxR 5TMfzRiIv7XKkAJMQX4ZGEiSCpHaucTONqGi1KfwKZPiSqr4uko3sPhLmZnTuOWqDxyoTPkb2 8AHqelY1PEjhgmMT3l+aCXMRpAnX31U6TTIa7ZwP+m5QN9Vrz6OW4x+nxZgYrnWW/j0YHNtRn oLrgcUlyIGqpAjmgi23yZwPlMXFKS8iYyL1Pl4iU34U+gfCuv3ds5TtgxkpWa1ZV6htKrEjbg BbwDnc05n3YiWiH8q6nXuPEUQDq+DYJLbE7sPvR6TxIT3S3fTdnnwyPiahIj5J5LvHfBmUu3W yTMXURDLV+FYy/2HPckyzn+gNdNazxt8SQV2ZQHSVebYexmNJ2d7TfsDFyO69EkR+z/6aw/1o 9cgbF4ImsnoKgtjsx/IVOTG/ULxx8/BHiiTpOje8r+mt42a/Teown/xF7zZi3EoHA4OrgSyNB 2A6V5eVRIO8axEaMxPo7w2VHcE92i1f2L2io0NLcq3i/Q+rF0/RLlZQBGAB6K6WI59RSVQadJ g+zGoNwCAImzRgASsxmImFTOfXrt3AuheNTu9qBsfnj+hSbI7RaegM0y7mBpDzGbVWmRdOJ2K sq85zbsY+gV5Vv7PDijtyicmlDyTSBFsBKcxqw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clang warns about an unused variable when CONFIG_PM is disabled, since it is only referenced from an #ifdef: drivers/amba/tegra-ahb.c:97:18: error: variable 'tegra_ahb_gizmo' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration] Rather than trying to get the #ifdef right, remove it and use __maybe_unused here, which is less error prone. Signed-off-by: Arnd Bergmann --- drivers/amba/tegra-ahb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.20.0 Acked-by: Thierry Reding diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c index b0b688c481e8..3751d811be39 100644 --- a/drivers/amba/tegra-ahb.c +++ b/drivers/amba/tegra-ahb.c @@ -170,8 +170,7 @@ int tegra_ahb_enable_smmu(struct device_node *dn) EXPORT_SYMBOL(tegra_ahb_enable_smmu); #endif -#ifdef CONFIG_PM -static int tegra_ahb_suspend(struct device *dev) +static int __maybe_unused tegra_ahb_suspend(struct device *dev) { int i; struct tegra_ahb *ahb = dev_get_drvdata(dev); @@ -181,7 +180,7 @@ static int tegra_ahb_suspend(struct device *dev) return 0; } -static int tegra_ahb_resume(struct device *dev) +static int __maybe_unused tegra_ahb_resume(struct device *dev) { int i; struct tegra_ahb *ahb = dev_get_drvdata(dev); @@ -190,7 +189,6 @@ static int tegra_ahb_resume(struct device *dev) gizmo_writel(ahb, ahb->ctx[i], tegra_ahb_gizmo[i]); return 0; } -#endif static UNIVERSAL_DEV_PM_OPS(tegra_ahb_pm, tegra_ahb_suspend,