From patchwork Tue Jan 31 10:11:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 648925 Delivered-To: patch@linaro.org Received: by 2002:a17:522:d8c:b0:4be:c3dc:14d8 with SMTP id d12csp3960pva; Tue, 31 Jan 2023 02:15:01 -0800 (PST) X-Google-Smtp-Source: AK7set9FKNi42NwFh+TYULQSg46jK5ldyMqFnUxf6EMVlx5i9xQo6FN5SnR5YL7Bc65a1f8Bfll5 X-Received: by 2002:a0c:b692:0:b0:537:77d7:c8d3 with SMTP id u18-20020a0cb692000000b0053777d7c8d3mr28261289qvd.45.1675160101126; Tue, 31 Jan 2023 02:15:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675160101; cv=none; d=google.com; s=arc-20160816; b=reIr4AhdriQtCCPKPKxjVcgK+eKt4Bh2RKs4rEenB+KUj8aCOwSx9WsaDgK0JAuzeo RnfQHKubKpN2+PMzy4f/4iA5r/z42QERWmcc9m5JWKhesXjAeh7WPGHRDnk9dLHlE+qa pYOV7ND3+nr5FTOedzdK6AEezKqmTYGehtted2nV+76xYXJH0/nJlTHz6926IXK8wpBG nhvQfrwq0WrmtJq1JibKKuG9FwlrzPZl8Us1BhphwOzOhgA19hh5XbtIVufloqzUaaTN t3ZbB+yegCb0WImAOKJdkaElgURcpzZ5TvHCVx+aJrgunVF3HXh2HxMV9lsGoLcy6+kC 6+CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fnln5n3qbH4yuU4E1jBolBkc8rkU6by5EGC32hfPJ4c=; b=AbUM5QPB9U/oLkWbbhCrGbRdfXWxqJak3/4icy6iziCU+dj+5XlOSBms7eb6PytlV+ Lws+qwSXbs6/KHUMBpSv9szOIUZIqrUadVrrKJxVdQJxM6F5ccbaGVOVmAhCq8Y3pQur Dj6vKzB3+sk3JUaGHgnT1GVlzbDTDpMg/SQNOCYBawXtl4LbCwKQYxfg0uJ7/oePB9Lo sKKCyuTvmGH6DqokJGLn/We/ScdNqATDz0aSXgcHLfUo3Jaugzop/ETo3OZbJzD5cVMw Fa9s0WOm6PatloWKJJMP9K081Tm0itOEXecB80xReOOKk37NWd3p8HGCy1MN8DTbKXm1 BfLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M54aKZUa; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u5-20020a0ce5c5000000b004bb9ab0a3b1si8106368qvm.211.2023.01.31.02.15.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jan 2023 02:15:01 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M54aKZUa; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMndE-0002nO-Jy; Tue, 31 Jan 2023 05:12:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMnd2-0002Pw-LL for qemu-devel@nongnu.org; Tue, 31 Jan 2023 05:12:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMnd0-0002YQ-Rx for qemu-devel@nongnu.org; Tue, 31 Jan 2023 05:12:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675159954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fnln5n3qbH4yuU4E1jBolBkc8rkU6by5EGC32hfPJ4c=; b=M54aKZUaJEXMdP2UokvvIKZDAfiACYxjGsWRLz9v0nuO5RUf7MyhUU7tdr4TDioeaD4R9k uhVSLrOB5jbOQAmta/6veCbdG5hvP1mPk9/ahF/bSRa/VW1bJr1dKSuDKp4Fu9RXcRgGdQ CjTiQRb2xfXiIgVNaoN+Dgb7iFQWYsw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-344-hOoXk_FLMJG3BiZWpjHAhw-1; Tue, 31 Jan 2023 05:12:30 -0500 X-MC-Unique: hOoXk_FLMJG3BiZWpjHAhw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92CD7101A52E; Tue, 31 Jan 2023 10:12:30 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 742F9C15BAD; Tue, 31 Jan 2023 10:12:29 +0000 (UTC) From: Thomas Huth To: Peter Maydell , qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , =?utf-8?q?Marc-Andr=C3=A9?= =?utf-8?q?_Lureau?= Subject: [PULL 18/27] tests/qtest/vnc-display-test: Suppress build warnings on Windows Date: Tue, 31 Jan 2023 11:11:56 +0100 Message-Id: <20230131101205.1499867-19-thuth@redhat.com> In-Reply-To: <20230131101205.1499867-1-thuth@redhat.com> References: <20230131101205.1499867-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé While this test is skipped on Windows, we still get when building: tests/qtest/vnc-display-test.c:22:20: warning: unused function 'on_vnc_error' [-Wunused-function] static inline void on_vnc_error(VncConnection* self, ^ tests/qtest/vnc-display-test.c:28:20: warning: unused function 'on_vnc_auth_failure' [-Wunused-function] static inline void on_vnc_auth_failure(VncConnection *self, ^ 2 warnings generated. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20230119120514.28778-2-philmd@linaro.org> Reviewed-by: Richard Henderson Reviewed-by: Marc-André Lureau Signed-off-by: Thomas Huth --- tests/qtest/vnc-display-test.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/qtest/vnc-display-test.c b/tests/qtest/vnc-display-test.c index e2a9d682bb..fd63e3a881 100644 --- a/tests/qtest/vnc-display-test.c +++ b/tests/qtest/vnc-display-test.c @@ -19,6 +19,8 @@ typedef struct Test { GMainLoop *loop; } Test; +#if !defined(WIN32) + static void on_vnc_error(VncConnection* self, const char* msg) { @@ -31,6 +33,8 @@ static void on_vnc_auth_failure(VncConnection *self, g_error("vnc-auth-failure: %s", msg); } +#endif + static bool test_setup(Test *test) { From patchwork Tue Jan 31 10:11:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 648926 Delivered-To: patch@linaro.org Received: by 2002:a17:522:d8c:b0:4be:c3dc:14d8 with SMTP id d12csp4109pva; Tue, 31 Jan 2023 02:15:29 -0800 (PST) X-Google-Smtp-Source: AK7set8OAJLIK32YbGkSxzZYWGYV0ixesacLPHapc46cHELqeOYsnIc3GbLGg7rCRnztO+iGb5D3 X-Received: by 2002:a05:622a:104b:b0:3b8:1723:6d15 with SMTP id f11-20020a05622a104b00b003b817236d15mr30102307qte.58.1675160128870; Tue, 31 Jan 2023 02:15:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675160128; cv=none; d=google.com; s=arc-20160816; b=sDXawB5yqpZ4wsOo4y1OST4rq0pNzF5dXFIEpc98qH/8LNZnVZ2pLhycsW9+1qauOf NvoPrJQmMHwIlsiXLNFZi2agRG+xpE0Lf8DG4TnVHeIkqhqnDGcpkPyJia3hjZnhYUSo 3E6ceg7S9lqSiE1b9fIL+PajBGKHfe3cdVHrqULwjoW4nrY85IJk8UQ23fCPgcwbJ08x 47rlG6S41vep4GplWq7BToLc4KwZbuHC7v9HXZYUPE86CsjZZ9at9uSsm7rfCZ4dJCH2 kljR8kq1Ot7zMGlpFDATQRcfFhuXMD4iShqxkEtHVx+l5eWSPkN8Lwo4V1vVK8JdtOx6 tPBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=syNPSs1Lvj9n5gJrpz1cqrCXWtIT+qsg4d2Ug+4M250=; b=mIlcvNUsP27Ch0sRMtozSsaY/oNyUkxUmnFfVzsT9HlhfN4fvGKr5X3lYnnF6b8V5m E9YAdXzqsagW11JjLd+xiq4eQ5QI/SgmB8eaoWjXo/oD1shP0Eaf4odoYN+kM2C9M+UP 6jwH6lC95dZoWzkhcDKOGmN2JAGtW0+HAROrqEzcwmPGpD9qZt5Sl9HnNUX0W9zI9IMr NtYCoXK+fpqNXtQRTQjI3P9WONP+HfDU7KNiO+NujObRH+lrvRDlUg7LvKUHUtf4wY68 BjnKOX3dlK23vhtus+6YoBGD2ep7jqM1GxexD2XEUsQ6YIbC+MD/XHesEsZcFwBkJ3X3 mUOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cxmB9p9n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c123-20020a379a81000000b0071a7a156eebsi5819142qke.240.2023.01.31.02.15.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jan 2023 02:15:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cxmB9p9n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMndC-0002hL-Gr; Tue, 31 Jan 2023 05:12:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMnd2-0002PV-Ft for qemu-devel@nongnu.org; Tue, 31 Jan 2023 05:12:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMnd0-0002YK-I5 for qemu-devel@nongnu.org; Tue, 31 Jan 2023 05:12:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675159954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=syNPSs1Lvj9n5gJrpz1cqrCXWtIT+qsg4d2Ug+4M250=; b=cxmB9p9n/AOQSS4Rluj5JoUiC97IgMluak+Fqx2QUX48kVSNK5W3PR2uErCkoTu5l81cgZ Oz3NrAMmP8p5TpVdJQLGdRexdTFWnWP9K9iiqDkXYInnJ6dDmrkYl6mr+mTBtHyISNX7cU Wv30O1Pc6Vub3+8DqBe6g/HFjcbK7Yk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-184-clnAdze-ONOQqWB9jzxAQQ-1; Tue, 31 Jan 2023 05:12:32 -0500 X-MC-Unique: clnAdze-ONOQqWB9jzxAQQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 10AA280280B; Tue, 31 Jan 2023 10:12:32 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5AA7C15BAE; Tue, 31 Jan 2023 10:12:30 +0000 (UTC) From: Thomas Huth To: Peter Maydell , qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Subject: [PULL 19/27] tests/qtest/vnc-display-test: Use the 'none' machine Date: Tue, 31 Jan 2023 11:11:57 +0100 Message-Id: <20230131101205.1499867-20-thuth@redhat.com> In-Reply-To: <20230131101205.1499867-1-thuth@redhat.com> References: <20230131101205.1499867-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé If we don't specify any machine, an architecture default might be picked. But some architectures don't provide any default, such ARM: $ make check-qtest-aarch64 ... 19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test qemu-system-aarch64: No machine specified, and there is no default Since we don't need any particular machine to run this VNC test, use the 'none' machine. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20230119120514.28778-3-philmd@linaro.org> Reviewed-by: Richard Henderson Reviewed-by: Fabiano Rosas Reviewed-by: Marc-André Lureau Signed-off-by: Thomas Huth --- tests/qtest/vnc-display-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/vnc-display-test.c b/tests/qtest/vnc-display-test.c index fd63e3a881..df468c7b22 100644 --- a/tests/qtest/vnc-display-test.c +++ b/tests/qtest/vnc-display-test.c @@ -44,7 +44,7 @@ test_setup(Test *test) #else int pair[2]; - test->qts = qtest_init("-vnc none -name vnc-test"); + test->qts = qtest_init("-M none -vnc none -name vnc-test"); g_assert_cmpint(qemu_socketpair(AF_UNIX, SOCK_STREAM, 0, pair), ==, 0); From patchwork Tue Jan 31 10:11:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 648924 Delivered-To: patch@linaro.org Received: by 2002:a17:522:d8c:b0:4be:c3dc:14d8 with SMTP id d12csp3856pva; Tue, 31 Jan 2023 02:14:41 -0800 (PST) X-Google-Smtp-Source: AK7set8PgL0a+ASmJrrghKpgo0P7kYv7dkFK+FWHbJq/3gR12JmWqL1en5cthR+znpIg6eACpCj4 X-Received: by 2002:a05:622a:15d2:b0:3b8:283f:8a59 with SMTP id d18-20020a05622a15d200b003b8283f8a59mr23911470qty.13.1675160081371; Tue, 31 Jan 2023 02:14:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675160081; cv=none; d=google.com; s=arc-20160816; b=Lzyzfi53N7JT+6Q/T51kRXs45iE7D9UKA7m551Z7sVGZXqaY7/5IrEaIMRbSbnbgAh mGfGEF6/56DmhfjUOCdlqITmNLiRhXGblHF3hjkk+DgPqufsnMZ7wgtP97wKPxW/USPF 9P/H8xBNBD+S7eiXiriSab6UzjzjsgXpS52myQPiomzgHFC/JEgQNxCnUJrj2P5rRKZA MOn4wjnEtDeH1nW1mhnmzN3F8cQ18yrMCeoTgXkWVBRbEGc1DnVfxCXKPOCj5J57YEju OxmQUhZqO564Xv9YRdMx/9Xiuj70QXbx5qrkTQRvJGdF57PKIYEJd2Ap3Bb5lwBQIPUC UCOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0qwmNctkBIRSRWUWQyCcS2Cb8oWJUu8VOrorByu2uSM=; b=rOvkNOzhsHKYzDnGqPZlSYNEZy7GKQ/TFiy286nY6n+pN7petDj1NHYoWrOBLsuQpo uhclTpb0BRQMpKH/hzJ9ofUJXaxzCMWfj2lBNE4fFSfQ6GdLKbExByc35aXIRrNE1N+Q k8/t7rm35T03dJEEwl3bX62yEs/MK5G9NR8sz7DzfWjM8cVmiMTNxC+e8Cviev2VJKdm Wt4CVjbrtrB+osZTRpcasfJMdeLQMwF/6Pyq7KTxY7vQA9l9snW6Q5ubjIAnGCExYlzJ jPN30QGdaw6gSLtGxFH4EeTtBNW93RRtC5ql7UydfSAbKMo+6JE6g7ECYbUm+sbTLLmF 5ZUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="fqoP/p6w"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z31-20020a05620a261f00b00726c88f3fe6si476908qko.44.2023.01.31.02.14.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jan 2023 02:14:41 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="fqoP/p6w"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMndA-0002dI-RC; Tue, 31 Jan 2023 05:12:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMnd4-0002TF-0B for qemu-devel@nongnu.org; Tue, 31 Jan 2023 05:12:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMnd0-0002Yh-U5 for qemu-devel@nongnu.org; Tue, 31 Jan 2023 05:12:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675159957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0qwmNctkBIRSRWUWQyCcS2Cb8oWJUu8VOrorByu2uSM=; b=fqoP/p6wfadzMUT8DVAjVQQ2pMdv04eOlQjvwWYV5PZ4NlEWNvc7O3PdVh1YLz+6AaCcco PEjNchn++w8mAz5+5gNEMB0Tt0CQswy9lUr/NKDZpICUIAGLpc028zwapSN8ptpb7/igBr U4Gz6+2LyzKzHYMR32CWRXgVwm4cc34= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-300-0KlVESzNOMyFjPa1pd1lCA-1; Tue, 31 Jan 2023 05:12:34 -0500 X-MC-Unique: 0KlVESzNOMyFjPa1pd1lCA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 60BB93C025B7; Tue, 31 Jan 2023 10:12:33 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54611C15BAD; Tue, 31 Jan 2023 10:12:32 +0000 (UTC) From: Thomas Huth To: Peter Maydell , qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?D?= =?utf-8?q?aniel_P_=2E_Berrang=C3=A9?= , =?utf-8?q?Marc?= =?utf-8?q?-Andr=C3=A9_Lureau?= Subject: [PULL 20/27] tests/qtest/vnc-display-test: Disable on Darwin Date: Tue, 31 Jan 2023 11:11:58 +0100 Message-Id: <20230131101205.1499867-21-thuth@redhat.com> In-Reply-To: <20230131101205.1499867-1-thuth@redhat.com> References: <20230131101205.1499867-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé This test is failing in gtk-vnc on Darwin: $ make check-qtest-aarch64 ... 19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672 While QEMU picks the sigaltstack coroutine backend, gtk-vnc uses the ucontext coroutine backend, which might be broken on Darwin. Disable this test (current problem being investigated in this thread: https://lore.kernel.org/qemu-devel/Y8kw6X6keB5l53nl@redhat.com/). Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20230119120514.28778-4-philmd@linaro.org> Reviewed-by: Daniel P. Berrangé Reviewed-by: Marc-André Lureau Signed-off-by: Thomas Huth --- tests/qtest/vnc-display-test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/qtest/vnc-display-test.c b/tests/qtest/vnc-display-test.c index df468c7b22..e52a4326ec 100644 --- a/tests/qtest/vnc-display-test.c +++ b/tests/qtest/vnc-display-test.c @@ -19,7 +19,7 @@ typedef struct Test { GMainLoop *loop; } Test; -#if !defined(WIN32) +#if !defined(WIN32) && !defined(CONFIG_DARWIN) static void on_vnc_error(VncConnection* self, const char* msg) @@ -41,6 +41,9 @@ test_setup(Test *test) #ifdef WIN32 g_test_skip("Not supported on Windows yet"); return false; +#elif defined(CONFIG_DARWIN) + g_test_skip("Broken on Darwin"); + return false; #else int pair[2]; From patchwork Tue Jan 31 10:11:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 648923 Delivered-To: patch@linaro.org Received: by 2002:a17:522:d8c:b0:4be:c3dc:14d8 with SMTP id d12csp3650pva; Tue, 31 Jan 2023 02:14:09 -0800 (PST) X-Google-Smtp-Source: AK7set/7pUKrpHNjJqdw2wKWaYCKVq2+MQERhSQzJRC4cgn/ynDZ5Sfgnugka1M6ZpuhzdbNUVA+ X-Received: by 2002:a05:6214:9a3:b0:53b:5bdf:a654 with SMTP id du3-20020a05621409a300b0053b5bdfa654mr10874285qvb.46.1675160049402; Tue, 31 Jan 2023 02:14:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675160049; cv=none; d=google.com; s=arc-20160816; b=u2QiWyqX8cs2zRNekGFLDXAdQTdGPLHqXazHaDBeaYrsYdAHs9tEkTC7bIod1jCNpX DSXNWh+0rZSL9Gaods4mER0Oz/jFQ0kYk0Gqk5IUvyZNrO2JUuMWmekILxS87mYRV64B GdLYo6TAFPdmGEcYldDXevMlFc+YRMLT2fd+jHGGL+5GjGxj8WRxssi13B14XqmoYoeK uFucaNopVIfABmM7KG+JeOj6g5tT7u9+UxZ7P+Uaosu5g1F+vxRBL3k+83E8AiFlpGeP R9PDKdM+yW5qOv+t4M3Wc46ZSy0mulvydN5DjVykiiv/pL+qpVAODk1wrDi1svWU5R7w oiSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7wXoy4hpawBJ9otqLXYC4v2SX/x9yrMcB9Eo4ArEVHI=; b=t6F1ya2GUlH7BL1jEKzdOGNHMm0h7Yf/OU+7F5soNNYNKkiQ/LCQAapu//loBpoEih XchhGJg/yQBXgHezZx0K2xNA3+M8CaW2LV7PuIAYcU7dkmeOR2B+kuABw71p64q3uL5g XKM2aciEp4y89ffl6jumSfwrUQ1nld4i8Lj4/yD1p3K5TdoQCZu6CVltgYHfIXaxcLQa 5fL5sUpR85yHgtq2MPkOEGLbjVvQ+QtKu7+lk6Jr+xSMWBjNf3393yARLHDnLl9e4his mbFinxtBjJwse+QSx3BdmEyZQan+wUz20X8TtTJJA7EbfDuLr3Mf+PB/DVBaV1e0Tk7T gb+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SuxR1Vnt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m3-20020a05620a24c300b006fef590aaf1si9797667qkn.0.2023.01.31.02.14.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jan 2023 02:14:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SuxR1Vnt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMndC-0002h7-Fj; Tue, 31 Jan 2023 05:12:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMnd5-0002Wr-Cd for qemu-devel@nongnu.org; Tue, 31 Jan 2023 05:12:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMnd2-0002ZP-T4 for qemu-devel@nongnu.org; Tue, 31 Jan 2023 05:12:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675159960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7wXoy4hpawBJ9otqLXYC4v2SX/x9yrMcB9Eo4ArEVHI=; b=SuxR1VntTvRoWZSz4QWtOz5Qy4rWx7oBRBJntTpT8eeAhwU01Tf/Da30JiWTqkM2Ply2xv kWalJ3iMMzc9/kEOdNzyL4nzM9+fh+wBk6qqw+z3MHTaQRSyR3UbxBaWWzANxxy9bMtV7k O0FGV+iGK4lZlV6kVcAdeirECZVzBf8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-by89KKNbOpq86BXkKjeUhA-1; Tue, 31 Jan 2023 05:12:35 -0500 X-MC-Unique: by89KKNbOpq86BXkKjeUhA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 91C00885622; Tue, 31 Jan 2023 10:12:34 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3289C15BAD; Tue, 31 Jan 2023 10:12:33 +0000 (UTC) From: Thomas Huth To: Peter Maydell , qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 21/27] tests/qtest/boot-serial-test: Constify tests[] array Date: Tue, 31 Jan 2023 11:11:59 +0100 Message-Id: <20230131101205.1499867-22-thuth@redhat.com> In-Reply-To: <20230131101205.1499867-1-thuth@redhat.com> References: <20230131101205.1499867-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20230120082341.59913-2-philmd@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/boot-serial-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c index b216519b62..3aef3a97a9 100644 --- a/tests/qtest/boot-serial-test.c +++ b/tests/qtest/boot-serial-test.c @@ -139,7 +139,7 @@ typedef struct testdef { const uint8_t *bios; /* Set in case we use our own mini bios */ } testdef_t; -static testdef_t tests[] = { +static const testdef_t tests[] = { { "alpha", "clipper", "", "PCI:" }, { "avr", "arduino-duemilanove", "", "T", sizeof(bios_avr), NULL, bios_avr }, { "avr", "arduino-mega-2560-v3", "", "T", sizeof(bios_avr), NULL, bios_avr},