From patchwork Mon Jan 30 15:48:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 648973 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA0FC636CB for ; Mon, 30 Jan 2023 15:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237461AbjA3PuK (ORCPT ); Mon, 30 Jan 2023 10:50:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237166AbjA3Ptn (ORCPT ); Mon, 30 Jan 2023 10:49:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2006941B62 for ; Mon, 30 Jan 2023 07:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675093730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iK+zUbg3IfyivImjOtAAZPRNA3nl2U9KaOpRKvRLj9U=; b=IfJVxzlNfdFyKgRp1cEq3wAwRnuLo8qbEUqBNJ4Uw+hxEI3MFlWPoO7YrCC0RrVCrV1Vnp n6WxwtgjIRnQMhxYSyCFnXMZ1V9jRLsYEHRzyYnsOeeerA1YcaxJU29NGe8wVQTYC23XCP QoB0iV8glLDmWSgP8lM91reY/A8gKG0= Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-556-BTa62y4gMsyYURBA_kV1JQ-1; Mon, 30 Jan 2023 10:48:49 -0500 X-MC-Unique: BTa62y4gMsyYURBA_kV1JQ-1 Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-1500bc69a97so4187497fac.7 for ; Mon, 30 Jan 2023 07:48:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iK+zUbg3IfyivImjOtAAZPRNA3nl2U9KaOpRKvRLj9U=; b=RMXROPfVWyyCOG8PoZKLXvEZ5LWYFxoQ0+bKODbK1EBQUrCfgGbX0wAKJeag3FTtAn 2gac3mtLQVhXVAxp9ELemAuZfcxmbcntIU8VyVEZKOPPgtw3EPmatyEHRE6G1CKMBkf2 KrMap6QMk/opzjeKc6qMGh8AzMQSjDr+P6lYGXB3fFZ9S7p85cKlCcYeC+NlYv+qFbli QMopRg9kkOJnEYxdYvSXwfdCa43diDAoUoZRGFP7ZoV7uNUemAtzuFFkuMyV/I/u4qx6 kJB5rz7P4LwQlx2UsATyxLh+ZRdIGrnOkbCmUHmX3+id7mNiONWx5OvWHnjcf0I/s9/J DoAg== X-Gm-Message-State: AFqh2koTLgI9ZuAMWGlPExP88xZYVvy82GwpCHr/8zBTxYrvX/OQwPJf Fv33i16KWvA9mtU7hDZ/7XMsWylq9dw7oGKtLHkkJSIEJJRvbhJL4KrSmiEqGRWnJtovDSOu5fN 7cw7CpLWWYsZ9YygXcB0FQJQBRw== X-Received: by 2002:a4a:8c68:0:b0:4a3:aa96:23c7 with SMTP id v37-20020a4a8c68000000b004a3aa9623c7mr21645477ooj.6.1675093728223; Mon, 30 Jan 2023 07:48:48 -0800 (PST) X-Google-Smtp-Source: AMrXdXsZlKsW4UmOUh6zsAp22dbVWH2s79oinxhwudtqXjMDouXPUguT+G2PrV8znXbFRgCyFddmFQ== X-Received: by 2002:a4a:8c68:0:b0:4a3:aa96:23c7 with SMTP id v37-20020a4a8c68000000b004a3aa9623c7mr21645469ooj.6.1675093727973; Mon, 30 Jan 2023 07:48:47 -0800 (PST) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::41]) by smtp.gmail.com with ESMTPSA id h3-20020a4ad743000000b0051763fef75fsm2137688oot.37.2023.01.30.07.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 07:48:47 -0800 (PST) From: Andrew Halaney To: andersson@kernel.org Cc: agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bmasney@redhat.com, quic_shazhuss@quicinc.com, Andrew Halaney Subject: [PATCH v2 1/2] arm64: dts: qcom: sa8540p-ride: Fix some i2c pinctrl settings Date: Mon, 30 Jan 2023 09:48:22 -0600 Message-Id: <20230130154823.117542-1-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Some of the pinctrl groups were invalid for the selected pins. Select the proper qup group to fix these warnings: [ 6.523566] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio135" for function "qup15" [ 6.535042] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio136" for function "qup15" [ 6.597536] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio158" for function "qup15" [ 6.597544] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio159" for function "qup15" [ 6.597991] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio0" for function "qup15" [ 6.597996] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio1" for function "qup15" Fixes: e073899ec3e1 ("arm64: dts: qcom: sa8540p-ride: add i2c nodes") Reviewed-by: Shazad Hussain Reviewed-by: Konrad Dybcio Reviewed-by: Brian Masney Signed-off-by: Andrew Halaney --- Changes since v1: * collected Reviewed-by tags arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts index a43f831f9018..6ab4b435c49e 100644 --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts @@ -318,21 +318,21 @@ &xo_board_clk { &tlmm { i2c0_default: i2c0-default-state { pins = "gpio135", "gpio136"; - function = "qup15"; + function = "qup0"; drive-strength = <2>; bias-pull-up; }; i2c1_default: i2c1-default-state { pins = "gpio158", "gpio159"; - function = "qup15"; + function = "qup1"; drive-strength = <2>; bias-pull-up; }; i2c12_default: i2c12-default-state { pins = "gpio0", "gpio1"; - function = "qup15"; + function = "qup12"; drive-strength = <2>; bias-pull-up; }; From patchwork Mon Jan 30 15:48:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 648699 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8397C54EAA for ; Mon, 30 Jan 2023 15:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237359AbjA3PuI (ORCPT ); Mon, 30 Jan 2023 10:50:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237718AbjA3Ptt (ORCPT ); Mon, 30 Jan 2023 10:49:49 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79DC11BD7 for ; Mon, 30 Jan 2023 07:49:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675093741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fRlDyXKPLMeNzgtxy7Fw1k/Ln61yLUxV1SRBoDuWD4Q=; b=Wcj5E2UEpndKyB7dxMxsoHY14MoSxA2pkB3JcfkPwZ1zk2BZWzKwZ8eQDL340NARWYOjGX J39vKFH8/xTrVPXjfX2+l/pYXVWgLgXSMfWGVU3bMmZRMvrfI8lF1PdSl/B9IB/XUoQzAK Bj4kKSvCpMEQVS+lDFKGotZuIlF1Axs= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-130-Rn4ZXEuhOFKRXL6v3bzPrg-1; Mon, 30 Jan 2023 10:49:00 -0500 X-MC-Unique: Rn4ZXEuhOFKRXL6v3bzPrg-1 Received: by mail-ot1-f69.google.com with SMTP id bu27-20020a0568300d1b00b006865fffa6d7so5830934otb.14 for ; Mon, 30 Jan 2023 07:49:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fRlDyXKPLMeNzgtxy7Fw1k/Ln61yLUxV1SRBoDuWD4Q=; b=cRk9tFM0Pk3P6lOFC2eDzgmvYBpaiTeLCp6XqLDQVLLkMRVSmKjTZZO5g3Dqh6ovgA ohZ8r/TY2e0b10hexiweduYodXxcHZXf13ZOk2V2ok/Sz/hHJwBoWiajGbp4YR2vhjmm vZhSbYcJgUO5+GCdCWnzmSz4fedMMDbGgchTaYixKGo75x93aEDHAxM5nwp2JD9v9BTH DhScPIVbEWgCSf8u2JGSHdW6cJyGW5NpnMoET0guW0/EA8IXh98hruSmI5SmoidzRPLx C7ECJgsSqYcatTMrTgWSb734NW2mXvd9NqgzIEndQN5mxvQZnBdNjFJDyvc+ebmcdqpj tfpQ== X-Gm-Message-State: AFqh2kp1x9B06wkrJdHqP3ncj3q6wPgmUBOXcE2DPCEIZw2U0hGCx44i hylgLv/1N8MuuNlTaMgAC8lg4/W0tQkU80S++6wwly4MA7rkXieh2UkkkdDFIK9KZ8WXcyY7QT6 JSum1QJhKslq+Pfhw9eWwNp98GQ== X-Received: by 2002:a4a:c305:0:b0:49f:8941:ffed with SMTP id c5-20020a4ac305000000b0049f8941ffedmr21754433ooq.9.1675093739563; Mon, 30 Jan 2023 07:48:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXtF/MHLgvMCX+knJ4UvMho4BjyD1571KGt8hCsvHeghOqHWHjJDyISzjJkMZy6DLoylQR5e1Q== X-Received: by 2002:a4a:c305:0:b0:49f:8941:ffed with SMTP id c5-20020a4ac305000000b0049f8941ffedmr21754421ooq.9.1675093739348; Mon, 30 Jan 2023 07:48:59 -0800 (PST) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::41]) by smtp.gmail.com with ESMTPSA id h3-20020a4ad743000000b0051763fef75fsm2137688oot.37.2023.01.30.07.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 07:48:58 -0800 (PST) From: Andrew Halaney To: andersson@kernel.org Cc: agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bmasney@redhat.com, quic_shazhuss@quicinc.com, Andrew Halaney Subject: [PATCH v2 2/2] arm64: dts: qcom: sa8540p-ride: Document i2c busses Date: Mon, 30 Jan 2023 09:48:23 -0600 Message-Id: <20230130154823.117542-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230130154823.117542-1-ahalaney@redhat.com> References: <20230130154823.117542-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org It isn't obvious in the current devicetree what is connected. Go ahead and document what's on the other end. Signed-off-by: Andrew Halaney Reviewed-by: Eric Chanudet --- Changes since v1: * Document i2c12 having a max20411 (Shazad) In v1 I said i2c12 was not connected, that's not true though (I just have a board schematic which shows it not connected, but it _is_ connected on the SIP/SOM, which I verified with series [0]). I debated waiting for Bjorn to sort out appropriate label names over at [0] (and follow suit in a third patch here), but decided to get this series out again to clean up the current warnings while that's worked out. Once [0] is resubmitted I'll submit a separate patch to enable the max20411 on this board as well! [0] https://lore.kernel.org/linux-arm-msm/20230130035642.GA464800@hu-bjorande-lv.qualcomm.com/ Thanks, Andrew arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 5 +++++ 1 file changed, 5 insertions(+) -- 2.39.1 diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts index 6ab4b435c49e..8b7555f22528 100644 --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts @@ -317,6 +317,7 @@ &xo_board_clk { &tlmm { i2c0_default: i2c0-default-state { + /* To USB7002T-I/KDXVA0 USB hub (SIP1 only) */ pins = "gpio135", "gpio136"; function = "qup0"; drive-strength = <2>; @@ -324,6 +325,7 @@ i2c0_default: i2c0-default-state { }; i2c1_default: i2c1-default-state { + /* To PM40028B-F3EI PCIe switch */ pins = "gpio158", "gpio159"; function = "qup1"; drive-strength = <2>; @@ -331,6 +333,7 @@ i2c1_default: i2c1-default-state { }; i2c12_default: i2c12-default-state { + /* To Maxim max20411 */ pins = "gpio0", "gpio1"; function = "qup12"; drive-strength = <2>; @@ -338,6 +341,7 @@ i2c12_default: i2c12-default-state { }; i2c15_default: i2c15-default-state { + /* To display connector (SIP1 only) */ pins = "gpio36", "gpio37"; function = "qup15"; drive-strength = <2>; @@ -345,6 +349,7 @@ i2c15_default: i2c15-default-state { }; i2c18_default: i2c18-default-state { + /* To ASM330LHH IMU (SIP1 only) */ pins = "gpio66", "gpio67"; function = "qup18"; drive-strength = <2>;