From patchwork Tue Apr 23 03:49:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162641 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322341jan; Mon, 22 Apr 2019 20:51:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzP5cSqaDKaGed9fbES7qa4ni5EA3ReGPeFTmPzfhIXjEP7QKxr8QPs81I2F7tADJRAEROU X-Received: by 2002:a65:6259:: with SMTP id q25mr22453853pgv.103.1555991492991; Mon, 22 Apr 2019 20:51:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991492; cv=none; d=google.com; s=arc-20160816; b=xluvX4MN0uSyuU4u4Tk2l+JqGTiQm7CNl1F5ZnAJsFT+9/dKjFC7xNz/mfx+dkDzDw stqA6YhMC8zCacaaJv/Vf0uXYrWxKr0zTP9GggMCrwR37ddsBGI56VMeOxZnaQWtJt3N BUTmbuF2Wnzxk2vlmVb2JiUt9/iJhMjhhOiW9ZQLo3QT96WC5x5WTpI6ucK4o3conEYc +HsjIfc6GFa3AjYkVtVm+xYpjBEC9D66xoV/6uGsWUs0n6+mcRIDX6ryQ2yGG+BB01Aj 6SvBnIWqrApD0V19DcoPDCrUGoaKDrzPIqyLMSqGz1uXMbf4hT5OseUB+8dWLD1EiBUD LaEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=bSpCfUAcyt+UjPMgYyZQmseLNPkdMgHIhxbhwQzsBmI=; b=R1KUNdMAQKkyYB16tTMCEdCbDLguE28quAi17EyEyBSUE5dfCzM4+SJgPhqGFi3yBX JIZfsm3fxahcy9uz+i1xhgg5JYsa6PYV3f4zYt3o+4dFCOzJjApxE9ZhPRfswB7i3MGj zgfczYm+SWXx44mSElKzbA1VMRa2CU9/JPIYPP59DFZa+bR5cVEhfEnd52LsocOADfhJ peZDAiJLPhULrSN3XN3xUmK3icTHBlvqNbQUCXX0S2Jcdgk6lwWRIQZ8S6bY32QtLnWy e2CM7NzcRvF0CwPSkZ2aNdjji/r5W+ZUUDaw0RS1KUv/CXqkeupXcVt1yfixM3PhUIJ6 YzGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=qQonU7ZJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r75si15528021pfa.10.2019.04.22.20.51.32; Mon, 22 Apr 2019 20:51:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=qQonU7ZJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730415AbfDWDvb (ORCPT + 30 others); Mon, 22 Apr 2019 23:51:31 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:38312 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730182AbfDWDv1 (ORCPT ); Mon, 22 Apr 2019 23:51:27 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2cA023044; Tue, 23 Apr 2019 12:50:04 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2cA023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991405; bh=bSpCfUAcyt+UjPMgYyZQmseLNPkdMgHIhxbhwQzsBmI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qQonU7ZJ8JQuK/yYFMxbIUEgpGk8t0atMGb/Xg6wfixcHjJS4ZUo9nyW+pQqWbV8T OxvALrGC8d/ErgshgANG1OAY+TcpQpCqnaavYGTgwqrgaUitAzgyE/9JOFwv4BsBdG wbeykQA6/Q04egSC+2R80XMzpSETZsYTxdB0oHI0xSH/b0z6nhabFnafw6cY5n9tKs 0f2/DWceDLDknEENgje4LV91UluDtdJv9N5kvqx6b3GklMOHRjgjlpHvwKHOkoiQvj F7yiwswgn7WygwK4jBgoIws8Okj6DQ9vW0zIHi+Rcqbu1FlYnNlSg+X3RQo8mdEc/b gz8IOWt3SAfsQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Cc: linux-s390@vger.kernel.org, Heiko Carstens , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Mathieu Malaterre , Masahiro Yamada Subject: [RESEND PATCH v3 02/11] arm64: mark (__)cpus_have_const_cap as __always_inline Date: Tue, 23 Apr 2019 12:49:50 +0900 Message-Id: <20190423034959.13525-3-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place. We need to eliminate potential issues beforehand. If it is enabled for arm64, the following errors are reported: In file included from ././include/linux/compiler_types.h:68, from : ./arch/arm64/include/asm/jump_label.h: In function 'cpus_have_const_cap': ./include/linux/compiler-gcc.h:120:38: warning: asm operand 0 probably doesn't match constraints #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while (0) ^~~ ./arch/arm64/include/asm/jump_label.h:32:2: note: in expansion of macro 'asm_volatile_goto' asm_volatile_goto( ^~~~~~~~~~~~~~~~~ ./include/linux/compiler-gcc.h:120:38: error: impossible constraint in 'asm' #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while (0) ^~~ ./arch/arm64/include/asm/jump_label.h:32:2: note: in expansion of macro 'asm_volatile_goto' asm_volatile_goto( ^~~~~~~~~~~~~~~~~ Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - split into a separate patch arch/arm64/include/asm/cpufeature.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 Tested-by: Mark Rutland diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h index e505e1fbd2b9..77d1aa57323e 100644 --- a/arch/arm64/include/asm/cpufeature.h +++ b/arch/arm64/include/asm/cpufeature.h @@ -406,7 +406,7 @@ static inline bool cpu_have_feature(unsigned int num) } /* System capability check for constant caps */ -static inline bool __cpus_have_const_cap(int num) +static __always_inline bool __cpus_have_const_cap(int num) { if (num >= ARM64_NCAPS) return false; @@ -420,7 +420,7 @@ static inline bool cpus_have_cap(unsigned int num) return test_bit(num, cpu_hwcaps); } -static inline bool cpus_have_const_cap(int num) +static __always_inline bool cpus_have_const_cap(int num) { if (static_branch_likely(&arm64_const_caps_ready)) return __cpus_have_const_cap(num); From patchwork Tue Apr 23 03:49:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162640 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322304jan; Mon, 22 Apr 2019 20:51:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwiaAc1Dz8xarxY7FtfVa6dIK0HP1TdyVs7GtdE6an0dDeMOrNcktQ+e0mnpGoazVyDAV+m X-Received: by 2002:a17:902:be04:: with SMTP id r4mr23648856pls.218.1555991487439; Mon, 22 Apr 2019 20:51:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991487; cv=none; d=google.com; s=arc-20160816; b=cmga7zTxhzLB5M2rMzDW608WxyaTClyN3dPMm4XXIP6yz6GnQpagbJSwCearxb+EfH FrZZJwyFrQ8V7iSW1dwJTkWD3z/h3YPzObxhmM+fjrogGp3PdFtoUP61EBa6QaazaPxa dJGZBZh49nGEzhkNO0U6d/UZ2d6eEMJUPBS/qvTqQckPYgharYVtj1HYPhGpyzGroUZ6 8O1J1vTHyzJdNo1eHb3CKWsR2D2wBQ5gB4cMd2e6VlUi7LTK70FFkZCjpXNvd89pqYMS 3FdMKTi53EfZmAXBGXeXOeDNsE83DVlCicNUGBwuYOYLVas4WZvueZ+Nv3bsjawwsAer ihiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=Uo1hU/pOzqv1Q6UwWPC8xpA1XS41uzJeh8wwHc0qw10=; b=EvkDdNvhrTXQfnwpNL8yB6KLQui9pGPQNdeD/ORl3p07o/MbUYAWHWi5Ujb/R08DcC 6VdZngKw2GSBtHklAeIOnZEldyiFEGUi1rpfBwzRlsAPmeZ4HzeO0oU4vkMs0t81zCVO qHYRVEuiYT8D+T9ifv/S+rr37G0w5Q7lRGAznKx8lI2Z9NPKkTHtJ0gfILeY8NLpz/FV JJxhUfkesse+X/+W0+1FkFnOx+tDhuNzAOcaivWTwnNIhCiDblWgLamFMsAAteq8lbTD K6nIbBS4ZOPkLsC2ipmsqUYKtm2+OdbKc0dWOPj71+asHxl3vg/3vDVFv0rUW6rBLQVG n+dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=afqDfXVj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 15si16057993pfz.73.2019.04.22.20.51.27; Mon, 22 Apr 2019 20:51:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=afqDfXVj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730281AbfDWDvZ (ORCPT + 30 others); Mon, 22 Apr 2019 23:51:25 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:38273 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730111AbfDWDvZ (ORCPT ); Mon, 22 Apr 2019 23:51:25 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2cB023044; Tue, 23 Apr 2019 12:50:06 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2cB023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991406; bh=Uo1hU/pOzqv1Q6UwWPC8xpA1XS41uzJeh8wwHc0qw10=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=afqDfXVjkaU0um6ru4UQMMi/0BjTNH297qWtGHSlxZheAmZyP7g2xdSoWOVya1o3F wGNcrJgeLRi6N/dbYoVHmPyHDzsnc2AU0bWQ+9qUTrdrQivAR0riQON09o58AWsOGr 3MiTJC5LhBxOf783Kh7T5ogQtLBRlDPZpIjEknU13Pb5R24UeulQjWWACsWqksWNy/ MOi4jEYXLWhhh0fOsa98tELQZ7ialZWJGxUV2Bf+R1moCuqtuvyxDYXI3zc0pibOqZ Ia4mCuwX/wsrlpQjBMZfH8khciAtejgbm1rP56cXK3ZONAbZKMksvRc2KMzhxqMxfc n907v8qlw7Oqw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Cc: linux-s390@vger.kernel.org, Heiko Carstens , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Mathieu Malaterre , Masahiro Yamada Subject: [RESEND PATCH v3 03/11] MIPS: mark mult_sh_align_mod() as __always_inline Date: Tue, 23 Apr 2019 12:49:51 +0900 Message-Id: <20190423034959.13525-4-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place. We need to eliminate potential issues beforehand. If it is enabled for mips, the following error is reported: arch/mips/kernel/cpu-bugs64.c: In function 'mult_sh_align_mod.constprop': arch/mips/kernel/cpu-bugs64.c:33:2: error: asm operand 1 probably doesn't match constraints [-Werror] asm volatile( ^~~ arch/mips/kernel/cpu-bugs64.c:33:2: error: asm operand 1 probably doesn't match constraints [-Werror] asm volatile( ^~~ arch/mips/kernel/cpu-bugs64.c:33:2: error: impossible constraint in 'asm' asm volatile( ^~~ arch/mips/kernel/cpu-bugs64.c:33:2: error: impossible constraint in 'asm' asm volatile( ^~~ Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - split into a separate patch arch/mips/kernel/cpu-bugs64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/arch/mips/kernel/cpu-bugs64.c b/arch/mips/kernel/cpu-bugs64.c index bada74af7641..c04b97aace4a 100644 --- a/arch/mips/kernel/cpu-bugs64.c +++ b/arch/mips/kernel/cpu-bugs64.c @@ -42,8 +42,8 @@ static inline void align_mod(const int align, const int mod) : "n"(align), "n"(mod)); } -static inline void mult_sh_align_mod(long *v1, long *v2, long *w, - const int align, const int mod) +static __always_inline void mult_sh_align_mod(long *v1, long *v2, long *w, + const int align, const int mod) { unsigned long flags; int m1, m2; From patchwork Tue Apr 23 03:49:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162644 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322546jan; Mon, 22 Apr 2019 20:51:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqyrRcLUM81OZNVwmCyZthp8+wseSDzGwLLGZOhKnIgOT0dXjNbp4KEQqM9vvnK2owOqRmla X-Received: by 2002:a17:902:302:: with SMTP id 2mr24146868pld.232.1555991515436; Mon, 22 Apr 2019 20:51:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991515; cv=none; d=google.com; s=arc-20160816; b=w9BUbeM2e57W/Nkz09qKuV3boRRphE25PZfVD+rh2yAtRB9iA7sRvIkNwtLiMcxzbj 0pP7XzTxOvoTjBShD5m4vGAD//f7koZRwYGhSkZf3fHvJfwO2Y7VhB51iMySp44oidAR 45Y4jxPCp2QRXgeisQ6oQZQzoRL5HO274gG/Brhv6UqPNfda45xq9p7k2J0QBakyvrxP FWiTH2+asaKxvg9fNaQaLOtkv4x+6icVBlRyYfwpYrbpr/PJe6lOSqVrI+vw2XLTk0c5 o7ib1TWANV7jATtZgkOkHYRcNcNGnlfDTPGLvBhNGDSmHJigmWPPgH1r5xHUGuKajN61 FBuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=ck3m1Bnhk+gBZ69Ip9jiWsEf5IWvpXJTs7wxMIQoCXU=; b=eWMcUYdLc2p2cVlF2kI82qG0fJA4+2sMUdHJNC2HYcMiUxXjz5w4jA6ccuVNK6a/Wi gl3+v8a2tJ1SX01dDgejFz89VhOG62BY2NR5lA3yh2j8yC5YV/bzVFGyF9kNtrYMo/7J Sw8OoYAPza4vsplWjGFXP7sug7ecItpiGDW5+Z9lx3FL+9uqqvt42v5FDPExi9Yqu3pU tDsKOLRjGWh+EOCS8dgSyKkbdwdbBQe9bcSEYHjkfD3bgS/wNZgkZq4HzLuicSqEmr3c SYh1iEqxwT7ezxTv6nhkyB5BFywktwAMexjo9obrMZibPUDYGNSyTmMuzwkVAm73p2lQ gnaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=n6YMDDai; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cb16si15980247plb.227.2019.04.22.20.51.55; Mon, 22 Apr 2019 20:51:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=n6YMDDai; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730734AbfDWDvy (ORCPT + 30 others); Mon, 22 Apr 2019 23:51:54 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:38995 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730606AbfDWDvu (ORCPT ); Mon, 22 Apr 2019 23:51:50 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2cD023044; Tue, 23 Apr 2019 12:50:11 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2cD023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991412; bh=ck3m1Bnhk+gBZ69Ip9jiWsEf5IWvpXJTs7wxMIQoCXU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n6YMDDaiO+Y+ehsJY3BwtkUdg1YDcyPA3Dzmuu8XOwJ1WrZig5ClP17Sypb2aBakK pdb05/Mxt6GVPh61aaBT0xJP66Mu0V7s+lzlxmzMKtCZpnT8wEPrNDYE+HzwcwOsrt M+K4hgRSZ2BsDVMyqA2McjsJjJooi4+aOx81MKG7ecEsFD8/riXxDnXctaXPrCzSeY 2Awph1mCyl2BuT2YcctjtjX9fGNx3slwDHVqkisVXH/eIqwqW4g1+6Ign1Zg0xzjsQ nEbhKOdhvwUnu9BexA/KqiOdzGngWI9/3T9raieSibcixW3rUYkf2NW/Jkw05P6Tx3 svNkTBvfuxmgA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Cc: linux-s390@vger.kernel.org, Heiko Carstens , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Mathieu Malaterre , Masahiro Yamada Subject: [RESEND PATCH v3 05/11] mtd: rawnand: vf610_nfc: add initializer to avoid -Wmaybe-uninitialized Date: Tue, 23 Apr 2019 12:49:53 +0900 Message-Id: <20190423034959.13525-6-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place. We need to eliminate potential issues beforehand. Kbuild test robot has never reported -Wmaybe-uninitialized warning for this probably because vf610_nfc_run() is inlined by the x86 compiler's inlining heuristic. If CONFIG_OPTIMIZE_INLINING is enabled for a different architecture and vf610_nfc_run() is not inlined, the following warning is reported: drivers/mtd/nand/raw/vf610_nfc.c: In function ‘vf610_nfc_cmd’: drivers/mtd/nand/raw/vf610_nfc.c:455:3: warning: ‘offset’ may be used uninitialized in this function [-Wmaybe-uninitialized] vf610_nfc_rd_from_sram(instr->ctx.data.buf.in + offset, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nfc->regs + NFC_MAIN_AREA(0) + offset, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ trfr_sz, !nfc->data_access); ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - split into a separate patch drivers/mtd/nand/raw/vf610_nfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c index a662ca1970e5..19792d725ec2 100644 --- a/drivers/mtd/nand/raw/vf610_nfc.c +++ b/drivers/mtd/nand/raw/vf610_nfc.c @@ -364,7 +364,7 @@ static int vf610_nfc_cmd(struct nand_chip *chip, { const struct nand_op_instr *instr; struct vf610_nfc *nfc = chip_to_nfc(chip); - int op_id = -1, trfr_sz = 0, offset; + int op_id = -1, trfr_sz = 0, offset = 0; u32 col = 0, row = 0, cmd1 = 0, cmd2 = 0, code = 0; bool force8bit = false; From patchwork Tue Apr 23 03:49:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162648 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322838jan; Mon, 22 Apr 2019 20:52:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzOInAvEjjK3llq/4Jhay7HV23RjJtC+uhTapW1Q4Nqm/rML5USE4yb08iu2852LGCu996u X-Received: by 2002:a17:902:42:: with SMTP id 60mr23908405pla.79.1555991539361; Mon, 22 Apr 2019 20:52:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991539; cv=none; d=google.com; s=arc-20160816; b=AUHTY8qPt+f4yI5l8wMhxTpodkXhekgO+eAIf6smyVf0J6mA3fzqvWpBeBHPgsbc16 JGybsdmgEfLacTsUavekiXGhKHBa1Bsmm78qv5ZE9VmWa3z8UQ34zx1ItBkdPGe6BPPM jn2MlcQYAhFfYngPxrBoYXBGbmqFrx1z4HnbdFwfNMaJDkXysRzq1zQaeTuWeolpAjq9 QMl0I9HCNN7eRzi7J+wbBRQXMUrB2A2f05JVGLl9z2PmYJl7yLuQlMyn623wMqCW3jP4 L0fPCSC5+YYV3RpNEeRvEdu/QwZH/a675yLEIpYNrVmdMN4S5xWSeJGLR1wqPQmrzWFx l98w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=h+EwU9qqdYxQmwoBR4Te9yGMUTWayFtr2mQvRUGDY+4=; b=dF8CInsPTCDITlQ9c1lHGrPzCjFVyVHCiubJIFh2Fz3u9W+9FdgWMqUYWLCMaMmv9o xomVbF/kSfVzI2t9waHt86TeVEH7xD4HLM5YrheA/DejTdGn8sT5fX8V3+2rqzWlf+Tu O9tO4Xf8gtd6odZaAT6gD4w/EHJQLs7uQbKA5ZDDCU9b0TyegjQJ/UPmnBQiUxqu/xTZ JhR8PEHu3rsRbS3gQR2XZ9MAvjB/ia1QL+oWO+fxMICkpOAOGn6SFNbpqsQBp0YPp8wL xI6MKMa/6XPqrwj7Uw+sw6PiDIeaHfhdBEBl7GlLAzHtOokAmkdSFIh0JK5rf/YgKAEZ dqew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=1P23h9vh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m2si14679399plt.429.2019.04.22.20.52.19; Mon, 22 Apr 2019 20:52:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=1P23h9vh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730566AbfDWDvp (ORCPT + 30 others); Mon, 22 Apr 2019 23:51:45 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:38719 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730463AbfDWDvj (ORCPT ); Mon, 22 Apr 2019 23:51:39 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2cE023044; Tue, 23 Apr 2019 12:50:12 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2cE023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991413; bh=h+EwU9qqdYxQmwoBR4Te9yGMUTWayFtr2mQvRUGDY+4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1P23h9vht+/GBqnRwv/UkIJ1suM0Gl11zAvmk/8SvuVwFNSEjjcz5wleVPujRFppK Nx/EYAsyelP9HyPthWeDWEqGmry1y5MqVAH4kuSg33aYusbvligBz2HN/GC99w5vtM 5Yg0icURIigmLM1gADO7WXFZwt4Hq3fD5BBu/LSkX8+UB6/Luat0ziOGN7ZMWhGLS9 fo58H0dKM6524EBjfnfQOTOMJ1r1Ka3EpWa+TiKZiQ94Q1gXooQjZTOQDDB6tvyUPV 0xBOTQRtogiBnMr/KZOj2ZHdEdJmH3fC/VnCXHcN5E/hwV0LkVqNuoBAt1sE3Wfa2v Nsv6CrzlYC6bA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Cc: linux-s390@vger.kernel.org, Heiko Carstens , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Mathieu Malaterre , Masahiro Yamada Subject: [RESEND PATCH v3 06/11] MIPS: mark __fls() and __ffs() as __always_inline Date: Tue, 23 Apr 2019 12:49:54 +0900 Message-Id: <20190423034959.13525-7-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place. We need to eliminate potential issues beforehand. If it is enabled for mips, the following errors are reported: arch/mips/mm/sc-mips.o: In function `mips_sc_prefetch_enable.part.2': sc-mips.c:(.text+0x98): undefined reference to `mips_gcr_base' sc-mips.c:(.text+0x9c): undefined reference to `mips_gcr_base' sc-mips.c:(.text+0xbc): undefined reference to `mips_gcr_base' sc-mips.c:(.text+0xc8): undefined reference to `mips_gcr_base' sc-mips.c:(.text+0xdc): undefined reference to `mips_gcr_base' arch/mips/mm/sc-mips.o:sc-mips.c:(.text.unlikely+0x44): more undefined references to `mips_gcr_base' Signed-off-by: Masahiro Yamada --- Changes in v3: - forcibly inline __ffs() too Changes in v2: - new patch arch/mips/include/asm/bitops.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/arch/mips/include/asm/bitops.h b/arch/mips/include/asm/bitops.h index 830c93a010c3..9a466dde9b96 100644 --- a/arch/mips/include/asm/bitops.h +++ b/arch/mips/include/asm/bitops.h @@ -482,7 +482,7 @@ static inline void __clear_bit_unlock(unsigned long nr, volatile unsigned long * * Return the bit position (0..63) of the most significant 1 bit in a word * Returns -1 if no 1 bit exists */ -static inline unsigned long __fls(unsigned long word) +static __always_inline unsigned long __fls(unsigned long word) { int num; @@ -548,7 +548,7 @@ static inline unsigned long __fls(unsigned long word) * Returns 0..SZLONG-1 * Undefined if no bit exists, so code should check against 0 first. */ -static inline unsigned long __ffs(unsigned long word) +static __always_inline unsigned long __ffs(unsigned long word) { return __fls(word & -word); } From patchwork Tue Apr 23 03:49:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162647 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322785jan; Mon, 22 Apr 2019 20:52:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqx4UdyHjiIW5kbu5z+IwW8prPlah+lcWkV+YnshblbX9JKlKn8RSLka0qSDa9jZk8bP8y66 X-Received: by 2002:a63:d24d:: with SMTP id t13mr22427171pgi.439.1555991534432; Mon, 22 Apr 2019 20:52:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991534; cv=none; d=google.com; s=arc-20160816; b=YfNjpvqdx8TneriFAU1prq8JKjfb8G8A48dNKjBvl+3jIWkkJ9nUivo1pqeTF9xLSj YASEylXHTn4C05LTldR1I46rIduuyWjeYRsBIxZYtCa6FGRwtoKzulx8cfFnDACS2WIQ un7cc2JsS1wyhYQjcl5CzyGU30eZcP3GUqSO6ML5d3wZA0rYKcL1oGIeGOwdgEgFcchn 7TdZ4e+H3hWZwVPlNPfh8YXsdAiBSX6Cj8cZ2LmJIR8PhBLk9i0gVHoRNZVAIGdUxpp9 bsPu4xiHVuRnHiwLLkbM+lexbpGxU9+fSXzruoBOJm7Gs7cu1YWwuC+RQ8VXCQfJI0mU Zbrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=6a2lxZ60QvbOnt17TfgaQyw8mxjsKyu0piFkGUEaJaM=; b=KEf3QSUgpXfJ7/chKe8Phl8ketQCBT+M1bs7rhjVtnB3wNLfrmXQPPB85wCi62LpMV vEDpVqHZF6U7Vn5oIUFF66Dj3Hq/WKr/SugqAlMtDr3bWPGpfd6HJFyqhw5znGRPtyMq J1E3ZyEzmFp3kc0RXNF+3tR2Zxnwj85MTMjd1i2dt6DwZuuSVTqK9iKzBr6UF81p4JHh MMuLiM6Yyz8Z6dRwlYWofWkoaAxEDJMi/ZnioidSqY8NepQBj8jFAw7fdSi9s8NBM2/Y PnjkoSzg0SIizKKLVzOCr27SjEsvF3pTYJcwaWCMLuxfejF8lgM8Ztye88qeFhkrXrJQ EJQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=KkcVGuZw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m2si14679399plt.429.2019.04.22.20.52.14; Mon, 22 Apr 2019 20:52:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=KkcVGuZw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730802AbfDWDwM (ORCPT + 30 others); Mon, 22 Apr 2019 23:52:12 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:38869 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730510AbfDWDvq (ORCPT ); Mon, 22 Apr 2019 23:51:46 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2cF023044; Tue, 23 Apr 2019 12:50:13 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2cF023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991414; bh=6a2lxZ60QvbOnt17TfgaQyw8mxjsKyu0piFkGUEaJaM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KkcVGuZwG103H22stN6irsWh0/sE3M3Fy3ba9dpJ8bE+lRWF8/73lXPhpMJlOJ1dC HDbfqkLUOj8YWYZezvqSDCGIdHrA3b6mtMnVdeKAihhOSFTi75d3V5YMkzVDnusnr2 Rw7CiZrEfeqlhJwcxuKX67jhSm/GwXXH2AAd5hO03PCzS2n6mBkJw7LQjt1WuzBcxB zp8uRZnudBf6v6v98crxC1YC6HwhxAEH9CR13J0EN8vLuJkWpV6zlraxtQOH15A5/a 0OM2V6uoxhBSrIa6qnl6e66u2YQyPGzWKCrTYana/63053f3qtdEe/+GWbdYwjVmfA MOuO6rgVe+s9Q== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Cc: linux-s390@vger.kernel.org, Heiko Carstens , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Mathieu Malaterre , Masahiro Yamada Subject: [RESEND PATCH v3 07/11] ARM: mark setup_machine_tags() stub as __init __noreturn Date: Tue, 23 Apr 2019 12:49:55 +0900 Message-Id: <20190423034959.13525-8-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place. We need to eliminate potential issues beforehand. If it is enabled for arm, Clang build results in the following modpost warning: WARNING: vmlinux.o(.text+0x1124): Section mismatch in reference from the function setup_machine_tags() to the function .init.text:early_print() The function setup_machine_tags() references the function __init early_print(). This is often because setup_machine_tags lacks a __init annotation or the annotation of early_print is wrong. Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - new patch arch/arm/kernel/atags.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/arch/arm/kernel/atags.h b/arch/arm/kernel/atags.h index 201100226301..067e12edc341 100644 --- a/arch/arm/kernel/atags.h +++ b/arch/arm/kernel/atags.h @@ -5,7 +5,7 @@ void convert_to_tag_list(struct tag *tags); const struct machine_desc *setup_machine_tags(phys_addr_t __atags_pointer, unsigned int machine_nr); #else -static inline const struct machine_desc * +static inline const struct machine_desc * __init __noreturn setup_machine_tags(phys_addr_t __atags_pointer, unsigned int machine_nr) { early_print("no ATAGS support: can't continue\n"); From patchwork Tue Apr 23 03:49:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162645 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322636jan; Mon, 22 Apr 2019 20:52:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqwaTwyscYOmW6B3vkCdcNJJHIVTumZ66/+sa8knUWyFp0+KI1ARyBa6GPP7QYlykqB6LctT X-Received: by 2002:a17:902:4827:: with SMTP id s36mr24407198pld.296.1555991522134; Mon, 22 Apr 2019 20:52:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991522; cv=none; d=google.com; s=arc-20160816; b=XVpnlxaQvA4jErmNGpe6vZVn22+ROgbU2iNy/0RB+kVDhWnVqNa1OPOvGNlqQz7buk GoueGFPdCb/gjMXn94Y86KzASIM5kKhmFgbtLgk6SEXIoEe1lRkxdDInIb1AnVOsaLDp Gpn3oHmvuXY4FQw9PEbL7Jur3leisQyN4LY9MFpJDC9FBko9cgW3Kpaidn1ONnaEf0Nh ZdY0sY4f+HFzU9Pm0UHZEmFFcia8pBct8TecgGWdh8Fk9+IWJQPvS3KYFiCa6qTnPEfB PDmVSG+vyZPHlxkY1PA3STzKtFl0ko805WvJX3YeZq6sDWzcpRuXOkUXEt0ZZU4NBcc8 rXNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=7qo1vbhArO2n/LZF4sYuHYL1/6J0V//9VqfNxacUkeY=; b=z38kEZVdOz6JXr2y1ClOmjZ8u+I50D6U+8e+PWBczU/qkqT+GcVhwdtn4IhcbPRuM+ GpW6GeI+84K0hmNYF1vhvyDAhbxGxE4yDW1ji2jbb9HdXBjjFAlna6k9+Y7MBaPtddsk WwI9SO82WbTM/jSFZO3vMD9eCLgtt7W2LowBA4EETjGRrvBquDTSs5bCnhPGXAeweomL VXvaNdXb0DCjcIJE1YQqB4S8BdqqDdXbSozbmKYE+nmDktrKzpQ04fezm/D20H0+87C1 0yZeHMYMCihbTRy/z6fcsG/IqwfvYd2OHc5XOG/EgC6QRNhmy+21Wjhcx4ytG8EnYELU /vXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Q1F13NSr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cb16si15980247plb.227.2019.04.22.20.52.01; Mon, 22 Apr 2019 20:52:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Q1F13NSr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730656AbfDWDvu (ORCPT + 30 others); Mon, 22 Apr 2019 23:51:50 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:38927 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730536AbfDWDvr (ORCPT ); Mon, 22 Apr 2019 23:51:47 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2cG023044; Tue, 23 Apr 2019 12:50:14 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2cG023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991415; bh=7qo1vbhArO2n/LZF4sYuHYL1/6J0V//9VqfNxacUkeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q1F13NSrcvF2A8qD58k2kFX20pyFSYFFSEFXfst6MemH5nI+ogQbTVZV3rS+GsNcQ KHXD/9fjRv22l68l7IfxbcQnjZxs4/S6S0aDRad5BGjZ9TbVEhTGuuTtQqcH3vZlMa Siw+84dNlAlVVzvfSrMI067rafVMa4BZHPnzWNsDgdS02CdcDMajkswexssLpGT01t l2AFzuHdfvAep6hvoUoVEMXRoVxLbpZN+6DdicEMa0CRcEk/LeolZuI3xJ3MSFXuaj MiCbwlnKTnNt1QTVHluGORCKmpwIjnHxYZ/R8g+wKMdXrh00H0Yb3w3Ov8DaBB5Rkt tvc2mqgRywIIg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Cc: linux-s390@vger.kernel.org, Heiko Carstens , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Mathieu Malaterre , Masahiro Yamada Subject: [RESEND PATCH v3 08/11] powerpc/prom_init: mark prom_getprop() and prom_getproplen() as __init Date: Tue, 23 Apr 2019 12:49:56 +0900 Message-Id: <20190423034959.13525-9-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place. We need to eliminate potential issues beforehand. If it is enabled for powerpc, the following modpost warnings are reported: WARNING: vmlinux.o(.text.unlikely+0x20): Section mismatch in reference from the function .prom_getprop() to the function .init.text:.call_prom() The function .prom_getprop() references the function __init .call_prom(). This is often because .prom_getprop lacks a __init annotation or the annotation of .call_prom is wrong. WARNING: vmlinux.o(.text.unlikely+0x3c): Section mismatch in reference from the function .prom_getproplen() to the function .init.text:.call_prom() The function .prom_getproplen() references the function __init .call_prom(). This is often because .prom_getproplen lacks a __init annotation or the annotation of .call_prom is wrong. Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - split into a separate patch arch/powerpc/kernel/prom_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.17.1 diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index f33ff4163a51..241fe6b7a8cc 100644 --- a/arch/powerpc/kernel/prom_init.c +++ b/arch/powerpc/kernel/prom_init.c @@ -501,14 +501,14 @@ static int __init prom_next_node(phandle *nodep) } } -static inline int prom_getprop(phandle node, const char *pname, - void *value, size_t valuelen) +static inline int __init prom_getprop(phandle node, const char *pname, + void *value, size_t valuelen) { return call_prom("getprop", 4, 1, node, ADDR(pname), (u32)(unsigned long) value, (u32) valuelen); } -static inline int prom_getproplen(phandle node, const char *pname) +static inline int __init prom_getproplen(phandle node, const char *pname) { return call_prom("getproplen", 2, 1, node, ADDR(pname)); } From patchwork Tue Apr 23 03:49:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162643 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322525jan; Mon, 22 Apr 2019 20:51:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqxV3QfbTH+uMHDgHFWcV/uAPpqqCiMMOEE+jIvUhmTMvTmpbrbRDm3XgZUK1GAuCdsvx958 X-Received: by 2002:a62:1249:: with SMTP id a70mr24580315pfj.160.1555991513524; Mon, 22 Apr 2019 20:51:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991513; cv=none; d=google.com; s=arc-20160816; b=kK62zjJ0HjgJkhAJcSgzWQOfstJfgN3PPaBMXBiPLklzzFFGkwIuM3X69fOS0TkHav GTSy7Pbft2jyar37zwvSPb+RlDoEh+CfTLNe03FFVI/BE2vSFXNZGvjZYJnEXi4+Aeqh fekgfZz/ECKvsqK1LApVt5lZZ+pY7rBxGs8qa5mLncVRcAKmcoF7nnJalW5lmerM4Ncw lefccIDAAWJgFFYbzxSt4CozKoxeSih31egQsPszt+oEjYsrw3crhteH8Htu3saKdFwd v+ud+3aOyDU2o0zUGINJkpop5KDZkIoGAxd9fcq6dYdlaxTYHtTAZ2+uOF0MMh0hCe1P k+IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=dlukBYO6sgrMJOkaTgBisXwB5sU3qv4thlZ8O2ehfGY=; b=IiwBRUNVsQ7uid/ErRt7S1qfzvcXvX1DCvdHpomkoR/QSam2wBW6wcs+WeYernlGGz LV6uIxQzQnokrwMxX+BHH0v4EXpribmlwgPm7umVxJTLjSIcnoa1U1qdbPuT7hCodS/1 jBMRByjsHkCZFUBhc6i6PucRqR3fCoFwOvriFqCyd1UwgzFlBSO6T6X9mM+YJIaFO8/a LKGyGjWkHhsJRpCH1pQVGhhQqgyyArTGIQiz/1VrPXxsN/JbLVCR1JbcmN6qlOlEWhEp f9vwqvfQ/OhVIAUAxbUzX7uSuNqQAzTQnymSUy6ND+y6NJGU8iAz7Xvb1JRTEMS7Mjfr Ed6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="DgLSh5p/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si2342574pgm.568.2019.04.22.20.51.53; Mon, 22 Apr 2019 20:51:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="DgLSh5p/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730702AbfDWDvw (ORCPT + 30 others); Mon, 22 Apr 2019 23:51:52 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:38896 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730524AbfDWDvq (ORCPT ); Mon, 22 Apr 2019 23:51:46 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2cH023044; Tue, 23 Apr 2019 12:50:16 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2cH023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991416; bh=dlukBYO6sgrMJOkaTgBisXwB5sU3qv4thlZ8O2ehfGY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DgLSh5p//r6WFmO5jHCtDDcni9rgvcY+M0jXqaVcDpmetnoTv3LH2i7BbTaWnPEQA ekvT9GhnH/wJhjlIDDCG4ogK8OrxDRfpKrXxorea+hWs44MMGkmufq8vRI1VDI2xtf E/Egf9Qrn/X2ji428KFPPca6RL3Odgm+aeiI1TlOh5n2jGHjU9CzdRcVlpwYNM1u8B D3Rdxm3EAtjpH5wFt6I+bTxO/6dZmwf0tIr0TQbamP2Q7SfjkbqmrBg4bNiJZ+U2QP 5+M50jLU0nfTpzi0185F/CXJtegbNcH2kUGjKtAAsw1ufXr+9imCgE16mm7HqCVTgg 13SiP6iuu4Trw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Cc: linux-s390@vger.kernel.org, Heiko Carstens , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Mathieu Malaterre , Masahiro Yamada Subject: [RESEND PATCH v3 09/11] powerpc/mm/radix: mark __radix__flush_tlb_range_psize() as __always_inline Date: Tue, 23 Apr 2019 12:49:57 +0900 Message-Id: <20190423034959.13525-10-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place. We need to eliminate potential issues beforehand. If it is enabled for powerpc, the following error is reported: arch/powerpc/mm/tlb-radix.c: In function '__radix__flush_tlb_range_psize': arch/powerpc/mm/tlb-radix.c:104:2: error: asm operand 3 probably doesn't match constraints [-Werror] asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1) ^~~ arch/powerpc/mm/tlb-radix.c:104:2: error: impossible constraint in 'asm' Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - split into a separate patch arch/powerpc/mm/tlb-radix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c index 6a23b9ebd2a1..a2b2848f0ae3 100644 --- a/arch/powerpc/mm/tlb-radix.c +++ b/arch/powerpc/mm/tlb-radix.c @@ -928,7 +928,7 @@ void radix__tlb_flush(struct mmu_gather *tlb) tlb->need_flush_all = 0; } -static inline void __radix__flush_tlb_range_psize(struct mm_struct *mm, +static __always_inline void __radix__flush_tlb_range_psize(struct mm_struct *mm, unsigned long start, unsigned long end, int psize, bool also_pwc) { From patchwork Tue Apr 23 03:49:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162642 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322474jan; Mon, 22 Apr 2019 20:51:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqyGjKtySeZwLaJyHZfaekQzAcZFs5Vx+TwsnP6WoI3mp5p7GlBA+m8WF73wG99HzQrcCxIr X-Received: by 2002:a17:902:9b92:: with SMTP id y18mr15650116plp.187.1555991508050; Mon, 22 Apr 2019 20:51:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991508; cv=none; d=google.com; s=arc-20160816; b=Bjyyz6mo0RJzrXxPIat3UdLpENkaqLRRm7MMoRMLfsehGfuUt7LcyEKawKV7FiNcKH LyfLsJXRh83Jq4bmc6M7tFN85upJkJuJtJxd3/Cko58EyfkWGPBG4FVKZ2JR+K747Zog 120mlzArEnQPC0UF7p3oAV5q1+by4xTcIkwHCUO9NKY0JCdCu3+XFICKH7aiS7dW/b2W R1GSlIBX2gRY14CsihWRVqvx6t9i6l7P9tVJsk2wesIoHS3P68NUjDdLtViWEcR6zMHQ ZaAUKMt6D/GulnKaFmIlv81N/0UpNcmgCzX38FxC+KT75fbHOlaLPAQhVACVi3sy4Oh8 COeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=O+ymeBuOvG0uQG78yokX58qG5GQYyDm6Ks5zKkCXYg8=; b=DrPWgX62Q9VhYERgMMOq1hOgPawl65ayjqhmNcmHZ+ofuxkDmALRVYP3dBV8KwAsfy vfKxg49x7pnYD4LQH2cvQBQxC1F85Q65HnIEapyCiqm7tFj23SYOSutM/PGkP7DH/a7K UeYd96ytnE9oN2PnsRyORo3qRVGjNEOXL/kJB7crDG71k+C+DQzmdcQfGLPjtuS2OWzk YDMUtEMEimuKyBO22G+UXIEuKtJ80lYHlAzRwCY+ur5Y6u8ySGN66diTiHH0yBySb9z/ 2+A7OIs8iZGskrlb2SA5eY5NN6Qx/HW+zq2tAZFvbbwQiKs1FM7J93bU5dFAit34emyQ 8r8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Wkvm6o1l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si2342574pgm.568.2019.04.22.20.51.47; Mon, 22 Apr 2019 20:51:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Wkvm6o1l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730611AbfDWDvq (ORCPT + 30 others); Mon, 22 Apr 2019 23:51:46 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:38797 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730482AbfDWDvp (ORCPT ); Mon, 22 Apr 2019 23:51:45 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2cI023044; Tue, 23 Apr 2019 12:50:17 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2cI023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991417; bh=O+ymeBuOvG0uQG78yokX58qG5GQYyDm6Ks5zKkCXYg8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wkvm6o1lunQyjJ9Kab2hpLJJedT9k6nDHed+tC9S6VEWmYvf12KiI0/z8UecSh1Eg xrkEGs/qi9IL4SEof7zav4uTYP2NKn+XLwUo/z1vl1eIWuA17x8p75dh3d6jQOZGHh N2qAtQbEChxQuldIRkwF1/08tj7sFulQcpJj8OpsIyRxy74PnIjvZVRyrF/edxyZnk LU9ba5mzUm28sLO+xk7dX5WwI3G4smz4D4xfAkONCSj9ym/jZSJQOCfTXeoOdlT3Xh ZWG8+Sol2L2KV3VGsZzHGEn8/lvYNwrSeDfa5qvcdMvUX8pvYS/oTV4OjOO7F7wkkQ r8yksoHWxXEqw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Cc: linux-s390@vger.kernel.org, Heiko Carstens , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Mathieu Malaterre , Masahiro Yamada Subject: [RESEND PATCH v3 10/11] powerpc/mm/radix: mark as __tlbie_pid() and friends as__always_inline Date: Tue, 23 Apr 2019 12:49:58 +0900 Message-Id: <20190423034959.13525-11-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place. We need to eliminate potential issues beforehand. If it is enabled for powerpc, the following errors are reported: arch/powerpc/mm/tlb-radix.c: In function '__tlbie_lpid': arch/powerpc/mm/tlb-radix.c:148:2: warning: asm operand 3 probably doesn't match constraints asm volatile(PPC_TLBIE_5(%0, %4, %3, %2, %1) ^~~ arch/powerpc/mm/tlb-radix.c:148:2: error: impossible constraint in 'asm' arch/powerpc/mm/tlb-radix.c: In function '__tlbie_pid': arch/powerpc/mm/tlb-radix.c:118:2: warning: asm operand 3 probably doesn't match constraints asm volatile(PPC_TLBIE_5(%0, %4, %3, %2, %1) ^~~ arch/powerpc/mm/tlb-radix.c: In function '__tlbiel_pid': arch/powerpc/mm/tlb-radix.c:104:2: warning: asm operand 3 probably doesn't match constraints asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1) ^~~ Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - new patch arch/powerpc/mm/tlb-radix.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.17.1 diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c index a2b2848f0ae3..14ff414d1545 100644 --- a/arch/powerpc/mm/tlb-radix.c +++ b/arch/powerpc/mm/tlb-radix.c @@ -90,8 +90,8 @@ void radix__tlbiel_all(unsigned int action) asm volatile(PPC_INVALIDATE_ERAT "; isync" : : :"memory"); } -static inline void __tlbiel_pid(unsigned long pid, int set, - unsigned long ric) +static __always_inline void __tlbiel_pid(unsigned long pid, int set, + unsigned long ric) { unsigned long rb,rs,prs,r; @@ -106,7 +106,7 @@ static inline void __tlbiel_pid(unsigned long pid, int set, trace_tlbie(0, 1, rb, rs, ric, prs, r); } -static inline void __tlbie_pid(unsigned long pid, unsigned long ric) +static __always_inline void __tlbie_pid(unsigned long pid, unsigned long ric) { unsigned long rb,rs,prs,r; @@ -136,7 +136,7 @@ static inline void __tlbiel_lpid(unsigned long lpid, int set, trace_tlbie(lpid, 1, rb, rs, ric, prs, r); } -static inline void __tlbie_lpid(unsigned long lpid, unsigned long ric) +static __always_inline void __tlbie_lpid(unsigned long lpid, unsigned long ric) { unsigned long rb,rs,prs,r; @@ -239,7 +239,7 @@ static inline void fixup_tlbie_lpid(unsigned long lpid) /* * We use 128 set in radix mode and 256 set in hpt mode. */ -static inline void _tlbiel_pid(unsigned long pid, unsigned long ric) +static __always_inline void _tlbiel_pid(unsigned long pid, unsigned long ric) { int set; From patchwork Tue Apr 23 03:49:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162646 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322676jan; Mon, 22 Apr 2019 20:52:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqwoe2dpYDboog7Y7XZSAhW/serPpahHs32/OSwDy32LS9DuxkFElfG8uHWQmfGKybo46xgg X-Received: by 2002:a63:b0b:: with SMTP id 11mr22801081pgl.445.1555991525400; Mon, 22 Apr 2019 20:52:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991525; cv=none; d=google.com; s=arc-20160816; b=n1QYNxPU4vtziBZfOlp3Y5K2E9SMo5o1OhaLdE0ExrFnJ5YvYwfIV7R5Srg0shUzqa 0WxZtvhcdVCMmA0gLLzgEFfjpgjq8Ul1p8YVtwDlLEIn3h0ovY7ZeQyZIR/dhldQXjDJ e2mbI735lQNCoP2R/m/mJV4WEBg2PukiGo+Cb3G+epDIgQfM9hBRZiaE20xgZUFmJV4O R7nFZLUhrnYImvEaMrBJwm+bFhA0q46v3eRfFMecDp++l2Ry5V3UjwNbMvl/wfxl6HTt vjy9IoefF3ZyfLHTwjvv1awWwGjcCBCvI2nnHo5KvbVl2C7paxLA/OC15/F/vQnfF+oc oMKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=YGW0gg01jtKnXbnK1Ap0mVZ9GqJOY8DcvskWgXT4tQY=; b=GHXwVajQkZKeH25HAA4lsJdAZijDpJs97LgOcR2XGEPtG/2VOJxvV04R/YlgkR0sZ5 hQlGcurirHROu5EtnWA9Gi3MkovtdUD7hLMtirLJTtyZIXGMfGlwVkWIwfvyncrFWGzB abDn0pimjfm9GbtI+Vc+XdUXHccrj+S/T5FaS8zLpOinaD78b18zwXh/UtPY2hmeCiBA E7SmzHfqXCR8DymJA+6gma7aI38pQoiCILZd40kMHOW2tDKPGA7xSNJY1zl5FCAZ09W7 koGXdAUAPqY98T/Iz+6YNAMWd2KZ73wVMSCua4EXgw0TYtp+PlZmCO7+dvueCqkQZRbp 4BEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=ewcDEyxA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cb16si15980247plb.227.2019.04.22.20.52.05; Mon, 22 Apr 2019 20:52:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=ewcDEyxA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730766AbfDWDwE (ORCPT + 30 others); Mon, 22 Apr 2019 23:52:04 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:38990 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730264AbfDWDvu (ORCPT ); Mon, 22 Apr 2019 23:51:50 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2cJ023044; Tue, 23 Apr 2019 12:50:18 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2cJ023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991419; bh=YGW0gg01jtKnXbnK1Ap0mVZ9GqJOY8DcvskWgXT4tQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ewcDEyxAy830oNo0YRW7jR4QvsmMHJ7U9S64TPwRMLWVV1Rsdm+QuGqFD8eVuQzA1 JDeIVx3feidNla9E96nmF8wSY728TufIWZCckpdG4EdzTiWFjhDkl1qYWAhbGtMOvH xo8ifEmC+GwRQFpXB00+PHkczCbiY3Edx/sD0mvzV134YRwxkX7r+n7NXQBI2jQ/PC tzTk4fiyXAczxbRs/vk2vJTApA0bhWQQ9OU7i7d1T/3wDZ0R7kU9AELrMePMx0TqNa MxOdnol7IZuan0BiS94RGSAcH1PAU3odAktvY0h5BgyeHTBXnhekgv8YtdPaUB6ptG t6M2dszBtsRcg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Cc: linux-s390@vger.kernel.org, Heiko Carstens , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Mathieu Malaterre , Masahiro Yamada Subject: [RESEND PATCH v3 11/11] compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING Date: Tue, 23 Apr 2019 12:49:59 +0900 Message-Id: <20190423034959.13525-12-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 60a3cdd06394 ("x86: add optimized inlining") introduced CONFIG_OPTIMIZE_INLINING, but it has been available only for x86. The idea is obviously arch-agnostic. This commit moves the config entry from arch/x86/Kconfig.debug to lib/Kconfig.debug so that all architectures can benefit from it. This can make a huge difference in kernel image size especially when CONFIG_OPTIMIZE_FOR_SIZE is enabled. For example, I got 3.5% smaller arm64 kernel for v5.1-rc1. dec file 18983424 arch/arm64/boot/Image.before 18321920 arch/arm64/boot/Image.after This also slightly improves the "Kernel hacking" Kconfig menu as e61aca5158a8 ("Merge branch 'kconfig-diet' from Dave Hansen') suggested; this config option would be a good fit in the "compiler option" menu. Signed-off-by: Masahiro Yamada Acked-by: Borislav Petkov --- Changes in v3: None Changes in v2: - split into a separate patch arch/x86/Kconfig | 3 --- arch/x86/Kconfig.debug | 14 -------------- include/linux/compiler_types.h | 3 +-- lib/Kconfig.debug | 14 ++++++++++++++ 4 files changed, 15 insertions(+), 19 deletions(-) -- 2.17.1 diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 62fc3fda1a05..f214bb5d60d8 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -310,9 +310,6 @@ config ZONE_DMA32 config AUDIT_ARCH def_bool y if X86_64 -config ARCH_SUPPORTS_OPTIMIZED_INLINING - def_bool y - config ARCH_SUPPORTS_DEBUG_PAGEALLOC def_bool y diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug index 15d0fbe27872..f730680dc818 100644 --- a/arch/x86/Kconfig.debug +++ b/arch/x86/Kconfig.debug @@ -266,20 +266,6 @@ config CPA_DEBUG ---help--- Do change_page_attr() self-tests every 30 seconds. -config OPTIMIZE_INLINING - bool "Allow gcc to uninline functions marked 'inline'" - ---help--- - This option determines if the kernel forces gcc to inline the functions - developers have marked 'inline'. Doing so takes away freedom from gcc to - do what it thinks is best, which is desirable for the gcc 3.x series of - compilers. The gcc 4.x series have a rewritten inlining algorithm and - enabling this option will generate a smaller kernel there. Hopefully - this algorithm is so good that allowing gcc 4.x and above to make the - decision will become the default in the future. Until then this option - is there to test gcc for this. - - If unsure, say N. - config DEBUG_ENTRY bool "Debug low-level entry code" depends on DEBUG_KERNEL diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h index ba814f18cb4c..19e58b9138a0 100644 --- a/include/linux/compiler_types.h +++ b/include/linux/compiler_types.h @@ -140,8 +140,7 @@ struct ftrace_likely_data { * Do not use __always_inline here, since currently it expands to inline again * (which would break users of __always_inline). */ -#if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \ - !defined(CONFIG_OPTIMIZE_INLINING) +#if !defined(CONFIG_OPTIMIZE_INLINING) #define inline inline __attribute__((__always_inline__)) __gnu_inline \ __maybe_unused notrace #else diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 00dbcdbc9a0d..37402f210115 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -310,6 +310,20 @@ config HEADERS_CHECK exported to $(INSTALL_HDR_PATH) (usually 'usr/include' in your build tree), to make sure they're suitable. +config OPTIMIZE_INLINING + bool "Allow compiler to uninline functions marked 'inline'" + help + This option determines if the kernel forces gcc to inline the functions + developers have marked 'inline'. Doing so takes away freedom from gcc to + do what it thinks is best, which is desirable for the gcc 3.x series of + compilers. The gcc 4.x series have a rewritten inlining algorithm and + enabling this option will generate a smaller kernel there. Hopefully + this algorithm is so good that allowing gcc 4.x and above to make the + decision will become the default in the future. Until then this option + is there to test gcc for this. + + If unsure, say N. + config DEBUG_SECTION_MISMATCH bool "Enable full Section mismatch analysis" help