From patchwork Tue Apr 23 03:49:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162638 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322057jan; Mon, 22 Apr 2019 20:51:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnH49e9MZ0Mo5n2woncj968rOFgLhXWNGMJXWyIEboY1qk364DNkOIOepWbLmP7COlSWQa X-Received: by 2002:aa7:9116:: with SMTP id 22mr17249529pfh.165.1555991461218; Mon, 22 Apr 2019 20:51:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991461; cv=none; d=google.com; s=arc-20160816; b=oA3ajLTlGafyJ4hZM1iPaKmnjmSD52klqx2buw8qyysuSVTKGilQfDJpCYQjikGhY2 JExAs523Ek4aTXOIXV9xMT5KRLJG8kbSuDoZOx+JH3K3LCrvnmDaOcB96RE5U/ykJ7lW DoXIweRqZOBRyp65wwHEbwYJ2x96PYd5jowhPo8qV9IRNuWkcBOwCjqR70RbF7R6tpFg 7EFa5MlPHdh6QAuqpX1wAyC/3CuwaYIwfBmzcB3MqknWY7rXWN3GN4BUpbGVNHqh8E9y /Y5fA8cd3swAgmTTnGFyb79kfiC6OtOd8bc5YYssN0nxb8fiAiP+8piNMohF5gj5LLY2 gcqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-filter:dkim-signature; bh=cn3PaHxGtzDE+tZw0Yx61KRfxo58+hgMgsA3zAKqArg=; b=hsLlHctk+7q+y7sz41NHyjhR2L8omaYUuqkmlcCHyeBHUKzhwS6I1FmkPGttJBeUhW zWbF0HO3rEfxXACX+j0JdCwFgRVIj/MO2zmTFB+ogVY2lCbPSBnowyzsi/QNWUXu2+Mb gDuFoQNuNmyXAkRc1ZVpuOdJXsAvgTY6OEeSMbLE37R7iwpIlY41+oVRsmJ26PcNuBzo tVxV83RFPXUaTKrEFWcSm41gQE2rkhSWiraNYMQUX49h8CkaHENHVj9fg/CGo0OUXIsP EoCDbjdBbJFVYUY5/F4T+gxWYP1UMOfTfi3beWD6KN+owf891uZ1m90ul7DCrD2kei5s qMkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=YJN8hRgb; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=t4SgPc4w; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id f2si13777403pgv.441.2019.04.22.20.51.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 20:51:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=YJN8hRgb; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=t4SgPc4w; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=cn3PaHxGtzDE+tZw0Yx61KRfxo58+hgMgsA3zAKqArg=; b=YJN8hRgbkLgqo9K22pWIGnEYuw Un57d671gA/NYNtUNO6vrNWT+mWmgZjQ9voSR9o9nx/SaphndHJ9WI2a5ru+p5YPnXDrvKG8tHtz7 +nu9KKW3vS+MgFeo3QPVFHBbyjmaHvZmUKiM/4gqW/zcADRpmc3iK2PR2BAJG9MxHU+LnSI9tocaI eBGCBffNzzVf/wkDw45iEO8iaDgVnFpTDIl/8PG33F6g0K8hU4qTKGT6vAI7NNsvlis3HcncgG50s wi7mdjwUK442rgHJhc2DG/d++UHztGnCJNP33RfvVx7hxeQoILxGSr92oMmtuhCtOw/AoI16yFKgy zMt4T2iw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hImSO-0006mY-Lv; Tue, 23 Apr 2019 03:50:56 +0000 Received: from conuserg-07.nifty.com ([210.131.2.74]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hImS6-0006Nc-4g; Tue, 23 Apr 2019 03:50:40 +0000 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2c9023044; Tue, 23 Apr 2019 12:50:03 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2c9023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991404; bh=SmiVSvw93zT7NvPci9qgt4Vy7TfTUMkww9tsRFb3tZ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t4SgPc4w5I7DdstRLSozscsSmaeNRAtph21jYtwDtmFtamYizi6vDPeUC6Z0iKtXS ioMNCexdryOpYpIu8ADFPEW5fWQXCgek+DwDlnwgZqq1UUROzUm/LvFAXy+RyM7MXV tFrYRfR4akVsfljiE/skpPYRp0LfRpj/LDfpLiVzDQFYTg8JtWiqTuMTArkTexZcny 2LxkbPw8KNGxjz745TtsSqDM2gDhWWxwHLL2ZqpSPmEgOwnXEWyu8fMV46KvN+AaYI e1Y+LvNNpRlrTTL09XiEnvjziJs5EnfEatyNvENDoHyeEfbhxAo5Hfn9cl6Nxrn0Ng B5nPB6M1B9nlw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Subject: [RESEND PATCH v3 01/11] ARM: prevent tracing IPI_CPU_BACKTRACE Date: Tue, 23 Apr 2019 12:49:49 +0900 Message-Id: <20190423034959.13525-2-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190422_205038_399549_C0991905 X-CRM114-Status: GOOD ( 13.39 ) X-Spam-Score: 0.8 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [210.131.2.74 listed in list.dnswl.org] -0.2 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [210.131.2.74 listed in wl.mailspike.net] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , linux-s390@vger.kernel.org, Arnd Bergmann , Mathieu Malaterre , x86@kernel.org, Heiko Carstens , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Ingo Molnar , linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org From: Arnd Bergmann When function tracing for IPIs is enabled, we get a warning for an overflow of the ipi_types array with the IPI_CPU_BACKTRACE type as triggered by raise_nmi(): arch/arm/kernel/smp.c: In function 'raise_nmi': arch/arm/kernel/smp.c:489:2: error: array subscript is above array bounds [-Werror=array-bounds] trace_ipi_raise(target, ipi_types[ipinr]); This is a correct warning as we actually overflow the array here. This patch raise_nmi() to call __smp_cross_call() instead of smp_cross_call(), to avoid calling into ftrace. For clarification, I'm also adding a two new code comments describing how this one is special. The warning appears to have shown up after patch e7273ff49acf ("ARM: 8488/1: Make IPI_CPU_BACKTRACE a "non-secure" SGI"), which changed the number assignment from '15' to '8', but as far as I can tell has existed since the IPI tracepoints were first introduced. If we decide to backport this patch to stable kernels, we probably need to backport e7273ff49acf as well. Fixes: e7273ff49acf ("ARM: 8488/1: Make IPI_CPU_BACKTRACE a "non-secure" SGI") Fixes: 365ec7b17327 ("ARM: add IPI tracepoints") # v3.17 Signed-off-by: Arnd Bergmann [yamada.masahiro@socionext.com: rebase on v5.1-rc1] Signed-off-by: Masahiro Yamada --- This is a long-standing issue, and Arnd posted this patch two years ago: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/409393.html It is no longer applied, so I rebased it on top of the latest kernel. Changes in v3: None Changes in v2: None arch/arm/include/asm/hardirq.h | 1 + arch/arm/kernel/smp.c | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) -- 2.17.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/arch/arm/include/asm/hardirq.h b/arch/arm/include/asm/hardirq.h index cba23eaa6072..7a88f160b1fb 100644 --- a/arch/arm/include/asm/hardirq.h +++ b/arch/arm/include/asm/hardirq.h @@ -6,6 +6,7 @@ #include #include +/* number of IPIS _not_ including IPI_CPU_BACKTRACE */ #define NR_IPI 7 typedef struct { diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c index facd4240ca02..c93fe0f256de 100644 --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -70,6 +70,10 @@ enum ipi_msg_type { IPI_CPU_STOP, IPI_IRQ_WORK, IPI_COMPLETION, + /* + * CPU_BACKTRACE is special and not included in NR_IPI + * or tracable with trace_ipi_* + */ IPI_CPU_BACKTRACE, /* * SGI8-15 can be reserved by secure firmware, and thus may @@ -797,7 +801,7 @@ core_initcall(register_cpufreq_notifier); static void raise_nmi(cpumask_t *mask) { - smp_cross_call(mask, IPI_CPU_BACKTRACE); + __smp_cross_call(mask, IPI_CPU_BACKTRACE); } void arch_trigger_cpumask_backtrace(const cpumask_t *mask, bool exclude_self) From patchwork Tue Apr 23 03:49:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162637 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3322056jan; Mon, 22 Apr 2019 20:51:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqzBAPCKjK/joEi3nUeOZgGUewfCbA1/d11U1Gy/A64N8SwzLz1mgIzQB6DcSwWp+Om79a70 X-Received: by 2002:a65:64d3:: with SMTP id t19mr22818907pgv.57.1555991461144; Mon, 22 Apr 2019 20:51:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555991461; cv=none; d=google.com; s=arc-20160816; b=uJlJAKk6O8shSAhwSDeRPKE5uFli3lQJeEOhiWzqJd4ItHm9x3ndynx8TguG8EgWUb p0mrzHkQBF3n9T95lcukTRug1BdLTWQvd2bSsuZ8AwZFDrYjyJOlr9whzVjO458XwNBw bJqSBgbfwZuJlQkVtR/2e9OZbLbUbWC/t3UPe4idxgv1NreMlR1Hdftov76TKl6DmxY8 6JSr6jMmWu5vNR2GnQljl2TIX40lm6WdZm+cjHnJm9vvmlWN2oi8JWPJuO/QaM+uyLd0 2rEWyv5bjG4ljU/q8G+f6rxhCmgwJ/qQZ8F5vc+0T2mZpGTU4JzlXiq1X1PVMzfJ7QE/ eX3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-filter:dkim-signature; bh=kpSXJWRgDefqqXJVy1CI4C7u5uwaMYyUrXvW3AxGojQ=; b=ZoW3ox1m0pJztM1ezuynCOeWKcuHUqRYlfBGkOnpGmG4fDpIT8FWoNpLUS2mhbVAnM W0M084DeM7qwkJtlQCT1jx4tIHIUHT166rP/s6g7uwSbBk2dLubMuiCJ8j9sllmnp3ff +UL8OCDc/ns4uMYzHR2K/OXv4hMMLTZvNgvkGHJRhlrld+uRo5Ynw8q47DDOnufAUW4w 90ShRZdtsXw4Pz9aPM4n5nQ91q6BWyBN7bPbtkBd4g0muWbGcd4VbJLokV26CX3Nt61v CJGKjYnfC1RLfvFoztmvNbc2YQyvlNwNbaCImxUCBpjDZ94pDpwoYhb8c+qAoTwKn8O8 Tr7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b="nA/tYS/3"; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=JRgS6Tvy; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id r1si14993027plb.317.2019.04.22.20.51.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 20:51:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b="nA/tYS/3"; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=JRgS6Tvy; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=kpSXJWRgDefqqXJVy1CI4C7u5uwaMYyUrXvW3AxGojQ=; b=nA/tYS/3V5qCnFhyC1b9An2OIk ng1946E5B+dfEDMlkWMhL8HRc9wytBohTYajoWqTdvBuD9ccajq0XKCb454B+/KMRhq5WjPu4o1jH FqhYIUTB3SA7mnq5R1pUN8ZOaI2uagAJoDjopVYu0b8sp7OvOCDIUzjceLX5fqWwycR9Y99QTgAzI jNICZ6ZZRiTw7t/e7pXdKC+us3SbnCCGbi/U0qD21J0Zb5ma3PL/Rmy14nTLPbLt2dEALJN8f5DbM sHo52tj27W9MvDarmAk3ETGGY2vsfmLbhZYB4lWvanqVpzJtOZBBjTgYHJI/VMbywSx3BZy+j5Zge Ye+fXZ6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hImSE-0006VC-RT; Tue, 23 Apr 2019 03:50:46 +0000 Received: from conuserg-07.nifty.com ([210.131.2.74]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hImS6-0006Ng-4f; Tue, 23 Apr 2019 03:50:39 +0000 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3N3o2cC023044; Tue, 23 Apr 2019 12:50:07 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3N3o2cC023044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555991409; bh=WxeGjpwIMtUh4NapkUcSoliRiI5DD/Rdf3zwHkix9l0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JRgS6TvykK2VfzGREOAHkRyhk2HU8HY8tH8Qv2cO2WA0R9pxRuSnRL2l2nwF2rSl2 uFBXOndu6Yxp30Ok+h6kuTyz1lG3PihD63BocSfvTU5n31Jo+S9vy3jMsA6nTJtEZs vm6Y9xJflB9iaVlWxhtuLPtePohZQGxBk6DAICJ/P8KdMoexqYceDJBLIBPcwtsL5p R/jAaPfkqPKMSUUT42VfBdxfmrbSbnp+alKzF5A7WCi2a92an7hfPqXb6HgnjbDNNN QjXdLJUq/2K/5VL0Ur5Ot1MGSdmgWZkTb+J72txXZMzvax7raUOfVsy5FUhwCuulkR uyV+27X02YYgg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Andrew Morton , linux-arch Subject: [RESEND PATCH v3 04/11] s390/cpacf: mark scpacf_query() as __always_inline Date: Tue, 23 Apr 2019 12:49:52 +0900 Message-Id: <20190423034959.13525-5-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190423034959.13525-1-yamada.masahiro@socionext.com> References: <20190423034959.13525-1-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190422_205038_487608_170ADF68 X-CRM114-Status: UNSURE ( 8.45 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.8 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [210.131.2.74 listed in list.dnswl.org] -0.2 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [210.131.2.74 listed in wl.mailspike.net] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , linux-s390@vger.kernel.org, Arnd Bergmann , Mathieu Malaterre , x86@kernel.org, Heiko Carstens , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Ingo Molnar , linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place. We need to eliminate potential issues beforehand. If it is enabled for s390, the following error is reported: In file included from arch/s390/crypto/des_s390.c:19: ./arch/s390/include/asm/cpacf.h: In function 'cpacf_query': ./arch/s390/include/asm/cpacf.h:170:2: warning: asm operand 3 probably doesn't match constraints asm volatile( ^~~ ./arch/s390/include/asm/cpacf.h:170:2: error: impossible constraint in 'asm' Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - split into a separate patch arch/s390/include/asm/cpacf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/arch/s390/include/asm/cpacf.h b/arch/s390/include/asm/cpacf.h index 3cc52e37b4b2..f316de40e51b 100644 --- a/arch/s390/include/asm/cpacf.h +++ b/arch/s390/include/asm/cpacf.h @@ -202,7 +202,7 @@ static inline int __cpacf_check_opcode(unsigned int opcode) } } -static inline int cpacf_query(unsigned int opcode, cpacf_mask_t *mask) +static __always_inline int cpacf_query(unsigned int opcode, cpacf_mask_t *mask) { if (__cpacf_check_opcode(opcode)) { __cpacf_query(opcode, mask);