From patchwork Thu Apr 18 09:57:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 162450 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp534100jan; Thu, 18 Apr 2019 02:58:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEPF3vxBULiNWjymFei8iPkCAnJIbuMgwTqwR/OS99dn5f94C7DGG9rXQDXPKX+2cT1ABI X-Received: by 2002:a62:1647:: with SMTP id 68mr33041236pfw.113.1555581526009; Thu, 18 Apr 2019 02:58:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555581526; cv=none; d=google.com; s=arc-20160816; b=LGXnFBVVv6ZsaWY5yXgJJZY4QQ6DAqDLykSy4+8gAYcFjgmmulKjvFJEhzoIV0xovs zDAFXSJO+3twe2usca1wZ/yIKFO6QPx8HojYHwdqOHkol/kejqwSAi2f1oLx3oNOe75E BFHJ0Ey0VS9saXFo8C91TmS8+dWHlyVzTlajf7jsmN6vkBrxDOTzgW7Z9es86AzLWVsm 6V7NiX/qSj3lA7ko1B2JWRV9KzWRb2sl+OqzZbCIQ3XPLc8gaCwfUdbxdkbd31pQWLmY Tq5SGuIFf1+0vYqh38IAZRTu+fmsBBzH0REml4JwVbMbAbuyR+S7rmmpZSVjcJKIQQpU tFlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=iCYGPRLl0wMWGlvfN/1qveyRnyzRthbp0RuhN/AgD1c=; b=NvO8DYukFCI7Cby7UvFzfBP32V+0F+uVfZQ/pFwt2Lj3f2WP0q39roGKRF1hiv1bav CfMX4aOWWRS3sZNwaHYb1f2lBrpOoP51lilgXnqQz3yE6UJnnTJ/6PPwCh7aj6l+QVZL 0QqDcp9NIyqGIKdgkpxxUxyDUa1MKhDPSn6Z21w6GdM1VWSKKkZwRkLY01n05QDYbs5G DoHQOfkcE1FZNkP78aahHXj9RzZXhvS8+62eAdOHjAMT/bi0q1TZv3Txz5cThVNwQuND 6tkDhSQRcOC4tKSiCuFZOQ65q3s0w5jKcVTqCUqi0v91iOi7d/0/Y2fY7b6Q0oV6aQ4u Bc0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=uuivzEpD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v12si1529418pgh.303.2019.04.18.02.58.45; Thu, 18 Apr 2019 02:58:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=uuivzEpD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388408AbfDRJ6o (ORCPT + 30 others); Thu, 18 Apr 2019 05:58:44 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:60748 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728074AbfDRJ6o (ORCPT ); Thu, 18 Apr 2019 05:58:44 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id x3I9vr8v025261; Thu, 18 Apr 2019 18:57:53 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x3I9vr8v025261 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1555581474; bh=iCYGPRLl0wMWGlvfN/1qveyRnyzRthbp0RuhN/AgD1c=; h=From:To:Cc:Subject:Date:From; b=uuivzEpDR9sO7dZaN8xUiUwpV1SdXTqb/WwsrIcwjTdDgPU6Ji/kHdEvpwK5xEjOG BLSEpE3aMfkt/ZbjPy4BaegAYlsf3tV+SxvjoW+Vp5FkvIKXuXXgBfWdct7CqfB0cy hXlRJqChxXBgQGdoha04r4ElOAcKTJhi6q+BonKPInPtGXuDDnCw+fW6g02/8FOxKr ij6ffpFwNug3pHpm8gEWb9ZQz1Uszbo6XQp50VvSdleeCklttRHRLN8uXPGkL4c/EO xOUQSEwJO4NVy16Ye9wc5N/Ta9JaB8FsDzUQWXOsAz+NJdZluBE+EuC9PIHqMkUdSi SIpa8plHj/3Iw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: patches@arm.linux.org.uk Cc: Masahiro Yamada , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: vdso: use $(LD) instead of $(CC) to link VDSO Date: Thu, 18 Apr 2019 18:57:49 +0900 Message-Id: <20190418095749.21422-1-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We use $(LD) to link vmlinux, modules, decompressors, etc. VDSO is the only exceptional case where $(CC) is used as the linker driver, but I do not know why we need to do so. VDSO uses a special linker script, and does not link standard libraries at all. I changed the Makefile to use $(LD) rather than $(CC). I confirmed the same vdso.so.raw was still produced. Users will be able to use their favorite linker (e.g. lld instead of of bfd) by passing LD= from the command line. My plan is to rewrite all VDSO Makefiles to use $(LD), then delete cc-ldoption. Signed-off-by: Masahiro Yamada Reviewed-by: Nick Desaulniers --- KernelVersion: 5.1-rc5 arch/arm/vdso/Makefile | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) -- 2.17.1 diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile index f4efff9d3afb..fadf554d9391 100644 --- a/arch/arm/vdso/Makefile +++ b/arch/arm/vdso/Makefile @@ -10,12 +10,12 @@ obj-vdso := $(addprefix $(obj)/, $(obj-vdso)) ccflags-y := -fPIC -fno-common -fno-builtin -fno-stack-protector ccflags-y += -DDISABLE_BRANCH_PROFILING -VDSO_LDFLAGS := -Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1 -VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 -VDSO_LDFLAGS += -nostdlib -shared -VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) -VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--build-id) -VDSO_LDFLAGS += $(call cc-ldoption, -fuse-ld=bfd) +ldflags-y = -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ + -z max-page-size=4096 -z common-page-size=4096 \ + -nostdlib -shared \ + $(call ld-option, --hash-style=sysv) \ + $(call ld-option, --build-id) \ + -T obj-$(CONFIG_VDSO) += vdso.o extra-$(CONFIG_VDSO) += vdso.lds @@ -37,8 +37,8 @@ KCOV_INSTRUMENT := n $(obj)/vdso.o : $(obj)/vdso.so # Link rule for the .so file -$(obj)/vdso.so.raw: $(src)/vdso.lds $(obj-vdso) FORCE - $(call if_changed,vdsold) +$(obj)/vdso.so.raw: $(obj)/vdso.lds $(obj-vdso) FORCE + $(call if_changed,ld) $(obj)/vdso.so.dbg: $(obj)/vdso.so.raw $(obj)/vdsomunge FORCE $(call if_changed,vdsomunge) @@ -48,11 +48,6 @@ $(obj)/%.so: OBJCOPYFLAGS := -S $(obj)/%.so: $(obj)/%.so.dbg FORCE $(call if_changed,objcopy) -# Actual build commands -quiet_cmd_vdsold = VDSO $@ - cmd_vdsold = $(CC) $(c_flags) $(VDSO_LDFLAGS) \ - -Wl,-T $(filter %.lds,$^) $(filter %.o,$^) -o $@ - quiet_cmd_vdsomunge = MUNGE $@ cmd_vdsomunge = $(objtree)/$(obj)/vdsomunge $< $@