From patchwork Wed Jan 11 19:14:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 641415 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39CDBC678D6 for ; Wed, 11 Jan 2023 19:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233869AbjAKTPI (ORCPT ); Wed, 11 Jan 2023 14:15:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234416AbjAKTO6 (ORCPT ); Wed, 11 Jan 2023 14:14:58 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1578E3DBDD for ; Wed, 11 Jan 2023 11:14:57 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id n5so16511525ljc.9 for ; Wed, 11 Jan 2023 11:14:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tvetCGKgjl4TOcgsE3HW1CpjBzYScqI9QN0WXqkeGn4=; b=UqhKEmCNju2kbHfZHKTxtm3c5czCKHVZOHbWKFfA+y3BQABbnOEAaQAEtZu8Hw6ODL g9Ela4PeWz2KlODeCwSpZJBLxWlZIPCzzQEbanxbIN4Z4IG4eQmhLIxp+g7YecT2ic6H +7RNb+lfTiQKcHE7PWJTmBaDXxPcrBDkfy0l58IsOlKnH76wTZFBDZuC6DlozB0dIr94 T1IuhM40k4s0FtYwrzxXSwJtz2y/SenTuLSY+yT6vBmELKmgZQ8qKYJxQriZbm9h4+x2 uEEqrNDKI2ujs8QPx4GkmXo8zb5Dinv8G9XgN/xBYxDLuovutltK4GiGZIz7dZYL693w g5/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tvetCGKgjl4TOcgsE3HW1CpjBzYScqI9QN0WXqkeGn4=; b=e8teIka7q+sNeYDD/4/lKMfoY68aFh7W7DyF8ULH5jordf7nnqvrOuxm6N2SopXvt+ 9xhiiBVJmLsjh0yoj0dw4tQ4GPvQaniiS34LYZhwcnb4vB5oR98OqfdEoPQ7olPZycjV YYyZigj5tlGzXYfTFeOyw8lKeWgU0z+0Cz5HOfyNvzCNKSwTAFzmBtL9h+kf47in6f5c oCoth5U7h5qxxAxyA+jJhqDxGauj1457kCLN1q60F7ef992D29V6Li3rCmZ0Gh3xmAB0 2Q9OaDfmIZPYyujG0oTckkbAtYZelzC6rKwwzYdje1NGbrU9996F678aAzDGFlsH+WaY 4wQQ== X-Gm-Message-State: AFqh2krZv3u+YPAF2ucfJZNbnBqm/Tw6M3oHfwSCnre0w+/0kAiZcsv6 pae4OvksvfyQnwo1lhLxLLNj2w== X-Google-Smtp-Source: AMrXdXtRgrWhdT6cEv/zJaSMKYCkCBZoQwGdm6GxhA/zjl8LuIh8iSWnzd6HzUuMcQR0F2lo0Jyjig== X-Received: by 2002:a2e:8e67:0:b0:281:17f6:eeb9 with SMTP id t7-20020a2e8e67000000b0028117f6eeb9mr5621561ljk.8.1673464495502; Wed, 11 Jan 2023 11:14:55 -0800 (PST) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id r7-20020a2e8e27000000b00289873cce0bsm76343ljk.14.2023.01.11.11.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 11:14:55 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] dt-bindings: mailbox: qcom: correct the list of platforms using clocks Date: Wed, 11 Jan 2023 22:14:50 +0300 Message-Id: <20230111191453.2509468-2-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> References: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Only three platforms require `pll' and `aux' clocks: msm8916, msm8939 and qcs404. Correct the list of platforms in the corresponding clause. Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") Signed-off-by: Dmitry Baryshkov --- .../bindings/mailbox/qcom,apcs-kpss-global.yaml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 943f9472ae10..b8a44ef0540f 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -71,15 +71,8 @@ allOf: compatible: enum: - qcom,msm8916-apcs-kpss-global - - qcom,msm8994-apcs-kpss-global - - qcom,msm8996-apcs-hmss-global - - qcom,msm8998-apcs-hmss-global + - qcom,msm8939-apcs-kpss-global - qcom,qcs404-apcs-apps-global - - qcom,sc7180-apss-shared - - qcom,sdm660-apcs-hmss-global - - qcom,sdm845-apss-shared - - qcom,sm6125-apcs-hmss-global - - qcom,sm8150-apss-shared then: properties: clocks: From patchwork Wed Jan 11 19:14:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 641414 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19523C678D9 for ; Wed, 11 Jan 2023 19:15:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234263AbjAKTPN (ORCPT ); Wed, 11 Jan 2023 14:15:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238657AbjAKTPH (ORCPT ); Wed, 11 Jan 2023 14:15:07 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5477D3E0D1 for ; Wed, 11 Jan 2023 11:14:59 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id n5so16511637ljc.9 for ; Wed, 11 Jan 2023 11:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/UXtctDmgy3FdaxNyTJINCTK6qOQw5kYpO166rCggWQ=; b=qym5ytsZN3GQaBori/kOTx2Aep16/qNYc2VJvNqD8DFQ9VjVpng6JnQxWBpQm7DSh/ v0iXSSbNM5PMxGMoWAFJVILD/V+E8mOSrHeBW/SXXV9ztayAlnlvlq+DHqogQbhmBjef 16wTpZOxKLnCegLhMEWh2L7Wb77NUteeeeDYcMSVPvlrrAeW4SE9SKDcMPmabe+Gy9XB k91n7kOT8N38u4/6vSfPE+xCIPeW+t3Jj9DDYDfGE0hgvvoZsov0ZaJ8lr/yx5m1ZiAd iJiYRmmbYECRPJXMHN09rSYdaL4XyqYZsCUq8aMzuT1xh5ukpJ3N1eSTT5J7S62xYY97 Df4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/UXtctDmgy3FdaxNyTJINCTK6qOQw5kYpO166rCggWQ=; b=rx38FNihTQ4w0+GSbxxS5/BZIlvYHzLrPLgZ45aRZTFEZwpo+X8/is0faYtuhLiVea pa5vsaxtkxIwrvyNu5NCPzg1JZheB+e81rJwQvUF3mK2uRULXqFduE+YM+mLKkvC7mBT 1uynJg6/pMDj6Fvv2Oq7ccIJa9kPEWuTKD+ClYVg+YZS5zndCam7y15x5xLC0YcyPSAF 3NglO7I/0ReBrovrccARjCs92rUiZz8YjHCcoScBS6/NpnQahNCu6p2jJGCkcNPR8CoO OLYIZLBX1jW5BRUyjYirc91cDmy6h+vdjllZH2bEducs8lS6zmluwKKEXJT43pJrcwqE vO/w== X-Gm-Message-State: AFqh2krXRPaVCFgK2FIzbbBEDzUQ6aBLbFzZwyrxsqErficIChTOXhXT UR953TmacqdHcJcCzYqSPy8oSA== X-Google-Smtp-Source: AMrXdXu1EYK0JDO4UII/7zB1knsDVnmMAe5zoz1LVmjb+jur+ozkviixsD6HgC14w38fwIUFCL8InQ== X-Received: by 2002:a2e:a5ca:0:b0:27f:d652:f38c with SMTP id n10-20020a2ea5ca000000b0027fd652f38cmr13729215ljp.19.1673464497640; Wed, 11 Jan 2023 11:14:57 -0800 (PST) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id r7-20020a2e8e27000000b00289873cce0bsm76343ljk.14.2023.01.11.11.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 11:14:57 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] clk: qcom: add the driver for the MSM8996 APCS clocks Date: Wed, 11 Jan 2023 22:14:53 +0300 Message-Id: <20230111191453.2509468-5-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> References: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add a simple driver handling the APCS clocks on MSM8996. For now it supports just a single aux clock, linking GPLL0 to CPU and CBF clocks. Note, there is little sense in registering sys_apcs_aux as a child of gpll0. The PLL is always-on. And listing the gpll0 as a property of the apcs would delay its probing until the GCC has been probed (while we would like for the apcs to be probed as early as possible). Signed-off-by: Dmitry Baryshkov --- drivers/clk/qcom/Makefile | 2 +- drivers/clk/qcom/apcs-msm8996.c | 77 +++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+), 1 deletion(-) create mode 100644 drivers/clk/qcom/apcs-msm8996.c diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile index f18c446a97ea..ca2f586edb3e 100644 --- a/drivers/clk/qcom/Makefile +++ b/drivers/clk/qcom/Makefile @@ -52,7 +52,7 @@ obj-$(CONFIG_MSM_MMCC_8998) += mmcc-msm8998.o obj-$(CONFIG_QCOM_A53PLL) += a53-pll.o obj-$(CONFIG_QCOM_A7PLL) += a7-pll.o obj-$(CONFIG_QCOM_CLK_APCS_MSM8916) += apcs-msm8916.o -obj-$(CONFIG_QCOM_CLK_APCC_MSM8996) += clk-cpu-8996.o +obj-$(CONFIG_QCOM_CLK_APCC_MSM8996) += apcs-msm8996.o clk-cpu-8996.o obj-$(CONFIG_QCOM_CLK_APCS_SDX55) += apcs-sdx55.o obj-$(CONFIG_QCOM_CLK_RPM) += clk-rpm.o obj-$(CONFIG_QCOM_CLK_RPMH) += clk-rpmh.o diff --git a/drivers/clk/qcom/apcs-msm8996.c b/drivers/clk/qcom/apcs-msm8996.c new file mode 100644 index 000000000000..2e9959974ed9 --- /dev/null +++ b/drivers/clk/qcom/apcs-msm8996.c @@ -0,0 +1,77 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Qualcomm APCS clock controller driver + * + * Copyright (c) 2022, Linaro Limited + * Author: Dmitry Baryshkov + */ + +#include +#include +#include +#include +#include +#include +#include + +#define APCS_AUX_OFFSET 0x50 + +#define APCS_AUX_DIV_MASK GENMASK(17, 16) +#define APCS_AUX_DIV_2 0x1 + +static int qcom_apcs_msm8996_clk_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct device *parent = dev->parent; + struct regmap *regmap; + struct clk_hw *hw; + unsigned int val; + int ret = -ENODEV; + + regmap = dev_get_regmap(parent, NULL); + if (!regmap) { + dev_err(dev, "failed to get regmap: %d\n", ret); + return ret; + } + + regmap_read(regmap, APCS_AUX_OFFSET, &val); + regmap_update_bits(regmap, APCS_AUX_OFFSET, APCS_AUX_DIV_MASK, + FIELD_PREP(APCS_AUX_DIV_MASK, APCS_AUX_DIV_2)); + + /* Hardware mandated delay */ + udelay(5); + + /* + * Register the clock as fixed rate instead of being a child of gpll0 + * to let the driver register probe as early as possible. + */ + hw = devm_clk_hw_register_fixed_rate(dev, "sys_apcs_aux", NULL, 0, 300000000); + if (IS_ERR(hw)) + return PTR_ERR(hw); + + return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, hw); +} + +static struct platform_driver qcom_apcs_msm8996_clk_driver = { + .probe = qcom_apcs_msm8996_clk_probe, + .driver = { + .name = "qcom-apcs-msm8996-clk", + }, +}; + +/* Register early enough to fix the clock to be used for other cores */ +static int __init qcom_apcs_msm8996_clk_init(void) +{ + return platform_driver_register(&qcom_apcs_msm8996_clk_driver); +} +postcore_initcall(qcom_apcs_msm8996_clk_init); + +static void __exit qcom_apcs_msm8996_clk_exit(void) +{ + platform_driver_unregister(&qcom_apcs_msm8996_clk_driver); +} +module_exit(qcom_apcs_msm8996_clk_exit); + +MODULE_AUTHOR("Dmitry Baryshkov "); +MODULE_LICENSE("GPL v2"); +MODULE_DESCRIPTION("Qualcomm MSM8996 APCS clock driver");