From patchwork Sat Dec 24 15:42:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 636623 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C99BAC4332F for ; Sat, 24 Dec 2022 15:42:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231293AbiLXPmR (ORCPT ); Sat, 24 Dec 2022 10:42:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbiLXPmP (ORCPT ); Sat, 24 Dec 2022 10:42:15 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90085D2E2 for ; Sat, 24 Dec 2022 07:42:13 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id cf42so10734212lfb.1 for ; Sat, 24 Dec 2022 07:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VqWUzbhnIAOTNuauAVvGliUcjdZQPn3jI6LrgXIAOOE=; b=ZISpF/bQ1vT7Hdz9XwEiNw5O4wSPD9NIaG8Bj72o+0OysHCmbuLWznK+t2xd2SnkEt BT7j6S1TVu4r1W/QIC8p9wm4HRyTSqIRwUdWImryZfcSyGPRlkKb6XqQygsyvl1yPwLw oPukVD1Axb0QmACySyS6pw7mbZzuklsOLAXYKpsW7MjOvGahSBl/p4kk1MjY6bv2WV8n s3xE15aHGpFJ3O+egsbP9YIWeu8LiLIV8aOT5OjYsm+5apC8TJJCch1eK+mE9n9C8+p1 gSVn93lJIiGSOosrvAGEFh8BTPWE5IemOHksSeNE30ZPH3BHt4cj1JS5hZ14w/4H5tio xWow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VqWUzbhnIAOTNuauAVvGliUcjdZQPn3jI6LrgXIAOOE=; b=hGgx1NNS3xrnPlg+riVz/aHs22t+W1orUZED6pzmZaiETpKGF02gKm9rDTiAVFj8UP k6eVo2s9NaePdde4j7g/bBVv41bxw0ujgXOIOxdeBUh3SC0AlJVAuclCX8/moEEucrUb LWP1hp8osDnwAQMuhVtmAOA11lJopdGbTbNrNrZskQoSMEucJxjFzE8CjmIFNYrau9VQ wx09zDOfIM0H5ud6svT7E1H4vtoFoZPQLz14s6sOeSa4JxcjNpVuGgknDbJ94E496qPr wmTVioo0YHwYQYdo5ja/ifnieGRtSI4kdujRwNzomrYMVCRQZ/7DPkKMhtNOLCej5e3h o/tA== X-Gm-Message-State: AFqh2kof6w8pUe1vk8y9xyPRQ4COuv7vH56TCdCHR2uM/Lrekiy2aYBs jv+v/1/432MJkWAKGuq5+5WyXg== X-Google-Smtp-Source: AMrXdXtE4roLvHWHaTa2XWArg6aS1kUMpuXXyPvEmgNO0tkVjIjWdQkVTIyMDwCHiss/5ix5ynBINg== X-Received: by 2002:a05:6512:3294:b0:4bd:de32:b789 with SMTP id p20-20020a056512329400b004bdde32b789mr4633400lfe.52.1671896533122; Sat, 24 Dec 2022 07:42:13 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c14-20020ac25f6e000000b004b5821219fbsm987035lfc.60.2022.12.24.07.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Dec 2022 07:42:12 -0800 (PST) From: Krzysztof Kozlowski To: James Schulman , David Rhodes , Lucas Tanure , Richard Fitzgerald , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] ASoC: dt-bindings: cirrus,cs35l41: add interrupts Date: Sat, 24 Dec 2022 16:42:09 +0100 Message-Id: <20221224154210.43356-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Both DTS (SM8250 and SM8350 based Sony Xperia boards) and Linux driver mention interrupt, so allow it to fix: sm8350-sony-xperia-sagami-pdx215.dtb: cs35l41@41: Unevaluated properties are not allowed ('interrupt-parent', 'interrupts' were unexpected) Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml index 82062d80d700..919d7f16f24c 100644 --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml @@ -22,6 +22,9 @@ properties: reg: maxItems: 1 + interrupts: + maxItems: 1 + '#sound-dai-cells': description: The first cell indicating the audio interface. From patchwork Sat Dec 24 15:42:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 636728 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9084C4332F for ; Sat, 24 Dec 2022 15:42:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231302AbiLXPmT (ORCPT ); Sat, 24 Dec 2022 10:42:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231304AbiLXPmQ (ORCPT ); Sat, 24 Dec 2022 10:42:16 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23B1B6549 for ; Sat, 24 Dec 2022 07:42:14 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id f34so10692349lfv.10 for ; Sat, 24 Dec 2022 07:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B5CHbg+8b24jKcyqMjIgkeB+fm8k5OGLCytCdmtDF84=; b=Tu4Cn/+Bfo24LQKjYhx6hQjfaVH2XkiYAWLSLXtJzX51Hf9SJ3RuYQDdDX4ttZJ1T2 e94Bb3HuIYU9MnvWYHSIWuuMHizHj7YlM32orCoG7rrCnkvXO3jg4UsNix7Ote/aJyxa jdq6uLohW+SHjtZLH9c1WuZpXC0m4viJVRE8+NFSYTZD7o2qy62Ow4d9L0CMsp+MUKox jL1jqVQWyD36UA7tI4YZnOMaS5iRCkvfwLrYY/Zoo4YR4r0DTjK5xO/z5HMHZVq4EOSU 5YMci66YvKAY/1SbEtp00YrilTS3Rj3Pt+Vj8uvgq/jrO56mttgnTp6oIphvKmqJWa0e vWvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B5CHbg+8b24jKcyqMjIgkeB+fm8k5OGLCytCdmtDF84=; b=1hxc4oK3E4nbZFC2Le7+urcJ3gFUxbSB0H1bdlOzwG/TnFLRhy/jF0v55DMSUG/NiD EWBAz6n6avceKR5zf8S2xh9iCH4Lai1oSQUdYWXpAmBt5fdRQhCOYeIBIVeFHImn8ObA 2anwmYdKAbvLd5OfEGORBpd+rUwTt4EGlmtYbjDsAgiVVvoUCI3pnLWehNQPuYxWaXNJ XK+D8t9n9TNs0TAetqMhHIxXZzyqe9vDbR1HiBILwNih/3at+46svBhISrSjA1z4DSN6 PPMpJqW/Ua7ZHCBFFJ0mgwhhBEXmTxoihMH8I46cwoCAaUbOUPfsFH+S8VTUFR2QltUl lzsA== X-Gm-Message-State: AFqh2kqgnrjH0/vA3ye3iahmGkuLNw6LlXNB8phxEqKgC9nfnoP/Rnhs nDgmflAFKYD+vkguZfRQ+rq/cw== X-Google-Smtp-Source: AMrXdXtwLkq5JjJtX7uA0W5OuWnCMwaKAklXGhAKpIPUbnZS/ecaOwe4cZr6IggAtCbXCFd9FNqITw== X-Received: by 2002:a05:6512:1582:b0:4b6:e494:a98d with SMTP id bp2-20020a056512158200b004b6e494a98dmr4545398lfb.44.1671896534235; Sat, 24 Dec 2022 07:42:14 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c14-20020ac25f6e000000b004b5821219fbsm987035lfc.60.2022.12.24.07.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Dec 2022 07:42:13 -0800 (PST) From: Krzysztof Kozlowski To: James Schulman , David Rhodes , Lucas Tanure , Richard Fitzgerald , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] ASoC: dt-bindings: cirrus,cs35l41: cleanup $ref and example Date: Sat, 24 Dec 2022 16:42:10 +0100 Message-Id: <20221224154210.43356-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221224154210.43356-1-krzysztof.kozlowski@linaro.org> References: <20221224154210.43356-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Non-functional cleanup: 1. Drop unneeded quotes form $ref, 2. Example: Use generic node name, use define for GPIO flag, adjust indentation to consistent 4-space style. Signed-off-by: Krzysztof Kozlowski --- .../bindings/sound/cirrus,cs35l41.yaml | 40 ++++++++++--------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml index 919d7f16f24c..18fb471aa891 100644 --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml @@ -45,7 +45,7 @@ properties: Configures the peak current by monitoring the current through the boost FET. Range starts at 1600 mA and goes to a maximum of 4500 mA with increments of 50 mA. See section 4.3.6 of the datasheet for details. - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 1600 maximum: 4500 default: 4500 @@ -54,7 +54,7 @@ properties: description: Boost inductor value, expressed in nH. Valid values include 1000, 1200, 1500 and 2200. - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 1000 maximum: 2200 @@ -63,7 +63,7 @@ properties: Total equivalent boost capacitance on the VBST and VAMP pins, derated at 11 volts DC. The value must be rounded to the nearest integer and expressed in uF. - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 cirrus,asp-sdout-hiz: description: @@ -73,7 +73,7 @@ properties: 1 = Hi-Z during unused slots but logic 0 while all transmit channels disabled 2 = (Default) Logic 0 during unused slots, but Hi-Z while all transmit channels disabled 3 = Hi-Z during unused slots and while all transmit channels disabled - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 0 maximum: 3 default: 2 @@ -87,7 +87,7 @@ properties: enable boost voltage. 0 = Internal Boost 1 = External Boost - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 0 maximum: 1 @@ -112,7 +112,7 @@ properties: 1 = GPIO 2 = Sync 3 = MCLK input - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 0 maximum: 3 @@ -139,7 +139,7 @@ properties: 3 = MCLK input 4 = Push-pull INTB (active low) 5 = Push-pull INT (active high) - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 0 maximum: 5 @@ -179,21 +179,23 @@ unevaluatedProperties: false examples: - | + #include + spi { #address-cells = <1>; #size-cells = <0>; - cs35l41: cs35l41@2 { - #sound-dai-cells = <1>; - compatible = "cirrus,cs35l41"; - reg = <2>; - VA-supply = <&dummy_vreg>; - VP-supply = <&dummy_vreg>; - reset-gpios = <&gpio 110 0>; - - cirrus,boost-type = <0>; - cirrus,boost-peak-milliamp = <4500>; - cirrus,boost-ind-nanohenry = <1000>; - cirrus,boost-cap-microfarad = <15>; + cs35l41: speaker-amp@2 { + #sound-dai-cells = <1>; + compatible = "cirrus,cs35l41"; + reg = <2>; + VA-supply = <&dummy_vreg>; + VP-supply = <&dummy_vreg>; + reset-gpios = <&gpio 110 GPIO_ACTIVE_HIGH>; + + cirrus,boost-type = <0>; + cirrus,boost-peak-milliamp = <4500>; + cirrus,boost-ind-nanohenry = <1000>; + cirrus,boost-cap-microfarad = <15>; }; };