From patchwork Sat Dec 24 15:42:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 636987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B16A5C3DA7D for ; Sat, 24 Dec 2022 15:43:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E12E4B9AA; Sat, 24 Dec 2022 16:42:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E12E4B9AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1671896588; bh=3nT3DeZF5i9pQFxuFaL0flQ2ATEb6zWrvMChjlr1LPw=; h=From:To:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Cc:From; b=TTPQCP1+9hNqu1qZ9ou92RENQaX/dGBmISTgCQEod/r8mKQaIYUA3xgaFxkTbLca3 Br1LpKRBA164GdlQrSriE4w1M5H9ZS0yUJ+iUtHZSEDRYqFA0AcbLIL+EJrpMu/3mx R8KDkqUKp2Lpe/JUAZX8eecDEVP7zrPd+fSJpQEo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 912B8F802E0; Sat, 24 Dec 2022 16:42:18 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6BFF6F8032B; Sat, 24 Dec 2022 16:42:17 +0100 (CET) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 41955F8027C for ; Sat, 24 Dec 2022 16:42:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 41955F8027C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZISpF/bQ Received: by mail-lf1-x12f.google.com with SMTP id z26so10703774lfu.8 for ; Sat, 24 Dec 2022 07:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VqWUzbhnIAOTNuauAVvGliUcjdZQPn3jI6LrgXIAOOE=; b=ZISpF/bQ1vT7Hdz9XwEiNw5O4wSPD9NIaG8Bj72o+0OysHCmbuLWznK+t2xd2SnkEt BT7j6S1TVu4r1W/QIC8p9wm4HRyTSqIRwUdWImryZfcSyGPRlkKb6XqQygsyvl1yPwLw oPukVD1Axb0QmACySyS6pw7mbZzuklsOLAXYKpsW7MjOvGahSBl/p4kk1MjY6bv2WV8n s3xE15aHGpFJ3O+egsbP9YIWeu8LiLIV8aOT5OjYsm+5apC8TJJCch1eK+mE9n9C8+p1 gSVn93lJIiGSOosrvAGEFh8BTPWE5IemOHksSeNE30ZPH3BHt4cj1JS5hZ14w/4H5tio xWow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VqWUzbhnIAOTNuauAVvGliUcjdZQPn3jI6LrgXIAOOE=; b=tJcSvIjGBOcFjoORcXenT+71kimkAtOs7XtTFCLHoJMHNLm/za7q4jk4snMUERny6T 30FuKowV93pUY3rCBAL2asxHZ0kBtqEX+f3ljM9Arny9Jg1zkhg5Hhzz58zjUSckIBbc RAIVrqp0sew4tiEqsuynie6889sNEb+Vt+Xp8J8TKl0sFow0XBDSgu8DRiashZhzjStW CAf2uxnXcD7SE4cveFKDqstdllA/bYW1pfikj67pmNsI+Q/rFJWgdx3U8OQXOFZ2WYpY DuJRAT4zYRoqcORAY87fY9NsjnMS4m+s1AT9SMDvgEqsudaHKtcFue+VuJI4NjSuK0sf Hh5w== X-Gm-Message-State: AFqh2krmXofm+f31gbjXy/tLeo+9dVaBxqQ4xPtiv+gJRv++/J2J58mE FpvRQh5J0/3HdhddfgotorCQOA== X-Google-Smtp-Source: AMrXdXtE4roLvHWHaTa2XWArg6aS1kUMpuXXyPvEmgNO0tkVjIjWdQkVTIyMDwCHiss/5ix5ynBINg== X-Received: by 2002:a05:6512:3294:b0:4bd:de32:b789 with SMTP id p20-20020a056512329400b004bdde32b789mr4633400lfe.52.1671896533122; Sat, 24 Dec 2022 07:42:13 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c14-20020ac25f6e000000b004b5821219fbsm987035lfc.60.2022.12.24.07.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Dec 2022 07:42:12 -0800 (PST) From: Krzysztof Kozlowski To: James Schulman , David Rhodes , Lucas Tanure , Richard Fitzgerald , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] ASoC: dt-bindings: cirrus,cs35l41: add interrupts Date: Sat, 24 Dec 2022 16:42:09 +0100 Message-Id: <20221224154210.43356-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof Kozlowski Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Both DTS (SM8250 and SM8350 based Sony Xperia boards) and Linux driver mention interrupt, so allow it to fix: sm8350-sony-xperia-sagami-pdx215.dtb: cs35l41@41: Unevaluated properties are not allowed ('interrupt-parent', 'interrupts' were unexpected) Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml index 82062d80d700..919d7f16f24c 100644 --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml @@ -22,6 +22,9 @@ properties: reg: maxItems: 1 + interrupts: + maxItems: 1 + '#sound-dai-cells': description: The first cell indicating the audio interface. From patchwork Sat Dec 24 15:42:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 636612 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E448C4332F for ; Sat, 24 Dec 2022 15:43:34 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0587BB696; Sat, 24 Dec 2022 16:42:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0587BB696 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1671896613; bh=qs1HtR41DKmzvbXr38da6U7rQemq9fr8f3GeCaPQHbc=; h=From:To:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=X9b7HfSwt+JpG1vwRhM82SvkaHqIxihm9sSnthbmIUrYVBNy96+d3daDxVQyWSKSX Tzgcx8Rx8Ue2PVkYMmvhb2/BHn0cEXhU4lD9EQD5C5VTzB0mvKWGxQ9IZspfKPAgSA NGrc4gVcI1kqRZQqrl7y24PBosKNA5GF8hEiMIqw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 37BF7F8047D; Sat, 24 Dec 2022 16:42:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C118EF80496; Sat, 24 Dec 2022 16:42:22 +0100 (CET) Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E426EF8032B for ; Sat, 24 Dec 2022 16:42:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E426EF8032B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Tu4Cn/+B Received: by mail-lf1-x12d.google.com with SMTP id bp15so10677769lfb.13 for ; Sat, 24 Dec 2022 07:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B5CHbg+8b24jKcyqMjIgkeB+fm8k5OGLCytCdmtDF84=; b=Tu4Cn/+Bfo24LQKjYhx6hQjfaVH2XkiYAWLSLXtJzX51Hf9SJ3RuYQDdDX4ttZJ1T2 e94Bb3HuIYU9MnvWYHSIWuuMHizHj7YlM32orCoG7rrCnkvXO3jg4UsNix7Ote/aJyxa jdq6uLohW+SHjtZLH9c1WuZpXC0m4viJVRE8+NFSYTZD7o2qy62Ow4d9L0CMsp+MUKox jL1jqVQWyD36UA7tI4YZnOMaS5iRCkvfwLrYY/Zoo4YR4r0DTjK5xO/z5HMHZVq4EOSU 5YMci66YvKAY/1SbEtp00YrilTS3Rj3Pt+Vj8uvgq/jrO56mttgnTp6oIphvKmqJWa0e vWvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B5CHbg+8b24jKcyqMjIgkeB+fm8k5OGLCytCdmtDF84=; b=Ro6K606B79crJnjVq+6o01Dc4feslAe0NQCTuSP2X7Gp72XcxP3QGf0r5tvtglwOqv MSGyKaR6EoQQSeuUzYY2w++RUlXnWXlPlI4P5+zvV0zm6TgOtKwbUpdZXg3Cm9n6CsS0 wUpsbp/GyP+u4Q/jolJL6TVMoiqCUhyazEowJTxG4rKHlnmUH78Po2Zd/wKzrpLb/FAb VRs+BBWDOvTRO8xWaj6grq3D6b/mx7li72Y+E2dj2yPrIwzERPSecE5H9mJUCJPpvc6n HGHm7mxaZY32MWL/fXJiPizReZ3xUhMwGG4tDsa/26nfbA1ADoOWowhhjIi7CSYQqyJK Ev5g== X-Gm-Message-State: AFqh2kpar0q5a61VEBFE5qE3wGqfcG3JZkIOiNu+zwBq0PRXCEDLfFbn kcH7XcW8oNPXhS6XpUcWogetjA== X-Google-Smtp-Source: AMrXdXtwLkq5JjJtX7uA0W5OuWnCMwaKAklXGhAKpIPUbnZS/ecaOwe4cZr6IggAtCbXCFd9FNqITw== X-Received: by 2002:a05:6512:1582:b0:4b6:e494:a98d with SMTP id bp2-20020a056512158200b004b6e494a98dmr4545398lfb.44.1671896534235; Sat, 24 Dec 2022 07:42:14 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c14-20020ac25f6e000000b004b5821219fbsm987035lfc.60.2022.12.24.07.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Dec 2022 07:42:13 -0800 (PST) From: Krzysztof Kozlowski To: James Schulman , David Rhodes , Lucas Tanure , Richard Fitzgerald , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ASoC: dt-bindings: cirrus, cs35l41: cleanup $ref and example Date: Sat, 24 Dec 2022 16:42:10 +0100 Message-Id: <20221224154210.43356-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221224154210.43356-1-krzysztof.kozlowski@linaro.org> References: <20221224154210.43356-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof Kozlowski Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Non-functional cleanup: 1. Drop unneeded quotes form $ref, 2. Example: Use generic node name, use define for GPIO flag, adjust indentation to consistent 4-space style. Signed-off-by: Krzysztof Kozlowski Acked-by: Charles Keepax --- .../bindings/sound/cirrus,cs35l41.yaml | 40 ++++++++++--------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml index 919d7f16f24c..18fb471aa891 100644 --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml @@ -45,7 +45,7 @@ properties: Configures the peak current by monitoring the current through the boost FET. Range starts at 1600 mA and goes to a maximum of 4500 mA with increments of 50 mA. See section 4.3.6 of the datasheet for details. - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 1600 maximum: 4500 default: 4500 @@ -54,7 +54,7 @@ properties: description: Boost inductor value, expressed in nH. Valid values include 1000, 1200, 1500 and 2200. - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 1000 maximum: 2200 @@ -63,7 +63,7 @@ properties: Total equivalent boost capacitance on the VBST and VAMP pins, derated at 11 volts DC. The value must be rounded to the nearest integer and expressed in uF. - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 cirrus,asp-sdout-hiz: description: @@ -73,7 +73,7 @@ properties: 1 = Hi-Z during unused slots but logic 0 while all transmit channels disabled 2 = (Default) Logic 0 during unused slots, but Hi-Z while all transmit channels disabled 3 = Hi-Z during unused slots and while all transmit channels disabled - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 0 maximum: 3 default: 2 @@ -87,7 +87,7 @@ properties: enable boost voltage. 0 = Internal Boost 1 = External Boost - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 0 maximum: 1 @@ -112,7 +112,7 @@ properties: 1 = GPIO 2 = Sync 3 = MCLK input - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 0 maximum: 3 @@ -139,7 +139,7 @@ properties: 3 = MCLK input 4 = Push-pull INTB (active low) 5 = Push-pull INT (active high) - $ref: "/schemas/types.yaml#/definitions/uint32" + $ref: /schemas/types.yaml#/definitions/uint32 minimum: 0 maximum: 5 @@ -179,21 +179,23 @@ unevaluatedProperties: false examples: - | + #include + spi { #address-cells = <1>; #size-cells = <0>; - cs35l41: cs35l41@2 { - #sound-dai-cells = <1>; - compatible = "cirrus,cs35l41"; - reg = <2>; - VA-supply = <&dummy_vreg>; - VP-supply = <&dummy_vreg>; - reset-gpios = <&gpio 110 0>; - - cirrus,boost-type = <0>; - cirrus,boost-peak-milliamp = <4500>; - cirrus,boost-ind-nanohenry = <1000>; - cirrus,boost-cap-microfarad = <15>; + cs35l41: speaker-amp@2 { + #sound-dai-cells = <1>; + compatible = "cirrus,cs35l41"; + reg = <2>; + VA-supply = <&dummy_vreg>; + VP-supply = <&dummy_vreg>; + reset-gpios = <&gpio 110 GPIO_ACTIVE_HIGH>; + + cirrus,boost-type = <0>; + cirrus,boost-peak-milliamp = <4500>; + cirrus,boost-ind-nanohenry = <1000>; + cirrus,boost-cap-microfarad = <15>; }; };