From patchwork Thu Dec 22 12:54:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jianhua Lu X-Patchwork-Id: 636520 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12A4C4332F for ; Thu, 22 Dec 2022 12:55:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229742AbiLVMzP (ORCPT ); Thu, 22 Dec 2022 07:55:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbiLVMzP (ORCPT ); Thu, 22 Dec 2022 07:55:15 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D08A1FCD1; Thu, 22 Dec 2022 04:55:14 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id u7so1908969plq.11; Thu, 22 Dec 2022 04:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lFxf6zDLXyxyCvBzfL4x586BkarrSV+wQb1epY2jp74=; b=On9oQbwjOVA+gh1rsGDpTgOa42M66ZYlefPZmYMAH0Byx7IdaETwDq0GQnSVashA8l W2j9K+DjBvJHnWyQhHX14OvGUaLbylzRL6D5aB8tAeIe47ElkqQbwwza05trj3kO1T5R aTAfTeRY2uHCDrtku17F0hAjCf5LMX3x4OpSxzy5wI2UQ+ZAMpFhkpyWg7QNX2FMUvn6 1/tmWBfhayklrAfCCOhHDN1Mdgob1Fr+W+lc6bues+JZtuN/1de573c/NU2zv2LJ1L9T ygXFtYwmL1+MO+yUsuhAXBMlfXjNcTZ7GeZsDzhxf2kdT1h2d3OHrdsbYvOzo6nTHbRI 351g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lFxf6zDLXyxyCvBzfL4x586BkarrSV+wQb1epY2jp74=; b=gk7a9EHmzE9hznvsC1wmtlRJPAOVaGQYuVZFX1TSf0Zgg08OSisfbuhllWVoVtaEso MGA+eemNFC3ak5B9RHRPQjuReQua496fbYDV2Hav33wPTFhseUcIYhGrr4sy8OqaCgvs hs0TQwLUY0SMMMsTOHHzMGMWJS70YplsK164M9sLUg+ON8IteeBvLrAI+z2GkeUFaL21 oQAQLHjPuh0SolmT2OLGNwAp1bRQGyZJgeqeEB+Pi0dZi4EUtC8YiVTlTpWnCPgRzT1a XK5lIGVy5sLSqTP9NkcPUaNRzkYh5byE1LEHCsHx2KLJdow66abqIKMN+nq1yXdbPwzs d+BA== X-Gm-Message-State: AFqh2kqDY7+CWw3lVrKZVO+6syMxUTZiICNv2wKporzKcDsNwXGbasXj jwuNqajIkTYP4iLN4O+ugt77ehDFCZjZRtyW X-Google-Smtp-Source: AMrXdXvDO88A3XgNmQ5g+bssendpBJKHV7mI1End013yByJJ1gnrhInrxH1DgWYCt4AoOCyoEg9ADQ== X-Received: by 2002:a17:902:e2ca:b0:18e:c6b0:b2f6 with SMTP id l10-20020a170902e2ca00b0018ec6b0b2f6mr5450331plc.14.1671713713553; Thu, 22 Dec 2022 04:55:13 -0800 (PST) Received: from localhost.localdomain ([45.62.172.3]) by smtp.gmail.com with ESMTPSA id t8-20020a170902e84800b0017849a2b56asm503048plg.46.2022.12.22.04.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 04:55:13 -0800 (PST) From: Jianhua Lu To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Helge Deller Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Jianhua Lu Subject: [PATCH v3 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight Date: Thu, 22 Dec 2022 20:54:40 +0800 Message-Id: <20221222125441.1547-1-lujianhua000@gmail.com> X-Mailer: git-send-email 2.38.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu --- Changes in v2: - Add missing staitc modifier to ktz8866_write function. Changes in v3: - Add 2022 to Copyright line. - Sort headers - Remove meaningless comment - Use definitions instead of hardcoding. - Add missing maintainer info MAINTAINERS | 6 + drivers/video/backlight/Kconfig | 8 ++ drivers/video/backlight/Makefile | 1 + drivers/video/backlight/ktz8866.c | 180 ++++++++++++++++++++++++++++++ drivers/video/backlight/ktz8866.h | 31 +++++ 5 files changed, 226 insertions(+) create mode 100644 drivers/video/backlight/ktz8866.c create mode 100644 drivers/video/backlight/ktz8866.h diff --git a/MAINTAINERS b/MAINTAINERS index 1daadaa4d48b..b33385b5fd3c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11507,6 +11507,12 @@ M: John Hawley S: Maintained F: tools/testing/ktest +KTZ8866 BACKLIGHT DRIVER +M: Jianhua Lu +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml +F: drivers/video/backlight/ktz8866.c + L3MDEV M: David Ahern L: netdev@vger.kernel.org diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 936ba1e4d35e..2845fd7e33ad 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -190,6 +190,14 @@ config BACKLIGHT_KTD253 which is a 1-wire GPIO-controlled backlight found in some mobile phones. +config BACKLIGHT_KTZ8866 + tristate "Backlight Driver for Kinetic KTZ8866" + depends on I2C + select REGMAP_I2C + help + Say Y to enabled the backlight driver for the Kinetic KTZ8866 + found in Xiaomi Mi Pad 5 series. + config BACKLIGHT_LM3533 tristate "Backlight Driver for LM3533" depends on MFD_LM3533 diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile index e815f3f1deff..f70a819c304c 100644 --- a/drivers/video/backlight/Makefile +++ b/drivers/video/backlight/Makefile @@ -36,6 +36,7 @@ obj-$(CONFIG_BACKLIGHT_HP680) += hp680_bl.o obj-$(CONFIG_BACKLIGHT_HP700) += jornada720_bl.o obj-$(CONFIG_BACKLIGHT_IPAQ_MICRO) += ipaq_micro_bl.o obj-$(CONFIG_BACKLIGHT_KTD253) += ktd253-backlight.o +obj-$(CONFIG_BACKLIGHT_KTZ8866) += ktz8866.o obj-$(CONFIG_BACKLIGHT_LM3533) += lm3533_bl.o obj-$(CONFIG_BACKLIGHT_LM3630A) += lm3630a_bl.o obj-$(CONFIG_BACKLIGHT_LM3639) += lm3639_bl.o diff --git a/drivers/video/backlight/ktz8866.c b/drivers/video/backlight/ktz8866.c new file mode 100644 index 000000000000..ea641bdfc4d2 --- /dev/null +++ b/drivers/video/backlight/ktz8866.c @@ -0,0 +1,180 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Backlight driver for the Kinetic KTZ8866 + * + * Copyright (C) 2022 Jianhua Lu + */ + +#include +#include +#include +#include +#include +#include +#include +#include "ktz8866.h" + +#define DEFAULT_BRIGHTNESS 1500 +#define MAX_BRIGHTNESS 2047 +#define REG_MAX 0x15 + +#define BL_EN_BIT BIT(6) +#define BL_CURRENT_SINKS 0x1F +#define BL_OVP_LIMIT 0x33 +#define LED_CURRENT_RAMPING_TIME 0xBD +#define LED_DIMMING_TIME 0x11 +#define LCD_BIAS_EN 0x9F +#define LED_CURRENT 0xF9 + +#define low_3_bit(x) ((x)&0x7) +#define high_8_bit(x) ((x >> 3) & 0xFF) + +struct ktz8866 { + struct i2c_client *client; + struct regmap *regmap; + bool state; +}; + +enum { + LED_OFF, + LED_ON, +}; + +static const struct regmap_config ktz8866_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + .max_register = REG_MAX, +}; + +static int ktz8866_write(struct ktz8866 *ktz, unsigned int reg, + unsigned int val) +{ + return regmap_write(ktz->regmap, reg, val); +} + +static int ktz8866_update_bits(struct ktz8866 *ktz, unsigned int reg, + unsigned int mask, unsigned int val) +{ + return regmap_update_bits(ktz->regmap, reg, mask, val); +} + +static int ktz8866_backlight_update_status(struct backlight_device *backlight_dev) +{ + struct ktz8866 *ktz = bl_get_data(backlight_dev); + unsigned int brightness = backlight_get_brightness(backlight_dev); + + if (!ktz->state && brightness > 0) { + ktz8866_update_bits(ktz, BL_EN, BL_EN_BIT, BL_EN_BIT); + ktz->state = LED_ON; + } else if (brightness == 0) { + ktz8866_update_bits(ktz, BL_EN, BL_EN_BIT, 0); + ktz->state = LED_OFF; + msleep(10); + } + + /* Set brightness */ + ktz8866_write(ktz, BL_BRT_LSB, low_3_bit(brightness)); + ktz8866_write(ktz, BL_BRT_MSB, high_8_bit(brightness)); + + return 0; +} + +static const struct backlight_ops ktz8866_backlight_ops = { + .options = BL_CORE_SUSPENDRESUME, + .update_status = ktz8866_backlight_update_status, +}; + +static void ktz8866_init(struct ktz8866 *ktz) +{ + /* Enable 1~5 current sinks */ + ktz8866_write(ktz, BL_EN, BL_CURRENT_SINKS); + /* Backlight OVP 26.4V */ + ktz8866_write(ktz, BL_CFG1, BL_OVP_LIMIT); + /* LED current ramping time 128ms */ + ktz8866_write(ktz, BL_CFG2, LED_CURRENT_RAMPING_TIME); + /* LED on/off ramping time 1ms */ + ktz8866_write(ktz, BL_DIMMING, LED_DIMMING_TIME); + /* Enable OUTP and OUTN via pin ENP and ENN */ + ktz8866_write(ktz, LCD_BIAS_CFG1, LCD_BIAS_EN); + /* Backlight Full-scale LED Current 30.0mA */ + ktz8866_write(ktz, FULL_SCALE_CURRENT, LED_CURRENT); +} + +static int ktz8866_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + struct backlight_device *backlight_dev; + struct backlight_properties props; + struct ktz8866 *ktz; + + ktz = devm_kzalloc(&client->dev, sizeof(*ktz), GFP_KERNEL); + if (!ktz) + return -ENOMEM; + + ktz->client = client; + ktz->regmap = devm_regmap_init_i2c(client, &ktz8866_regmap_config); + + if (IS_ERR(ktz->regmap)) { + dev_err(&client->dev, "failed to init regmap\n"); + return PTR_ERR(ktz->regmap); + } + + memset(&props, 0, sizeof(props)); + props.type = BACKLIGHT_RAW; + props.max_brightness = MAX_BRIGHTNESS; + props.brightness = clamp_t(unsigned int, DEFAULT_BRIGHTNESS, 0, + props.max_brightness); + + backlight_dev = devm_backlight_device_register( + &client->dev, "ktz8866-backlight", &client->dev, ktz, + &ktz8866_backlight_ops, &props); + + if (IS_ERR(backlight_dev)) { + dev_err(&client->dev, "failed to register backlight device\n"); + return PTR_ERR(backlight_dev); + } + + ktz8866_init(ktz); + + i2c_set_clientdata(client, backlight_dev); + backlight_update_status(backlight_dev); + + return 0; +} + +static void ktz8866_remove(struct i2c_client *client) +{ + struct backlight_device *backlight_dev = i2c_get_clientdata(client); + + backlight_dev->props.brightness = 0; + backlight_update_status(backlight_dev); +} + +static const struct i2c_device_id ktz8866_ids[] = { + { "ktz8866", 0 }, + {}, +}; +MODULE_DEVICE_TABLE(i2c, ktz8866_ids); + +static const struct of_device_id ktz8866_match_table[] = { + { + .compatible = "kinetic,ktz8866", + }, + {}, +}; + +static struct i2c_driver ktz8866_driver = { + .driver = { + .name = "ktz8866", + .of_match_table = ktz8866_match_table, + }, + .probe = ktz8866_probe, + .remove = ktz8866_remove, + .id_table = ktz8866_ids, +}; + +module_i2c_driver(ktz8866_driver); + +MODULE_DESCRIPTION("Kinetic KTZ8866 Backlight Driver"); +MODULE_AUTHOR("Jianhua Lu "); +MODULE_LICENSE("GPL"); diff --git a/drivers/video/backlight/ktz8866.h b/drivers/video/backlight/ktz8866.h new file mode 100644 index 000000000000..b0ed8cbee608 --- /dev/null +++ b/drivers/video/backlight/ktz8866.h @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Register definitions for Kinetic KTZ8866 backlight + * + * Copyright (C) 2022 Jianhua Lu + */ + +#ifndef KTZ8866_H +#define KTZ8866_H + +#define DEVICE_ID 0x01 +#define BL_CFG1 0x02 +#define BL_CFG2 0x03 +#define BL_BRT_LSB 0x04 +#define BL_BRT_MSB 0x05 +#define BL_EN 0x08 +#define LCD_BIAS_CFG1 0x09 +#define LCD_BIAS_CFG2 0x0A +#define LCD_BIAS_CFG3 0x0B +#define LCD_BOOST_CFG 0x0C +#define OUTP_CFG 0x0D +#define OUTN_CFG 0x0E +#define FLAG 0x0F +#define BL_OPTION1 0x10 +#define BL_OPTION2 0x11 +#define PWM2DIG_LSBs 0x12 +#define PWM2DIG_MSBs 0x13 +#define BL_DIMMING 0x14 +#define FULL_SCALE_CURRENT 0x15 + +#endif /* KTZ8866_H */ From patchwork Thu Dec 22 12:54:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jianhua Lu X-Patchwork-Id: 636209 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC4CC4332F for ; Thu, 22 Dec 2022 12:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235233AbiLVMz0 (ORCPT ); Thu, 22 Dec 2022 07:55:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235133AbiLVMzY (ORCPT ); Thu, 22 Dec 2022 07:55:24 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E608E275C7; Thu, 22 Dec 2022 04:55:22 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id z8-20020a17090abd8800b00219ed30ce47so5609212pjr.3; Thu, 22 Dec 2022 04:55:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W/70G/iNRFg0+tqFbgre+zSYvcngTPI1dr+sS/6Z8gg=; b=JKAltLDQ3krQAXiX8vfnL7ROx6AVWxgu47kG7d/yv6i/PcLUOmDydXX8GFy0H7/AUo rHbbLRBbM5kbCSAE5VE7Q0xVGjFzsQyj7QwPAC1RmBbLdHV42VAd2ZqdRmgF5JMwhrMe GM9gtEHX18SQDz2xaMBEs1qA4O6UiFwQSXJK+fepF9E8FKJnZxbg7dl6fVRMYhfiljVX nX/jC3qN5dlX4sMnWAa6Z4+YguoeWz7t7OZa2Ct8ckw2nwb67nnH+pozxHCQVK4LMCQs ZZimW2gQ84jUJZB+LaQaXpaDkHoaZAHt8IXBTz4tF8hwfIPVEDAxlGy+9LHT7EpicHNB S6fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W/70G/iNRFg0+tqFbgre+zSYvcngTPI1dr+sS/6Z8gg=; b=UIPa0aWpKWE/V2NCdFlTaVouDiNtgs5q/tGGLJEYcP6F66gRGdDTLXbms4pew9NDmI 3f967P2TWwJz9MVa95TKP1ayjRa7x6XPe2m6SS1PvbeqMSXPnaXhvvJxIuw3hXjJDeHh wccIc2vl4ET00IUohnP5UOXoom3kAn8BgCvPv/CwSsnxL/un+ESuH+6YBSKThLlHag+o ckOKhZ+VRIlvcyqNfowBJmMFTd3zvfdSNRhWCptvV1xngQlWZUenGpkirkGAubBcA9Ad NekxQGi9OBLjxauM+cw3SYVMGkV+UJVYdes/44Uf/IivRSFN15qak2ZUZ3SW13mRSyKk RJwg== X-Gm-Message-State: AFqh2krfQzNkL72W+JJjAmyxLCfIJwgJoGxjrjdakMisNS3mtW+X9F/a tWFvIRvvTi9Hz0Q6vXX8vdY= X-Google-Smtp-Source: AMrXdXu+UkvaD+1wradcsdg55khU6E+1KfnZ/StEOvUkENC+h47PnAfvm4EN7g3Z98Nv8lvs2/Hy/A== X-Received: by 2002:a17:902:b58a:b0:186:def0:66f2 with SMTP id a10-20020a170902b58a00b00186def066f2mr5511853pls.11.1671713722425; Thu, 22 Dec 2022 04:55:22 -0800 (PST) Received: from localhost.localdomain ([45.62.172.3]) by smtp.gmail.com with ESMTPSA id t8-20020a170902e84800b0017849a2b56asm503048plg.46.2022.12.22.04.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 04:55:22 -0800 (PST) From: Jianhua Lu To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Helge Deller Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Jianhua Lu , Krzysztof Kozlowski Subject: [PATCH v3 2/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight Date: Thu, 22 Dec 2022 20:54:41 +0800 Message-Id: <20221222125441.1547-2-lujianhua000@gmail.com> X-Mailer: git-send-email 2.38.2 In-Reply-To: <20221222125441.1547-1-lujianhua000@gmail.com> References: <20221222125441.1547-1-lujianhua000@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866" - Change "additionalProperties" to "unevaluatedProperties" Changes in v3: - Add Krzysztof's R-b .../leds/backlight/kinetic,ktz8866.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml new file mode 100644 index 000000000000..c63c21bf69d6 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml @@ -0,0 +1,36 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Kinetic Technologies KTZ8866 backlight + +maintainers: + - Jianhua Lu + +description: | + The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight + with dual lcd bias power. + https://www.kinet-ic.com/ktz8866/ + +allOf: + - $ref: common.yaml# + +properties: + compatible: + const: kinetic,ktz8866 + +required: + - compatible + +unevaluatedProperties: false + +examples: + - | + backlight { + compatible = "kinetic,ktz8866"; + + pinctrl-names = "default"; + pinctrl-0 = <&bl_en_default>; + };