From patchwork Tue Dec 20 15:04:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 635477 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2967625pvb; Tue, 20 Dec 2022 07:05:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf7mLHv8XAlMUQJFISbSD9o1ZA1Da0lLNqRT3bHERKP/aYgROccSrZnb8tLNRIcjoyE7tHV0 X-Received: by 2002:a05:6214:186d:b0:4c7:b0f:6751 with SMTP id eh13-20020a056214186d00b004c70b0f6751mr56160698qvb.4.1671548735241; Tue, 20 Dec 2022 07:05:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671548735; cv=none; d=google.com; s=arc-20160816; b=z8RkhTgUnLY55W/z1z7BQq2Ott4aRKjvqbhICICx2UABq+tRcFpzeRAv3NTJpssdZU tKIjPVDDbrjq970RxXIjRRhkgmJ80OkESjMCKjBU+I06LAAEsaJ7p+dQCeoSzcy5yV9e ZK31qqOGDbNEDuls1Gjf5+cQavaAW2whZEDlVNIDvsxi3pTrctgkiL3MNSjljeWag0Cn jq2+K0DyB65dtgRaWWzVGDVTDVlHAxLFHIDkWknx+BV4sJuA7UQEGUw8Oir5VeGMLz6n BpMEpZAi99XnIh/k70wypZdnAXBEEaBUpU8Ue5wLigdv+2FRCW7YuN1UOveMTdRAIt7U Y0zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=N5MKPnkKMOF2zElU9F+BUaj6NASlCAgcWBEAiMR6F1g=; b=fCx1/xH5sFjeuy4WuCqSsF7BMinqc/CO2fvEoFiBA1qIOCJ2Fz05pLGAwGVV4KMgfD 7YYd1UyjZiOjIcXe1oobNhfBUU/VKwwiRSHQljzdqhw3JsEqVWH7oTFaa2DFMRQWbsV4 zUbmABwIljhtggX635xTRltzUHj6uB1Uspj72vWmkc6AgV5RS0eWenZizOmfAQ7Xdify 1Olu4x9IKpPaco7Rvafhmz/lcBLfiyVCWhKTSRMYUFPh/G877SplY9QRDn1R9HXIRZhH sFl3i2SRgplWYQ2XWQEciRgNT7NZzMGXkjUskbzKKBoKpjW0/haRBeyGWSXUagS/7nCJ Sj6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JHRbfeTg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id gv5-20020a056214262500b004bb62e51dfdsi5209600qvb.538.2022.12.20.07.05.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Dec 2022 07:05:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JHRbfeTg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7eAP-0000Um-1W; Tue, 20 Dec 2022 10:04:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7eAK-0000TS-LR for qemu-devel@nongnu.org; Tue, 20 Dec 2022 10:04:27 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7eAJ-0005vD-4V for qemu-devel@nongnu.org; Tue, 20 Dec 2022 10:04:24 -0500 Received: by mail-wm1-x334.google.com with SMTP id 131-20020a1c0289000000b003d35acb0f9fso1262901wmc.2 for ; Tue, 20 Dec 2022 07:04:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=N5MKPnkKMOF2zElU9F+BUaj6NASlCAgcWBEAiMR6F1g=; b=JHRbfeTgO2uOXWLI8FdPjujFnWEf+vUl3LPPBodk9q0WxdM1cCMskWLYMiqVkcuZgH RMIFBy0Hd9iIxHhQMyVH7U6u/VmofMNGlFcn0XU/uu8qFHLgRI7CrRgtOdqpAkVFJIM+ uQDH8H7xkV5UCZRXgyPlu/G+iAUvzBl45qk3P7YA4zKYYLpVTgL5k/iv4orTW9FCHqI7 wYMSu9JCO0E/T/CLcjY9atig0CB6Nn0PPzLUeBQhRJEdvqm5Rz7tcLhEuIG1QRc2V3nw 44p1mF2jUusN4rZaGpFWkHY5CqJxKye73hi+JfLYgm6JZSq7UNy1ATBIemH4CskJn5uD yOyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N5MKPnkKMOF2zElU9F+BUaj6NASlCAgcWBEAiMR6F1g=; b=iQRVjHrnxsKQ+W5uHDXre+v8KwI9rfYLRhGAC6ijJjbASClCJECcLr5T/WLgmB8yrP JH0faNLIcB2yDVAPrAh1C7UuVDSHPXfYNosr7S9XcpTE7IvDjLB64mljFjDVNGW33hoz QSsXNjz0MMaV14Up3spVryuUZ4DwMwoSEC+m2Vjnaib7W8dtHF2F4nxVDENTczO0TtPQ aKPnCxMAoSwDbzUMcVFSss1BLcJhmbqnXBEdjFXY1Yy+MQCfUDREYPQe9rUFId5MmECX BaKlwd3uLBmKAjytBgi7Msc4HKK07p8QvIF65bXVTPZkHvZrbfLe6Iq3/UqVDcMjCej3 TDbw== X-Gm-Message-State: ANoB5pkoOkuWfiH5G+ffMMA41iJJj7cXhLsr8S8Vv/MhoYrqgg9YOtue c96yWdfShCESbFIWZ62ev40YXggsbpF3lG343Xk= X-Received: by 2002:a05:600c:22ca:b0:3d1:ee97:980 with SMTP id 10-20020a05600c22ca00b003d1ee970980mr47115971wmg.7.1671548660860; Tue, 20 Dec 2022 07:04:20 -0800 (PST) Received: from localhost.localdomain ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id x8-20020a05600c21c800b003b47ff307e1sm15738748wmj.31.2022.12.20.07.04.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 20 Dec 2022 07:04:19 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Markus Armbruster , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH] trace: Do not try to include QMP commands in user emulation binaries Date: Tue, 20 Dec 2022 16:04:17 +0100 Message-Id: <20221220150417.26751-1-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org QMP is not available on user emulation; there is not monitor. Besides, since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the qapi-commands-trace.h header in a user-emulation-only build. Remove the QMP trace commands from qemu-user binaries. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson --- trace/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/trace/meson.build b/trace/meson.build index 26b54714d5..4385afbff0 100644 --- a/trace/meson.build +++ b/trace/meson.build @@ -88,4 +88,6 @@ if 'ftrace' in get_option('trace_backends') trace_ss.add(files('ftrace.c')) endif trace_ss.add(files('control.c')) -trace_ss.add(files('qmp.c')) +if have_system or have_tools or have_ga + trace_ss.add(files('qmp.c')) +endif