From patchwork Mon Jun 13 15:18:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102236 Delivered-To: patch@linaro.org Received: by 10.140.106.246 with SMTP id e109csp1598411qgf; Mon, 13 Jun 2016 08:22:55 -0700 (PDT) X-Received: by 10.36.36.72 with SMTP id f69mr246514ita.43.1465831375660; Mon, 13 Jun 2016 08:22:55 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7si18322058pae.92.2016.06.13.08.22.55; Mon, 13 Jun 2016 08:22:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423728AbcFMPWy (ORCPT + 4 others); Mon, 13 Jun 2016 11:22:54 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:49226 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424231AbcFMPWx (ORCPT ); Mon, 13 Jun 2016 11:22:53 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue104) with ESMTPA (Nemesis) id 0MGi7V-1bHCjC0kEL-00DanP; Mon, 13 Jun 2016 17:19:23 +0200 From: Arnd Bergmann To: Linus Walleij Cc: Arnd Bergmann , Jean-Christophe Plagniol-Villard , Heiko Stuebner , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Shawn Guo , Adrian Alonso , Thomas Gleixner , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@stlinux.com Subject: [PATCH 1/2] pinctrl: fix incorrect inline keyword in multiple drivers Date: Mon, 13 Jun 2016 17:18:34 +0200 Message-Id: <1465831250-2689101-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:lAeBL5HTRb3m/DkdHfm0qNPetHlIphRtQktpEFZgvtqGYXK7nCU n4HJiHYbyzuRjFf8AZLXXDeJUdkgxpqkkznwdQLLe9tiw8WdkNnCVoXC1I/mVDw/uDnHvov YTmB7uB199UHY4Q7DKrV7TUzFYJiKizuZuXJ8LtL4UokdHhc8G8MxE59M51MJZmFbaK92eR 1Gspj6aO0HWWfr4hm1jSg== X-UI-Out-Filterresults: notjunk:1; V01:K0:VyuK92+GU4s=:PIMErf71XoGDoCuLSDBE/s hOQwCtFxMqjNNLgQb3BqZHDViw+OwVcCv2u4ZafJacvJoooth2ne3S5PAIXPP9mTMWWUf51PV EFWulLYiuN/T2lQlm06D/rxwYxWpA5z9jL3q4XDlZRmdtshcHim0YbVnByiJ/xzbbERjFtyGb HlPUVazWcJgmRqT2KShHYC3E1Oh9OH8ygAmsTac2IFG+f6R5FLStx9MUOEjsqvTGmMSPl+pEY RjrAYTRUY9FlNLzD9JFk6d5wPzrv8BjgWwPAikg4R7rFTZAOgqHkt5SSf/0Yv83vXmhvuqSCw AaBjS9549nJJGfKAOuGrOGZcoKQYzAV+O96e1CmPi93dBBOryolcnVC2mqFpoYaWu9+Jet351 R6qu2QNunGItuaNG0trGfQX0T1PmALtAB3vP5cnpWPWEq5zqRK6gpIHCtlLx/W2lKelVSwv3I ZeMUX+7gGrl/1A5eVHOEkSh8XGmK5TYPuNBqDTp57IoKj5lceDkUaoGqskHOsV27a0HW79Mr3 XPavCkH0rGQwkEGJLlF/VcvWG1yXFMbTnafWT3wtgOaspmvWxBJR6aNggdEpUbyKHKmy/kuxV FN/Lsc9tTsg7nsRCqIwohLasWcJqj6GgmY2V+BhJK6A2W1FuByhl1mgJLfo26IMRTeizSgO50 XyMvkhuhIZ4sWwvFGIN2sRYSgoxdLhYaRbQblU0ef1cOqjpcpa6QMPg7sIEDUMVvb4bk= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org When building with 'make W=1', we get harmless warnings about five drivers in drivers/pinctrl, which all contain a copy of the same line: drivers/pinctrl/freescale/pinctrl-imx1-core.c:160:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration] This replaces the somewhat nonstandard 'static const inline' with 'static inline const', which has the same meaning but does not cause this warning. Signed-off-by: Arnd Bergmann --- drivers/pinctrl/freescale/pinctrl-imx.c | 2 +- drivers/pinctrl/freescale/pinctrl-imx1-core.c | 2 +- drivers/pinctrl/pinctrl-at91.c | 2 +- drivers/pinctrl/pinctrl-rockchip.c | 2 +- drivers/pinctrl/pinctrl-st.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- 2.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index 309d31d61390..491d2d244f56 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -46,7 +46,7 @@ struct imx_pinctrl { const struct imx_pinctrl_soc_info *info; }; -static const inline struct imx_pin_group *imx_pinctrl_find_group_by_name( +static inline const struct imx_pin_group *imx_pinctrl_find_group_by_name( const struct imx_pinctrl_soc_info *info, const char *name) { diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c index b4400cb19b61..38d39388d7a4 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c @@ -157,7 +157,7 @@ static int imx1_read_bit(struct imx1_pinctrl *ipctl, unsigned int pin_id, return !!(readl(reg) & BIT(offset)); } -static const inline struct imx1_pin_group *imx1_pinctrl_find_group_by_name( +static inline const struct imx1_pin_group *imx1_pinctrl_find_group_by_name( const struct imx1_pinctrl_soc_info *info, const char *name) { diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c index b7c0d6f7c046..2ce429cf41e6 100644 --- a/drivers/pinctrl/pinctrl-at91.c +++ b/drivers/pinctrl/pinctrl-at91.c @@ -189,7 +189,7 @@ struct at91_pinctrl { struct at91_pinctrl_mux_ops *ops; }; -static const inline struct at91_pin_group *at91_pinctrl_find_group_by_name( +static inline const struct at91_pin_group *at91_pinctrl_find_group_by_name( const struct at91_pinctrl *info, const char *name) { diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index a91026e8cd7c..a2337b7dfc41 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -360,7 +360,7 @@ static struct regmap_config rockchip_regmap_config = { .reg_stride = 4, }; -static const inline struct rockchip_pin_group *pinctrl_name_to_group( +static inline const struct rockchip_pin_group *pinctrl_name_to_group( const struct rockchip_pinctrl *info, const char *name) { diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index d0ba968af5bb..0de1c67dfb94 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -844,7 +844,7 @@ static int st_pctl_get_group_pins(struct pinctrl_dev *pctldev, return 0; } -static const inline struct st_pctl_group *st_pctl_find_group_by_name( +static inline const struct st_pctl_group *st_pctl_find_group_by_name( const struct st_pinctrl *info, const char *name) { int i; From patchwork Mon Jun 13 15:18:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102237 Delivered-To: patch@linaro.org Received: by 10.140.106.246 with SMTP id e109csp1597266qgf; Mon, 13 Jun 2016 08:20:16 -0700 (PDT) X-Received: by 10.107.38.145 with SMTP id m139mr23984813iom.15.1465831216824; Mon, 13 Jun 2016 08:20:16 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qz3si18338777pab.82.2016.06.13.08.20.16; Mon, 13 Jun 2016 08:20:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424535AbcFMPUJ (ORCPT + 4 others); Mon, 13 Jun 2016 11:20:09 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:64716 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423957AbcFMPUI (ORCPT ); Mon, 13 Jun 2016 11:20:08 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue104) with ESMTPA (Nemesis) id 0M2M3o-1bSlaX29JM-00s3ty; Mon, 13 Jun 2016 17:20:01 +0200 From: Arnd Bergmann To: Linus Walleij Cc: Arnd Bergmann , Laxman Dewangan , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] pinctrl: max77620: select PINMUX Date: Mon, 13 Jun 2016 17:18:35 +0200 Message-Id: <1465831250-2689101-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1465831250-2689101-1-git-send-email-arnd@arndb.de> References: <1465831250-2689101-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:6Dsdiw+DDMVjyuH2fV6Wu59p3tJb8dJeQ3rEBQBv3obC6ERi2KG +bODUJ2UFTKzkOJcl5iAksJxR5D0aUYPFjJNywFmaNRSclgPjKFS8FacPqqA1aBtryoSWtx MjvR2pP64vG4nltVCa0V3htRuOtVjbd7atLew/LpXrD/LOLzhCXoEpVLhgR1rnx5tXWJe6m a06N5irlSNoxJo/UMMfZA== X-UI-Out-Filterresults: notjunk:1; V01:K0:1LiGeret/pY=:Duo05p8MWYBBpiShL5YCDj 4pq7GDIkZRMbT67OdGmpUievzXjyO+yGl4lCCbroYX9SwrSL5fh2kGU4d6nJqF7vn0XPK61/m qWpUPdeHR6OOAftKYlD3Pew9X9kEwvMkDbacApeZjbkHmuglx/paqhwnd6EOVVJvgs0HP07Ao kVLjjM6YyHLGX1KAMmqa9Q9mvhHgzpFOB2xQeuAZ7GYbGcMKhO9RqR5NAt0ZUNyKNGcIDuvCr DjJLhq3m4jGaPv0D9VjmZ5BXVvwnV4lqCVib+riqhgFtIWnD2HqpwZByn1bAeazZdmpKFyEMF Lt/2BvRnxWrB+btNExPrs9oH0RRADrigIaQ6rBGnUDsvjlIV+TglajFXfrjPJLiIbR9iqf5W0 nDDAs+qlInATc24F6X5cufs2Ti5cwIzFaluiJ85OxBzhBr457AhHhxvBc3xnEp7LJq6baYKvF ljLIDbLBrgnjrV/D+8hUO8MmoGhLFN0lnrkrKUILBSZPzF/x2ySCQZ/TojgWvRcN0OnZ3PG0E aybHRriF+hB2eLewbPQ3yXFxuLzqWRACLC8CWgI2miyybZIxTTubFWuO4fTghuQcGVf/LRVd+ WUB8jDleUAgfOXRGTuVt+8THcUOEFwWA15MBg18TeRZxkGb8hzEsxAany8cAKQa51U/Uee/Cv tKvLxus0w5iTSYUyrqcdKSZSAwvxGObu1cM/sFRk+6tlAAFHmjXq7kmEsPfaFOkNY/lY= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The recently added max77620 driver fails to build when CONFIG_PINMUX is not set: pinctrl/pinctrl-max77620.c:272:21: error: variable 'max77620_pinmux_ops' has initializer but incomplete type static const struct pinmux_ops max77620_pinmux_ops = { ^~~~~~~~~~ pinctrl/pinctrl-max77620.c:273:2: error: unknown field 'get_functions_count' specified in initializer This adds the Kconfig 'select' statement that was clearly meant to be there and is used in all other pinmux drivers. Signed-off-by: Arnd Bergmann --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index ea25eeeceef1..78c9ed277a77 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -210,6 +210,7 @@ config PINCTRL_COH901 config PINCTRL_MAX77620 tristate "MAX77620/MAX20024 Pincontrol support" depends on MFD_MAX77620 + select PINMUX select GENERIC_PINCONF help Say Yes here to enable Pin control support for Maxim PMIC MAX77620.