From patchwork Wed Dec 7 20:43:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 632072 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 601EBC4708D for ; Wed, 7 Dec 2022 20:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229479AbiLGUnf (ORCPT ); Wed, 7 Dec 2022 15:43:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbiLGUne (ORCPT ); Wed, 7 Dec 2022 15:43:34 -0500 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3014F2C65B; Wed, 7 Dec 2022 12:43:32 -0800 (PST) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1445ca00781so16131950fac.1; Wed, 07 Dec 2022 12:43:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=clsoCCY66HioZ8dD2GeAWKW0zSQrMxZw2XXN7NxYt3A=; b=LLoSKIukcSrUDGWNElsslTpBqGb/p0xu7LBNlhTn9fq3TwZqi7M8HEIYtp6R5frnWq 4vAcvyShuebmweOPVVPECvqk2/58prb2Vn3Hw/b8ZODN9GxTBeZuiZ3VrmNfMKN07j2G DUYVHRQv2kGGc+JPDaf7B9TShhSIWty6yI+KrZsXfuXUPoWlnH9sn621uK3cbNvfTexk 5hXjzuGPsyN0f6DOL1T7No0lV3mi0+GMAXms+XSXGAJk75CNckrS0FQNEvFRyahughne K/9q4XlOpAODR4syMW9tjvpEffP/7jOfwkJqq3Id3tdbq/+GHX/e92j2x03/7O6nlbaq ow3A== X-Gm-Message-State: ANoB5pmKkv7NLsxUrHbgNBchnshJM++8MKualfIfB6YZgOAAsyrGn7wo 0Wsx+hFppXqpFSeFVCUXVQ== X-Google-Smtp-Source: AA0mqf7uG9MBmgLp3fO95KnMvzIt6eIUOGbfoadp1aCxQjPuXRTndixvrCmpsYIPYUKNQruFQ5Ps1w== X-Received: by 2002:a05:6870:c18a:b0:142:870e:bd06 with SMTP id h10-20020a056870c18a00b00142870ebd06mr48346239oad.181.1670445812066; Wed, 07 Dec 2022 12:43:32 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id w12-20020a056830410c00b006619295af60sm10798290ott.70.2022.12.07.12.43.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 12:43:31 -0800 (PST) Received: (nullmailer pid 2810095 invoked by uid 1000); Wed, 07 Dec 2022 20:43:31 -0000 From: Rob Herring To: Pavel Machek , Krzysztof Kozlowski , Yi Xin , Mallikarjuna reddy Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Date: Wed, 7 Dec 2022 14:43:26 -0600 Message-Id: <20221207204327.2810001-1-robh@kernel.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org The example has 'led-gpio' properties, but that's not documented. As the 'gpio' form is deprecated, add 'led-gpios' to the schema and update the example. Signed-off-by: Rob Herring --- Documentation/devicetree/bindings/leds/leds-lgm.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/leds-lgm.yaml b/Documentation/devicetree/bindings/leds/leds-lgm.yaml index f8d7963c3a13..3f13db0dc915 100644 --- a/Documentation/devicetree/bindings/leds/leds-lgm.yaml +++ b/Documentation/devicetree/bindings/leds/leds-lgm.yaml @@ -64,6 +64,9 @@ properties: minimum: 0 maximum: 2 + led-gpios: + maxItems: 1 + intel,sso-hw-trigger: type: boolean description: This property indicates Hardware driven/control LED. @@ -118,14 +121,14 @@ examples: reg = <0>; function = "gphy"; color = ; - led-gpio = <&ssogpio 0 0>; + led-gpios = <&ssogpio 0 0>; }; led@2 { reg = <2>; function = LED_FUNCTION_POWER; color = ; - led-gpio = <&ssogpio 23 0>; + led-gpios = <&ssogpio 23 0>; }; }; }; From patchwork Wed Dec 7 20:43:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 631785 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE925C4708D for ; Wed, 7 Dec 2022 20:43:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbiLGUnm (ORCPT ); Wed, 7 Dec 2022 15:43:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229746AbiLGUnh (ORCPT ); Wed, 7 Dec 2022 15:43:37 -0500 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9AF927CD9; Wed, 7 Dec 2022 12:43:36 -0800 (PST) Received: by mail-ot1-f47.google.com with SMTP id t19-20020a9d7753000000b0066d77a3d474so12037399otl.10; Wed, 07 Dec 2022 12:43:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FEwpHty4elixafpE9VoyApenzrPDPlvITLCjJ/4fxLg=; b=Uq2lRDPsnii+efMkw4ZrCngFUWEOM5LJRcpYoPiG3y9n20Y9wT+pnNMw0lhpTBeIeR qZerx9FRM2jMBcvK9nq1SMAGLE1O+4STDkiVpceHR9NyCzlC6YIYBA9pXfjPnlsissFf Q9NUFaPcwJdl/7+zHjZQSm0lPaR0gtgK2Hx5iM4sHziH19uyWGvMaYG8ekX/mTXwxEcG dPkOeEt3xmEW6BF+BsV0p+gkmaIEvwT8VpWqObNBGS3KlhM3pnwIv0GQaLcmQfVEGP7R OI3wC/jKEovwezOtXa2EDL+hUxX2DTFqpr9Bh0hzmSLyAwJCWZG5lhrP8vCDSQsjc3xO /+7A== X-Gm-Message-State: ANoB5pnDzVfPugdKNfFXzeE4hvFj4RVD5nCn/RF7qGgzskzZonWsPUnU ZBNQatLW6SABmXHQ27lBfA== X-Google-Smtp-Source: AA0mqf45B3e2Qmlb+2p55qLWRUyHWXllC5gykTPV7GiGZ6Mr2MN0ZGFh41A6Kzg8pbyOimTIMeEgHQ== X-Received: by 2002:a9d:1b10:0:b0:66e:6964:1f20 with SMTP id l16-20020a9d1b10000000b0066e69641f20mr16917173otl.296.1670445815581; Wed, 07 Dec 2022 12:43:35 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id w18-20020a056871061200b00144bb1013e6sm3827191oan.4.2022.12.07.12.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 12:43:35 -0800 (PST) Received: (nullmailer pid 2810197 invoked by uid 1000); Wed, 07 Dec 2022 20:43:34 -0000 From: Rob Herring To: Pavel Machek , Krzysztof Kozlowski , Yi Xin , Mallikarjuna reddy , Bartosz Golaszewski , Matti Vaittinen Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema Date: Wed, 7 Dec 2022 14:43:27 -0600 Message-Id: <20221207204327.2810001-2-robh@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221207204327.2810001-1-robh@kernel.org> References: <20221207204327.2810001-1-robh@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org 'led' nodes should have a reference to LED common.yaml schema. Add it where missing and drop any duplicate properties. Signed-off-by: Rob Herring Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/leds/leds-lgm.yaml | 3 ++- .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++------- .../bindings/leds/rohm,bd71828-leds.yaml | 16 +++------------- 3 files changed, 7 insertions(+), 21 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/leds-lgm.yaml b/Documentation/devicetree/bindings/leds/leds-lgm.yaml index 3f13db0dc915..8b3b3bf1eaf2 100644 --- a/Documentation/devicetree/bindings/leds/leds-lgm.yaml +++ b/Documentation/devicetree/bindings/leds/leds-lgm.yaml @@ -56,7 +56,8 @@ properties: patternProperties: "^led@[0-2]$": - type: object + $ref: common.yaml# + unevaluatedProperties: false properties: reg: diff --git a/Documentation/devicetree/bindings/leds/leds-max77650.yaml b/Documentation/devicetree/bindings/leds/leds-max77650.yaml index c6f96cabd4d1..fdb08f44a45d 100644 --- a/Documentation/devicetree/bindings/leds/leds-max77650.yaml +++ b/Documentation/devicetree/bindings/leds/leds-max77650.yaml @@ -30,9 +30,8 @@ properties: patternProperties: "^led@[0-2]$": - type: object - description: | - Properties for a single LED. + $ref: common.yaml# + unevaluatedProperties: false properties: reg: @@ -41,10 +40,6 @@ patternProperties: minimum: 0 maximum: 2 - label: true - - linux,default-trigger: true - required: - compatible - "#address-cells" diff --git a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml index 86a37c92b834..ca92cea56a6f 100644 --- a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml +++ b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml @@ -26,26 +26,16 @@ properties: patternProperties: "^led-[1-2]$": - type: object - description: - Properties for a single LED. + $ref: common.yaml# + unevaluatedProperties: false + properties: - #allOf: - #- $ref: "common.yaml#" rohm,led-compatible: description: LED identification string $ref: "/schemas/types.yaml#/definitions/string" enum: - bd71828-ambled - bd71828-grnled - function: - description: - Purpose of LED as defined in dt-bindings/leds/common.h - $ref: "/schemas/types.yaml#/definitions/string" - color: - description: - LED colour as defined in dt-bindings/leds/common.h - $ref: "/schemas/types.yaml#/definitions/uint32" required: - compatible