From patchwork Mon Mar 25 12:43:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 161091 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3921679jan; Mon, 25 Mar 2019 05:44:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqw8KniKuW8KHWmR+8tt7HpD/C91lSpkWrZ2ZC4truOhDqMuRaeKcgIGk1GWWZjlVcSq1ER/ X-Received: by 2002:aa7:885a:: with SMTP id k26mr23675090pfo.70.1553517864792; Mon, 25 Mar 2019 05:44:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553517864; cv=none; d=google.com; s=arc-20160816; b=URVkQcv7fj8P7TfltZfm5usmER2y707zki9qpFNHwvDA1npGAvZmXedsoujBvPXydk RZsp2TDpqVuYWkbPQvDd6tVVlgiNK4LjMoQesXBUWRmSNbqgrQW1QVPXzLBiQjS3RTH6 MxhZkrwyJh1Vr8qHZWhs6AxUh15sBw3Qp3mZ8c6jNYNau2I4jw6iMv0sEbj2tth9GpDy xWM5oOUQIyGkcs6o42u33IQhi8mQfhSgxjRrujKBJMW8zIhtERc/thpaEYdknxKvEfGL ZhJCDKF+tEgvsAoVeOd+zd8Z0w24XVxLPU2w8JuSq31MwZcz5m/hFks/MNZaGa7DTkrR fv4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7dgtAXpLGSbzRCQmUIJw4lNkArpkOgSTMHKhDbT0f/Q=; b=SuM6Kvq/TSAxUZr7o8bVTw7ZxSyprjQIuffa1AZ4SibLyzHTN9wCE27zp+fi8WIjWl 8ExZ+Od7nB+HhTpGwC0KAb6hctD8ivKLY3VO+toeDfcaFI+jeEcFSQFxNuMxPAB6No5X hQnAwF3lVlzqsmRRwvhEe0froQ67mIRJr51XbxEjbju3GitnDAXjkLaqXqhcDgLMzbuq m9piTvu5hLotvG2FTP97y6gDjlpAfkjvzixRE1SI16geirwW/J4PZ+b68TW7Q+JYXIq8 50YS9mtS2aNQyq7THnxpXPow6kRQhun4pg/B1Snq2gtZS9JWFHdiuRsheB6SUYOLvuFa VfEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i72si13415978pgd.466.2019.03.25.05.44.24; Mon, 25 Mar 2019 05:44:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731238AbfCYMoX (ORCPT + 31 others); Mon, 25 Mar 2019 08:44:23 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:51243 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731043AbfCYMoW (ORCPT ); Mon, 25 Mar 2019 08:44:22 -0400 Received: from wuerfel.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPA (Nemesis) id 1MoNu2-1gbJGm1gwC-00omWj; Mon, 25 Mar 2019 13:43:56 +0100 From: Arnd Bergmann To: Christian Lamparter , Kalle Valo , "David S. Miller" Cc: clang-built-linux@googlegroups.com, Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , Dan Carpenter , "Gustavo A. R. Silva" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wireless: carl9170: fix clang build warning Date: Mon, 25 Mar 2019 13:43:44 +0100 Message-Id: <20190325124354.1413529-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:UJEE+690qtoqc0+6QE1rpuNULFFV3R4QEgmmMAtZRDqIVsFR3GW xTGq2R4H+lO1Uck0S25/23uZNxLhGiH50mmo/c+M8RtRmfKM8NzkMw3o+gU5U7iEDe6R5YQ RyTg4WyyH56h7QtRUy4HtM5CyYaqEvjN9mYxc2gkE12I5Z0moZbwEcyRTITDjEXOgxrwiTZ 0spQKnV3m5yYJR7CPVotA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:HR07PaPTuSs=:LbsKnalSBTt0U0SGi7zw3q LFvvZjYZRZP1wddNYCLLSZP+0mXl8UhhvQarelTVSIPizxx5gEtm7XffUpZYIBPxHHjVg76ui w+EOrRzagp37kRVdfmwdvAnQaNOQQWlAOznF3OzSRapcEaHW/BJM4rx7eg7nWIaowljmkyxW8 XaSecp/Z//GlXs+nVWSeGK01+vh/Y8T2ZmYsYJP2lWBnT0LUuucvlrn+MxinswKaOIF+mEkNy sMYauVgq8X/3hFWffb1TOv/YXhoSgT9Qufyz2yvNJJhbHN52fZbi/x29/LrOSMgkxgZ+DYepH yI2BLh/Q4g6VN4H+gGjlRLSEDNqVjIH38L0CoJ0458m5iqqWsmmhm4sxLGZTSvaX/IqYav9Y8 /8jKjcyMTBif9bnugsAkf7QX6n1XetPkuujk0M2sUS2lTS5kMbol8GdVKg5VFoMXB5tv9uaAt trzpbm6941SpXh/tcO0NYaJz9guuyNPBdOkYYRgpK13aW4+X1rQHtzdUY36dCyZ+qSQjYFCQW gH+2u3kxrJqQCWXl1VriTUl+xW4yeFOjW2tlvQiQFelEMH8XsS62j/dgm70QlYfEVkZ4PjPqH V/HALPTwLZ+9ryQGfa6G+cUCk0Cg0C3eGUlPjHPbJT7mcBSmCiCz/q/BJQDLzVbpQMVyKEWYd qoJjLgYPxgHNGERXmPCs1QijmbVZaWxy8ZCl4eAdjdPqaJqhZoyiZfuLKgkMzfZp8PguwPdqw 8f2vArPbRz20ZACSJZuKlqXByHjxq4mpcWol0w== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clang fails to eliminate some dead code with always-taken branches when CONFIG_PROFILE_ANNOTATED_BRANCHES is set, leading to a false-positive warning: drivers/net/wireless/ath/carl9170/mac.c:522:3: error: variable 'power' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] BUG_ON(1); ^~~~~~~~~ Change both instances of BUG_ON(1) in carl9170 to the simpler BUG() to avoid the warning. Signed-off-by: Arnd Bergmann --- drivers/net/wireless/ath/carl9170/mac.c | 2 +- drivers/net/wireless/ath/carl9170/rx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.20.0 Acked-by: Christian Lamparter diff --git a/drivers/net/wireless/ath/carl9170/mac.c b/drivers/net/wireless/ath/carl9170/mac.c index 7d4a72dc98db..b2eeb9fd68d2 100644 --- a/drivers/net/wireless/ath/carl9170/mac.c +++ b/drivers/net/wireless/ath/carl9170/mac.c @@ -519,7 +519,7 @@ int carl9170_set_mac_tpc(struct ar9170 *ar, struct ieee80211_channel *channel) power = ar->power_5G_leg[0] & 0x3f; break; default: - BUG_ON(1); + BUG(); } power = min_t(unsigned int, power, ar->hw->conf.power_level * 2); diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c index 8e154f6364a3..23ab8a80c18c 100644 --- a/drivers/net/wireless/ath/carl9170/rx.c +++ b/drivers/net/wireless/ath/carl9170/rx.c @@ -795,7 +795,7 @@ static void carl9170_rx_untie_data(struct ar9170 *ar, u8 *buf, int len) break; default: - BUG_ON(1); + BUG(); break; }