From patchwork Fri Mar 22 14:19:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 160906 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp870306jan; Fri, 22 Mar 2019 07:19:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqxr9lmX2mMY9FogAZngYoqxMlauFTGvNGV+HisYMzv+jDIG4grDyav1PBy2YxYkBfu7uqjU X-Received: by 2002:a17:902:8bc7:: with SMTP id r7mr9751482plo.163.1553264378712; Fri, 22 Mar 2019 07:19:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553264378; cv=none; d=google.com; s=arc-20160816; b=XTJFIR70mrSX23oufIL27gCTDLcR7Rjslv6xW9dGeD2XI2IdgZDRqCBN680SssAbXE Zm/Vn7w0VipmLH+pr4m06csWirAymqO9YJ+gX7GCF2LfEMBf9k6ky1QMug+q1pkUNd/F xp3SjuJnCEs3Pq5N8HCjUrPlTr1qhYsOzBzmsuRr+YisVxTz/HoroqQJggFGcSEgG/Rp S3BeFhpH/BChyfwVb8wZtGI10CuMSl0jM7sLs5jQL2ahlMUdIAG9V6bWBSHjfJe/TO7n dHokq90Fr/NnzMsCnC4QoNhxroO8P0atH7GPNphOIIBO0CkLNwLVf3qpJnVmqk7gYkeG gn1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=AIqzvAi2mfLQhdhmJCosIkSy2p1Sjz9jEXyb2Ie6sPk=; b=l14q4Tx2k8Bneg7SRZjEEPAUybS937rENSiM2DNP4iDgmVJ2+l95nKpmnA61VqtZjR Z8iUyXHUny9rxth1Y/TNIf4guw0j0pyKJaV+is4mNegw89Gx7m8o0EdnBqpslBPuHRF3 TN3jVgAhEqN5gQcmehZOXFUdxfHb2+aMTTuopG5nhrLIh2jKAiCa2F5qQdGtS8Owqhc4 ywf5f6mWpRrXFSyuPCBBH1WaVOV2XX1pyvZY6N00te/Z3Ru+DxR1tmMqjCy9R3kXOLLB qYkSI8HdTv2zPhVZY4GZLNnKdS4mu/9mjLp74Y51RnuyQ4/wEfosRKxEORn0nvPrwNYd 63hA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bg1si7056652plb.118.2019.03.22.07.19.38; Fri, 22 Mar 2019 07:19:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728636AbfCVOTh (ORCPT + 31 others); Fri, 22 Mar 2019 10:19:37 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:41881 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728103AbfCVOTg (ORCPT ); Fri, 22 Mar 2019 10:19:36 -0400 Received: from wuerfel.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPA (Nemesis) id 1MbC5g-1gaC3Q0f7o-00be3v; Fri, 22 Mar 2019 15:19:24 +0100 From: Arnd Bergmann To: Dave Kleikamp Cc: clang-built-linux@googlegroups.com, Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] jfs: fix bogus variable self-initialization Date: Fri, 22 Mar 2019 15:19:16 +0100 Message-Id: <20190322141922.691391-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:dysjoZs9F1yYd4bEUKZjlYJHOG/zqeHpWBN2qk3C0cUEDSJ8r5k wa6GbZZmD9w0kz2k62HbylXr9lYFOYWl9/+PCNlAl7KkFneGn4f5KuHgamgOhCpXOL9zvL6 cwUfLmErtjgHISJn4k8qu/7QGTe7HZNvMDF7YEzvKUS63rG1+n8xOBMVnmYyLjx6XAIYKsT s0ZFZcwJbI9JRT2zzPcZg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:qZ6m3ZQ2kR4=:vqm0S1vREvvyZpw8Ni+LY9 Ay8XYgGF4XRJXUHEv08GA24/NysH4u5OJB2vbdlVtgT5aM0NmrWP8YU6huXCcqaVs4WMAEkxz lfluPWHEuu2oZRi35Hwdu/kPN2KgLy7vaOI9Jy+WiEuE+pu7joS0IBrJeEYvxpor1ckUeJQf2 d7UlHbshgAZ1hSqXpnoTi/sM4GZFejBh5GiOIGdBCcSVa85SSniMYqsbQ2JoWBhNB7BgXEmS2 o94XIP8HJOdN1Ym4UZRLC4mQqA5dHmRq573ogIAHZM46TvhnzsY/mVD0TR3RwztuB+VbFsK6F IoErIfzvScEuHMkxwWpgIl01suQYTz4p9iebPaQw8QNl+P8XLowCPpcvHdj12kWqiwC0593HI BkPMFQTYKqGAmZ/St84ERWL/u7rPUwJ3AtPGo+oIJ8asH6J4nEF7nUFzBRtDIEWUrDIgNX2WQ RzweZKy9lGz2BbiQjVenlRUfp74upS95QlxqmnbEc3sYkm8ZYAhx6AKQEQVchYKkm4mXu96jm k4PpieMtWCIx8jW1rtvYnXAU2NgBwmJBSc4M5EuRSW8+TUlB0TZUnI1M4Cibwi9vsQUY/x4fB q/s1EYEMl573dL1uDefnxhaqxaIsfUJRAN9X9PeANbEH2Yzx6N/dstPqL2uDx+6mjQZX2HxUC H1G+tTtmsdTDhXK9Njxt3ZJNmkVUHEnZkUvNe9/kzRYtQhz/ln1xy2SI9pVZpWsR338OIjHuK 8zhz3qO+8+eU9sAwFrgY+YEa7vJuzDc6eCfcuA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A statement was originally added in 2006 to shut up a gcc warning, now but now clang warns about it: fs/jfs/jfs_txnmgr.c:1932:15: error: variable 'pxd' is uninitialized when used within its own initialization [-Werror,-Wuninitialized] pxd_t pxd = pxd; /* truncated extent of xad */ ~~~ ^~~ Modern versions of gcc are fine without the silly assignment, so just drop it. Tested with gcc-4.6 (released 2011), 4.7, 4.8, and 4.9. Fixes: c9e3ad6021e5 ("JFS: Get rid of "may be used uninitialized" warnings") Signed-off-by: Arnd Bergmann --- fs/jfs/jfs_txnmgr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.20.0 Signed-off-by: Dave Kleikamp diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c index a5663cb621d8..78789c5ed36b 100644 --- a/fs/jfs/jfs_txnmgr.c +++ b/fs/jfs/jfs_txnmgr.c @@ -1928,8 +1928,7 @@ static void xtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd, * header ? */ if (tlck->type & tlckTRUNCATE) { - /* This odd declaration suppresses a bogus gcc warning */ - pxd_t pxd = pxd; /* truncated extent of xad */ + pxd_t pxd; /* truncated extent of xad */ int twm; /*