From patchwork Sun Nov 27 20:32:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 628896 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A63C46467 for ; Sun, 27 Nov 2022 20:32:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229658AbiK0Ucr (ORCPT ); Sun, 27 Nov 2022 15:32:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbiK0Ucq (ORCPT ); Sun, 27 Nov 2022 15:32:46 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC158B1ED for ; Sun, 27 Nov 2022 12:32:44 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id j16so14499589lfe.12 for ; Sun, 27 Nov 2022 12:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5wctFOz/nSpTN4OSDfsZrkfnC9lhpWkR8Iis9Z6iKT0=; b=Sx86bGCOyWNaKmj5BPxdr9MyKwyQeijbpW8Jh7pLwHSF4soVXVHaaz4Pgj7qDi1Yhm KmkzySjj2FCvHeWKPEW5H/U4WZ1XQN/8IBKWXd73E7kqAFB8es02kv4D9lGhIyN9igWm MyvtD8fn0zADpHPbJzZJ9kibX3TgwlMFWh69MoB4HSUtL/Sp3dAOGTjg/9ANgDQUL2Jb S8pYC5H5p+gOUrnxTtGGruMFlU5yFtfTbEumGfggG2q497HUSef7+E5UadoxSZeHPFJn bjW2lN3nO49L3Ve035LI+dCoIDzzF6qd1R95re4Lcpe92FypHGH+RHa8mK7jEOk+9V7X zd5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5wctFOz/nSpTN4OSDfsZrkfnC9lhpWkR8Iis9Z6iKT0=; b=oq34oQ24S9YsXQqgTpG6lo2ntIyO5p2mr5rbqCs58zYvQOoB1ujwVDUJRGCX3XOjuw KiIATXKPXB0Km85coR8YnCPENe0a72cyXHOTgERDIrYYyzqEc5gFyLwF9wLcLhEN+mr9 fI1Icb6S1nxPBTHOmVLmQGn/q2o19lJs4FIaLqyubfFaBpjYvKzCF5SnUWvTsby4BHS2 Q/SatQCfTHT32mdn3HlEFo89h10YeYV9dIxjWI03rI3BLKSRjI5YwUNWTfjC12wuBjtp Yy9BW+ScSWldRnimBvxRziSa57+CVSre+ThMCubhqY7algxQ9QdyVNlZkjEO1c3tsvi3 EviQ== X-Gm-Message-State: ANoB5pkRWpXcPWrdZa5Uux92wiw8+Ec4/KdU3EJVK0d6LOfy6lz1bTEv Ztj283P3F8hQn9tkkXQswqns9w== X-Google-Smtp-Source: AA0mqf64W+e/ef0exP7/t4NwMCa6LM0vubj3hAHb04DAerLYPrBLv1lUKmfiVcckYnQzPrbisY/+ig== X-Received: by 2002:ac2:51cc:0:b0:4b5:a72:1a8 with SMTP id u12-20020ac251cc000000b004b50a7201a8mr2665413lfm.391.1669581163254; Sun, 27 Nov 2022 12:32:43 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id w10-20020a05651234ca00b00494942bec60sm1412827lfr.17.2022.11.27.12.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Nov 2022 12:32:42 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 1/3] arm64: dts: qcom: msm8996-xiaomi-gemini: use preferred enable-gpios for LP5562 LED Date: Sun, 27 Nov 2022 21:32:38 +0100 Message-Id: <20221127203240.54955-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The preferred name suffix for properties with single and multiple GPIOs is "gpios". Linux GPIO core code supports both. Bindings are going to expect the "gpios" one: qcom/msm8996-xiaomi-gemini.dtb: lp5562@30: 'enable-gpio' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- Changes since v1: 1. New patch --- arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts index d8734913482f..dbd5f7e2df65 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts @@ -54,7 +54,7 @@ lp5562@30 { reg = <0x30>; #address-cells = <1>; #size-cells = <0>; - enable-gpio = <&pm8994_gpios 7 1>; + enable-gpios = <&pm8994_gpios 7 1>; clock-mode = /bits/8 <2>; label = "button-backlight"; From patchwork Sun Nov 27 20:32:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 628895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF167C46467 for ; Sun, 27 Nov 2022 20:32:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229693AbiK0Ucu (ORCPT ); Sun, 27 Nov 2022 15:32:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbiK0Uct (ORCPT ); Sun, 27 Nov 2022 15:32:49 -0500 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10A85B1ED for ; Sun, 27 Nov 2022 12:32:47 -0800 (PST) Received: by mail-lj1-x22a.google.com with SMTP id z24so11024764ljn.4 for ; Sun, 27 Nov 2022 12:32:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jDF3wtVae7sFV7RHSN3RWyepCJgWam189Cxle5ELR+0=; b=svDjpxjGgEYAtvQEU782VlP0v8qkhnR89/c3bV98qc+sPcuYmy9NlECraEuztBL/H9 +yagQWGEQ/Jf8d/SQYlAIBd0n+O3WBKmJLe5oOMOTUp0D9g88+KGpgCUUa/uf62AVFN2 dCu7gd/D6fE4sDMCIBbYe154EjfgAfuaNAjBskpzwYc8btoBwA/rBDquUqwI5X2h58R9 3HaBeJDl/UoPVioW8vEWJHuf8JRmk+NUST/cfGJdJr3yqj6D3SgneiYIViChc3zn11Hf Dv4EiUbNrfW3S7ubpc0YQ9tXPlX2DMroWqgwW6BmsTlFR7od2U5hbylBAKoHFQ4m+0ny fhig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jDF3wtVae7sFV7RHSN3RWyepCJgWam189Cxle5ELR+0=; b=7ZjE6r38qye7vW6tVdat6cAi0KCZC9EucVlcqtYzcLKwwl9yAoIyAbxwEc7i7hMGZQ Al8j9vEfVesVoX4NlnrhJ0fWAmNiW/duRmApzhIP7pRJBhSJMT1AGkY+jwD1LGSnuk5R Gz2Bv4p2BIpbghyE5G9+lr2Zh4x0WWu7TDhgclfgP/jpnOCW58pt5HZiz1WbrlBnfBPq 8EoOYGcbPwHUHZPWJ73BORpvdPpvkZwt4Jt8a1D8QRFz1jA87dyt5k90ZS/9DYKK+Uty dj9hzUJV92TBsYqt1hnGAHXJ83Nh0bIwZSSSBuZGiBVnwQvH/fsHqy5/BzgF35n8c4xS DWBg== X-Gm-Message-State: ANoB5pkrxZKJ6q/hftuuZLf1z++bmwxZ6GGH75dG/tQiqYU7cMDglTEA /8JJ1i1G6onw8LaXC2VQIVD7ig== X-Google-Smtp-Source: AA0mqf5emVQaTM9KtZ2LkxfssBLpH/7Ag1JkNnoIUclLXQ0BN1SY+nseOw+cqpq0ULrLYl9T3ni5tw== X-Received: by 2002:a2e:3e17:0:b0:279:96c4:2c2d with SMTP id l23-20020a2e3e17000000b0027996c42c2dmr3088855lja.153.1669581165273; Sun, 27 Nov 2022 12:32:45 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id w10-20020a05651234ca00b00494942bec60sm1412827lfr.17.2022.11.27.12.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Nov 2022 12:32:44 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 3/3] ARM: dts: qcom: align LED node names with dtschema Date: Sun, 27 Nov 2022 21:32:40 +0100 Message-Id: <20221127203240.54955-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221127203240.54955-1-krzysztof.kozlowski@linaro.org> References: <20221127203240.54955-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The node names should be generic and DT schema expects certain pattern: qcom-ipq4018-ap120c-ac.dtb: leds: 'wlan2g', 'wlan5g' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- Changes since v1: 1. Add Rb --- arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts | 6 +++--- arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts index cf7da1ab177c..1b27edce9d4f 100644 --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts @@ -9,7 +9,7 @@ / { leds { compatible = "gpio-leds"; - power { + led-power { label = "ap120c-ac:green:power"; function = LED_FUNCTION_POWER; color = ; @@ -17,14 +17,14 @@ power { default-state = "on"; }; - wlan { + led-wlan { label = "ap120c-ac:green:wlan"; function = LED_FUNCTION_WLAN; color = ; gpios = <&tlmm 3 GPIO_ACTIVE_HIGH>; }; - support { + led-support { label = "ap120c-ac:green:support"; color = ; gpios = <&tlmm 2 GPIO_ACTIVE_HIGH>; diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts index c4f89b712fd9..a707057c887d 100644 --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts @@ -7,7 +7,7 @@ / { leds { compatible = "gpio-leds"; - status: status { + status: led-status { label = "ap120c-ac:blue:status"; function = LED_FUNCTION_STATUS; color = ; @@ -15,7 +15,7 @@ status: status { default-state = "keep"; }; - wlan2g { + led-wlan2g { label = "ap120c-ac:green:wlan2g"; function = LED_FUNCTION_WLAN; color = ; @@ -23,7 +23,7 @@ wlan2g { linux,default-trigger = "phy0tpt"; }; - wlan5g { + led-wlan5g { label = "ap120c-ac:red:wlan5g"; function = LED_FUNCTION_WLAN; color = ;