From patchwork Fri Nov 25 14:42:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 628618 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E2DC4167B for ; Fri, 25 Nov 2022 14:43:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbiKYOnT (ORCPT ); Fri, 25 Nov 2022 09:43:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230243AbiKYOm6 (ORCPT ); Fri, 25 Nov 2022 09:42:58 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3588E419A3 for ; Fri, 25 Nov 2022 06:42:15 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id f13so7207446lfa.6 for ; Fri, 25 Nov 2022 06:42:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3o4Ak/tooirHnNJn7lhjm6d8X2fgF8UcvDymE+bkTxc=; b=x7IEN5UsmY1JDkSkMKt6SFtlKQILzjEDG8mZ/yAk0l5GJidYSbQ3YuTSLW+ei7GOCI IdCOMhu69TQ4IIztr30Af5lg7Nz8GKb8GDbcSssop8+5/ucwZlzAZsaj2B3Pjab/rROP +0ccyTq3k8Y7VoGi1iNYe0dii3Ty7O55ks3zIoNJ7B0N23L/XRKYmsDGa60qV98jdAx9 q5YVSpUIXp5kES/+ldTU/ASurG8bRRtXjPZMSUqtDLgxN86IEgP0/xkdoKXbM4pgR2AH 4VHDHvfU6WMrHAJTyXDiWRfwteUlhlcUykLRfmyiMUW6DAZZ3FCRGm5fIpA8Mi+hJsHa Imdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3o4Ak/tooirHnNJn7lhjm6d8X2fgF8UcvDymE+bkTxc=; b=W5kZpvrMfy0VRdyi3eOvAX6+4KsPwxB/m43VppJiuPd+FxjvzxRmmyxDPyYvTVg0fQ +d886VdE4gYC/J2LMJWCNiqKFDi1X08N+sMinkczx8aJrWblsqorgPQrTj7UEMx//+2r fiwipK70gcQ4HZnGwwhgzFH6WTYi6baOYP3PzGXAUHxBaPFgAG6SihAAeOi5I4y1x0Jn Z6UctRBF4TY8J6xzxpaf/TO/nujPXruGew3xe2KASMn4JeMr/A8XKvcdSk9hYr69eu5i PaXKIDV0YWVKcHX3Pi13/h+hZqSiPXhTdYT0q60m9Vx5DHSbTKe3bhoYCE/DSqsx1kBt 1kww== X-Gm-Message-State: ANoB5plBWz/BlyuVyuTc3xfjECXa/pABrQWYFzSYeXGBekcb4DHr0iLq dagJ3W6Mwn+39Fk+3d7ZPO99bw== X-Google-Smtp-Source: AA0mqf4tTyIvlnJxKmbAjhQ8HsOG9Vjbi/ohPlYPlxliaqFSzhlaUTAKGt9GkP1Q+NWCBbWEAbMKQw== X-Received: by 2002:ac2:456a:0:b0:4ad:23ac:94f5 with SMTP id k10-20020ac2456a000000b004ad23ac94f5mr12834073lfm.490.1669387333499; Fri, 25 Nov 2022 06:42:13 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c13-20020a056512238d00b0049ebc44994fsm553711lfv.128.2022.11.25.06.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 06:42:13 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] arm64: dts: qcom: align LED node names with dtschema Date: Fri, 25 Nov 2022 15:42:08 +0100 Message-Id: <20221125144209.477328-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The node names should be generic and DT schema expects certain pattern: qcom/msm8998-oneplus-cheeseburger.dtb: leds: 'button-backlight' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' qcom/sc7180-trogdor-coachz-r1.dtb: pwmleds: 'keyboard-backlight' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts | 2 +- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts index b951f98d1b7b..9fb1fb9b8529 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts @@ -22,7 +22,7 @@ leds { pinctrl-names = "default"; pinctrl-0 = <&button_backlight_default>; - button-backlight { + led-keypad-backlight { gpios = <&pmi8998_gpio 5 GPIO_ACTIVE_HIGH>; color = ; function = LED_FUNCTION_KBD_BACKLIGHT; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 65601bea0797..74a90948db6b 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -354,7 +354,7 @@ max98360a: audio-codec-0 { pwmleds { compatible = "pwm-leds"; - keyboard_backlight: keyboard-backlight { + keyboard_backlight: led-0 { status = "disabled"; label = "cros_ec::kbd_backlight"; function = LED_FUNCTION_KBD_BACKLIGHT; diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index 448da9794722..27f479ff9d80 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -307,7 +307,7 @@ max98360a: audio-codec-0 { pwmleds: pwmleds { compatible = "pwm-leds"; status = "disabled"; - keyboard_backlight: keyboard-backlight { + keyboard_backlight: led-0 { label = "cros_ec::kbd_backlight"; function = LED_FUNCTION_KBD_BACKLIGHT; pwms = <&cros_ec_pwm 0>; From patchwork Fri Nov 25 14:42:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 629633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FBB4C4332F for ; Fri, 25 Nov 2022 14:43:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230111AbiKYOnS (ORCPT ); Fri, 25 Nov 2022 09:43:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230107AbiKYOm6 (ORCPT ); Fri, 25 Nov 2022 09:42:58 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1065F41982 for ; Fri, 25 Nov 2022 06:42:15 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id r12so7241896lfp.1 for ; Fri, 25 Nov 2022 06:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a1xSVUhkUfrXUhf8CMusEDuKEs4N/AtKVgIpTqaWjgU=; b=rV7OXzdx6QVyI+A/2k8RpReSXMFb0Dnhi5C6GaVYBIDNoVggmmoQh/xQohAiGKVMf2 WdkeIGQUuIURvOnmj+VWZlDV4+zhUnPeWMpcQI2EEk+xpdBN0DtqgnXVx389EqvzMFGG zXgBXx2MWglY8+Bv9MzWCSORTnp2NZAcNwPGuHeMrFHF6A+oNH78ZT0OtSkwfYs33HkE HWKBH3Lp8gW0SkUpUzlFRQa+5RG0gL4QQjn0oGceBduqcjS1WzqPvZQEFOgjyBb3WbEt gzwVTGwfwLNWgNKTg8qJwFkHN39aP7KWydVuOpsDGWgtwkK0SzTApE9MwEapc7OgjA+R 0b1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a1xSVUhkUfrXUhf8CMusEDuKEs4N/AtKVgIpTqaWjgU=; b=5/nYveFgAFOZuMoDTqRedFE0NTq6WHSCiViY+RcQ4n7wwmh6Zn2y74Z2QOSVj4WDiS hcpXPn0bw/g+6eXamZdY3GOXff8QppHEXKP+VM6ZdC14S4uHpU58nZ28/H9CRISHU5LJ fOV+K84EA8zrIJSt/5np9Kd+2jxMoVVvBOW7za/dd0VQoP2kYgKe/+j8r/w8NHK3TJGj bvT+J9AhlbDyQ7bVIraRE2KCMnYHL0FoIC966g36HXi4tpGTWjvEuqUUSjdyM3NLot1l R5UaEQbFeS478LRYrILAqXguv8ZID2fa6AoeBDatpuXmtaWfVFkoysM0z5ZJTHPPV+qZ ZRxA== X-Gm-Message-State: ANoB5pmVcdg57oY8ei6CHN6/pc/mlp1oiU/fLWy9m7Gi7trBZzg7ZIbj FCetzbL6ILxgNmKGShtoaUMo6w== X-Google-Smtp-Source: AA0mqf62WPBt2G+cougPd3AQ5x/TOUIZAgyUfpsCm/dfHDCoT2+gYaVYZO2DA+CR98ghz03PzC6GbA== X-Received: by 2002:a19:2d0c:0:b0:4ad:5fbb:a5b9 with SMTP id k12-20020a192d0c000000b004ad5fbba5b9mr12365525lfj.98.1669387334578; Fri, 25 Nov 2022 06:42:14 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c13-20020a056512238d00b0049ebc44994fsm553711lfv.128.2022.11.25.06.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 06:42:14 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] ARM: dts: qcom: align LED node names with dtschema Date: Fri, 25 Nov 2022 15:42:09 +0100 Message-Id: <20221125144209.477328-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221125144209.477328-1-krzysztof.kozlowski@linaro.org> References: <20221125144209.477328-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The node names should be generic and DT schema expects certain pattern: qcom-ipq4018-ap120c-ac.dtb: leds: 'wlan2g', 'wlan5g' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts | 6 +++--- arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts index cf7da1ab177c..1b27edce9d4f 100644 --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts @@ -9,7 +9,7 @@ / { leds { compatible = "gpio-leds"; - power { + led-power { label = "ap120c-ac:green:power"; function = LED_FUNCTION_POWER; color = ; @@ -17,14 +17,14 @@ power { default-state = "on"; }; - wlan { + led-wlan { label = "ap120c-ac:green:wlan"; function = LED_FUNCTION_WLAN; color = ; gpios = <&tlmm 3 GPIO_ACTIVE_HIGH>; }; - support { + led-support { label = "ap120c-ac:green:support"; color = ; gpios = <&tlmm 2 GPIO_ACTIVE_HIGH>; diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts index c4f89b712fd9..a707057c887d 100644 --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts @@ -7,7 +7,7 @@ / { leds { compatible = "gpio-leds"; - status: status { + status: led-status { label = "ap120c-ac:blue:status"; function = LED_FUNCTION_STATUS; color = ; @@ -15,7 +15,7 @@ status: status { default-state = "keep"; }; - wlan2g { + led-wlan2g { label = "ap120c-ac:green:wlan2g"; function = LED_FUNCTION_WLAN; color = ; @@ -23,7 +23,7 @@ wlan2g { linux,default-trigger = "phy0tpt"; }; - wlan5g { + led-wlan5g { label = "ap120c-ac:red:wlan5g"; function = LED_FUNCTION_WLAN; color = ;