From patchwork Mon Mar 18 16:35:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 160498 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp2853075jad; Mon, 18 Mar 2019 09:35:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqw4VgZTglwi/IcNpBfSmXNJMiKDk4L54P5EH/HwTBM+j2huy3omwjDTSj/itPGDIQZtWeRA X-Received: by 2002:a62:17d4:: with SMTP id 203mr19709290pfx.244.1552926951131; Mon, 18 Mar 2019 09:35:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552926951; cv=none; d=google.com; s=arc-20160816; b=LVkVphDpSe+lcwaO0Pgv96XB/4cmhRkRQ8WUVopfIzQndhs7pReIKSJp9M5dgIHJKQ fv2W7HxtfPoxBM92+jk+ruLSsu5NXOUdCHOJ/j1ZaXqrRReecbCMQ1rCEzYAwXxZlhtP 64s+yluPTnESCUrzr6Z3a9qA88FAj73NK8p+ND8L59C9+wDlKc7JHk5p95ZM8pbrvFI1 ySZHE9rN3FOHrV8g/p0umFtnYggeFMd2uLnT6iqw16M1Try7KRFiwqu36pkgr44qpOda 9xzFD3bmMEdx76v9fIJNisa8Rp+Al0t7VwfUqLKoET64WAs8nHpLoIR+G2G5YLwo37WP Tl9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=WVOms4jMxKvecAMHg2JI3SUvhOK/lZfCoTbcxHUMbkk=; b=mNE906ih+L056/QvmRcpvaPW8WhKU/yBGSc/CYJexnA+3wL3HaUJCid3kMLsCR3eno o6L1Ms5kSnV1kFqUmMryFeY/wh9B2u6zqGGeguyk/qQ8H3rnVDrepOVIbWMUCcUdWXJd yRHzEellzXM4PLVBIWLLjU5+pWQ7OJiy0VwGIMm3YnSoCNp5Sk/vs9RJmaF4qdu01PUp UIsiz1U77w9t7VvvLZFgl9CY9RbSJjSDC6284Wz/YzsB/mlJZbPklX4aMvkZLX7pfk+V 8jZgCmNnoDqD7U7NvbgFt9c5cASCbA6I9FgSsfmIRct1Zyyq0rklLQVtLv3/KNeZLn+n QFfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u73si2911286pfj.30.2019.03.18.09.35.50; Mon, 18 Mar 2019 09:35:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727553AbfCRQft (ORCPT + 31 others); Mon, 18 Mar 2019 12:35:49 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:57661 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726808AbfCRQft (ORCPT ); Mon, 18 Mar 2019 12:35:49 -0400 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id 1MEVFi-1hGPtR490s-00FxTQ; Mon, 18 Mar 2019 17:35:40 +0100 From: Arnd Bergmann To: Jiri Pirko , Ido Schimmel , "David S. Miller" Cc: Masahiro Yamada , Arnd Bergmann , Vadim Pasternak , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mlxsw: core: mlxsw: core: avoid -Wint-in-bool-context warning Date: Mon, 18 Mar 2019 17:35:11 +0100 Message-Id: <20190318163536.2171073-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:c1w42up200TKqjRrYRKgUK7VltNjESreqJ1xLouMC+e16xKdPCL kfeA8SlqwOU88vSFl5dNJq4clnmkRFZCBr/LcNxvuYdsJrGMQBWksMR4zaDMB37X0WJhsxW /72pf9IcvEK+7gCsQ9MIQyVHRZDYEnhf2CP0BpWAu5pnzLoW+ChIeOrdzrZ/x5Cx9l6IAAS TeJg8YtVI0W8aF49P6TTg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:+fZ6XtPWBuU=:ameA70zY4LCt+vQyVQtj0v VRLcDD9U1/wppek0CFKSdWV5q0Jx2ofEdjPhG3+XiDWzQ3Dk3T9Tb0M1Dh374ezoook18X7Pk i7Y0yER4BvDNSzeq5o48o1g08g3AVzJ9jfFBjNOC6FmjArMpbdp92d7fSXls7GBv1ckH/sM3L sOCvx8SL8+oOisPrEpZrY1cpNSyi4emzJHsjJNUOf9zqMCctn1bE2Gc0F1sqTwyVxAPgii0oC mj9k9s8/la+Evp8IPXiFR+ydiLJc4eKz7bvJC0lXMRG64NMbPNNL7yJtr6ix3bNW8NDyZ+uRl fyox+DudUvi965aiETANVYDfli+v84Nl4DaCQbRiY1wFoS8rm4UlHAdOXfweWt3yNd8m/mrXA 2WnFRfq/I0wNeQ8ZduE75rQ2eeWXg5HIqJzlai+M4waTpj2snocuGT0A/IllLuFrxPUaJnOHS 7NCwbENz2J0Xx0nadfrdHpzP6nh0/PUbUmL+lbBrOUeJSNJNJLC7BFF1ozsPw9huS15EkbjqH 5GBvaeOFevscbi0HT3K2bCe9QeJv2c73yyeCg4MzFRL3MG86zm2x7/P6laX2kUCIsnggDTwh5 H/40T9lsHCOwVUzGVLQtzArXEla/Zgw/heddlsy8pMJQP7MsHmAUYg5KKwN7/8D7ANuv9fvCw RDNxekrlcGtSmPhuAw9NbmSasQMLiVabH546ibC3N2MV2lbx6SD0Dzq3bYDYun5CJd2oh/ubS pZ0kfCNZuiSw3PzGTARCQrpRBbCpJ61bnVD1YA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A recently added function in mlxsw triggers a harmless compiler warning: In file included from drivers/net/ethernet/mellanox/mlxsw/core.h:17, from drivers/net/ethernet/mellanox/mlxsw/core_env.c:7: drivers/net/ethernet/mellanox/mlxsw/core_env.c: In function 'mlxsw_env_module_temp_thresholds_get': drivers/net/ethernet/mellanox/mlxsw/reg.h:8015:45: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context] #define MLXSW_REG_MTMP_TEMP_TO_MC(val) (val * 125) ~~~~~^~~~~~ drivers/net/ethernet/mellanox/mlxsw/core_env.c:116:8: note: in expansion of macro 'MLXSW_REG_MTMP_TEMP_TO_MC' if (!MLXSW_REG_MTMP_TEMP_TO_MC(module_temp)) { ^~~~~~~~~~~~~~~~~~~~~~~~~ The warning is normally disabled, but it would be nice to enable it to find real bugs, and there are no other known instances at the moment. Replace the negation with a zero-comparison, which also matches the comment above it. Fixes: d93c19a1d95c ("mlxsw: core: Add API for QSFP module temperature thresholds reading") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/mellanox/mlxsw/core_env.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 Acked-by: Jiri Pirko diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_env.c b/drivers/net/ethernet/mellanox/mlxsw/core_env.c index 7a15e932ed2f..c1c1965d7acc 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/core_env.c +++ b/drivers/net/ethernet/mellanox/mlxsw/core_env.c @@ -113,7 +113,7 @@ int mlxsw_env_module_temp_thresholds_get(struct mlxsw_core *core, int module, return 0; default: /* Do not consider thresholds for zero temperature. */ - if (!MLXSW_REG_MTMP_TEMP_TO_MC(module_temp)) { + if (MLXSW_REG_MTMP_TEMP_TO_MC(module_temp) == 0) { *temp = 0; return 0; }