From patchwork Wed Nov 16 20:01:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 625272 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E300C4332F for ; Wed, 16 Nov 2022 20:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230203AbiKPUCf (ORCPT ); Wed, 16 Nov 2022 15:02:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238603AbiKPUC0 (ORCPT ); Wed, 16 Nov 2022 15:02:26 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BC9A63CCD; Wed, 16 Nov 2022 12:02:25 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id h14so17496154pjv.4; Wed, 16 Nov 2022 12:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gWHeg8M1ItPKLADHrX13a52utCw4BMmhpRsIIQk2Fck=; b=XMsHoBVwkTCzyxRUnxAnS4OFKDbb1cNra2uUSHWdYCfwL9DGCbnSB80aMn0s2RiSv/ dzgPX4ZLZz7WWLKdqaz/iMX3PYvnXcUaA+GfcKYixqUqO1KRF6V8B041ZZiWqWvWJyRs KjxLQ3Vfcjq7dCBSBret8vz3d2bVmpMplOdSDnlrtGBX7rhcfTReRFbwKa2w6z8qipXe oNNaCNmgrlR5CcasYxh5HGGqk8bm9yBmpMm224JG/biPZESuByYdmSlCtPPPHnZAyWmS e1T9vGJOgXrxPr/+rnxsgCAuWmUYP8EJHeiZxmeC2YJN+4J1NmjeQn3fX8/s2XEpeBfr XUHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gWHeg8M1ItPKLADHrX13a52utCw4BMmhpRsIIQk2Fck=; b=3hOI/UAI3J1wm7eT9Os5Rt41CTr8EFUFEq1glQefAxWBEauWPfZ3SpzWWqka+mxKDC sG1yqUog2c/9oQzIHvRoOOJbsGaBWruiv3AJVzeeQ2YBSVun2UR7AzKkJVR15HIscJbM goJvJyFzbXPUoXOn9jukw+41s0rYcID3Kf9Rgb1JiX7nNrxiGid4Vdph3SXgtvdNG+lD Pw9WrYBlMqEEc65ZEGTwYbFfvvArTc/fPCjdSJoakt21rNlgreIj+1K4+teghIg1J5E+ nILY/Zy/lkUO0Ab6oNCS/IWo9lODyBa0lNVlcz4gBEUGIBsudFneUZN4tO5WhEV1ysKf ukDw== X-Gm-Message-State: ANoB5pmxxK3fN69fihBZA9FVCeSvZe+jNt9eb1kw24yqv8mpVRxrmkSG D90zhmxccK80uHv15bIZUx1AIyfAwhn9Pg== X-Google-Smtp-Source: AA0mqf5WKCdpBqS0le2On+nkdH9MkMJqW/Gj1R/YMS4+BiCNzeC5zLTPe4lkmEF8PNdG2C5SYXspFg== X-Received: by 2002:a17:902:c94f:b0:188:712f:dfa5 with SMTP id i15-20020a170902c94f00b00188712fdfa5mr10049999pla.140.1668628945118; Wed, 16 Nov 2022 12:02:25 -0800 (PST) Received: from localhost.localdomain ([103.51.72.182]) by smtp.gmail.com with ESMTPSA id s18-20020a170903215200b00186a6b6350esm12423950ple.268.2022.11.16.12.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:02:24 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: Anand Moon , Chukun Pan , Michael Riesch , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [linux-next-v2 1/5] arm64: dts: rockchip: Fix gmac phy mode to rgmii on Rock 3A SBC. Date: Wed, 16 Nov 2022 20:01:43 +0000 Message-Id: <20221116200150.4657-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116200150.4657-1-linux.amoon@gmail.com> References: <20221116200150.4657-1-linux.amoon@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On rk356x ethernet phy support reduced media independent interface (RMII) and reduced gigabit media independent interface (RGMII). So set the phy mode to rgmii to support clock delay, also add TX and RX delay for phy-mode. Fix following warning [ 7.365215] rk_gmac-dwmac fe010000.ethernet: Can not read property: tx_delay. [ 7.365219] rk_gmac-dwmac fe010000.ethernet: set tx_delay to 0x30 [ 7.365224] rk_gmac-dwmac fe010000.ethernet: Can not read property: rx_delay. [ 7.365228] rk_gmac-dwmac fe010000.ethernet: set rx_delay to 0x10 Signed-off-by: Anand Moon --- V2: Fix commit message and added the RX and TX clock delay. --- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts index ea74ba32fbbd..e1c75532dcee 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts @@ -253,13 +253,16 @@ &gmac1 { assigned-clock-rates = <0>, <125000000>; clock_in_out = "output"; phy-handle = <&rgmii_phy1>; - phy-mode = "rgmii-id"; + phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&gmac1m1_miim &gmac1m1_tx_bus2 &gmac1m1_rx_bus2 &gmac1m1_rgmii_clk &gmac1m1_rgmii_bus>; + + tx_delay = <0x4f>; + rx_delay = <0x26>; status = "okay"; }; From patchwork Wed Nov 16 20:01:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 625271 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 110DEC4332F for ; Wed, 16 Nov 2022 20:02:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234187AbiKPUCk (ORCPT ); Wed, 16 Nov 2022 15:02:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233955AbiKPUCj (ORCPT ); Wed, 16 Nov 2022 15:02:39 -0500 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04B26657EC; Wed, 16 Nov 2022 12:02:39 -0800 (PST) Received: by mail-pg1-x536.google.com with SMTP id 6so17716845pgm.6; Wed, 16 Nov 2022 12:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9u48IeVxeYRpqZXDq8TEy2jgfthr+zPe9V44R0XXV6s=; b=OJlre6S9pakulZA+yEGpONatIYHUbfqM2duW/AMNUeogjFygAv4bC1gl8iiKIN6L6l 9V9rlywuoLnK5SwYcyVQS2YSTt3Kqvii4TqEmU2ENGMclvuydNlmNCAUteaOS75MjF/Y MhGThK8Twowj8WQeQ9lAWEYmiILMeQtIu+PiP3qqkDG6rsjtDicG+9RKXHykP+xknhc6 X6gs7BePV5RcqSFi1V8QY3DelJ/Ut7FesSt/BazrNm21n79ND4L3ithnApPPwZpaJJfM TAh28RRnZv87qP/NiskyIMIboOAh8QHacJG3uShCw95I0tDHwrsw/zQMQFyCOGnu5Bag R17Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9u48IeVxeYRpqZXDq8TEy2jgfthr+zPe9V44R0XXV6s=; b=Q0vMvJtCXwaL/Zkk7+V/mukgy/kXp2FOP1Z49bwMBolK0I0ZSAWEO9cn6ZF3GFZSpZ l4RIQp7DHPJv3qR09+XZWB9E0sQoWIWDHHAQRdmuyRNYGkPZfXC+xEqxJM2yyxhj+5kq stpUr3SZ9EYNhnqVMjPkRZw5AI3SIJMYP1KaQEjn9gOWwPM2/JEE5t+R3gvQ6AQyrlE5 +oJ8XmeTTr5mbEpZF5GIb5ibV2aZC4yS0NazqpAhyGwwhcjpDycnNh1ELdVb6tq2Hnq1 PLEpVJbqRJou61EylmvSow2mwBAqZtaeXDyKzSM3QRgZBEON8IsEmR1s4Lb06/TZrBrL 5EKQ== X-Gm-Message-State: ANoB5plGjdpzqCSYeErksrC39uibhz82YkbEOHxRpmrwUc+CRVhGwpK5 e8mqsAD031KKiEIw9d2fPSA= X-Google-Smtp-Source: AA0mqf790rR++Tn3av8PLwCoZX/3FlqthhDW8C6waWJTH8vWZ4I6VdRk+YNTEVcH7PvR8/e6wp9Pyg== X-Received: by 2002:a63:5f4c:0:b0:45f:fc05:270b with SMTP id t73-20020a635f4c000000b0045ffc05270bmr21765809pgb.14.1668628958408; Wed, 16 Nov 2022 12:02:38 -0800 (PST) Received: from localhost.localdomain ([103.51.72.182]) by smtp.gmail.com with ESMTPSA id s18-20020a170903215200b00186a6b6350esm12423950ple.268.2022.11.16.12.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:02:37 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: Anand Moon , Chukun Pan , Michael Riesch , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [linux-next-v2 3/5] arm64: dts: rockchip: Add support of regulator for ethernet node on Rock 3A SBC Date: Wed, 16 Nov 2022 20:01:45 +0000 Message-Id: <20221116200150.4657-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116200150.4657-1-linux.amoon@gmail.com> References: <20221116200150.4657-1-linux.amoon@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add regulator support for ethernet node Fix following warning. [ 7.365199] rk_gmac-dwmac fe010000.ethernet: no regulator found Signed-off-by: Anand Moon --- v2: new patch added --- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts index b848282ea005..5378254c57ca 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts @@ -260,6 +260,7 @@ &gmac1 { clock_in_out = "input"; phy-handle = <&rgmii_phy1>; phy-mode = "rgmii"; + phy-supply = <&vcc_3v3>; pinctrl-names = "default"; pinctrl-0 = <&gmac1m1_miim &gmac1m1_tx_bus2 From patchwork Wed Nov 16 20:01:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 625270 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F69C433FE for ; Wed, 16 Nov 2022 20:03:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238617AbiKPUDL (ORCPT ); Wed, 16 Nov 2022 15:03:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237831AbiKPUDG (ORCPT ); Wed, 16 Nov 2022 15:03:06 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24834663C2; Wed, 16 Nov 2022 12:02:52 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id w23so11010488ply.12; Wed, 16 Nov 2022 12:02:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hlf4RPnys2xlptR6hKKlXQBW5qSMO1/p3GZVaaL5DEk=; b=p1xoRO47ZrZ1DdmzZr9wv/ZEi13KH85MY5IcJaX02FD68/K/cmdmHDvzNED+iQn6fi b/BywVdnyw7bc1gzPutqrwvD8uma5HbPaN9VxphqGCIXb9Oi1B0cCgbkoobNrkjbaYe7 nN5k/BCr2axXuXqOWPhfsVw/0ldm+p2Qz+Ni//ONsEcVAAZiGlqV/odH2z4xuqy4gAI1 YL67GKHiSw63d4ySeeWwOlXjWAKS8bK1oPHYv3zp2EybFz58fl28AJHD9Xqm8dmpaHLN eW81F2sIX89Df+kGKWG2KvKyO2744SmkuuquwI35IOh8l5MNJx5ETidYVQxKmuVi1cCD AkGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hlf4RPnys2xlptR6hKKlXQBW5qSMO1/p3GZVaaL5DEk=; b=NrX6YXYrjaK5MzrPEXz4ohQtYCj97s2+adxMlzyYzENQ46rly7LAMpylB3dxrOE9b3 AQDJuq9Wx7NOCChKQh5tAofxFY02dq281G8mEr4uhZGpjEyxqfV3WmWcgXCXIqSyJg5O lZzsIKdHjyMp/Ix8UzsMYG5/jmVF5dDCETl1Rl2TmdmV3dVOaG7CgPjFFwtpAkURkn6U LLPJA0T8RkZm8I2TR3BXI0T3Lx+fuucnCyBrbuuqM9zlXQUF4ejejD1iobGqwpPszZJz fVE2rgvnv7qNj6nnPpsHOTf3lTs337cjqieysRSLMYy+SHRav8JEW32n2vmD+GEJAsTo aRAQ== X-Gm-Message-State: ANoB5pki4zK0JtV0hrSdmH9oCCUdyiyCYqosvXhLMruSGSaa6VkQC+7z pYga265N1T8YpabBqcOfYYc= X-Google-Smtp-Source: AA0mqf7C+XsGFEi9GeihjTn5V5WPZwj9QlHhQ6Xr1g1pK9CvcEqH7Zj01PlVmvLBIF1bcTXt+nB5cA== X-Received: by 2002:a17:902:e791:b0:186:9870:506a with SMTP id cp17-20020a170902e79100b001869870506amr10439418plb.45.1668628971684; Wed, 16 Nov 2022 12:02:51 -0800 (PST) Received: from localhost.localdomain ([103.51.72.182]) by smtp.gmail.com with ESMTPSA id s18-20020a170903215200b00186a6b6350esm12423950ple.268.2022.11.16.12.02.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:02:51 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: Anand Moon , Chukun Pan , Michael Riesch , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [linux-next-v2 4/5] arm64: dts: rockchip: Add support of interrupt to ethernet node on Rock 3A SBC Date: Wed, 16 Nov 2022 20:01:47 +0000 Message-Id: <20221116200150.4657-6-linux.amoon@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116200150.4657-1-linux.amoon@gmail.com> References: <20221116200150.4657-1-linux.amoon@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org As per the shematic gmac1 support gpio interrupt controller GMAC1_INT/PMEB_GPIO3_A7 add the support for this. Signed-off-by: Anand Moon --- v2: new patch added --- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts index 5378254c57ca..9f84a23a8789 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts @@ -588,10 +588,14 @@ rgmii_phy1: ethernet-phy@0 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x0>; pinctrl-names = "default"; - pinctrl-0 = <ð_phy_rst>; + pinctrl-0 = <ð_phy_rst>, <ð_phy_int>; reset-assert-us = <20000>; reset-deassert-us = <100000>; reset-gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>; + interrupt-parent = <&gpio3>; + /* GMAC1_INT/PMEB_GPIO3_A7 */ + interrupts = ; + #interrupt-cells = <1>; }; }; @@ -630,6 +634,10 @@ vcc_mipi_en: vcc_mipi_en { }; ethernet { + eth_phy_int: eth-phy-int { + rockchip,pins = <3 RK_PA7 RK_FUNC_GPIO &pcfg_pull_down>; + }; + eth_phy_rst: eth_phy_rst { rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; };